)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"239a4b872156fe22c9481623ec8e00dedf4e3684","unresolved":false,"context_lines":[{"line_number":16,"context_line":"upgrade impact as its being done as part of the post_tasks within"},{"line_number":17,"context_line":"the container create play and any changes that need to happen"},{"line_number":18,"context_line":"within an existing environment will be automatically taken care"},{"line_number":19,"context_line":"of within impacting the functionality of an existing deployment."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib31a48dd480ecb376a6a8c5b35b09dfa5d2e58f6"},{"line_number":22,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_bbe53ddd","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":9},"updated":"2016-04-19 16:15:08.000000000","message":"nit: without?","commit_id":"5e650ef468aea462bff1e16637643e5243e679b0"}],"playbooks/lxc-containers-create.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"df3ac76f599472fd35d03e35092bbac5bdde35d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create container(s)"},{"line_number":17,"context_line":"  hosts: \"all_containers\""},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  gather_facts: false"},{"line_number":20,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_5ab1cce0","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":25},"updated":"2016-04-18 11:50:23.000000000","message":"Is this change intentional. Does this break functionality which a deployer may wish to use. For example see the commit message and changes in https://github.com/openstack/openstack-ansible/commit/8ededdd280073cbbfb0b0f5c658ee830060c2232","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"fa7820d8db1d24a7b615875bde57587c5f82d3df","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create container(s)"},{"line_number":17,"context_line":"  hosts: \"all_containers\""},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  gather_facts: false"},{"line_number":20,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_b62f543d","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":25},"in_reply_to":"1a122d0e_29192c89","updated":"2016-04-18 14:08:15.000000000","message":"container_group change does not seem to affect my change that Jesse linked.. no objection to removing it. I do think a reno would be prudent when removing a var/group even if it is old and undocumented.","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f39d2948195cb35df6fdc4d117a9ffd5b3a3e48a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create container(s)"},{"line_number":17,"context_line":"  hosts: \"all_containers\""},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  gather_facts: false"},{"line_number":20,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_29192c89","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":25},"in_reply_to":"1a122d0e_5ab1cce0","updated":"2016-04-18 13:17:07.000000000","message":"it was intentional, the host group limits would normally be processed by --limit this was a hold over from \"icehouse\". That said, i can put it back the way it was.","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d4f6d262d068c2d90b77d017462b52deec04d41e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  vars:"},{"line_number":57,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":58,"context_line":"    lxc_container_release: \"{{ properties.container_release|default(\u0027trusty\u0027) }}\""},{"line_number":59,"context_line":"    lxc_container_domain: \"openstack.local\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_adb9c7cd","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":43},"updated":"2016-04-18 13:27:02.000000000","message":"Is there a reason that this can\u0027t go into group_vars?","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"53dc4cecd40a140e7f078cd1b0755c715ed15b81","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  vars:"},{"line_number":57,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":58,"context_line":"    lxc_container_release: \"{{ properties.container_release|default(\u0027trusty\u0027) }}\""},{"line_number":59,"context_line":"    lxc_container_domain: \"openstack.local\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_b050fc0b","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":43},"in_reply_to":"1a122d0e_adb9c7cd","updated":"2016-04-18 13:34:46.000000000","message":"no, I\u0027d be happy to place it in the group_vars.","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fbb259b8814acbebc91f7247d9aaa0004c4a62ef","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  vars:"},{"line_number":57,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":58,"context_line":"    lxc_container_release: \"{{ properties.container_release|default(\u0027trusty\u0027) }}\""},{"line_number":59,"context_line":"    lxc_container_domain: \"openstack.local\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_96ba1822","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":43},"in_reply_to":"1a122d0e_b050fc0b","updated":"2016-04-18 14:04:06.000000000","message":"That\u0027d be better, thanks - one place to look for things.","commit_id":"693319b621eb2cab50990d7978bfe73cac8e3abd"}],"releasenotes/notes/RFC-1034-and-1035-container-update-6e880e4b45e11cf0.yaml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"9677c796d3d9af23e4b1cb106cbea0cfd2a34286","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - LXC containers will now have a proper RFC1034/5 hostname set within"},{"line_number":4,"context_line":"    them during post build tasks. The simple set of task will ensure a"},{"line_number":5,"context_line":"    localhost entry for 127.0.1.1 is created using the inventory_hostname"},{"line_number":6,"context_line":"    while ensuring all of the \"_\" are coverted to \"-\". Additionally the"},{"line_number":7,"context_line":"    containers will be created with a default domain of *openstack.local*."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a122d0e_20daa317","line":4,"range":{"start_line":4,"start_character":38,"end_line":4,"end_character":56},"updated":"2016-04-19 14:41:07.000000000","message":"tasks","commit_id":"79fd8d6eb873e308475ea272bae00ac54c2df0c7"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"9677c796d3d9af23e4b1cb106cbea0cfd2a34286","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - LXC containers will now have a proper RFC1034/5 hostname set within"},{"line_number":4,"context_line":"    them during post build tasks. The simple set of task will ensure a"},{"line_number":5,"context_line":"    localhost entry for 127.0.1.1 is created using the inventory_hostname"},{"line_number":6,"context_line":"    while ensuring all of the \"_\" are coverted to \"-\". Additionally the"},{"line_number":7,"context_line":"    containers will be created with a default domain of *openstack.local*."},{"line_number":8,"context_line":"    This domain name can be customized to meet your deployment needs by"},{"line_number":9,"context_line":"    setting the option ``lxc_container_domain``."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a122d0e_60065b87","line":6,"range":{"start_line":6,"start_character":38,"end_line":6,"end_character":46},"updated":"2016-04-19 14:41:07.000000000","message":"converted","commit_id":"79fd8d6eb873e308475ea272bae00ac54c2df0c7"}]}