)]}'
{"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"86bff85c5bc852e53d1718eba9fd69dda83dad25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a122d0e_fd05ad13","updated":"2016-04-20 15:41:57.000000000","message":"I expect that the inclusion of these changes is a mistake?","commit_id":"0027d0ccd7d2d54826462e26f2bd08c3c3e1f9c3"}],"playbooks/inventory/group_vars/hosts.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f3bf4ec1028aa5e4b57a3be2b037dec0560f9cb1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"keystone_rabbitmq_vhost: /keystone"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"keystone_service_internaluri_insecure: false"},{"line_number":202,"context_line":"keystone_service_adminuri_insecure: \"{{ keystone_service_internaluri_insecure }}\""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"keystone_service_publicuri: \"{{ keystone_service_publicuri_proto }}://{{ external_lb_vip_address }}:{{ keystone_service_port }}\""},{"line_number":205,"context_line":"keystone_service_internaluri: \"{{ keystone_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ keystone_service_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_1b48b6cb","line":202,"range":{"start_line":202,"start_character":36,"end_line":202,"end_character":80},"updated":"2016-04-19 14:59:10.000000000","message":"I would far rather see this derived from some conditions, for example:\n\nif keystone_service_adminuri_proto \u003d\u003d \u0027https\u0027 and (keystone_ssl_cert is not defined or haproxy_ssl_cert is not defined)) then true else false\n\nThe same, perhaps should be done for the internaluri var. This approach keeps them overridable, but also eases use and makes the setting depend appropriately on the endpoints.","commit_id":"28b844b11faacc310b55f10e4df052887921f291"}]}