)]}'
{"id":"openstack%2Fopenstack-ansible~307512","triplet_id":"openstack%2Fopenstack-ansible~master~I921031c676776884cb121a7914fcd9c505345e67","project":"openstack/openstack-ansible","branch":"master","topic":"bug/1566629","hashtags":[],"change_id":"I921031c676776884cb121a7914fcd9c505345e67","subject":"Change keystone admin/internal insecure flags","status":"MERGED","created":"2016-04-18 22:36:34.000000000","updated":"2016-04-21 13:48:02.000000000","submitted":"2016-04-21 13:38:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f3bfa162522d9e535b0ad87fb6e0f526779e293e","_number":307512,"virtual_id_number":307512,"owner":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":2,"date":"2016-04-21 13:38:07.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":2,"date":"2016-04-21 12:26:23.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},{"value":2,"date":"2016-04-21 01:29:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"all":[{"value":1,"date":"2016-04-21 12:26:23.000000000","_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-21 01:29:05.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2016-04-21 12:26:23.000000000","updated_by":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"reviewer":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"state":"REVIEWER"},{"updated":"2016-04-21 13:38:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e8931565e65e9977b06be71f8895dad25ab43ed6","author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"date":"2016-04-18 22:36:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b97290438f5400158c391cb904a64becae65061","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-04-19 01:08:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f784546dd9065ef0cb2d133f3543d5e96edbe079","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-04-19 08:50:49.000000000","message":"Patch Set 1: Code-Review-1\n\nThe internal and admin endpoints listen on different ports, are setup in different ways and we should not assume that they be treated in the same way.","accounts_in_message":[],"_revision_number":1},{"id":"5d68ee59d94e5d061c603f2d4c408ac966124668","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-19 13:33:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-docs http://docs-draft.openstack.org/12/307512/1/check/gate-openstack-ansible-docs/edd4cad//doc/build/html/ : SUCCESS in 1m 43s\n- gate-openstack-ansible-linters http://logs.openstack.org/12/307512/1/check/gate-openstack-ansible-linters/51ad817/ : SUCCESS in 2m 06s\n- gate-openstack-ansible-dsvm-commit http://logs.openstack.org/12/307512/1/check/gate-openstack-ansible-dsvm-commit/d6a4c4b/ : SUCCESS in 53m 54s","accounts_in_message":[],"_revision_number":1},{"id":"f3bf4ec1028aa5e4b57a3be2b037dec0560f9cb1","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-04-19 14:59:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"106483bb688e6efac3c8b122b9194c23e4fcb467","author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"date":"2016-04-20 15:29:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f06224952bfd56d4e63f63425549eb4c334f2f2f","author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"date":"2016-04-20 15:29:37.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nDone.","accounts_in_message":[],"_revision_number":2},{"id":"86bff85c5bc852e53d1718eba9fd69dda83dad25","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-04-20 15:41:57.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1ad040bb44c383353be4e1c3637eeece1717ee93","author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"date":"2016-04-20 15:45:52.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\ndefinitely!","accounts_in_message":[],"_revision_number":2},{"id":"5762d1c651b7c1911d3d7ac1ed5f8d21238d7ac3","author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"date":"2016-04-20 15:53:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0fe34c1f7df4a0a1fa99243f8f8bca7d55e7e394","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-20 19:02:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-docs http://docs-draft.openstack.org/12/307512/3/check/gate-openstack-ansible-docs/098f541//doc/build/html/ : SUCCESS in 2m 37s\n- gate-openstack-ansible-linters http://logs.openstack.org/12/307512/3/check/gate-openstack-ansible-linters/e320f56/ : SUCCESS in 4m 03s\n- gate-openstack-ansible-dsvm-commit http://logs.openstack.org/12/307512/3/check/gate-openstack-ansible-dsvm-commit/91a7177/ : SUCCESS in 1h 14m 59s","accounts_in_message":[],"_revision_number":3},{"id":"008f1596684c3cf464a59c51410c75eabe1810ff","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2016-04-21 01:29:05.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"15d8769b505e0ba788d330838db8603c629dd45b","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-04-21 12:26:23.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"1ebb1c34e7d4b6f31eaf3e27df2c14d9995b8ada","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 12:26:29.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"f82f4451dc2e438a42a20bc5c5beb8f4b9b2fa34","date":"2016-04-21 13:38:07.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"1936d86da7053dba7bb013a691f8a4a41a2e9c93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 13:38:07.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-docs http://docs-draft.openstack.org/12/307512/3/gate/gate-openstack-ansible-docs/17eebcf//doc/build/html/ : SUCCESS in 2m 22s\n- gate-openstack-ansible-linters http://logs.openstack.org/12/307512/3/gate/gate-openstack-ansible-linters/56bca37/ : SUCCESS in 3m 54s\n- gate-openstack-ansible-dsvm-commit http://logs.openstack.org/12/307512/3/gate/gate-openstack-ansible-dsvm-commit/4d58f5d/ : SUCCESS in 54m 00s","accounts_in_message":[],"_revision_number":3},{"id":"dc59f275c0d87eaa8cd49c3649f17be38879723c","author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"date":"2016-04-21 13:48:02.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/mitaka as commit f5f7eb13db407019552cf9a25f5e990b0df88ab9","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2ffb77638f48d75a444c35e619355cd6f1339076","revisions":{"28b844b11faacc310b55f10e4df052887921f291":{"kind":"REWORK","_number":1,"created":"2016-04-18 22:36:34.000000000","uploader":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"ref":"refs/changes/12/307512/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/12/307512/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/1"}}},"commit":{"parents":[{"commit":"6142484fe999fd21c02de7357343d603e10dbd78","subject":"Merge \"Doc: Improved documentation about LVM overwrite behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6142484fe999fd21c02de7357343d603e10dbd78"}]}],"author":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-18 22:22:25.000000000","tz":0},"committer":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-18 22:22:25.000000000","tz":0},"subject":"Set admin/internal insecure flag same by default","message":"Set admin/internal insecure flag same by default\n\nInternal and admin URLs are both internals.\nSetting `keystone_service_internaluri_insecure` flag true\nshould also set `keystone_service_adminuri_insecure`\nto true unless specified.\n\nChange-Id: I921031c676776884cb121a7914fcd9c505345e67\nCloses-Bug: 1566629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/28b844b11faacc310b55f10e4df052887921f291"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/28b844b11faacc310b55f10e4df052887921f291"}]},"branch":"refs/heads/master"},"0027d0ccd7d2d54826462e26f2bd08c3c3e1f9c3":{"kind":"REWORK","_number":2,"created":"2016-04-20 15:29:14.000000000","uploader":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"ref":"refs/changes/12/307512/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/12/307512/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/2"}}},"commit":{"parents":[{"commit":"6142484fe999fd21c02de7357343d603e10dbd78","subject":"Merge \"Doc: Improved documentation about LVM overwrite behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6142484fe999fd21c02de7357343d603e10dbd78"}]}],"author":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-18 22:22:25.000000000","tz":0},"committer":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-20 15:08:38.000000000","tz":0},"subject":"Change keystone admin/internal insecure flags","message":"Change keystone admin/internal insecure flags\n\nMake `keystone_service_internaluri_insecure` and\n`keystone_service_adminuri_insecure` flag default values\nderived from facts like protocol each endpoint is using and\nkind of certificates being used to reach that endpoint\n(user-provided or self-signed).\n\nChange-Id: I921031c676776884cb121a7914fcd9c505345e67\nCloses-Bug: 1566629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0027d0ccd7d2d54826462e26f2bd08c3c3e1f9c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/0027d0ccd7d2d54826462e26f2bd08c3c3e1f9c3"}]},"branch":"refs/heads/master"},"2ffb77638f48d75a444c35e619355cd6f1339076":{"kind":"REWORK","_number":3,"created":"2016-04-20 15:53:13.000000000","uploader":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"ref":"refs/changes/12/307512/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/12/307512/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/12/307512/3"}}},"commit":{"parents":[{"commit":"6142484fe999fd21c02de7357343d603e10dbd78","subject":"Merge \"Doc: Improved documentation about LVM overwrite behaviour\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/6142484fe999fd21c02de7357343d603e10dbd78"}]}],"author":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-18 22:22:25.000000000","tz":0},"committer":{"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","date":"2016-04-20 15:52:51.000000000","tz":0},"subject":"Change keystone admin/internal insecure flags","message":"Change keystone admin/internal insecure flags\n\nMake `keystone_service_internaluri_insecure` and\n`keystone_service_adminuri_insecure` flag default values\nderived from facts like protocol each endpoint is using and\nkind of certificates being used to reach that endpoint\n(user-provided or self-signed).\n\nChange-Id: I921031c676776884cb121a7914fcd9c505345e67\nCloses-Bug: 1566629\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/2ffb77638f48d75a444c35e619355cd6f1339076"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/2ffb77638f48d75a444c35e619355cd6f1339076"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}