)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"196d14861d1fc885876f8f2155836502dd3cf7d6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The tox.ini configuration is modified to make sure that the insert order"},{"line_number":24,"context_line":"on the configuration dictionary is the same on every run of the tests."},{"line_number":25,"context_line":"Were this not set, the insertion order may well change dependon on the"},{"line_number":26,"context_line":"hash seed, which would cause test failures because the assertions would"},{"line_number":27,"context_line":"not match."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a122d0e_c241373b","line":25,"updated":"2016-05-04 23:41:12.000000000","message":"nit: depending","commit_id":"59c8e6a70db18f866cc3efee2803726dd454643b"}],"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"becc388d96f2d487f4efdea2745f52789cd74b43","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"            for _key, _value in value.iteritems():"},{"line_number":373,"context_line":"                # Make sure we don\u0027t write a new IP for an existing host"},{"line_number":374,"context_line":"                if _key in inventory[\u0027_meta\u0027][\u0027hostvars\u0027]:"},{"line_number":375,"context_line":"                    current_ip \u003d hvs[_key][\u0027ansible_ssh_host\u0027]"},{"line_number":376,"context_line":"                    new_ip \u003d _value[\u0027ip\u0027]"},{"line_number":377,"context_line":"                    if not current_ip \u003d\u003d new_ip:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_dd2ef18a","line":374,"range":{"start_line":374,"start_character":27,"end_line":374,"end_character":57},"updated":"2016-04-20 15:47:40.000000000","message":"you can use hvs variable defined above","commit_id":"3fe7f9386b6eda01c28d641214482877073179e4"},{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"8a6b824488ba6a3195f54d94ee3fdd3fbd2aef34","unresolved":false,"context_lines":[{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class MultipleIpForHostError(Exception):"},{"line_number":53,"context_line":"    def __init__(self, hostname, current_ip, new_ip):"},{"line_number":54,"context_line":"        self.hostname \u003d hostname"},{"line_number":55,"context_line":"        self.current_ip \u003d current_ip"},{"line_number":56,"context_line":"        self.new_ip \u003d new_ip"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        info \u003d (current_ip, hostname, new_ip)"},{"line_number":59,"context_line":"        error_msg \u003d (\"Trying to assign address {} to host {}\""},{"line_number":60,"context_line":"                     \", but it already has address {}\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.message \u003d error_msg.format(*info)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __str__(self):"},{"line_number":65,"context_line":"        return self.message"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def args():"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_fbc6e714","line":65,"range":{"start_line":52,"start_character":0,"end_line":65,"end_character":27},"updated":"2016-04-22 15:31:22.000000000","message":"Nolan, I like the changes you made to this patch but I am still skeptical whether this exception class is necessary.","commit_id":"23d637446c1c430ff93fcb4c7618575145560e6c"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"083aa9aa8f3aa8c64dc3d827e3ddf9aee7dfa3d4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class MultipleIpForHostError(Exception):"},{"line_number":53,"context_line":"    def __init__(self, hostname, current_ip, new_ip):"},{"line_number":54,"context_line":"        self.hostname \u003d hostname"},{"line_number":55,"context_line":"        self.current_ip \u003d current_ip"},{"line_number":56,"context_line":"        self.new_ip \u003d new_ip"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        info \u003d (current_ip, hostname, new_ip)"},{"line_number":59,"context_line":"        error_msg \u003d (\"Trying to assign address {} to host {}\""},{"line_number":60,"context_line":"                     \", but it already has address {}\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.message \u003d error_msg.format(*info)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __str__(self):"},{"line_number":65,"context_line":"        return self.message"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def args():"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_21b9527a","line":65,"range":{"start_line":52,"start_character":0,"end_line":65,"end_character":27},"in_reply_to":"1a122d0e_fbc6e714","updated":"2016-04-22 15:46:16.000000000","message":"It is not strictly necessary, no. My stance is that more specific errors are better - raising SystemExit everywhere works, but then relies on scraping the messages.\n\nAlso, if the functionality included here is to turn into a library at some point, SystemExit would be unfit for use there, at least at the library level. Callers may want to catch specific exceptions, which may come up with different backends for the inventory configuration.","commit_id":"23d637446c1c430ff93fcb4c7618575145560e6c"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"196d14861d1fc885876f8f2155836502dd3cf7d6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        error_msg \u003d (\"Trying to assign address {} to host {}\""},{"line_number":75,"context_line":"                     \", but it already has address {}\")"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.message \u003d error_msg.format(current_ip, hostname, new_ip)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __str__(self):"},{"line_number":80,"context_line":"        return self.message"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_02b68f3d","line":77,"updated":"2016-05-04 23:41:12.000000000","message":"I may be misreading this, but are current_ip and new_ip the right way around here?","commit_id":"59c8e6a70db18f866cc3efee2803726dd454643b"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"8e4a42de4d9d7384f2846be0225ae8a935360584","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        error_msg \u003d (\"Trying to assign address {} to host {}\""},{"line_number":75,"context_line":"                     \", but it already has address {}\")"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.message \u003d error_msg.format(current_ip, hostname, new_ip)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __str__(self):"},{"line_number":80,"context_line":"        return self.message"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_d309eb2c","line":77,"in_reply_to":"1a122d0e_02b68f3d","updated":"2016-05-05 14:52:08.000000000","message":"Ah, you are not misreading, they\u0027re in the wrong order. Good catch.","commit_id":"59c8e6a70db18f866cc3efee2803726dd454643b"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"aa65d8a4234819c38365023f66898e34675c1f3c","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    host_ip_map \u003d {}"},{"line_number":920,"context_line":"    for key, value in config.items():"},{"line_number":921,"context_line":"        if \u0027_hosts\u0027 in key:"},{"line_number":922,"context_line":"            group \u003d config[key]"},{"line_number":923,"context_line":"            for hostname, entries in group.items():"},{"line_number":924,"context_line":"                if hostname not in host_ip_map:"},{"line_number":925,"context_line":"                    host_ip_map[hostname] \u003d entries[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_8ef76ef4","line":922,"updated":"2016-05-09 16:13:15.000000000","message":"isn\u0027t this the same as value, above?\n\nmaybe rename key, value to hint about the contents of config:\ne.g. inv_group_name, group or group_key, group","commit_id":"e47ce2be7b2d49aba035c1e02aea4d367b2d9384"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"92a41cf06075903e7bae9f0df36242a61e30c0a8","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    host_ip_map \u003d {}"},{"line_number":920,"context_line":"    for key, value in config.items():"},{"line_number":921,"context_line":"        if \u0027_hosts\u0027 in key:"},{"line_number":922,"context_line":"            group \u003d config[key]"},{"line_number":923,"context_line":"            for hostname, entries in group.items():"},{"line_number":924,"context_line":"                if hostname not in host_ip_map:"},{"line_number":925,"context_line":"                    host_ip_map[hostname] \u003d entries[\u0027ip\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_91ecb390","line":922,"in_reply_to":"dab17558_8ef76ef4","updated":"2016-05-09 16:43:31.000000000","message":"Done","commit_id":"e47ce2be7b2d49aba035c1e02aea4d367b2d9384"}],"tests/test_inventory.py":[{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"13dbffc62927101b2e95529a55f63eb142d9ffa1","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            self.user_defined_config.update(yaml.safe_load(f.read()) or {})"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def delete_config_key(self, user_defined_config, key):"},{"line_number":340,"context_line":"        self.config_changed \u003d True"},{"line_number":341,"context_line":"        try:"},{"line_number":342,"context_line":"            if key in user_defined_config:"},{"line_number":343,"context_line":"                del user_defined_config[key]"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_0ab8c229","line":340,"range":{"start_line":340,"start_character":8,"end_line":340,"end_character":34},"updated":"2016-05-03 02:10:46.000000000","message":"we can use one self.config_changed \u003d True\nunder write_config function","commit_id":"23f6dd12a1987ce325b3d3f68fa98eb41cb555af"},{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"13dbffc62927101b2e95529a55f63eb142d9ffa1","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            self.write_config()"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def delete_provider_network(self, net_name):"},{"line_number":352,"context_line":"        self.config_changed \u003d True"},{"line_number":353,"context_line":"        del self.user_defined_config[\u0027cidr_networks\u0027][net_name]"},{"line_number":354,"context_line":"        self.write_config()"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_eab46636","line":352,"range":{"start_line":352,"start_character":8,"end_line":352,"end_character":34},"updated":"2016-05-03 02:10:46.000000000","message":"same here to remove","commit_id":"23f6dd12a1987ce325b3d3f68fa98eb41cb555af"},{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"13dbffc62927101b2e95529a55f63eb142d9ffa1","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        self.assertEqual(context.exception.message, expectedLog)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def test_missing_cidr_networks_key(self):"},{"line_number":379,"context_line":"        self.config_changed \u003d True"},{"line_number":380,"context_line":"        del self.user_defined_config[\u0027cidr_networks\u0027]"},{"line_number":381,"context_line":"        self.write_config()"},{"line_number":382,"context_line":"        with self.assertRaises(SystemExit) as context:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_4a80fa49","line":379,"range":{"start_line":379,"start_character":8,"end_line":379,"end_character":34},"updated":"2016-05-03 02:10:46.000000000","message":"same","commit_id":"23f6dd12a1987ce325b3d3f68fa98eb41cb555af"},{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"13dbffc62927101b2e95529a55f63eb142d9ffa1","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        self.assertEqual(context.exception.message, expectedLog)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def set_new_ip(self, user_defined_config, group, hostname, ip):"},{"line_number":388,"context_line":"        self.config_changed \u003d True"},{"line_number":389,"context_line":"        # Sets an IP address for a specified host."},{"line_number":390,"context_line":"        user_defined_config[group][hostname][\u0027ip\u0027] \u003d ip"},{"line_number":391,"context_line":"        # rename temporarily our user_config_file so we can use the new one"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_6a7fb666","line":388,"range":{"start_line":388,"start_character":8,"end_line":388,"end_character":34},"updated":"2016-05-03 02:10:46.000000000","message":"same","commit_id":"23f6dd12a1987ce325b3d3f68fa98eb41cb555af"},{"author":{"_account_id":19592,"name":"Ala Raddaoui","email":"raddaoui.ala@intel.com","username":"ala_raddaoui"},"change_message_id":"13dbffc62927101b2e95529a55f63eb142d9ffa1","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.config_changed \u003d True"},{"line_number":389,"context_line":"        # Sets an IP address for a specified host."},{"line_number":390,"context_line":"        user_defined_config[group][hostname][\u0027ip\u0027] \u003d ip"},{"line_number":391,"context_line":"        # rename temporarily our user_config_file so we can use the new one"},{"line_number":392,"context_line":"        os.rename(USER_CONFIG_FILE, USER_CONFIG_FILE + \".tmp\")"},{"line_number":393,"context_line":"        # Save new user_config_file"},{"line_number":394,"context_line":"        with open(USER_CONFIG_FILE, \u0027wb\u0027) as f:"},{"line_number":395,"context_line":"            f.write(yaml.dump(user_defined_config))"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_provider_networks_check(self):"},{"line_number":398,"context_line":"        # create config file without provider networks"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_6af696fa","line":395,"range":{"start_line":391,"start_character":8,"end_line":395,"end_character":51},"updated":"2016-05-03 02:10:46.000000000","message":"use write_config function instead","commit_id":"23f6dd12a1987ce325b3d3f68fa98eb41cb555af"}]}
