)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"fadf69f5ef8c4760d8605344270e36e5502c324d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"success by having a retry on a playbook execution in the case of transient"},{"line_number":16,"context_line":"failure."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"A notice has been added to the script whenever it exists notifying"},{"line_number":19,"context_line":"the deployer that they should now work out of the playbooks directory"},{"line_number":20,"context_line":"and never execute the run-playbooks.sh script ever again. Within the"},{"line_number":21,"context_line":"notice links to our documentation have been added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_e3592c90","line":18,"updated":"2016-06-02 21:55:57.000000000","message":"s/exists/exits","commit_id":"bfb798775f1092be5467dc8f560648fc9390c4cc"}],"etc/openstack_deploy/conf.d/ironic.yml.example":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7b2a1698b96790990e0217c62fa619e09b87e492","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_d7b6e7da","updated":"2016-05-26 14:31:49.000000000","message":"This rename isn\u0027t necessary. If the bootstrap doesn\u0027t actually place this file down, then no containers will be created. This can still remain exactly as-is.","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"409c5335adb7d10d71db47e8799edede4192cd02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9abb7d3a_9e66e127","in_reply_to":"9abb7d3a_ab08f228","updated":"2016-06-02 09:26:59.000000000","message":"Yes, exactly - if those lines are removed then this rename is unnecessary.","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9abb7d3a_ab08f228","in_reply_to":"bab6814e_d7b6e7da","updated":"2016-06-01 15:56:54.000000000","message":"As this stands right now, the ironic.aio file is being placed which is building ironic containers and while its not exercising the ironic code path by default it is taking valuable gate resources which could be used elsewhere.\n\nIntegration point:\n  https://github.com/openstack/openstack-ansible/blob/master/tests/roles/bootstrap-host/tasks/prepare_aio_config.yml#L95-L96","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"}],"playbooks/setup-openstack.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"409c5335adb7d10d71db47e8799edede4192cd02","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- include: os-ceilometer-install.yml"},{"line_number":24,"context_line":"- include: os-aodh-install.yml"},{"line_number":25,"context_line":"- include: os-swift-install.yml"},{"line_number":26,"context_line":"- include: os-ironic-install.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_891ced6b","side":"PARENT","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":32},"updated":"2016-06-02 09:26:59.000000000","message":"Removing this is entirely unnecessary. If there are no hosts allocated in the configuration, then the playbook will simply pass by.","commit_id":"89e74db97469e6175f3fd447271428c0f97c1c4d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9c6823ac302c5c3af15dfcfc4650e9252649653f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- include: os-aodh-install.yml"},{"line_number":25,"context_line":"- include: os-swift-install.yml"},{"line_number":26,"context_line":"- include: os-ironic-install.yml"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9abb7d3a_0cd70aee","line":27,"updated":"2016-06-03 16:45:49.000000000","message":"Is this blank line necessary for the new parsing in run-playbooks.sh?","commit_id":"bfb798775f1092be5467dc8f560648fc9390c4cc"}],"scripts/run-playbooks.sh":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"17f6c0f6b17e2001bd0dbce5f4a006cc392d8c48","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -e -u"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Variables -----------------------------------------------------------------"},{"line_number":20,"context_line":"DEPLOY_AIO\u003d${DEPLOY_AIO:-false}"},{"line_number":21,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"## Main ----------------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_2fdfdd3a","line":20,"updated":"2016-04-20 21:01:44.000000000","message":"Since the variables are removed here, is the thought to move that kind of customization directly on the user_variables.yml file? The loop below executes every playbook, so the conditional would need to be in the playbooks themselves as I understand it.","commit_id":"ade8b7b7e7b37e10862e7ac9b7dc38b263542fa3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82fbb1291357e4b64ae3ee10a97458ee952e7f8f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -e -u"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"## Variables -----------------------------------------------------------------"},{"line_number":20,"context_line":"DEPLOY_AIO\u003d${DEPLOY_AIO:-false}"},{"line_number":21,"context_line":"COMMAND_LOGS\u003d${COMMAND_LOGS:-\"/openstack/log/ansible_cmd_logs/\"}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"## Main ----------------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_58401d07","line":20,"in_reply_to":"1a122d0e_2fdfdd3a","updated":"2016-04-20 22:07:03.000000000","message":"The idea is to essentially get this to execute ``setup-everything.yml``. This script was only ever intended to setup an AIO for testing and the gate. Because the primary consumer of this script is the gate, it needs to be executing playbooks using a strategy that would be found in production which is not what is being done today. As for the customization\u0027s of these variables, all of that can be achieved by simply adding or not adding items into inventory. The playbooks will do nothing if they have no hosts to execute against.","commit_id":"ade8b7b7e7b37e10862e7ac9b7dc38b263542fa3"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"9dd5bf86fb3877c3b0b028f232a15a7d1733492a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    log_instance_info"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    # When running in an AIO, we need to drop the following iptables rule in any neutron_agent containers"},{"line_number":79,"context_line":"    #   to that ensure instances can communicate with the neutron metadata service."},{"line_number":80,"context_line":"    #   This is necessary because in an AIO environment there are no physical interfaces involved in"},{"line_number":81,"context_line":"    #   instance -\u003e metadata requests, and this results in the checksums being incorrect."},{"line_number":82,"context_line":"    mkdir -p \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_80843b0b","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":15},"updated":"2016-05-26 01:36:39.000000000","message":"nit /to that ensure/to ensure/","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    log_instance_info"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    # When running in an AIO, we need to drop the following iptables rule in any neutron_agent containers"},{"line_number":79,"context_line":"    #   to that ensure instances can communicate with the neutron metadata service."},{"line_number":80,"context_line":"    #   This is necessary because in an AIO environment there are no physical interfaces involved in"},{"line_number":81,"context_line":"    #   instance -\u003e metadata requests, and this results in the checksums being incorrect."},{"line_number":82,"context_line":"    mkdir -p \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9abb7d3a_abf2b203","line":79,"range":{"start_line":79,"start_character":11,"end_line":79,"end_character":15},"in_reply_to":"bab6814e_80843b0b","updated":"2016-06-01 15:56:54.000000000","message":"Done","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"9dd5bf86fb3877c3b0b028f232a15a7d1733492a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    ansible neutron_agent -m command \\"},{"line_number":84,"context_line":"                          -a \u0027/sbin/iptables -t mangle -A POSTROUTING -p tcp --sport 80 -j CHECKSUM --checksum-fill\u0027 \\"},{"line_number":85,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"},{"line_number":86,"context_line":"                          \u0026\u003e ${COMMAND_LOGS}/add_neutron_agent_checksum_rule.log || true"},{"line_number":87,"context_line":"    ansible neutron_agent -m shell \\"},{"line_number":88,"context_line":"                          -a \u0027DEBIAN_FRONTEND\u003dnoninteractive apt-get install iptables-persistent\u0027 \\"},{"line_number":89,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_8000bb67","line":86,"range":{"start_line":86,"start_character":84,"end_line":86,"end_character":88},"updated":"2016-05-26 01:36:39.000000000","message":"This will make it a little harder to diagnose the failure of this task if they does fail?","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    ansible neutron_agent -m command \\"},{"line_number":84,"context_line":"                          -a \u0027/sbin/iptables -t mangle -A POSTROUTING -p tcp --sport 80 -j CHECKSUM --checksum-fill\u0027 \\"},{"line_number":85,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"},{"line_number":86,"context_line":"                          \u0026\u003e ${COMMAND_LOGS}/add_neutron_agent_checksum_rule.log || true"},{"line_number":87,"context_line":"    ansible neutron_agent -m shell \\"},{"line_number":88,"context_line":"                          -a \u0027DEBIAN_FRONTEND\u003dnoninteractive apt-get install iptables-persistent\u0027 \\"},{"line_number":89,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9abb7d3a_4befc61d","line":86,"range":{"start_line":86,"start_character":84,"end_line":86,"end_character":88},"in_reply_to":"bab6814e_8000bb67","updated":"2016-06-01 15:56:54.000000000","message":"Done","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"9dd5bf86fb3877c3b0b028f232a15a7d1733492a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    ansible neutron_agent -m shell \\"},{"line_number":88,"context_line":"                          -a \u0027DEBIAN_FRONTEND\u003dnoninteractive apt-get install iptables-persistent\u0027 \\"},{"line_number":89,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"},{"line_number":90,"context_line":"                          \u0026\u003e\u003e ${COMMAND_LOGS}/add_neutron_agent_checksum_rule.log || true"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Log repo data"},{"line_number":93,"context_line":"    mkdir -p \"${COMMAND_LOGS}/repo_data\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_4031b359","line":90,"range":{"start_line":90,"start_character":85,"end_line":90,"end_character":89},"updated":"2016-05-26 01:36:39.000000000","message":"This will make it a little harder to diagnose the failure of this task if they does fail?","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    ansible neutron_agent -m shell \\"},{"line_number":88,"context_line":"                          -a \u0027DEBIAN_FRONTEND\u003dnoninteractive apt-get install iptables-persistent\u0027 \\"},{"line_number":89,"context_line":"                          -t \"${COMMAND_LOGS}/add_neutron_agent_checksum_rule\" \\"},{"line_number":90,"context_line":"                          \u0026\u003e\u003e ${COMMAND_LOGS}/add_neutron_agent_checksum_rule.log || true"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # Log repo data"},{"line_number":93,"context_line":"    mkdir -p \"${COMMAND_LOGS}/repo_data\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9abb7d3a_8bf52eee","line":90,"range":{"start_line":90,"start_character":85,"end_line":90,"end_character":89},"in_reply_to":"bab6814e_4031b359","updated":"2016-06-01 15:56:54.000000000","message":"Done","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"9dd5bf86fb3877c3b0b028f232a15a7d1733492a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    mkdir -p \"${COMMAND_LOGS}/repo_data\""},{"line_number":94,"context_line":"    ansible \u0027repo_all[0]\u0027 -m raw \\"},{"line_number":95,"context_line":"                          -a \u0027find  /var/www/repo/os-releases -type l\u0027 \\"},{"line_number":96,"context_line":"                          -t \"${COMMAND_LOGS}/repo_data\" || true"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    openstack-ansible os-tempest-install.yml"},{"line_number":99,"context_line":"    print_report"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_a0321f5c","line":96,"range":{"start_line":96,"start_character":60,"end_line":96,"end_character":64},"updated":"2016-05-26 01:36:39.000000000","message":"This will make it a little harder to diagnose the failure of this task if they does fail?","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    mkdir -p \"${COMMAND_LOGS}/repo_data\""},{"line_number":94,"context_line":"    ansible \u0027repo_all[0]\u0027 -m raw \\"},{"line_number":95,"context_line":"                          -a \u0027find  /var/www/repo/os-releases -type l\u0027 \\"},{"line_number":96,"context_line":"                          -t \"${COMMAND_LOGS}/repo_data\" || true"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    openstack-ansible os-tempest-install.yml"},{"line_number":99,"context_line":"    print_report"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9abb7d3a_abc912ae","line":96,"range":{"start_line":96,"start_character":60,"end_line":96,"end_character":64},"in_reply_to":"bab6814e_a0321f5c","updated":"2016-06-01 15:56:54.000000000","message":"Done","commit_id":"82bd264c523f1b58ba2afbbf7e1d152f72240c94"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9c6823ac302c5c3af15dfcfc4650e9252649653f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"If you ever have any questions please join the community conversation on IRC at"},{"line_number":43,"context_line":"#openstack-ansible on freenode."},{"line_number":44,"context_line":"\""},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9abb7d3a_6cb696dd","line":43,"updated":"2016-06-03 16:45:49.000000000","message":"Really like the pointers for additional resourced added in this notification, thanks","commit_id":"bfb798775f1092be5467dc8f560648fc9390c4cc"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"9c6823ac302c5c3af15dfcfc4650e9252649653f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"\""},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function playbook_run {"},{"line_number":48,"context_line":"  for root_include in $(awk -F\u0027include:\u0027 \u0027{print $2}\u0027 setup-everything.yml); do"},{"line_number":49,"context_line":"    for include in $(awk -F\u0027include:\u0027 \u0027{print $2}\u0027 \"${root_include}\"); do"},{"line_number":50,"context_line":"      echo \"[Executing \\\"${include}\\\" playbook]\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"9abb7d3a_4cbf5260","line":47,"updated":"2016-06-03 16:45:49.000000000","message":"Much prefer this to maintaining entirely separate calls.\n\nI would prefer if we could just run setup-everything.yml, but I\u0027d have to do some research to see if that would actually accomplish what we want anyway, given the retry logic in install_bits.","commit_id":"bfb798775f1092be5467dc8f560648fc9390c4cc"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"a9aa3dc480b8935927409ec3b9221de06d6026aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\\\"\\e[1;33m${PLAYBOOK_DIR}\\e[0m\\\" directory using the \\\"\\e[1;32mopenstack-ansible\\e[0m\\\""},{"line_number":32,"context_line":"command line wrapper."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For more information OpenStack-Ansible please review our documentation at:"},{"line_number":35,"context_line":"  \\e[1;36mhttp://docs.openstack.org/developer/openstack-ansible\\e[0m"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Additionally if there\u0027s ever a need for information on common operational tasks please"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3aaa91ec_4bc42c5e","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":21},"updated":"2016-06-23 22:31:53.000000000","message":"nit: about","commit_id":"e9ed51a909ce95de00b22a3bd9b1003001e87cf8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d24e4aa2c5ea8d4da61003cc024d42d3b86551ef","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\\\"\\e[1;33m${PLAYBOOK_DIR}\\e[0m\\\" directory using the \\\"\\e[1;32mopenstack-ansible\\e[0m\\\""},{"line_number":32,"context_line":"command line wrapper."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"For more information OpenStack-Ansible please review our documentation at:"},{"line_number":35,"context_line":"  \\e[1;36mhttp://docs.openstack.org/developer/openstack-ansible\\e[0m"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Additionally if there\u0027s ever a need for information on common operational tasks please"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3aaa91ec_8fb9f517","line":34,"range":{"start_line":34,"start_character":20,"end_line":34,"end_character":21},"in_reply_to":"3aaa91ec_4bc42c5e","updated":"2016-06-24 05:01:54.000000000","message":"Done","commit_id":"e9ed51a909ce95de00b22a3bd9b1003001e87cf8"}],"tests/roles/bootstrap-host/tasks/prepare_aio_config.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6612229a794a1916361b3dce4476467c7b90ac28","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      override: \"{{ ceilometer_conf_overrides | default({}) }}\""},{"line_number":93,"context_line":"    - name: swift.yml.aio"},{"line_number":94,"context_line":"      override: \"{{ swift_conf_overrides | default({}) }}\""},{"line_number":95,"context_line":"    - name: ironic.yml.aio"},{"line_number":96,"context_line":"      override: \"{{ ironic_conf_overrides | default({}) }}\""},{"line_number":97,"context_line":"  tags:"},{"line_number":98,"context_line":"    - deploy-confd"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_0b5dbe14","side":"PARENT","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":59},"updated":"2016-06-01 15:56:54.000000000","message":"This is removed because it creates ironic containers that should not exist unless testing Ironic and we don\u0027t have an integrated gate for Ironic at this time so removing these bits should save precious resources from within the integrated gate.","commit_id":"89e74db97469e6175f3fd447271428c0f97c1c4d"}]}
