)]}'
{"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"2e59903aaa6d7f141add352b9933316112f05139","unresolved":false,"context_lines":[{"line_number":875,"context_line":"                                     \"assigned to host:{}, cannot \""},{"line_number":876,"context_line":"                                     \"assign same ip to host:{}\")"},{"line_number":877,"context_line":"                        info \u003d (ip, ips_to_hostnames_mapping[ip], hostname)"},{"line_number":878,"context_line":"                        raise SystemExit(error_msg.format(*info))"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"def _check_config_settings(cidr_networks, config, container_skel):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_04ba64e1","line":878,"updated":"2016-04-22 15:55:05.000000000","message":"While SystemExit works for now, it will need to be changed as this code evolves into a library. External callers would have to catch SystemExit and parse the error message in order to take some action if they want to handle this scenario.","commit_id":"3cada115cbdf9b03bf108474a79415a95e185a8b"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"757b58ec87dca312f50484957b77e369fabfd962","unresolved":false,"context_lines":[{"line_number":888,"context_line":"                    ips_to_hostnames_mapping[ip] \u003d hostname"},{"line_number":889,"context_line":"                else:"},{"line_number":890,"context_line":"                    if ips_to_hostnames_mapping[ip] !\u003d hostname:"},{"line_number":891,"context_line":"                        error_msg \u003d (\"ip address:{} has already been \""},{"line_number":892,"context_line":"                                     \"assigned to host:{}, cannot \""},{"line_number":893,"context_line":"                                     \"assign same ip to host:{}\")"},{"line_number":894,"context_line":"                        info \u003d (ip, ips_to_hostnames_mapping[ip], hostname)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_f7461c4e","line":891,"updated":"2016-05-02 16:23:37.000000000","message":"I don\u0027t think the error_msg declaration is necessary here - it\u0027s unused outside of the exception now.","commit_id":"87fdb42738c30a47799e203392355c0687c65d37"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"757b58ec87dca312f50484957b77e369fabfd962","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                     \"assigned to host:{}, cannot \""},{"line_number":893,"context_line":"                                     \"assign same ip to host:{}\")"},{"line_number":894,"context_line":"                        info \u003d (ip, ips_to_hostnames_mapping[ip], hostname)"},{"line_number":895,"context_line":"                        raise MultipleHostsWithOneIPError(*info)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"def _check_config_settings(cidr_networks, config, container_skel):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_77d4ccbc","line":895,"updated":"2016-05-02 16:23:37.000000000","message":"We should probably just pass all the variables to the exception rather than making a tuple and expanding it. I\u0027m in the process of changing this for my own, similar review. It\u0027s clearer that way, especially for people who aren\u0027t familiar with python tuple/argument expansion.","commit_id":"87fdb42738c30a47799e203392355c0687c65d37"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"58d44f743e9fcbeb8e39a133a0b73ce1c747eed9","unresolved":false,"context_lines":[{"line_number":892,"context_line":"                                     \"assigned to host:{}, cannot \""},{"line_number":893,"context_line":"                                     \"assign same ip to host:{}\")"},{"line_number":894,"context_line":"                        info \u003d (ip, ips_to_hostnames_mapping[ip], hostname)"},{"line_number":895,"context_line":"                        raise MultipleHostsWithOneIPError(*info)"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"def _check_config_settings(cidr_networks, config, container_skel):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_5d028f73","line":895,"in_reply_to":"1a122d0e_77d4ccbc","updated":"2016-05-02 17:41:12.000000000","message":"+1","commit_id":"87fdb42738c30a47799e203392355c0687c65d37"}],"tests/test_inventory.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"2e59903aaa6d7f141add352b9933316112f05139","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def test_two_hosts_same_ip(self):"},{"line_number":352,"context_line":"        self.set_new_hostname(self.user_defined_config, \"haproxy_hosts\","},{"line_number":353,"context_line":"                              \"aio1\", \"hap\")"},{"line_number":354,"context_line":"        with self.assertRaises(subprocess.CalledProcessError) as context:"},{"line_number":355,"context_line":"            get_inventory()"},{"line_number":356,"context_line":"        expectedLog \u003d (\"ip address:172.29.236.100 has already been assigned\""},{"line_number":357,"context_line":"                       \" to host:aio1, cannot assign same ip to host:hap\\n\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_44f3bc0a","line":354,"updated":"2016-04-22 15:55:05.000000000","message":"This should just catch SystemExit now, since master no longer uses a subprocess.","commit_id":"3cada115cbdf9b03bf108474a79415a95e185a8b"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"fcfa4411d91c568cf19e4312b7a73fb68e5af8a1","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def test_two_hosts_same_ip(self):"},{"line_number":352,"context_line":"        self.set_new_hostname(self.user_defined_config, \"haproxy_hosts\","},{"line_number":353,"context_line":"                              \"aio1\", \"hap\")"},{"line_number":354,"context_line":"        with self.assertRaises(subprocess.CalledProcessError) as context:"},{"line_number":355,"context_line":"            get_inventory()"},{"line_number":356,"context_line":"        expectedLog \u003d (\"ip address:172.29.236.100 has already been assigned\""},{"line_number":357,"context_line":"                       \" to host:aio1, cannot assign same ip to host:hap\\n\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_a56c339d","line":354,"in_reply_to":"1a122d0e_44f3bc0a","updated":"2016-04-23 19:07:21.000000000","message":"It appears this is now failing the gate because the `subprocess` import was removed in master.","commit_id":"3cada115cbdf9b03bf108474a79415a95e185a8b"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"2e59903aaa6d7f141add352b9933316112f05139","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        expectedLog \u003d (\"ip address:172.29.236.100 has already been assigned\""},{"line_number":357,"context_line":"                       \" to host:aio1, cannot assign same ip to host:hap\\n\")"},{"line_number":358,"context_line":"        self.assertEqual(context.exception.output, expectedLog)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def tearDown(self):"},{"line_number":361,"context_line":"        # get back our initial user config file"},{"line_number":362,"context_line":"        os.remove(USER_CONFIG_FILE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_6446b822","line":359,"updated":"2016-04-22 15:55:05.000000000","message":"I would use a second test here that tests the _same_ip_to_multiple_hosts function directly with a smaller dictionary.","commit_id":"3cada115cbdf9b03bf108474a79415a95e185a8b"}]}
