)]}'
{"scripts/upgrade-utilities/playbooks/mariadb-apt-cleanup.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dddc74783fd40f184e1bc0bda881743bc76dbb7e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - name: Remove MariaDB repositories left over from Juno"},{"line_number":23,"context_line":"      shell: |"},{"line_number":24,"context_line":"        sed -i \u0027/http:.*maria.*/d\u0027 /etc/apt/sources.list.d/*"},{"line_number":25,"context_line":"      ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_600aa0d3","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":25},"updated":"2016-04-28 10:23:23.000000000","message":"This is a wrong way of doing it.\nWe should not ignore errors.\n\nWe should either:\n- Ensure the line is absent from every file given by a fileglob\n- Run this task conditionally of the presence of sources.list.d folder.","commit_id":"065a81b40808c63c41231b2191a9ec1a53adf5b6"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5473657f7aec8778279fff60ac53c59760c77d95","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    - name: Remove MariaDB repositories left over from Juno"},{"line_number":26,"context_line":"      shell: |"},{"line_number":27,"context_line":"        sed -i \u0027/http:.*maria.*/d\u0027 /etc/apt/sources.list.d/*"},{"line_number":28,"context_line":"      when: sources_dir.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a122d0e_14284d99","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":35},"updated":"2016-04-28 11:26:08.000000000","message":"I\u0027d use isdir instead of exists, just in case someone dumb created a flat file named /etc/apt/sources.list.d\n\nisdir ensures path exists as folder and user (root here) can read stats.","commit_id":"d569689077dcc50d214fe8de365cf6274ad39a22"}]}
