)]}'
{"playbooks/roles/ceph_client/defaults/main.yml":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"1660d2681eb8ca0230d3465cc82b1b42944e969c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# The ceph_pkg_source variable controls the install source for the Ceph packages."},{"line_number":29,"context_line":"# Valid values include:"},{"line_number":30,"context_line":"#   * ceph This option installs Ceph from a ceph.com repo.  Additional variables to"},{"line_number":31,"context_line":"#\t\t   adjust items such as Ceph release and regional download mirror can be found"},{"line_number":32,"context_line":"#          in vars/ceph_*.yml"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"#   * uca  This option installs Ceph from the Ubuntu Cloud Archive. Additional variables"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_6c6d3204","line":31,"updated":"2016-05-06 17:21:33.000000000","message":"new editor, will remove tabs.","commit_id":"ae5e1acbc13522f9c4115cb96ac5011c03e5a834"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"1660d2681eb8ca0230d3465cc82b1b42944e969c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#          in vars/ceph_*.yml"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"#   * uca  This option installs Ceph from the Ubuntu Cloud Archive. Additional variables"},{"line_number":35,"context_line":"#\t\t   to adjust items such as the OpenStack/Ceph release can be found in vars/uca_apt.yml."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"#   * distro This options installs Ceph from the operating system\u0027s default repository and"},{"line_number":38,"context_line":"#            unlike the other options does not attempt to manage package keys or add additional"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_ac771ad3","line":35,"updated":"2016-05-06 17:21:33.000000000","message":"new editor, will remove tabs.","commit_id":"ae5e1acbc13522f9c4115cb96ac5011c03e5a834"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   * distro This options installs Ceph from the operating system\u0027s default repository and"},{"line_number":38,"context_line":"#            unlike the other options does not attempt to manage package keys or add additional"},{"line_number":39,"context_line":"#            package repositories."},{"line_number":40,"context_line":"ceph_pkg_source: ceph"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"ceph_apt_pinned_packages: [{ package: \"*\", release: Inktank,  priority: 1001 }]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_633caac8","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":21},"updated":"2016-05-10 15:00:32.000000000","message":"Has there been any discussion around the package source being something other than ceph?\n\nIf we are planning to always deploy from upstream ceph repos, I think we might do away with the uca/distro features.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"#   * distro This options installs Ceph from the operating system\u0027s default repository and"},{"line_number":38,"context_line":"#            unlike the other options does not attempt to manage package keys or add additional"},{"line_number":39,"context_line":"#            package repositories."},{"line_number":40,"context_line":"ceph_pkg_source: ceph"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"ceph_apt_pinned_packages: [{ package: \"*\", release: Inktank,  priority: 1001 }]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_9a32c8f0","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":21},"in_reply_to":"dab17558_633caac8","updated":"2016-05-10 17:38:45.000000000","message":"This patch set is providing the ability to install from uca or the distro directly rather than upstream ceph.com.  The commit message describes why this is needed in some situations.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"}],"playbooks/roles/ceph_client/tasks/ceph_all.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - ceph-config"},{"line_number":23,"context_line":"    - ceph-auth"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Include common apt variables"},{"line_number":26,"context_line":"  include_vars: common_apt.yml"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - always"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Include variables for the correct and Ceph package source"},{"line_number":33,"context_line":"  include_vars: \"{{ ceph_pkg_source }}_{{ ansible_pkg_mgr }}.yml\""},{"line_number":34,"context_line":"  when:"},{"line_number":35,"context_line":"    - ceph_pkg_source !\u003d \u0027distro\u0027"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - always"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include:  ceph_preinstall.yml"},{"line_number":40,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_a36052d0","line":37,"range":{"start_line":25,"start_character":0,"end_line":37,"end_character":12},"updated":"2016-05-10 15:00:32.000000000","message":"This is not really keeping with the pattern of supporting multiple distros as we have been previously.\n\nThese files should be combined into one.  Use a dictionary or other method to supply different variables for each case.\n\nExample:  https://review.openstack.org/gitweb?p\u003dopenstack/openstack-ansible-os_neutron.git;a\u003dblob;f\u003ddefaults/main.yml;hb\u003dHEAD#l115","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - ceph-config"},{"line_number":23,"context_line":"    - ceph-auth"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Include common apt variables"},{"line_number":26,"context_line":"  include_vars: common_apt.yml"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":29,"context_line":"  tags:"},{"line_number":30,"context_line":"    - always"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Include variables for the correct and Ceph package source"},{"line_number":33,"context_line":"  include_vars: \"{{ ceph_pkg_source }}_{{ ansible_pkg_mgr }}.yml\""},{"line_number":34,"context_line":"  when:"},{"line_number":35,"context_line":"    - ceph_pkg_source !\u003d \u0027distro\u0027"},{"line_number":36,"context_line":"  tags:"},{"line_number":37,"context_line":"    - always"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- include:  ceph_preinstall.yml"},{"line_number":40,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_1a6c18cf","line":37,"range":{"start_line":25,"start_character":0,"end_line":37,"end_character":12},"in_reply_to":"dab17558_a36052d0","updated":"2016-05-10 17:38:45.000000000","message":"I have followed the galera_client example:  https://github.com/openstack/openstack-ansible-galera_client/commit/0361308dbbf38720f9e723de92d70d8fd0e16958\n\nI agree about the common_apt.yml name and the check for !\u003d distro above.  I have change this in the latest patch set.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"ecbd40e5cff91fb2eb0ef80242fcf86a54830a5f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - ceph-config"},{"line_number":23,"context_line":"    - ceph-auth"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Include variables for the correct and Ceph package source"},{"line_number":26,"context_line":"  include_vars: \"{{ ceph_pkg_source }}_{{ ansible_pkg_mgr }}.yml\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - always"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- include:  ceph_preinstall.yml"},{"line_number":31,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dab17558_10e519db","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":12},"updated":"2016-05-10 18:20:29.000000000","message":"Don\u0027t do this.\n\nDo this instead:\nhttps://github.com/openstack/openstack-ansible-rsyslog_server/blob/master/tasks/main.yml#L16-L21","commit_id":"415978ae2c9d59e13eeab25d8556b827fc850aba"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"b22c4639039ac5fa71e68c8d31c472d07309da95","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - ceph-config"},{"line_number":23,"context_line":"    - ceph-auth"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Include variables for the correct and Ceph package source"},{"line_number":26,"context_line":"  include_vars: \"{{ ceph_pkg_source }}_{{ ansible_pkg_mgr }}.yml\""},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - always"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- include:  ceph_preinstall.yml"},{"line_number":31,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dab17558_f7bc8fdd","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":12},"in_reply_to":"dab17558_10e519db","updated":"2016-05-11 18:31:27.000000000","message":"Done","commit_id":"415978ae2c9d59e13eeab25d8556b827fc850aba"}],"playbooks/roles/ceph_client/tasks/ceph_preinstall_apt.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22b62dcf659e06d2d92991efc5f943ace618ebfc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Include any Ceph package source specific plays."},{"line_number":17,"context_line":"# This is usually where source specific apt key management is done."},{"line_number":18,"context_line":"- include: \"ceph_preinstall_{{ ceph_pkg_source }}_apt.yml\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - ceph-preinstall"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Add ceph repo(s)"},{"line_number":23,"context_line":"  apt_repository:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dab17558_964af7c3","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":21},"updated":"2016-05-09 11:12:07.000000000","message":"The lint job is failing due to this. I don\u0027t think that Ansible 1.9.x allows this. You may have to break this down into a task per ceph_pkg_source. :/","commit_id":"6aedbe43318599fd2d32cc532fe3a852c49cbced"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"ceb4e7267f34ca41ebc1817e700a3e240399ea3b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Include any Ceph package source specific plays."},{"line_number":17,"context_line":"# This is usually where source specific apt key management is done."},{"line_number":18,"context_line":"- include: \"ceph_preinstall_{{ ceph_pkg_source }}_apt.yml\""},{"line_number":19,"context_line":"  tags:"},{"line_number":20,"context_line":"    - ceph-preinstall"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Add ceph repo(s)"},{"line_number":23,"context_line":"  apt_repository:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dab17558_7645bc15","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":21},"in_reply_to":"dab17558_964af7c3","updated":"2016-05-09 20:07:32.000000000","message":"I will make this change in my next patch set version.  I\u0027m currently testing the patch set out with various source options between x86 and ppc64.","commit_id":"6aedbe43318599fd2d32cc532fe3a852c49cbced"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: Update apt cache"},{"line_number":46,"context_line":"  apt:"},{"line_number":47,"context_line":"    update_cache: yes"},{"line_number":48,"context_line":"  when: revoke_keys|changed or add_keys|changed or add_keys_fallback|changed or add_repos|changed"},{"line_number":49,"context_line":"  tags:"},{"line_number":50,"context_line":"    - ceph-apt-keys"},{"line_number":51,"context_line":"    - ceph-repos"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_1d7f0016","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":97},"updated":"2016-05-10 15:00:32.000000000","message":"Wrap in parenthesis and make it multi line for readability?","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: Update apt cache"},{"line_number":46,"context_line":"  apt:"},{"line_number":47,"context_line":"    update_cache: yes"},{"line_number":48,"context_line":"  when: revoke_keys|changed or add_keys|changed or add_keys_fallback|changed or add_repos|changed"},{"line_number":49,"context_line":"  tags:"},{"line_number":50,"context_line":"    - ceph-apt-keys"},{"line_number":51,"context_line":"    - ceph-repos"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_9a6008d1","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":97},"in_reply_to":"dab17558_1d7f0016","updated":"2016-05-10 17:38:45.000000000","message":"Done","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"}],"playbooks/roles/ceph_client/tasks/ceph_preinstall_ceph_apt.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  retries: 5"},{"line_number":51,"context_line":"  delay: 2"},{"line_number":52,"context_line":"  with_items: ceph_gpg_keys"},{"line_number":53,"context_line":"  when: add_keys|failed and (item.fallback_keyserver is defined or item.fallback_url is defined)"},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - ceph-apt-keys"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_c3ef561c","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":17},"updated":"2016-05-10 15:00:32.000000000","message":"Let\u0027s wrap this line.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  retries: 5"},{"line_number":51,"context_line":"  delay: 2"},{"line_number":52,"context_line":"  with_items: ceph_gpg_keys"},{"line_number":53,"context_line":"  when: add_keys|failed and (item.fallback_keyserver is defined or item.fallback_url is defined)"},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - ceph-apt-keys"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_baa18cfa","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":17},"in_reply_to":"dab17558_c3ef561c","updated":"2016-05-10 17:38:45.000000000","message":"Done","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"}],"playbooks/roles/ceph_client/tasks/ceph_preinstall_uca_apt.yml":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"1660d2681eb8ca0230d3465cc82b1b42944e969c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  register: add_keys"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - ceph-apt-keys"},{"line_number":22,"context_line":"  "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_4c402e57","line":22,"updated":"2016-05-06 17:21:33.000000000","message":"fixed","commit_id":"ae5e1acbc13522f9c4115cb96ac5011c03e5a834"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: add ubuntu cloud archive key package"},{"line_number":17,"context_line":"  apt:"},{"line_number":18,"context_line":"    pkg: ubuntu-cloud-keyring"},{"line_number":19,"context_line":"  register: add_keys"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - ceph-apt-keys"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_c3d6364e","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":19},"updated":"2016-05-10 15:00:32.000000000","message":"Does this really need to be in it\u0027s own file?","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: add ubuntu cloud archive key package"},{"line_number":17,"context_line":"  apt:"},{"line_number":18,"context_line":"    pkg: ubuntu-cloud-keyring"},{"line_number":19,"context_line":"  register: add_keys"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - ceph-apt-keys"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_3a959c86","line":21,"range":{"start_line":16,"start_character":0,"end_line":21,"end_character":19},"in_reply_to":"dab17558_c3d6364e","updated":"2016-05-10 17:38:45.000000000","message":"It does since it is following the pattern of having distro specific things in separate files.  The pre-install for ceph.com, in the ceph_preinstall_ceph_apt.yml does the key management for ceph.com.  This does the key management for UCA.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"}],"playbooks/roles/ceph_client/vars/common_apt.yml":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"0f9cd819e2acac0d65551a62c4a2421573c59c93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016 IBM Corp"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_43d086f6","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":18},"updated":"2016-05-10 15:00:32.000000000","message":"This file is not named using the existing pattern of multiple distro support.\n\nSee https://github.com/openstack/openstack-ansible-rsyslog_server/tree/master/vars\n\nand\nhttps://github.com/openstack/openstack-ansible-rsyslog_server/blob/master/tasks/main.yml#L16-L23\n\nFor an example of how to implement multi-distro var files.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9c5d64df24704c0d4be0a8b57fe5c31d94ce6c3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016 IBM Corp"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"# You may obtain a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"## APT Cache Options"},{"line_number":17,"context_line":"cache_timeout: 600"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dab17558_3af8fcc2","line":17,"range":{"start_line":1,"start_character":0,"end_line":17,"end_character":18},"in_reply_to":"dab17558_43d086f6","updated":"2016-05-10 17:38:45.000000000","message":"I agree on the rename to fit the ceph and uca file model and have renamed it such.\n\nThis whole patch set is not so much about adding trusty vs xenial vs centos support as it is adding support for ceph vs uca vs distro and a comment on the first patch set was to break that out like multi-distro support.  The breakout of the support allows the addition of yum/centos support to be added in easier in a future change since it is breaking out the apt variables and tasks into separate files.","commit_id":"049ce4433b80326a848e1338ccd4c649c01b55ab"}],"playbooks/roles/ceph_client/vars/ubuntu-14.04.yml":[{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"9120e1135b099992a775d00c679ad9051021bb42","unresolved":false,"context_lines":[{"line_number":34,"context_line":"ceph_stable_release: hammer"},{"line_number":35,"context_line":"ceph_apt_repo_url: \"http://{{ ceph_apt_repo_url_region }}.ceph.com/debian-{{ ceph_stable_release }}/\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Ubuntu Cloud Archive variables  "},{"line_number":38,"context_line":"uca_openstack_release: mitaka"},{"line_number":39,"context_line":"uca_apt_repo_url: \"http://ubuntu-cloud.archive.canonical.com/ubuntu\""},{"line_number":40,"context_line":"uca_repo_dist: \"{{ ansible_lsb.codename }}-updates/{{ uca_openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dab17558_f2ee5d20","line":37,"updated":"2016-05-11 18:51:20.000000000","message":"will fix in both files.","commit_id":"a60b40e118e13926fceae2735620e659666c7d89"}],"releasenotes/notes/ceph-from-uca-2fa04e03c39a61bc.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22b62dcf659e06d2d92991efc5f943ace618ebfc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support had been added to install the ceph_client packages and"},{"line_number":4,"context_line":"    dependencies from Ubuntu Cloud Archive (UCA). To use UCA for ceph_client"},{"line_number":5,"context_line":"    packages you must set the ``ceph_add_uca_repo`` variable to true and"},{"line_number":6,"context_line":"    set the ``ceph_apt_repo_url`` and ``ceph_repo_dist`` variables to"},{"line_number":7,"context_line":"    target the UCA repo and distribution required."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dab17558_96c5d73d","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":50},"updated":"2016-05-09 11:12:07.000000000","message":"This is now outdated.","commit_id":"6aedbe43318599fd2d32cc532fe3a852c49cbced"},{"author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"change_message_id":"ceb4e7267f34ca41ebc1817e700a3e240399ea3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support had been added to install the ceph_client packages and"},{"line_number":4,"context_line":"    dependencies from Ubuntu Cloud Archive (UCA). To use UCA for ceph_client"},{"line_number":5,"context_line":"    packages you must set the ``ceph_add_uca_repo`` variable to true and"},{"line_number":6,"context_line":"    set the ``ceph_apt_repo_url`` and ``ceph_repo_dist`` variables to"},{"line_number":7,"context_line":"    target the UCA repo and distribution required."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dab17558_d64c6844","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":50},"in_reply_to":"dab17558_96c5d73d","updated":"2016-05-09 20:07:32.000000000","message":"Done","commit_id":"6aedbe43318599fd2d32cc532fe3a852c49cbced"}]}