)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"ab1640b71ddba46d9d185ec2b4c9e5c240a326c1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix dynamic_inventory.py test bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"dynamic_inventory.py implements a test to check for"},{"line_number":10,"context_line":"duplicate IP addresses in user supplied inventory."},{"line_number":11,"context_line":"A test has been written which asserts the output of"},{"line_number":12,"context_line":"the error raised by MultipleHostsWithOneIPError to"},{"line_number":13,"context_line":"equal a string in which two hostnames appear.  Since"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_29543052","line":10,"updated":"2016-05-05 15:38:13.000000000","message":"the exception in question is about multiple host names with one IP, not duplicate IPs.","commit_id":"9205180a90f99db971eb80bcc6c54e82e0a9bc3f"}],"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"7252a7717d0df8666adfb9269825d0b801931937","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Order the hostnames for predictable testing."},{"line_number":59,"context_line":"        host_list \u003d [assigned_host, new_host]"},{"line_number":60,"context_line":"        host_list.sort()"},{"line_number":61,"context_line":"        error_msg \u003d (\"ip address:{} has already been \""},{"line_number":62,"context_line":"                     \"assigned to host:{}, cannot \""},{"line_number":63,"context_line":"                     \"assign same ip to host:{}\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_84e3ab33","line":60,"updated":"2016-05-05 15:47:39.000000000","message":"Since this is to correct ordering logic in a test, I think the change should be made in the test itself - changing it here means it affects everything.\n\nAlso, the sort is unreliable - it will use alphanumeric sorting, which may not be what was passed in to the exception, thus making the error message inaccurate.","commit_id":"6eb1ae784fac1e28e61f63cebcef3fbb103c69fe"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"1e49d30ae8637c2eea2411044700ac62d2a8b811","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        host_list.sort()"},{"line_number":61,"context_line":"        error_msg \u003d (\"ip address:{} has already been \""},{"line_number":62,"context_line":"                     \"assigned to host:{}, cannot \""},{"line_number":63,"context_line":"                     \"assign same ip to host:{}\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.message \u003d error_msg.format(ip, host_list[0], host_list[1])"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7a5ee413","line":63,"updated":"2016-05-05 16:19:57.000000000","message":"If we keep the sort, we could alter the error message to simply say multiple host names were trying to use the IP, rather that implying order with \"already\".\n\nSomething like: \"Both \u003chostname\u003e and \u003chostname\u003e have \u003cIP\u003e assigned.\" In that case, the test string would have to be updated, too.","commit_id":"6eb1ae784fac1e28e61f63cebcef3fbb103c69fe"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9d686e54da7cd43c08d58f9c5ab09a021961d04e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        # Order the hostnames for predictable testing."},{"line_number":59,"context_line":"        host_list \u003d [assigned_host, new_host]"},{"line_number":60,"context_line":"        host_list.sort()"},{"line_number":61,"context_line":"        error_msg \u003d (\"Both host:{} and host:{} have \""},{"line_number":62,"context_line":"                     \"address:{} assigned.  Cannot \""},{"line_number":63,"context_line":"                     \"assign same ip to both hosts\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4ef3cbd6","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":34},"updated":"2016-05-09 14:45:07.000000000","message":"Maybe add a space for readability between the column and the name?","commit_id":"32fd0e7facfe661d221a2ebe23de4482a8d2ee6f"}]}