)]}'
{"playbooks/roles/rsyslog_client/templates/99-rsyslog.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dae4f0a1ebb16d7ee799313f6941b2a9cdcffacc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if groups[\u0027rsyslog_all\u0027] is defined and groups[\u0027rsyslog_all\u0027] %}"},{"line_number":11,"context_line":"# Log shipment rsyslog target servers"},{"line_number":12,"context_line":"{% for server in groups[\u0027rsyslog_all\u0027] %}"},{"line_number":13,"context_line":"{% if hostvars[server][\u0027physical_host_group\u0027] \u003d\u003d \u0027log_hosts\u0027 %}"},{"line_number":14,"context_line":"$ActionQueueFileName {{ server }}"},{"line_number":15,"context_line":"$ActionQueueSaveOnShutdown on"},{"line_number":16,"context_line":"$ActionQueueType LinkedList"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"faac7902_551a9e6f","line":13,"updated":"2016-05-05 19:43:27.000000000","message":"This is bad form as it ties the role to the inventory structure. While in kilo its kind of unavoidable I\u0027d like to not push that pattern forward especially since kilo is soon to be EOL. I think it would be better to simply add a skip-tag to the playbook execution. See [ https://review.openstack.org/#/c/313117/2/scripts/upgrade-utilities/scripts/juno-container-cleanup.sh ] for more on that.","commit_id":"ac2b0cab0ff80d2c2f43f1f95ac3018512914a29"},{"author":{"_account_id":14552,"name":"Bjoern Teipel","email":"bjoern.teipel@rackspace.com","username":"bjoern"},"change_message_id":"53dc6d9bd10397c0bbfb20a4edc6a5227efaaeb9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if groups[\u0027rsyslog_all\u0027] is defined and groups[\u0027rsyslog_all\u0027] %}"},{"line_number":11,"context_line":"# Log shipment rsyslog target servers"},{"line_number":12,"context_line":"{% for server in groups[\u0027rsyslog_all\u0027] %}"},{"line_number":13,"context_line":"{% if hostvars[server][\u0027physical_host_group\u0027] \u003d\u003d \u0027log_hosts\u0027 %}"},{"line_number":14,"context_line":"$ActionQueueFileName {{ server }}"},{"line_number":15,"context_line":"$ActionQueueSaveOnShutdown on"},{"line_number":16,"context_line":"$ActionQueueType LinkedList"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"faac7902_f80e29e4","line":13,"in_reply_to":"faac7902_551a9e6f","updated":"2016-05-05 20:14:44.000000000","message":"Done","commit_id":"ac2b0cab0ff80d2c2f43f1f95ac3018512914a29"}],"scripts/run-upgrade.sh":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"1e16ac04fefc439c11190012df00ea51beccfcb9","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  RUN_TASKS+\u003d(\"openstack-hosts-setup.yml\")"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"  RUN_TASKS+\u003d(\"lxc-hosts-setup.yml --tags rsyslog-config\")"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"  RUN_TASKS+\u003d(\"${UPGRADE_PLAYBOOKS}/lxc-containers-create-upgrade-step-1.yml --limit \u0027!galera_all:!nova_scheduler:!nova_conductor:!rabbitmq_all:!cinder_scheduler:!neutron_agent\u0027\")"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"dab17558_a0bff1f9","line":150,"updated":"2016-05-09 10:03:50.000000000","message":"The entire role rsyslog_client is being skipped in juno-container-cleanup.sh and so it makes sense that the whole role should be run here. I think the tag rsyslog-config should have been rsyslog-client.","commit_id":"9380912114363c61a37d8b79f284a1cb63c8e2c9"}],"scripts/upgrade-utilities/scripts/juno-container-cleanup.sh":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"dae4f0a1ebb16d7ee799313f6941b2a9cdcffacc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Remove containers that we no longer need"},{"line_number":35,"context_line":"pushd ${PLAYBOOK_PATH}/playbooks"},{"line_number":36,"context_line":"  # Before interacting with any containers make sure that the libs are updated"},{"line_number":37,"context_line":"  openstack-ansible lxc-hosts-setup.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # Clean up post destroy"},{"line_number":40,"context_line":"  openstack-ansible lxc-containers-destroy.yml -e container_group\u003d\"rsyslog_all\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"faac7902_5255941b","side":"PARENT","line":37,"updated":"2016-05-05 19:43:27.000000000","message":"This has to happen in the current order. Without this change the lxc container driver will not be installed and ansible will be unable to control the containers installed on various hosts. \n\nA simpler fix would be to simply add a skip-tag switch. Something like:\n\n    openstack-ansible lxc-hosts-setup.yml --skip-tags rsyslog-client\n\nThis would ensure the playbook gets run as we need/want but also that the logging bits aropenstack-ansible lxc-hosts-setup.yml --skip-tags rsyslog-cliente not put down which addresses the spirit of this change.","commit_id":"75890e2372a66a8a9be24bc147179b6f08f90e76"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"458d6edcb0ee161d15e330fc82ee37b155e00ed3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Remove containers that we no longer need"},{"line_number":35,"context_line":"pushd ${PLAYBOOK_PATH}/playbooks"},{"line_number":36,"context_line":"  # Before interacting with any containers make sure that the libs are updated"},{"line_number":37,"context_line":"  openstack-ansible lxc-hosts-setup.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # Clean up post destroy"},{"line_number":40,"context_line":"  openstack-ansible lxc-containers-destroy.yml -e container_group\u003d\"rsyslog_all\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"faac7902_b5366ab2","side":"PARENT","line":37,"in_reply_to":"faac7902_5255941b","updated":"2016-05-05 19:47:24.000000000","message":"I think i had a paste failure. I meant to say: \"This would ensure the playbook gets run as we need/want but also that the logging bits are not updated which addresses the spirit of this change.\"","commit_id":"75890e2372a66a8a9be24bc147179b6f08f90e76"}]}
