)]}'
{"playbooks/rabbitmq-install.yml":[{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"c182de11b2bcb225974f5448aa6952b3ad491e4e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: rabbitmq container config"},{"line_number":17,"context_line":"  hosts: rabbitmq_all"},{"line_number":18,"context_line":"  max_fail_percentage: 0"},{"line_number":19,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_d0dcd51a","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"updated":"2016-05-06 02:21:15.000000000","message":"\"Create rabbitmq container\"?","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"8bf8fe658e856bfc142cbf1b70050b87eadd616b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: rabbitmq container config"},{"line_number":17,"context_line":"  hosts: rabbitmq_all"},{"line_number":18,"context_line":"  max_fail_percentage: 0"},{"line_number":19,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_05829452","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"in_reply_to":"dab17558_d0dcd51a","updated":"2016-05-06 08:02:13.000000000","message":"Done","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c6175b4d2a8a8fd799b3264847d5fd0315c10d96","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      tags:"},{"line_number":43,"context_line":"        - ssh-wait"},{"line_number":44,"context_line":"  roles:"},{"line_number":45,"context_line":"    - role: \"pip_lock_down\""},{"line_number":46,"context_line":"      when: \"(groups[\u0027repo_all\u0027] | length) \u003e\u003d 1\""},{"line_number":47,"context_line":"    - role: \"system_crontab_coordination\""},{"line_number":48,"context_line":"      tags:"},{"line_number":49,"context_line":"        - \"system-crontab-coordination\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_70e249a1","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":48},"updated":"2016-05-06 02:31:27.000000000","message":"I think this can be removed as all of the lockdown tasks are taken care of in the rabbitmq_server role.","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"8bf8fe658e856bfc142cbf1b70050b87eadd616b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      tags:"},{"line_number":43,"context_line":"        - ssh-wait"},{"line_number":44,"context_line":"  roles:"},{"line_number":45,"context_line":"    - role: \"pip_lock_down\""},{"line_number":46,"context_line":"      when: \"(groups[\u0027repo_all\u0027] | length) \u003e\u003d 1\""},{"line_number":47,"context_line":"    - role: \"system_crontab_coordination\""},{"line_number":48,"context_line":"      tags:"},{"line_number":49,"context_line":"        - \"system-crontab-coordination\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_85afa4e2","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":48},"in_reply_to":"dab17558_70e249a1","updated":"2016-05-06 08:02:13.000000000","message":"I\u0027m probably misunderstanding, but I don\u0027t see this anywhere in the rabbitmq_server role","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b51bd00803c8bdec49e66b53cf937859b0b154fa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      tags:"},{"line_number":43,"context_line":"        - ssh-wait"},{"line_number":44,"context_line":"  roles:"},{"line_number":45,"context_line":"    - role: \"pip_lock_down\""},{"line_number":46,"context_line":"      when: \"(groups[\u0027repo_all\u0027] | length) \u003e\u003d 1\""},{"line_number":47,"context_line":"    - role: \"system_crontab_coordination\""},{"line_number":48,"context_line":"      tags:"},{"line_number":49,"context_line":"        - \"system-crontab-coordination\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_99306803","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":48},"in_reply_to":"dab17558_85afa4e2","updated":"2016-05-09 11:54:43.000000000","message":"It has not yet merged for the rabbitmq_server role, so leave this as-is.","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b51bd00803c8bdec49e66b53cf937859b0b154fa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"- name: Install rabbitmq server"},{"line_number":54,"context_line":"  hosts: rabbitmq_all"},{"line_number":55,"context_line":"  serial: 1"},{"line_number":56,"context_line":"  max_fail_percentage: 20"},{"line_number":57,"context_line":"  user: root"},{"line_number":58,"context_line":"  roles:"},{"line_number":59,"context_line":"    - role: \"rabbitmq_server\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_7902e40c","line":56,"range":{"start_line":56,"start_character":2,"end_line":56,"end_character":25},"updated":"2016-05-09 11:54:43.000000000","message":"Should 20% of the cluster be allowed to fail? This sounds like a bad idea to me.","commit_id":"4b5b976ad38bf549aa258a043b6365ef27deacbb"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9164c407701da1277addd24cf5c65a2b94efde55","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- name: Install rabbitmq server"},{"line_number":56,"context_line":"  hosts: rabbitmq_all"},{"line_number":57,"context_line":"  serial: \"{{ rabbitmq_upgrade|default(false) | bool | ternary(0, 1)}}\""},{"line_number":58,"context_line":"  max_fail_percentage: 20"},{"line_number":59,"context_line":"  user: root"},{"line_number":60,"context_line":"  roles:"},{"line_number":61,"context_line":"    - role: \"rabbitmq_server\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_3464e3e3","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":25},"updated":"2016-05-09 11:57:00.000000000","message":"Is this necessary? It seems unnecessary, especially for a control plane element. In my mind this should only be applied to non control plane elements.","commit_id":"21c24789019bf1ee85347356fe6c70b0b9045d7c"},{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"31ad9f733eedd2ac0da050cbfde96fe314745a99","unresolved":false,"context_lines":[{"line_number":55,"context_line":"- name: Install rabbitmq server"},{"line_number":56,"context_line":"  hosts: rabbitmq_all"},{"line_number":57,"context_line":"  serial: \"{{ rabbitmq_upgrade|default(false) | bool | ternary(0, 1)}}\""},{"line_number":58,"context_line":"  max_fail_percentage: 20"},{"line_number":59,"context_line":"  user: root"},{"line_number":60,"context_line":"  roles:"},{"line_number":61,"context_line":"    - role: \"rabbitmq_server\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dab17558_54e887e2","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":25},"in_reply_to":"dab17558_3464e3e3","updated":"2016-05-09 12:04:34.000000000","message":"As discussed, this is a pattern from the galera role. This would only affect a cluster \u003e4 nodes anyway","commit_id":"21c24789019bf1ee85347356fe6c70b0b9045d7c"}]}
