)]}'
{"scripts/bootstrap-ansible.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"350d7ef2a6dafca45059e1edef5bd85a87d9268c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# Install pip"},{"line_number":67,"context_line":"get_pip"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PIP_OPTS\u003d\"--isolated \""},{"line_number":70,"context_line":"# Ensure we use the HTTPS/HTTP proxy with pip if it is specified"},{"line_number":71,"context_line":"if [ -n \"$HTTPS_PROXY\" ]; then"},{"line_number":72,"context_line":"  PIP_OPTS\u003d\"--proxy $HTTPS_PROXY\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dab17558_4ff90e80","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":22},"updated":"2016-05-09 12:40:31.000000000","message":"Can you add a one-liner comment here to explain why this is the starting value? Perhaps something like:\n\n# Ensure that pip ignores any existing pip conf lockdown settings","commit_id":"99f67c3ba8fba659e241d5fee9b60ea650789a1f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"739792ee3ef4b943a5fe38b5c3119beba8c03180","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# Install pip"},{"line_number":67,"context_line":"get_pip"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"PIP_OPTS\u003d\"--isolated \""},{"line_number":70,"context_line":"# Ensure we use the HTTPS/HTTP proxy with pip if it is specified"},{"line_number":71,"context_line":"if [ -n \"$HTTPS_PROXY\" ]; then"},{"line_number":72,"context_line":"  PIP_OPTS\u003d\"--proxy $HTTPS_PROXY\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dab17558_af7cfaeb","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":22},"in_reply_to":"dab17558_4ff90e80","updated":"2016-05-09 12:42:37.000000000","message":"There\u0027s a down-side to doing this from a gating standpoint - in the gate we use the global /etc/pip.conf file to ensure that the local pypi and wheel mirrors are used.\n\nI wonder if it wouldn\u0027t be better to test for the existance of ~/.pip/pip.conf (or whatever the use config file is) and then to add --isolated based on that.\n\nThis would allow the gating to work as we want it to, but also cater for the need outlined in the commit message.","commit_id":"99f67c3ba8fba659e241d5fee9b60ea650789a1f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c281c5e0f890e85ef9d7cca72e51265de33aaa1","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Install requirements if there are any"},{"line_number":84,"context_line":"if [ -f \"requirements.txt\" ];then"},{"line_number":85,"context_line":"  # When upgrading there will already be a pip.conf file locking pip down to the repo server, in such cases in may be"},{"line_number":86,"context_line":"  # necessary to use --isolated because the repo server does not meet the specified requirements."},{"line_number":87,"context_line":"  $PIP_COMMAND install $PIP_OPTS -r requirements.txt || $PIP_COMMAND install --isolated $PIP_OPTS -r requirements.txt"},{"line_number":88,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dab17558_4569efbd","line":85,"range":{"start_line":85,"start_character":108,"end_line":85,"end_character":110},"updated":"2016-05-09 13:21:17.000000000","message":"nit: \u0027it\u0027","commit_id":"0591c6579d7a961015bcb3811692ce3d882f6ad9"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c281c5e0f890e85ef9d7cca72e51265de33aaa1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"fi"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Install ansible"},{"line_number":91,"context_line":"# When upgrading there will already be a pip.conf file locking pip down to the repo server, in such cases in may be"},{"line_number":92,"context_line":"# necessary to use --isolated because the repo server does not meet the specified requirements."},{"line_number":93,"context_line":"$PIP_COMMAND install $PIP_OPTS \"${ANSIBLE_WORKING_DIR}\" || $PIP_COMMAND install --isolated $PIP_OPTS \"${ANSIBLE_WORKING_DIR}\""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"dab17558_2564abe3","line":91,"range":{"start_line":91,"start_character":106,"end_line":91,"end_character":108},"updated":"2016-05-09 13:21:17.000000000","message":"nit: \u0027it\u0027","commit_id":"0591c6579d7a961015bcb3811692ce3d882f6ad9"}]}