)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1e6e7d3629d83dea2fb4b07aea0d1261b51fd53f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"installation method to use git instead of pypi. The default"},{"line_number":13,"context_line":"installation source has been changed because Ansible 2.1 is not"},{"line_number":14,"context_line":"currently on PyPi because its still in RC testing."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I33ac20ebbc00fca4df00aaa3753ef75e575a23cf"},{"line_number":17,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bab6814e_c477a99d","line":15,"updated":"2016-05-19 11:21:39.000000000","message":"Please add \u0027Implements: blueprint ansible-2-1-support\u0027","commit_id":"75bca5339160379811469517b8d45984d9c9afcf"}],"playbooks/ansible.cfg":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[defaults]"},{"line_number":2,"context_line":"# Additional plugins"},{"line_number":3,"context_line":"lookup_plugins \u003d /etc/ansible/roles/plugins/lookup"},{"line_number":4,"context_line":"filter_plugins \u003d /etc/ansible/roles/plugins/filter"},{"line_number":5,"context_line":"action_plugins \u003d /etc/ansible/roles/plugins/action"},{"line_number":6,"context_line":"library \u003d /etc/ansible/roles/plugins/library"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Fact caching"},{"line_number":9,"context_line":"gathering \u003d smart"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_2a207ef6","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":44},"updated":"2016-05-23 09:37:03.000000000","message":"ok for deletion if the \"plugins\" role is included in the playbooks (meh...) or as a dependency of the roles using some parts of the \"plugins\" role (better IMO).\n\nThis could be done in a subsequent patch.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"}],"scripts/bootstrap-aio.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  openstack-ansible -i test-inventory.ini \\"},{"line_number":29,"context_line":"                    -e \"${BOOTSTRAP_OPTS}\" \\"},{"line_number":30,"context_line":"                    bootstrap-aio.yml"},{"line_number":31,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bab6814e_4a9b4218","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":41},"updated":"2016-05-23 09:37:03.000000000","message":"fine for me, but less readable IMO (and also too much files...).","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fa5711013d942e69cb1da0e4d2d43242cf599a60","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  openstack-ansible -i test-inventory.ini \\"},{"line_number":29,"context_line":"                    -e \"${BOOTSTRAP_OPTS}\" \\"},{"line_number":30,"context_line":"                    bootstrap-aio.yml"},{"line_number":31,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bab6814e_c676eda2","line":28,"range":{"start_line":28,"start_character":23,"end_line":28,"end_character":41},"in_reply_to":"bab6814e_4a9b4218","updated":"2016-05-23 17:38:05.000000000","message":"This was done because ansible no longer allows you to pass config in as an inventory string and because of it the  \"ansible-connection\u003dlocal\" option is broken causing a runtime error.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"}],"scripts/bootstrap-ansible.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# If the Ansible plugins are in the old location remove them and link them to the new location"},{"line_number":89,"context_line":"[[ -d \"/etc/ansible/plugins\" ]] \u0026\u0026 rm -rf \"/etc/ansible/plugins\""},{"line_number":90,"context_line":"ln -sf /etc/ansible/roles/plugins /etc/ansible/plugins"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"echo -e \"\\nNOTICE: System is bootstrapped and ready for use\\n\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"bab6814e_2a819e8f","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":54},"updated":"2016-05-23 09:37:03.000000000","message":"why do we need this backwards compatibility? Won\u0027t it bring more issues in the long run compared to a disruptive change?","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fa5711013d942e69cb1da0e4d2d43242cf599a60","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# If the Ansible plugins are in the old location remove them and link them to the new location"},{"line_number":89,"context_line":"[[ -d \"/etc/ansible/plugins\" ]] \u0026\u0026 rm -rf \"/etc/ansible/plugins\""},{"line_number":90,"context_line":"ln -sf /etc/ansible/roles/plugins /etc/ansible/plugins"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"echo -e \"\\nNOTICE: System is bootstrapped and ready for use\\n\""}],"source_content_type":"text/x-sh","patch_set":10,"id":"bab6814e_a6a009f5","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":54},"in_reply_to":"bab6814e_2a819e8f","updated":"2016-05-23 17:38:05.000000000","message":"This may not be needed.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"}],"scripts/openstack-ansible.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bab6814e_657757a0","updated":"2016-05-23 09:37:03.000000000","message":"Not sure about the right approach here.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":294,"context_line":"Bootstrap options:"},{"line_number":295,"context_line":"    -bf|--bootstrap-force        | Force the bootstrap operation to run"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    -bug|--bootstrap-use-pypi    | Use pypi to boostrap your Ansible runtime"},{"line_number":298,"context_line":"                                   The set option is ${ANSIBLE_INSTALL_USE_GIT}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    -bpv|--bootstrap-pypi-version| Set the version of Ansible to use as"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bab6814e_ea28369c","line":297,"range":{"start_line":297,"start_character":7,"end_line":297,"end_character":8},"updated":"2016-05-23 09:37:03.000000000","message":"typo -bup","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"}],"tests/ansible.cfg":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"roles_path \u003d /etc/ansible/roles:roles"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Additional plugins"},{"line_number":6,"context_line":"action_plugins \u003d /etc/ansible/roles/plugins/action"},{"line_number":7,"context_line":"callback_plugins \u003d /etc/ansible/roles/plugins/callback"},{"line_number":8,"context_line":"filter_plugins \u003d /etc/ansible/roles/plugins/filter"},{"line_number":9,"context_line":"lookup_plugins \u003d /etc/ansible/roles/plugins/lookup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_25b9cf2e","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":50},"updated":"2016-05-23 09:37:03.000000000","message":"not sure if this is needed (cf other comments on timeframe)","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fa5711013d942e69cb1da0e4d2d43242cf599a60","unresolved":false,"context_lines":[{"line_number":3,"context_line":"roles_path \u003d /etc/ansible/roles:roles"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Additional plugins"},{"line_number":6,"context_line":"action_plugins \u003d /etc/ansible/roles/plugins/action"},{"line_number":7,"context_line":"callback_plugins \u003d /etc/ansible/roles/plugins/callback"},{"line_number":8,"context_line":"filter_plugins \u003d /etc/ansible/roles/plugins/filter"},{"line_number":9,"context_line":"lookup_plugins \u003d /etc/ansible/roles/plugins/lookup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_26e53908","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":50},"in_reply_to":"bab6814e_25b9cf2e","updated":"2016-05-23 17:38:05.000000000","message":"Agreed, if we change the way plugins are loaded into roles we can remove these lines. It\u0027s likely that we\u0027ll need to convert to 2.1, update the roles, and then remove these lines.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Additional plugins"},{"line_number":6,"context_line":"action_plugins \u003d /etc/ansible/roles/plugins/action"},{"line_number":7,"context_line":"callback_plugins \u003d /etc/ansible/roles/plugins/callback"},{"line_number":8,"context_line":"filter_plugins \u003d /etc/ansible/roles/plugins/filter"},{"line_number":9,"context_line":"lookup_plugins \u003d /etc/ansible/roles/plugins/lookup"},{"line_number":10,"context_line":"library \u003d /etc/ansible/roles/plugins/library"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Set color options"},{"line_number":13,"context_line":"nocolor \u003d 0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_a57bff79","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":44},"updated":"2016-05-23 09:37:03.000000000","message":"Same comment here","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"ddb9a812debff69858f8bba6aff63ce489d485a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Set color options"},{"line_number":13,"context_line":"nocolor \u003d 0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"host_key_checking \u003d False"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_453df38d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"updated":"2016-05-23 09:37:03.000000000","message":"shouldn\u0027t we set this as an env variable? But yeah it could be done in a latter commit.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fa5711013d942e69cb1da0e4d2d43242cf599a60","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Set color options"},{"line_number":13,"context_line":"nocolor \u003d 0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"host_key_checking \u003d False"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bab6814e_26941989","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"bab6814e_453df38d","updated":"2016-05-23 17:38:05.000000000","message":"No I don\u0027t think this should be an environment variable. Using an environment variable has longer reaching effects than setting this option locally as something the OSA project uses.","commit_id":"635d6083134ef52536d5f8af288a73e9247219c9"}]}