)]}'
{"etc/openstack_deploy/user_variables.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1852be48c7e0ae12812c9f177115a99b27975a08","unresolved":false,"context_lines":[{"line_number":113,"context_line":"# or management user as \"guest\" has been removed for security reasons. In"},{"line_number":114,"context_line":"# order to create a new rabbitMQ user that will be assigned the rabbitmq monitoring"},{"line_number":115,"context_line":"# user tag, uncomment and set the user id  as such"},{"line_number":116,"context_line":"# rabbitmq_monitoring_userid: monitoring"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"## Additional pinning generator that will allow for more packages to be pinned as you see fit."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_6453f96b","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":40},"updated":"2016-05-21 05:47:42.000000000","message":"I think if an endpoint is being setup in HAProxy to access the monitoring UI then its ok to simply enable this users creation by default. IMO If the console is active and accessible but has no usability then its just an open security risk that nobody is paying attention to.","commit_id":"b0260dfed8c07d746ac436f07e5263966fe17bf0"}],"playbooks/rabbitmq-install.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"57cbc8ed0125a72c09785b4c30e4977a5a2554e5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":68,"context_line":"      run_once: true"},{"line_number":69,"context_line":"      tags:"},{"line_number":70,"context_line":"        - rabbitmq_monitoring_user"},{"line_number":71,"context_line":"  roles:"},{"line_number":72,"context_line":"    - role: \"rabbitmq_server\""},{"line_number":73,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dab17558_4cd865ef","line":70,"updated":"2016-05-17 19:27:44.000000000","message":"This should have a when clause. Not all deployers will want to enable the web interface of RabbitMQ","commit_id":"ad341f3a4a420a2310ce10c5b51dcc7322f5dbe3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        state: \"present\""},{"line_number":66,"context_line":"        tags: \"monitoring\""},{"line_number":67,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":68,"context_line":"      when: rabbitmq_monitoring_user is defined"},{"line_number":69,"context_line":"      run_once: true"},{"line_number":70,"context_line":"      tags:"},{"line_number":71,"context_line":"        - rabbitmq_monitoring_user"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_7c005eab","line":68,"range":{"start_line":68,"start_character":32,"end_line":68,"end_character":36},"updated":"2016-05-18 09:17:51.000000000","message":"I think you mean \u0027userid\u0027 here. You should perhaps also validate that \u0027rabbitmq_monitoring_password\u0027 is defined too.\n\nSuggestion:\n\n  when:\n    - rabbitmq_monitoring_user is defined\n    - rabbitmq_monitoring_password is defined","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1334ffff6ebb220b147f74c19a7b414469dd8c22","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        password: \"{{ rabbitmq_monitoring_password }}\""},{"line_number":65,"context_line":"        state: \"present\""},{"line_number":66,"context_line":"        tags: \"monitoring\""},{"line_number":67,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":68,"context_line":"      when:"},{"line_number":69,"context_line":"        - rabbitmq_monitoring_password is defined"},{"line_number":70,"context_line":"      run_once: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bab6814e_940f0836","line":67,"range":{"start_line":67,"start_character":6,"end_line":67,"end_character":52},"updated":"2016-05-23 10:45:21.000000000","message":"This task will be executed multiple times (serial delegate_to). Is it possible to set the monitoring as a separate thing in this playbook?","commit_id":"806b9f3bc2906b4cf8cf800945271de90c9cce5d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1334ffff6ebb220b147f74c19a7b414469dd8c22","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        tags: \"monitoring\""},{"line_number":67,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":68,"context_line":"      when:"},{"line_number":69,"context_line":"        - rabbitmq_monitoring_password is defined"},{"line_number":70,"context_line":"      run_once: true"},{"line_number":71,"context_line":"      tags:"},{"line_number":72,"context_line":"        - rabbitmq_monitoring_user"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bab6814e_3759fe35","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":49},"updated":"2016-05-23 10:45:21.000000000","message":"we should use default() instead.","commit_id":"806b9f3bc2906b4cf8cf800945271de90c9cce5d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1c7e1af2f180ddb6b5c7142231b5319415905c62","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        tags: \"monitoring\""},{"line_number":67,"context_line":"      delegate_to: \"{{ groups[\u0027rabbitmq_all\u0027][0] }}\""},{"line_number":68,"context_line":"      when:"},{"line_number":69,"context_line":"        - rabbitmq_monitoring_password is defined"},{"line_number":70,"context_line":"      run_once: true"},{"line_number":71,"context_line":"      tags:"},{"line_number":72,"context_line":"        - rabbitmq_monitoring_user"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bab6814e_77526668","line":69,"range":{"start_line":69,"start_character":10,"end_line":69,"end_character":49},"in_reply_to":"bab6814e_3759fe35","updated":"2016-05-23 10:53:27.000000000","message":"I disagree - passwords should never be defaulted.","commit_id":"806b9f3bc2906b4cf8cf800945271de90c9cce5d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"089e4c20acb37c7995e9c5502d82e4a4298b1a7f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        - \"rsyslog-client\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: Ensure rabbitmq user for monitoring GUI"},{"line_number":74,"context_line":"  hosts: rabbitmq_all"},{"line_number":75,"context_line":"  user: root"},{"line_number":76,"context_line":"  tasks:"},{"line_number":77,"context_line":"    - name: Create rabbitmq user for monitoring GUI"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_ef98cb6c","line":74,"updated":"2016-05-25 08:33:13.000000000","message":"I\u0027d replace it by: rabbitmq_all[0]","commit_id":"780f967980ebd61459067836799f121989716a49"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"089e4c20acb37c7995e9c5502d82e4a4298b1a7f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"         password: \"{{ rabbitmq_monitoring_password }}\""},{"line_number":81,"context_line":"         state: \"present\""},{"line_number":82,"context_line":"         tags: \"monitoring\""},{"line_number":83,"context_line":"      when:"},{"line_number":84,"context_line":"        - rabbitmq_monitoring_password is defined"},{"line_number":85,"context_line":"      run_once: true"},{"line_number":86,"context_line":"      tags:"},{"line_number":87,"context_line":"        - \"rabbitmq_monitoring_user\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_4f1bd7ca","line":84,"range":{"start_line":83,"start_character":11,"end_line":84,"end_character":10},"updated":"2016-05-25 08:33:13.000000000","message":"remove the unnecessary line?","commit_id":"780f967980ebd61459067836799f121989716a49"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"089e4c20acb37c7995e9c5502d82e4a4298b1a7f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"         tags: \"monitoring\""},{"line_number":83,"context_line":"      when:"},{"line_number":84,"context_line":"        - rabbitmq_monitoring_password is defined"},{"line_number":85,"context_line":"      run_once: true"},{"line_number":86,"context_line":"      tags:"},{"line_number":87,"context_line":"        - \"rabbitmq_monitoring_user\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_4fa8f777","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":20},"updated":"2016-05-25 08:33:13.000000000","message":"you can remove this if applied to only the first node","commit_id":"780f967980ebd61459067836799f121989716a49"}],"playbooks/vars/configs/haproxy_config.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1852be48c7e0ae12812c9f177115a99b27975a08","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      haproxy_balance_type: http"},{"line_number":202,"context_line":"      haproxy_backend_options:"},{"line_number":203,"context_line":"        - \"httpchk HEAD /\""},{"line_number":204,"context_line":"  - service:"},{"line_number":205,"context_line":"      haproxy_service_name: rabbitmq_mgmt"},{"line_number":206,"context_line":"      haproxy_backend_nodes: \"{{ groups[\u0027rabbitmq\u0027] | default([]) }}\""},{"line_number":207,"context_line":"      haproxy_ssl: \"{{ haproxy_ssl }}\""},{"line_number":208,"context_line":"      haproxy_port: 15672"},{"line_number":209,"context_line":"      haproxy_balance_type: http"},{"line_number":210,"context_line":"      haproxy_backend_options:"},{"line_number":211,"context_line":"        - \"httpchk HEAD /\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_047b0df6","line":211,"range":{"start_line":204,"start_character":0,"end_line":211,"end_character":26},"updated":"2016-05-21 05:47:42.000000000","message":"I think it may be a good idea to include a default ACL group here to limit public access to the RabbitMQ management UI. \n\nChanging this up to something like so:\n\n  - service:\n      haproxy_service_name: rabbitmq_mgmt\n      haproxy_backend_nodes: \"{{ groups[\u0027rabbitmq\u0027] | default([]) }}\"\n      haproxy_ssl: \"{{ haproxy_ssl }}\"\n      haproxy_port: 15672\n      haproxy_balance_type: http\n      haproxy_backend_options:\n        - \"httpchk HEAD /\"\n      haproxy_whitelist_networks:\n        - 192.168.0.0/16\n        - 172.16.0.0/12\n        - 10.0.0.0/8","commit_id":"b0260dfed8c07d746ac436f07e5263966fe17bf0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3f4151ca388cc4f4792f06e0902a1686ed0ae986","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      haproxy_balance_type: http"},{"line_number":202,"context_line":"      haproxy_backend_options:"},{"line_number":203,"context_line":"        - \"httpchk HEAD /\""},{"line_number":204,"context_line":"  - service:"},{"line_number":205,"context_line":"      haproxy_service_name: rabbitmq_mgmt"},{"line_number":206,"context_line":"      haproxy_backend_nodes: \"{{ groups[\u0027rabbitmq\u0027] | default([]) }}\""},{"line_number":207,"context_line":"      haproxy_ssl: \"{{ haproxy_ssl }}\""},{"line_number":208,"context_line":"      haproxy_port: 15672"},{"line_number":209,"context_line":"      haproxy_balance_type: http"},{"line_number":210,"context_line":"      haproxy_backend_options:"},{"line_number":211,"context_line":"        - \"httpchk HEAD /\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_80e989b9","line":211,"range":{"start_line":204,"start_character":0,"end_line":211,"end_character":26},"in_reply_to":"bab6814e_047b0df6","updated":"2016-05-23 09:55:55.000000000","message":"I strongly agree with this suggestion.","commit_id":"b0260dfed8c07d746ac436f07e5263966fe17bf0"}],"releasenotes/notes/rabbitmw-management-ui-haproxy-e9f9ec0343484f2d.yaml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"57cbc8ed0125a72c09785b4c30e4977a5a2554e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The RabbitMQ Management UI is now exposed "},{"line_number":4,"context_line":"    through HAProxy on port 15672. The user"},{"line_number":5,"context_line":"    is \"monitoring\", assigned the \"monitoring\" role,"},{"line_number":6,"context_line":"    and password is set in user_secrets.yml with the "}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dab17558_6c41e9a8","line":3,"updated":"2016-05-17 19:27:44.000000000","message":"Please remove the trailing whitespace in the note.","commit_id":"ad341f3a4a420a2310ce10c5b51dcc7322f5dbe3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The RabbitMQ Management UI is now exposed"},{"line_number":4,"context_line":"    through HAProxy on port 15672 . However a"},{"line_number":5,"context_line":"    user will not be created for monitoring"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_3c237607","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":9},"updated":"2016-05-18 09:17:51.000000000","message":"Please add an \u0027upgrade\u0027 note giving the heads up for the new variable in user_secrets.yml.","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The RabbitMQ Management UI is now exposed"},{"line_number":4,"context_line":"    through HAProxy on port 15672 . However a"},{"line_number":5,"context_line":"    user will not be created for monitoring"},{"line_number":6,"context_line":"    or management access unless the parameter"},{"line_number":7,"context_line":"    \"rabbitmq_monitoring_userid\" is defined"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_dc8eaa26","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":35},"updated":"2016-05-18 09:17:51.000000000","message":"Remove the space before the full stop.","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    through HAProxy on port 15672 . However a"},{"line_number":5,"context_line":"    user will not be created for monitoring"},{"line_number":6,"context_line":"    or management access unless the parameter"},{"line_number":7,"context_line":"    \"rabbitmq_monitoring_userid\" is defined"},{"line_number":8,"context_line":"    in user_variables.yml ."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_1cfe726b","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":32},"updated":"2016-05-18 09:17:51.000000000","message":"sed \u0027s/\"/``/\u0027","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    user will not be created for monitoring"},{"line_number":6,"context_line":"    or management access unless the parameter"},{"line_number":7,"context_line":"    \"rabbitmq_monitoring_userid\" is defined"},{"line_number":8,"context_line":"    in user_variables.yml ."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_9c770202","line":8,"range":{"start_line":8,"start_character":25,"end_line":8,"end_character":26},"updated":"2016-05-18 09:17:51.000000000","message":"and ``rabbitmq_monitoring_password`` is defined in ``user_secrets.yml``","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0b7b97f3def85c5c5cf558d70fa8d8394861ea8d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    user will not be created for monitoring"},{"line_number":6,"context_line":"    or management access unless the parameter"},{"line_number":7,"context_line":"    \"rabbitmq_monitoring_userid\" is defined"},{"line_number":8,"context_line":"    in user_variables.yml ."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_5cd11afb","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":25},"updated":"2016-05-18 09:17:51.000000000","message":"encase this in ``","commit_id":"f2575fb9f38a8d2a7c9b160500f5f32d699a5828"}]}