)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"d1bb4ea8753e64c71751e58952c51bf0230c18d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qing Wu Wang \u003cwangqwsh@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-17 22:27:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement PowerVM Virt Driver support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_ac772ed3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2016-05-18 11:49:41.000000000","message":"Perhaps a more appropriate title is:\n\nAdd nova-powervm repo for initial PowerVM support","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"b6d1c7f27f80d375cea04c2ea9780f54190c2972","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qing Wu Wang \u003cwangqwsh@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-17 22:27:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement PowerVM Virt Driver support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_823791e2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"in_reply_to":"bab6814e_ac772ed3","updated":"2016-05-18 12:12:00.000000000","message":"Done","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"d1bb4ea8753e64c71751e58952c51bf0230c18d9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I46f304f059c7ad3130c479d712bfe1cf70d41abb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_df34d2df","line":11,"updated":"2016-05-18 11:49:41.000000000","message":"Needs an:\nPartially-Implements: blueprint powervm-virt-driver","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"b6d1c7f27f80d375cea04c2ea9780f54190c2972","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I46f304f059c7ad3130c479d712bfe1cf70d41abb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_e2349ddf","line":11,"in_reply_to":"bab6814e_df34d2df","updated":"2016-05-18 12:12:00.000000000","message":"Done","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-powervm repo for initial PowerVM support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_0c82b394","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":15},"updated":"2016-05-18 13:37:39.000000000","message":"(nit) adds the","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-powervm repo for initial PowerVM support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_8c44e374","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":48},"updated":"2016-05-18 13:37:39.000000000","message":"(nit) creates","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-powervm repo for initial PowerVM support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_0c30f300","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":65},"updated":"2016-05-18 13:37:39.000000000","message":"(nit) tags","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"080d9aa92d9a0bd706c476ccaf56ad08bcd65a88","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-powervm repo for initial PowerVM support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add nova-powervm repo url and create nova-powervm tag"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab6814e_b5ac86ee","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":65},"in_reply_to":"bab6814e_0c30f300","updated":"2016-05-18 13:54:54.000000000","message":"Done","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"c34f8668f8c33693362341daaba5bf0a66ac4722","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nova-powervm repo for initial PowerVM support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds the nova-powervm repo url and creates nova-powervm tags"},{"line_number":10,"context_line":"to support PowerVM Virt Driver function."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially-Implements: blueprint powervm-virt-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_89f5ea84","line":9,"range":{"start_line":9,"start_character":43,"end_line":9,"end_character":72},"updated":"2016-05-18 15:32:07.000000000","message":"No longer accurate.","commit_id":"e985c051e5b4fe0422bccd3afbf64ad4700cb810"}],"playbooks/defaults/repo_packages/openstack_other.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2846551d7a97363d6e9a70b42155ef2617e1ce3f","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://github.com/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_ab1a8215","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":40},"updated":"2016-05-18 08:31:14.000000000","message":"Please use git.openstack.org","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"b6d1c7f27f80d375cea04c2ea9780f54190c2972","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://github.com/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_ff2f16f4","line":35,"range":{"start_line":35,"start_character":30,"end_line":35,"end_character":40},"in_reply_to":"bab6814e_ab1a8215","updated":"2016-05-18 12:12:00.000000000","message":"Done","commit_id":"6a007e57326a19efa029b5ab331d92449577c1ea"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"21ecbd7cb65618a08aceb443eec3e2d53b9f0c59","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_78517c62","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":72},"updated":"2016-05-18 12:47:28.000000000","message":"I think adreznec should take a peak at this.  Adding him to the review.  Want to make sure we target the right one.","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_ef3121ee","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":72},"in_reply_to":"bab6814e_78517c62","updated":"2016-05-18 13:37:39.000000000","message":"This should be fine for now. We\u0027ll have to do periodic updates of this as driver development continues throughout the cycle. My real question was whether this belongs here in openstack_other or in the openstack_services under the nova section. Obviously being out of tree but a nova driver makes that a fuzzy area.","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"474ea1ea322b740fdb53ffcecb0d18e0023712d2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_205696d2","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":72},"in_reply_to":"bab6814e_ef3121ee","updated":"2016-05-18 14:09:36.000000000","message":"If the branches follow the stable/ naming convention then here is fine. If the repo has another naming convention then it should be in its own file. If the repo only ever has a master branch to grab from then it should be in _other.","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"c34f8668f8c33693362341daaba5bf0a66ac4722","unresolved":false,"context_lines":[{"line_number":31,"context_line":"tempest_git_dest: \"/opt/tempest_{{ tempest_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"## PowerVM Virt Driver"},{"line_number":35,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":36,"context_line":"novapowervm_git_install_branch: 9b6a80a68c5c1262846041f3a165c5d5c7f30097 # HEAD of \"master\" as of 18.05.2016"},{"line_number":37,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"## NOVNC from source"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_69fec66c","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":97},"updated":"2016-05-18 15:32:07.000000000","message":"This should be in openstack_services rather than openstack_other since nova-powervm follows the stable/* naming convention.","commit_id":"e985c051e5b4fe0422bccd3afbf64ad4700cb810"}],"playbooks/defaults/repo_packages/openstack_services.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"9ae22002d57ee13c92c4d5c174749febb7cd2335","unresolved":false,"context_lines":[{"line_number":109,"context_line":"## PowerVM Virt Driver"},{"line_number":110,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":111,"context_line":"novapowervm_git_install_branch: 86d7fdfee450de555cdc506c4ad2fdfbbc14ab24 # HEAD of \"master\" as of 18.05.2016"},{"line_number":112,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"## Swift service"},{"line_number":115,"context_line":"swift_git_repo: https://git.openstack.org/openstack/swift"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_ea5edd10","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":20},"updated":"2016-05-19 18:28:42.000000000","message":"Would it be possible to change novapowervm to nova_powervm instead? That matches up with some of the hyphenated projects above, like neutron-lbaas-dashboard and neutron-lbaas.","commit_id":"32a35cec303b0a3fb99330b4a6bdd4a4400bb791"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"4f0c141c7eb09cb428a230a6e149f643e947437c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"## PowerVM Virt Driver"},{"line_number":110,"context_line":"novapowervm_git_repo: https://git.openstack.org/openstack/nova-powervm"},{"line_number":111,"context_line":"novapowervm_git_install_branch: 86d7fdfee450de555cdc506c4ad2fdfbbc14ab24 # HEAD of \"master\" as of 18.05.2016"},{"line_number":112,"context_line":"novapowervm_git_dest: \"/opt/novapowervm_{{ novapowervm_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"## Swift service"},{"line_number":115,"context_line":"swift_git_repo: https://git.openstack.org/openstack/swift"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bab6814e_b340c9a6","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":20},"in_reply_to":"bab6814e_ea5edd10","updated":"2016-05-19 20:34:33.000000000","message":"+1","commit_id":"32a35cec303b0a3fb99330b4a6bdd4a4400bb791"}],"playbooks/os-nova-install.yml":[{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"5bccda4c2cfacfec49cd76abee28ea0d7e0d918e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        - nova-kvm"},{"line_number":72,"context_line":"        - nova-kvm-container-devices"},{"line_number":73,"context_line":"        - nova-powervm"},{"line_number":74,"context_line":"        - nova-powervm-container-devices"},{"line_number":75,"context_line":"    - name: Add net/tun device to the compute"},{"line_number":76,"context_line":"      shell: |"},{"line_number":77,"context_line":"        lxc-device -n {{ container_name }} add /dev/net/tun /dev/net/tun"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_6fb9b1e9","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":40},"updated":"2016-05-18 13:40:49.000000000","message":"The PowerVM Compute Driver doesn\u0027t support running in a container.  I don\u0027t think it needs to be part of this tag.\n\nThis is a comment across the file.\n\nI actually don\u0027t think ANY of these tags make sense for this file. I think the tag itself will be used more in the openstack-ansible-os_nova project, in a \u0027tasks/nova_compute_powervm.yml\u0027","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"080d9aa92d9a0bd706c476ccaf56ad08bcd65a88","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        - nova-kvm"},{"line_number":72,"context_line":"        - nova-kvm-container-devices"},{"line_number":73,"context_line":"        - nova-powervm"},{"line_number":74,"context_line":"        - nova-powervm-container-devices"},{"line_number":75,"context_line":"    - name: Add net/tun device to the compute"},{"line_number":76,"context_line":"      shell: |"},{"line_number":77,"context_line":"        lxc-device -n {{ container_name }} add /dev/net/tun /dev/net/tun"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_b2adbc33","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":40},"in_reply_to":"bab6814e_6fb9b1e9","updated":"2016-05-18 13:54:54.000000000","message":"Done","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"5bccda4c2cfacfec49cd76abee28ea0d7e0d918e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tags:"},{"line_number":96,"context_line":"        - nova-kvm"},{"line_number":97,"context_line":"        - nova-kvm-container-devices"},{"line_number":98,"context_line":"        - nova-powervm"},{"line_number":99,"context_line":"        - nova-powervm-container-devices"},{"line_number":100,"context_line":"    - name: Add kvm device to the compute"},{"line_number":101,"context_line":"      shell: |"},{"line_number":102,"context_line":"        lxc-device -n {{ container_name }} add /dev/kvm /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_cf77fdd2","line":99,"range":{"start_line":98,"start_character":1,"end_line":99,"end_character":40},"updated":"2016-05-18 13:40:49.000000000","message":"No KVM device for PowerVM.","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tags:"},{"line_number":96,"context_line":"        - nova-kvm"},{"line_number":97,"context_line":"        - nova-kvm-container-devices"},{"line_number":98,"context_line":"        - nova-powervm"},{"line_number":99,"context_line":"        - nova-powervm-container-devices"},{"line_number":100,"context_line":"    - name: Add kvm device to the compute"},{"line_number":101,"context_line":"      shell: |"},{"line_number":102,"context_line":"        lxc-device -n {{ container_name }} add /dev/kvm /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_af6f1991","line":99,"range":{"start_line":98,"start_character":0,"end_line":99,"end_character":40},"updated":"2016-05-18 13:37:39.000000000","message":"Why do we need tags around checking for the kvm device during powervm driver install? Rather than add tags here, it seems better instead to just not execute anything tagged only with nova-kvm* in this flow during nova-powervm install.","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"080d9aa92d9a0bd706c476ccaf56ad08bcd65a88","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tags:"},{"line_number":96,"context_line":"        - nova-kvm"},{"line_number":97,"context_line":"        - nova-kvm-container-devices"},{"line_number":98,"context_line":"        - nova-powervm"},{"line_number":99,"context_line":"        - nova-powervm-container-devices"},{"line_number":100,"context_line":"    - name: Add kvm device to the compute"},{"line_number":101,"context_line":"      shell: |"},{"line_number":102,"context_line":"        lxc-device -n {{ container_name }} add /dev/kvm /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_5263b01a","line":99,"range":{"start_line":98,"start_character":0,"end_line":99,"end_character":40},"in_reply_to":"bab6814e_af6f1991","updated":"2016-05-18 13:54:54.000000000","message":"Done","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4ec32d307a2adf3fb92901356f702e5d7b8caed8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tags:"},{"line_number":96,"context_line":"        - nova-kvm"},{"line_number":97,"context_line":"        - nova-kvm-container-devices"},{"line_number":98,"context_line":"        - nova-powervm"},{"line_number":99,"context_line":"        - nova-powervm-container-devices"},{"line_number":100,"context_line":"    - name: Add kvm device to the compute"},{"line_number":101,"context_line":"      shell: |"},{"line_number":102,"context_line":"        lxc-device -n {{ container_name }} add /dev/kvm /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_80b942ec","line":99,"range":{"start_line":98,"start_character":0,"end_line":99,"end_character":40},"in_reply_to":"bab6814e_af6f1991","updated":"2016-05-18 14:11:57.000000000","message":"It would be better to have the when conditional have the first conditional be  based on the nova_virt_type so that these tasks are only run if it\u0027s not set (ie it presume that it should figure out the device)","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"080d9aa92d9a0bd706c476ccaf56ad08bcd65a88","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      tags:"},{"line_number":96,"context_line":"        - nova-kvm"},{"line_number":97,"context_line":"        - nova-kvm-container-devices"},{"line_number":98,"context_line":"        - nova-powervm"},{"line_number":99,"context_line":"        - nova-powervm-container-devices"},{"line_number":100,"context_line":"    - name: Add kvm device to the compute"},{"line_number":101,"context_line":"      shell: |"},{"line_number":102,"context_line":"        lxc-device -n {{ container_name }} add /dev/kvm /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_3268acf5","line":99,"range":{"start_line":98,"start_character":1,"end_line":99,"end_character":40},"in_reply_to":"bab6814e_cf77fdd2","updated":"2016-05-18 13:54:54.000000000","message":"Done","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":13883,"name":"Adam Reznechek","email":"adreznec@us.ibm.com","username":"adrez"},"change_message_id":"b41dafde263793ac2d5baf7bab550835ca68ae45","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      tags:"},{"line_number":113,"context_line":"        - nova-kvm"},{"line_number":114,"context_line":"        - nova-kvm-container-devices"},{"line_number":115,"context_line":"        - nova-powervm"},{"line_number":116,"context_line":"        - nova-powervm-container-devices"},{"line_number":117,"context_line":"    - name: Create log dir"},{"line_number":118,"context_line":"      file:"},{"line_number":119,"context_line":"        path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_ef0001ad","line":116,"range":{"start_line":115,"start_character":1,"end_line":116,"end_character":40},"updated":"2016-05-18 13:37:39.000000000","message":"Same as above","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":10347,"name":"Wang Qing wu","email":"wqw2700@sina.com","username":"cody"},"change_message_id":"080d9aa92d9a0bd706c476ccaf56ad08bcd65a88","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      tags:"},{"line_number":113,"context_line":"        - nova-kvm"},{"line_number":114,"context_line":"        - nova-kvm-container-devices"},{"line_number":115,"context_line":"        - nova-powervm"},{"line_number":116,"context_line":"        - nova-powervm-container-devices"},{"line_number":117,"context_line":"    - name: Create log dir"},{"line_number":118,"context_line":"      file:"},{"line_number":119,"context_line":"        path: \"{{ item.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_b2749ccf","line":116,"range":{"start_line":115,"start_character":1,"end_line":116,"end_character":40},"in_reply_to":"bab6814e_ef0001ad","updated":"2016-05-18 13:54:54.000000000","message":"Done","commit_id":"e28fb37274311d89f8121963fbf3a4d60b8bf726"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"20fed788cd15259301793556e2ea3c890e88c6bc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      tags:"},{"line_number":71,"context_line":"        - nova-kvm"},{"line_number":72,"context_line":"        - nova-kvm-container-devices"},{"line_number":73,"context_line":"        - nova-powervm"},{"line_number":74,"context_line":"    - name: Add net/tun device to the compute"},{"line_number":75,"context_line":"      shell: |"},{"line_number":76,"context_line":"        lxc-device -n {{ container_name }} add /dev/net/tun /dev/net/tun"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_b5c76644","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":22},"updated":"2016-05-18 13:59:29.000000000","message":"The PowerVM Nova Driver doesn\u0027t support running in a container.  This is for when the compute runs in a container (at least I believe it is due to the lxc-device command)","commit_id":"144bc34db8e8cb0f1d0fe57b7979afb3ca0491fe"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"20fed788cd15259301793556e2ea3c890e88c6bc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"      tags:"},{"line_number":82,"context_line":"        - nova-kvm"},{"line_number":83,"context_line":"        - nova-kvm-container-devices"},{"line_number":84,"context_line":"        - nova-powervm"},{"line_number":85,"context_line":"    - name: Check if kvm device exists"},{"line_number":86,"context_line":"      stat:"},{"line_number":87,"context_line":"        path: /dev/kvm"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_b5a00692","line":84,"range":{"start_line":84,"start_character":8,"end_line":84,"end_character":22},"updated":"2016-05-18 13:59:29.000000000","message":"The PowerVM Nova Driver doesn\u0027t support running in a container.  This is for when the compute runs in a container (at least I believe it is due to the lxc-device command)","commit_id":"144bc34db8e8cb0f1d0fe57b7979afb3ca0491fe"}]}