)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":425,"name":"Darren Birkett","email":"darren.birkett@gmail.com","username":"darren-birkett"},"change_message_id":"2369f2dc047c586deec5ae797df4954e96553614","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch cleans up the horizon variables in hosts.yml:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  * Switches to use ternary() filter"},{"line_number":12,"context_line":"  * Removes LBaaS v1 from horizon_enable_neutron_lbaas"},{"line_number":13,"context_line":"  * Adds LBaaS v2 to horizon_enable_neutron_lbaas"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_e811fbb0","line":11,"updated":"2016-05-24 20:00:15.000000000","message":"You\u0027ve removed the use of ternary since the first patchset so this can be removed from the commit message","commit_id":"395028099deb850b63d70f08e33e04453c620886"}],"playbooks/inventory/group_vars/hosts.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7216b9abbc5f5cb998ad2dcf86bc037419049498","unresolved":false,"context_lines":[{"line_number":226,"context_line":"horizon_enable_neutron_lbaas: \"{{ (neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":227,"context_line":"horizon_enable_neutron_fwaas: \"{{ (neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":228,"context_line":"horizon_enable_neutron_vpnaas: \"{{ (neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":229,"context_line":"horizon_enable_ha_router: \"{{ (neutron_plugin_type \u003d\u003d \u0027ml2\u0027 and (groups[\u0027neutron_l3_agent\u0027] | length \u003e\u003d 2)) | ternary(True, False) }}\""},{"line_number":230,"context_line":"horizon_rabbitmq_userid: horizon"},{"line_number":231,"context_line":"horizon_rabbitmq_vhost: /horizon"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_05b919cc","line":229,"updated":"2016-05-23 14:17:00.000000000","message":"I wonder whether these even need the ternary? Surely the conditionals on their own will end up with a boolean result. ie perhaps just \"{{ (add conditionals here) }}\" will work?","commit_id":"c31e4de1be188056eb2ed152a99d43b4356240be"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"df5f67900061f302519c391be48e84a64f66e21f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"horizon_enable_neutron_lbaas: \"{{ (neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":227,"context_line":"horizon_enable_neutron_fwaas: \"{{ (neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":228,"context_line":"horizon_enable_neutron_vpnaas: \"{{ (neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base) | ternary(True, False) }}\""},{"line_number":229,"context_line":"horizon_enable_ha_router: \"{{ (neutron_plugin_type \u003d\u003d \u0027ml2\u0027 and (groups[\u0027neutron_l3_agent\u0027] | length \u003e\u003d 2)) | ternary(True, False) }}\""},{"line_number":230,"context_line":"horizon_rabbitmq_userid: horizon"},{"line_number":231,"context_line":"horizon_rabbitmq_vhost: /horizon"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bab6814e_fc0d80e8","line":229,"updated":"2016-05-23 18:11:10.000000000","message":"You\u0027re right. I\u0027ll fix.","commit_id":"c31e4de1be188056eb2ed152a99d43b4356240be"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"291b3bda76c991a13efa611266057d09254eab96","unresolved":false,"context_lines":[{"line_number":230,"context_line":"## Horizon"},{"line_number":231,"context_line":"horizon_service_region: \"{{ service_region }}\""},{"line_number":232,"context_line":"horizon_enable_cinder_backup: \"{{ cinder_service_backup_program_enabled is defined and cinder_service_backup_program_enabled | bool }}\""},{"line_number":233,"context_line":"# NOTE(mhayden): neutron-lbaas is a separate plugin and requires the full"},{"line_number":234,"context_line":"# namespace to be specified. Also, LBaaS v1 was removed in Newton."},{"line_number":235,"context_line":"horizon_enable_neutron_lbaas: \"{{ neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base }}\""},{"line_number":236,"context_line":"horizon_enable_neutron_fwaas: \"{{ neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base }}\""},{"line_number":237,"context_line":"horizon_enable_neutron_vpnaas: \"{{ neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_a3cf9e7d","line":234,"range":{"start_line":233,"start_character":0,"end_line":234,"end_character":66},"updated":"2016-05-26 17:15:25.000000000","message":"Isn\u0027t it the same circumstance for vpnaas, and perhaps also fwaas? If so then those should also be changed, and changes should also be made in the Neutron repository.","commit_id":"0a41b4d7624583747f830e9562c7067952f202ef"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"c83b2f33414dd1d557d7facd792908c9080f9347","unresolved":false,"context_lines":[{"line_number":231,"context_line":"horizon_service_region: \"{{ service_region }}\""},{"line_number":232,"context_line":"horizon_enable_cinder_backup: \"{{ cinder_service_backup_program_enabled is defined and cinder_service_backup_program_enabled | bool }}\""},{"line_number":233,"context_line":"# NOTE(mhayden): neutron-lbaas is a separate plugin and requires the full"},{"line_number":234,"context_line":"# namespace to be specified. Also, LBaaS v1 was removed in Newton."},{"line_number":235,"context_line":"horizon_enable_neutron_lbaas: \"{{ neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base }}\""},{"line_number":236,"context_line":"horizon_enable_neutron_fwaas: \"{{ neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base }}\""},{"line_number":237,"context_line":"horizon_enable_neutron_vpnaas: \"{{ neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_ff881224","line":234,"in_reply_to":"bab6814e_a3cf9e7d","updated":"2016-05-26 19:54:50.000000000","message":"For now, vpnaas/fwaas are still in neutron\u0027s namespace, so they differ from LBaaS.","commit_id":"0a41b4d7624583747f830e9562c7067952f202ef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"291b3bda76c991a13efa611266057d09254eab96","unresolved":false,"context_lines":[{"line_number":235,"context_line":"horizon_enable_neutron_lbaas: \"{{ neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base }}\""},{"line_number":236,"context_line":"horizon_enable_neutron_fwaas: \"{{ neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base }}\""},{"line_number":237,"context_line":"horizon_enable_neutron_vpnaas: \"{{ neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base }}\""},{"line_number":238,"context_line":"horizon_enable_ha_router: \"{{ \u0027ml2\u0027 in neutron_plugin_type and (groups[\u0027neutron_l3_agent\u0027] | length \u003e\u003d 2) }}\""},{"line_number":239,"context_line":"horizon_rabbitmq_userid: horizon"},{"line_number":240,"context_line":"horizon_rabbitmq_vhost: /horizon"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_e30086ad","line":238,"range":{"start_line":238,"start_character":30,"end_line":238,"end_character":58},"updated":"2016-05-26 17:15:25.000000000","message":"neutron_plugin_type.split(\u0027.\u0027)[0] \u003d\u003d \u0027ml2\u0027","commit_id":"0a41b4d7624583747f830e9562c7067952f202ef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a80be1a4ba3bcc0406279a6316443e7839a50013","unresolved":false,"context_lines":[{"line_number":235,"context_line":"horizon_enable_neutron_lbaas: \"{{ neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base }}\""},{"line_number":236,"context_line":"horizon_enable_neutron_fwaas: \"{{ neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base }}\""},{"line_number":237,"context_line":"horizon_enable_neutron_vpnaas: \"{{ neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base }}\""},{"line_number":238,"context_line":"horizon_enable_ha_router: \"{{ \u0027ml2\u0027 in neutron_plugin_type and (groups[\u0027neutron_l3_agent\u0027] | length \u003e\u003d 2) }}\""},{"line_number":239,"context_line":"horizon_rabbitmq_userid: horizon"},{"line_number":240,"context_line":"horizon_rabbitmq_vhost: /horizon"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9abb7d3a_891a2d16","line":238,"in_reply_to":"bab6814e_9f99067c","updated":"2016-05-27 08:33:50.000000000","message":"Yeah, anything that used to refer to \u0027ml2\u0027 in neutron_plugin_type will now need to have the split, thanks to https://github.com/openstack/openstack-ansible-os_neutron/commit/656a9769899f090278f53768b0ae825e798f10ba","commit_id":"0a41b4d7624583747f830e9562c7067952f202ef"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"c83b2f33414dd1d557d7facd792908c9080f9347","unresolved":false,"context_lines":[{"line_number":235,"context_line":"horizon_enable_neutron_lbaas: \"{{ neutron_plugin_base is defined and \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\u0027 in neutron_plugin_base }}\""},{"line_number":236,"context_line":"horizon_enable_neutron_fwaas: \"{{ neutron_plugin_base is defined and \u0027firewall\u0027 in neutron_plugin_base }}\""},{"line_number":237,"context_line":"horizon_enable_neutron_vpnaas: \"{{ neutron_plugin_base is defined and \u0027vpnaas\u0027 in neutron_plugin_base }}\""},{"line_number":238,"context_line":"horizon_enable_ha_router: \"{{ \u0027ml2\u0027 in neutron_plugin_type and (groups[\u0027neutron_l3_agent\u0027] | length \u003e\u003d 2) }}\""},{"line_number":239,"context_line":"horizon_rabbitmq_userid: horizon"},{"line_number":240,"context_line":"horizon_rabbitmq_vhost: /horizon"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_9f99067c","line":238,"in_reply_to":"bab6814e_e30086ad","updated":"2016-05-26 19:54:50.000000000","message":"I don\u0027t see a split in the current version in master -- does that need to be added here? https://github.com/openstack/openstack-ansible/blob/master/playbooks/inventory/group_vars/hosts.yml#L238","commit_id":"0a41b4d7624583747f830e9562c7067952f202ef"}]}