)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78416ca106468563865524e944428d5bd68414f6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change implements CentOS7 and Ubuntu 16.04 support for the HAProxy"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib4f33185202b694b9611cc5fd6323c30a1c8d489"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_4f50f7d4","line":11,"updated":"2016-05-25 08:20:25.000000000","message":"Please add\n\nImplements: blueprint multi-platform-host","commit_id":"f405cc0585e9738eddf2a3e312c0a2c339aef212"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b4721807e3a6a2cf7a879b8b8d34a945de348e05","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change implements CentOS7 and Ubuntu 16.04 support for the HAProxy"},{"line_number":10,"context_line":"role."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib4f33185202b694b9611cc5fd6323c30a1c8d489"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckevin.carter@rackspace.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_cb7334b3","line":11,"in_reply_to":"bab6814e_4f50f7d4","updated":"2016-05-25 10:15:19.000000000","message":"Done","commit_id":"f405cc0585e9738eddf2a3e312c0a2c339aef212"}],"playbooks/roles/haproxy_server/files/haproxy.default":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_cbdcd41a","updated":"2016-05-25 10:34:37.000000000","message":"we shoudn\u0027t even ship this file.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_678b581f","in_reply_to":"bab6814e_07736c81","updated":"2016-05-25 11:12:31.000000000","message":"This is shipped by default with haproxy","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f2c33146fe7b10ebef72de88d80886d8f3062776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_4aae1b86","in_reply_to":"bab6814e_678b581f","updated":"2016-05-25 11:29:21.000000000","message":"it is shipped by default but its not enabled by default.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bab6814e_07736c81","in_reply_to":"bab6814e_cbdcd41a","updated":"2016-05-25 11:06:23.000000000","message":"We need this file so long as we support ubuntu 14.04. The original Haproxy init script requires ENABLED\u003d1 for it to work.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"}],"playbooks/roles/haproxy_server/meta/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":41,"context_line":"      - haproxy_ssl | bool"},{"line_number":42,"context_line":"      - ansible_distribution_version \u003c \"16.04\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_ab2d10ff","line":42,"updated":"2016-05-25 10:34:37.000000000","message":"does this work fine without the version compare filter? Not tested.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":41,"context_line":"      - haproxy_ssl | bool"},{"line_number":42,"context_line":"      - ansible_distribution_version \u003c \"16.04\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_878f5c22","line":42,"in_reply_to":"bab6814e_273030e8","updated":"2016-05-25 11:12:31.000000000","message":"up to you :)","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f2c33146fe7b10ebef72de88d80886d8f3062776","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":41,"context_line":"      - haproxy_ssl | bool"},{"line_number":42,"context_line":"      - ansible_distribution_version \u003c \"16.04\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_6acaff1b","line":42,"in_reply_to":"bab6814e_878f5c22","updated":"2016-05-25 11:29:21.000000000","message":"Done","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    when:"},{"line_number":40,"context_line":"      - ansible_pkg_mgr \u003d\u003d \u0027apt\u0027"},{"line_number":41,"context_line":"      - haproxy_ssl | bool"},{"line_number":42,"context_line":"      - ansible_distribution_version \u003c \"16.04\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_273030e8","line":42,"in_reply_to":"bab6814e_ab2d10ff","updated":"2016-05-25 11:06:23.000000000","message":"Yes in test but for clarity I\u0027ll change it.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"}],"playbooks/roles/haproxy_server/tasks/haproxy_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - install-yum"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Replace haproxy DEFAULT file"},{"line_number":29,"context_line":"  copy:"},{"line_number":30,"context_line":"    src: haproxy.default"},{"line_number":31,"context_line":"    dest: /etc/default/haproxy"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - haproxy-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Create haproxy conf.d dir"},{"line_number":36,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_cb1174b1","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":20},"updated":"2016-05-25 10:34:37.000000000","message":"we should remove this task","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - install-yum"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Replace haproxy DEFAULT file"},{"line_number":29,"context_line":"  copy:"},{"line_number":30,"context_line":"    src: haproxy.default"},{"line_number":31,"context_line":"    dest: /etc/default/haproxy"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - haproxy-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Create haproxy conf.d dir"},{"line_number":36,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_47ae1486","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":20},"in_reply_to":"bab6814e_06fed16a","updated":"2016-05-25 11:12:31.000000000","message":"Please check the context of this comment, written in previous review.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f2c33146fe7b10ebef72de88d80886d8f3062776","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - install-yum"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Replace haproxy DEFAULT file"},{"line_number":29,"context_line":"  copy:"},{"line_number":30,"context_line":"    src: haproxy.default"},{"line_number":31,"context_line":"    dest: /etc/default/haproxy"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - haproxy-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Create haproxy conf.d dir"},{"line_number":36,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_0a55334f","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":20},"in_reply_to":"bab6814e_47ae1486","updated":"2016-05-25 11:29:21.000000000","message":"The context is clear, in PS5 I moved this to the apt install file and added a 14.04 conditional check however there is no need to \"clean up\" by purging the old install on an upgrade as that will likely have further reaching consequences than simply shipping this file.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - install-yum"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Replace haproxy DEFAULT file"},{"line_number":29,"context_line":"  copy:"},{"line_number":30,"context_line":"    src: haproxy.default"},{"line_number":31,"context_line":"    dest: /etc/default/haproxy"},{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - haproxy-config"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Create haproxy conf.d dir"},{"line_number":36,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_06fed16a","line":33,"range":{"start_line":28,"start_character":0,"end_line":33,"end_character":20},"in_reply_to":"bab6814e_cb1174b1","updated":"2016-05-25 11:06:23.000000000","message":"This task is needed for upgrades on 14.04 hosts and while its not used on CentOS hosts the defaults directory still exists so there\u0027s really nothing to do here.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    state: directory"},{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_4b262417","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":27},"updated":"2016-05-25 10:34:37.000000000","message":"this should be a distro specific variable","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    state: directory"},{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_07f9ac80","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":27},"in_reply_to":"bab6814e_4407321c","updated":"2016-05-25 11:12:31.000000000","message":"This was not a mandatory request, just a convenience, I\u0027ve seen other distros with another folder.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    state: directory"},{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_4407321c","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":27},"in_reply_to":"bab6814e_4b262417","updated":"2016-05-25 11:06:23.000000000","message":"On RHEL installations of HAProxy the configuration files go here. What would you like to see this changed to?","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_6b1b28cb","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":28},"updated":"2016-05-25 10:34:37.000000000","message":"same (based on previous variable?)","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_a70c203c","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":28},"in_reply_to":"bab6814e_6b1b28cb","updated":"2016-05-25 11:06:23.000000000","message":"On RHEL installations of HAProxy the configuration files go in \"/etc/haproxy\". What would you like to see this changed to?","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    mode: \"0755\""},{"line_number":40,"context_line":"  with_items:"},{"line_number":41,"context_line":"    - { path: \"/etc/haproxy\" }"},{"line_number":42,"context_line":"    - { path: \"/etc/haproxy/conf.d\" }"},{"line_number":43,"context_line":"  tags:"},{"line_number":44,"context_line":"    - haproxy-config"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_2745d0b2","line":42,"range":{"start_line":42,"start_character":15,"end_line":42,"end_character":28},"in_reply_to":"bab6814e_a70c203c","updated":"2016-05-25 11:12:31.000000000","message":"cf. above","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"}],"playbooks/roles/haproxy_server/tasks/haproxy_install_yum.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"78416ca106468563865524e944428d5bd68414f6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - lxc-install-rhel"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - lxc-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_6f905b96","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":22},"updated":"2016-05-25 08:20:25.000000000","message":"Two tags headings.","commit_id":"f405cc0585e9738eddf2a3e312c0a2c339aef212"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b4721807e3a6a2cf7a879b8b8d34a945de348e05","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - lxc-install-rhel"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - lxc-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bab6814e_0bca5ca1","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":22},"in_reply_to":"bab6814e_6f905b96","updated":"2016-05-25 10:15:19.000000000","message":"Done","commit_id":"f405cc0585e9738eddf2a3e312c0a2c339aef212"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  register: install_packages"},{"line_number":21,"context_line":"  until: install_packages|success"},{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - haproxy-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_eb8558cf","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"updated":"2016-05-25 10:34:37.000000000","message":"why do we delay?","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f2c33146fe7b10ebef72de88d80886d8f3062776","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  register: install_packages"},{"line_number":21,"context_line":"  until: install_packages|success"},{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - haproxy-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_4afd7b39","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"bab6814e_67635842","updated":"2016-05-25 11:29:21.000000000","message":"It is needed to cool down, likely on package installation failures its highly likely that there may be some transient issue and running the same task without a cool down will generally never recover from a transient issue.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  register: install_packages"},{"line_number":21,"context_line":"  until: install_packages|success"},{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - haproxy-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_67635842","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"bab6814e_c68e8926","updated":"2016-05-25 11:12:31.000000000","message":"It doesn\u0027t mean it\u0027s still necessary...\n\nBut ok, whatever.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  register: install_packages"},{"line_number":21,"context_line":"  until: install_packages|success"},{"line_number":22,"context_line":"  retries: 5"},{"line_number":23,"context_line":"  delay: 2"},{"line_number":24,"context_line":"  with_items: haproxy_yum_packages"},{"line_number":25,"context_line":"  tags:"},{"line_number":26,"context_line":"    - haproxy-yum-packages"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_c68e8926","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"bab6814e_eb8558cf","updated":"2016-05-25 11:06:23.000000000","message":"This is a delay on retry and the pattern we\u0027ve been using for some time now.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"}],"playbooks/roles/haproxy_server/tasks/haproxy_post_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1ab740f7e50ff8cf48895a5e659c0ec2f0cc55d8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- include: haproxy_service_config.yml"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Generate haproxy config reload script"},{"line_number":45,"context_line":"  copy:"},{"line_number":46,"context_line":"    content: |"},{"line_number":47,"context_line":"      #!/usr/bin/env bash"},{"line_number":48,"context_line":"      cat /etc/haproxy/haproxy.cfg.base /etc/haproxy/conf.d/* | tee /etc/haproxy/haproxy.cfg"},{"line_number":49,"context_line":"    dest: \"/usr/local/bin/haproxy-config-rebuild\""},{"line_number":50,"context_line":"    mode: \"0755\""},{"line_number":51,"context_line":"  tags:"},{"line_number":52,"context_line":"    - haproxy-base-config"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Run haproxy config reload"},{"line_number":55,"context_line":"  command: \"/usr/local/bin/haproxy-config-rebuild\""},{"line_number":56,"context_line":"  tags:"},{"line_number":57,"context_line":"    - haproxy-base-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_c1734ce6","line":57,"range":{"start_line":45,"start_character":2,"end_line":57,"end_character":25},"updated":"2016-05-24 12:53:18.000000000","message":"This is what the assemble module is meant for: http://docs.ansible.com/ansible/assemble_module.html\n\nYou could get the inspiration from https://github.com/evrardjp/ansible-haproxy/blob/master/tasks/haproxy_config.yml","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3d9a81f85e6a1e7d2ee2136332540c6c2d8ff597","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- include: haproxy_service_config.yml"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Generate haproxy config reload script"},{"line_number":45,"context_line":"  copy:"},{"line_number":46,"context_line":"    content: |"},{"line_number":47,"context_line":"      #!/usr/bin/env bash"},{"line_number":48,"context_line":"      cat /etc/haproxy/haproxy.cfg.base /etc/haproxy/conf.d/* | tee /etc/haproxy/haproxy.cfg"},{"line_number":49,"context_line":"    dest: \"/usr/local/bin/haproxy-config-rebuild\""},{"line_number":50,"context_line":"    mode: \"0755\""},{"line_number":51,"context_line":"  tags:"},{"line_number":52,"context_line":"    - haproxy-base-config"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Run haproxy config reload"},{"line_number":55,"context_line":"  command: \"/usr/local/bin/haproxy-config-rebuild\""},{"line_number":56,"context_line":"  tags:"},{"line_number":57,"context_line":"    - haproxy-base-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_3611b9b0","line":57,"range":{"start_line":45,"start_character":2,"end_line":57,"end_character":25},"in_reply_to":"bab6814e_c1734ce6","updated":"2016-05-24 13:13:38.000000000","message":"Done","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"}],"playbooks/roles/haproxy_server/tasks/haproxy_pre_install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"d9059a6bc1b2c8c491d1f0db3291ae6bc52041cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Create haproxy log dir"},{"line_number":32,"context_line":"  file:"},{"line_number":33,"context_line":"    path: \"/var/log/haproxy\""},{"line_number":34,"context_line":"    state: directory"},{"line_number":35,"context_line":"    mode: \"0755\""},{"line_number":36,"context_line":"  when: log_dir | changed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_ebd398d3","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":27},"updated":"2016-05-25 10:34:37.000000000","message":"maybe a distro specific path here (but not mandatory)","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"7dda2e6e4fa680734bf19bb71e86c8bd0a1fd170","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Create haproxy log dir"},{"line_number":32,"context_line":"  file:"},{"line_number":33,"context_line":"    path: \"/var/log/haproxy\""},{"line_number":34,"context_line":"    state: directory"},{"line_number":35,"context_line":"    mode: \"0755\""},{"line_number":36,"context_line":"  when: log_dir | changed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_87c75c11","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":27},"in_reply_to":"bab6814e_e6e90db9","updated":"2016-05-25 11:12:31.000000000","message":"agreed","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d6d979109789c2603b5d9f2f10e275cf23b357ee","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Create haproxy log dir"},{"line_number":32,"context_line":"  file:"},{"line_number":33,"context_line":"    path: \"/var/log/haproxy\""},{"line_number":34,"context_line":"    state: directory"},{"line_number":35,"context_line":"    mode: \"0755\""},{"line_number":36,"context_line":"  when: log_dir | changed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_e6e90db9","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":27},"in_reply_to":"bab6814e_ebd398d3","updated":"2016-05-25 11:06:23.000000000","message":"I\u0027d rather this not be distro specific in fact I think we should have our standard and keep to that to reign in sprawl.","commit_id":"dabaaef18e0d6cbabf8cfec5e5c09888f027befd"}],"playbooks/roles/haproxy_server/tasks/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1ab740f7e50ff8cf48895a5e659c0ec2f0cc55d8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- name: Gather variables for each operating system"},{"line_number":29,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":30,"context_line":"  with_first_found:"},{"line_number":31,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":32,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":33,"context_line":"    - \"{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0] }}.yml\""},{"line_number":34,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - always"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_e15db049","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":43},"updated":"2016-05-24 12:53:18.000000000","message":"why another pattern?","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3d9a81f85e6a1e7d2ee2136332540c6c2d8ff597","unresolved":false,"context_lines":[{"line_number":28,"context_line":"- name: Gather variables for each operating system"},{"line_number":29,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":30,"context_line":"  with_first_found:"},{"line_number":31,"context_line":"    - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":32,"context_line":"    - \"{{ ansible_distribution | lower }}.yml\""},{"line_number":33,"context_line":"    - \"{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split(\u0027.\u0027)[0] }}.yml\""},{"line_number":34,"context_line":"    - \"{{ ansible_os_family | lower }}.yml\""},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - always"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_76f22108","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":43},"in_reply_to":"bab6814e_e15db049","updated":"2016-05-24 13:13:38.000000000","message":"What other pattern? This is copy/paste from our other roles.\n\nhttps://github.com/openstack/openstack-ansible-lxc_hosts/blob/master/tasks/main.yml#L34-L42","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"}],"playbooks/roles/haproxy_server/vars/ubuntu-14.04.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1ab740f7e50ff8cf48895a5e659c0ec2f0cc55d8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - haproxy"},{"line_number":38,"context_line":"  - hatop"},{"line_number":39,"context_line":"  - rsyslog  # Used for local logging"},{"line_number":40,"context_line":"  - vim-haproxy"},{"line_number":41,"context_line":"  - psmisc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_731fd35b","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":10},"updated":"2016-05-24 12:53:18.000000000","message":"this list starts to build up for no haproxy reason, I\u0027m not sure that\u0027s a good idea to keep this (when we are at the cleaning)","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3d9a81f85e6a1e7d2ee2136332540c6c2d8ff597","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  - haproxy"},{"line_number":38,"context_line":"  - hatop"},{"line_number":39,"context_line":"  - rsyslog  # Used for local logging"},{"line_number":40,"context_line":"  - vim-haproxy"},{"line_number":41,"context_line":"  - psmisc"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bab6814e_b671297a","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":10},"in_reply_to":"bab6814e_731fd35b","updated":"2016-05-24 13:13:38.000000000","message":"This list is what we had before just copied over from defaults. I\u0027d rather not remove packages in this PR.","commit_id":"2b84679a4f0827c5659cfc63a33fc4556640a328"}],"releasenotes/notes/haproxy-centos-support-de39c19d6a89b6a5.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7a49017d2f269277d022a5b3783ccee257d5aaa8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - CentOS 7 and Ubuntu 16.04 support has been added to the ``haproxy`` role."},{"line_number":4,"context_line":"  - Within the ``haproxy`` role *hatop* has been changed from a package installation"},{"line_number":5,"context_line":"    to a source install. This was done to ensure operator tooling was available"},{"line_number":6,"context_line":"    on within various distros we support where an *hatop* package may not be"},{"line_number":7,"context_line":"    available."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - A new variable has been added to the ``haproxy`` role to support a source"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9abb7d3a_a74915d3","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":6},"updated":"2016-05-27 11:07:59.000000000","message":"from?","commit_id":"deda6e85f47889fc273497c82d9583b281933b68"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7a49017d2f269277d022a5b3783ccee257d5aaa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - CentOS 7 and Ubuntu 16.04 support has been added to the ``haproxy`` role."},{"line_number":4,"context_line":"  - Within the ``haproxy`` role *hatop* has been changed from a package installation"},{"line_number":5,"context_line":"    to a source install. This was done to ensure operator tooling was available"},{"line_number":6,"context_line":"    on within various distros we support where an *hatop* package may not be"},{"line_number":7,"context_line":"    available."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - A new variable has been added to the ``haproxy`` role to support a source"},{"line_number":10,"context_line":"    installation of haptop. The new variable is **haproxy_hatop_download_url**."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9abb7d3a_e7783dfb","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":14},"updated":"2016-05-27 11:07:59.000000000","message":"This is an \u0027upgrade\u0027 note. It\u0027s not really a feature, but a change of behaviour.","commit_id":"deda6e85f47889fc273497c82d9583b281933b68"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7a49017d2f269277d022a5b3783ccee257d5aaa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    on within various distros we support where an *hatop* package may not be"},{"line_number":7,"context_line":"    available."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - A new variable has been added to the ``haproxy`` role to support a source"},{"line_number":10,"context_line":"    installation of haptop. The new variable is **haproxy_hatop_download_url**."},{"line_number":11,"context_line":"    This variable enables the installation of HATop on multiple distros."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9abb7d3a_e7c67d15","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":72},"updated":"2016-05-27 11:07:59.000000000","message":"If the note above has been move to the \u0027upgrade section\u0027 then this is not necessary.","commit_id":"deda6e85f47889fc273497c82d9583b281933b68"}]}
