)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"06f7240df460eab7588e651f6bfbda7a0c56db9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"RFC1034/5 hostname upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes created here allow for upgrades to take place"},{"line_number":10,"context_line":"without impacting cluster availablity in cases where a"},{"line_number":11,"context_line":"a service may be dependent on a non-compliant hostname(s)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Upgrade playbook has been added for ensuring hostname aliases"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_5b99c21e","line":10,"updated":"2016-05-30 22:41:42.000000000","message":"nit: availability","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2fe369124412b7ddb1b8d665920181705ff7a11c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"RFC1034/5 hostname upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes created here allow for upgrades to take place"},{"line_number":10,"context_line":"without impacting cluster availablity in cases where a"},{"line_number":11,"context_line":"a service may be dependent on a non-compliant hostname(s)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Upgrade playbook has been added for ensuring hostname aliases"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_bed6a94c","line":10,"in_reply_to":"9abb7d3a_5b99c21e","updated":"2016-05-31 17:07:57.000000000","message":"Done","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"06f7240df460eab7588e651f6bfbda7a0c56db9d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Because the initial release of Mitaka (13.0.0) did not contain"},{"line_number":24,"context_line":"the RFC1034/5 updates these changes are needed to guarentee"},{"line_number":25,"context_line":"custlers deployed on our initial release are upgradable to"},{"line_number":26,"context_line":"Newton (14.0.0)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I6901409c1dc5ac8ff4f0af988132b5ac71f6379e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_3bfe7e37","line":25,"updated":"2016-05-30 22:41:42.000000000","message":"nit: clusters","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2fe369124412b7ddb1b8d665920181705ff7a11c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Because the initial release of Mitaka (13.0.0) did not contain"},{"line_number":24,"context_line":"the RFC1034/5 updates these changes are needed to guarentee"},{"line_number":25,"context_line":"custlers deployed on our initial release are upgradable to"},{"line_number":26,"context_line":"Newton (14.0.0)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I6901409c1dc5ac8ff4f0af988132b5ac71f6379e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_1ec895a7","line":25,"in_reply_to":"9abb7d3a_3bfe7e37","updated":"2016-05-31 17:07:57.000000000","message":"Done","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"}],"doc/source/upgrade-guide/upgrade-playbooks.rst":[{"author":{"_account_id":18784,"name":"Michael Carden","email":"mike.carden@gmail.com","username":"mcarden"},"change_message_id":"06f7240df460eab7588e651f6bfbda7a0c56db9d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"old-hostname-compatibility.yml"},{"line_number":45,"context_line":"------------------------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This playbooks ensures an alias is create for old hostnames that may not be RFC"},{"line_number":48,"context_line":"1034 or 1035 compatible. Using a hostname alias allows agents to continue working"},{"line_number":49,"context_line":"in cases where the hostname is also the registered agent name. This playbook is"},{"line_number":50,"context_line":"only needed for upgrades of existing nodes in-place and if a node is replaced or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_9bba0a6d","line":47,"updated":"2016-05-30 22:41:42.000000000","message":"... playbook ...created","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2fe369124412b7ddb1b8d665920181705ff7a11c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"old-hostname-compatibility.yml"},{"line_number":45,"context_line":"------------------------------"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"This playbooks ensures an alias is create for old hostnames that may not be RFC"},{"line_number":48,"context_line":"1034 or 1035 compatible. Using a hostname alias allows agents to continue working"},{"line_number":49,"context_line":"in cases where the hostname is also the registered agent name. This playbook is"},{"line_number":50,"context_line":"only needed for upgrades of existing nodes in-place and if a node is replaced or"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_9e6ac57f","line":47,"in_reply_to":"9abb7d3a_9bba0a6d","updated":"2016-05-31 17:07:57.000000000","message":"Done","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},"change_message_id":"63139b03ba4f10c6170644821e62a17bdb180b31","unresolved":false,"context_lines":[{"line_number":43,"context_line":"``old-hostname-compatibility.yml``"},{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"This playbooks ensures an alias is created for old hostnames that may not be RFC"},{"line_number":47,"context_line":"1034 or 1035 compatible. Using a hostname alias allows agents to continue working"},{"line_number":48,"context_line":"in cases where the hostname is also the registered agent name. This playbook is"},{"line_number":49,"context_line":"only needed for upgrades of existing nodes in-place and if a node is replaced or"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_7653b36b","line":46,"range":{"start_line":46,"start_character":5,"end_line":46,"end_character":14},"updated":"2016-06-01 05:50:51.000000000","message":"nit: this playbook","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"}],"playbooks/inventory/group_vars/hosts.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"937425c3f54670d0cf32c1fa831e03d1bd0f668a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"lxc_container_domain: \"{{ openstack_domain }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"## DHCP Domain Name"},{"line_number":97,"context_line":"dhcp_domain: \"{{ openstack_domain }}\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"## SSL: Keystone"},{"line_number":100,"context_line":"# These do not need to be configured unless you\u0027re creating certificates for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9abb7d3a_e8041cc1","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":12},"updated":"2016-05-31 08:53:59.000000000","message":"This is the domain name given to instances by nova \u0026 neutron. I don\u0027t think this should also be given to the back-end as well.","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2fe369124412b7ddb1b8d665920181705ff7a11c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"lxc_container_domain: \"{{ openstack_domain }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"## DHCP Domain Name"},{"line_number":97,"context_line":"dhcp_domain: \"{{ openstack_domain }}\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"## SSL: Keystone"},{"line_number":100,"context_line":"# These do not need to be configured unless you\u0027re creating certificates for"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9abb7d3a_fe115105","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":12},"in_reply_to":"9abb7d3a_e8041cc1","updated":"2016-05-31 17:07:57.000000000","message":"Done","commit_id":"b5a3109fd5a9220ad6397db82a50edcdd8c22e37"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c38b84230d412bbd6f98313a6643442e1cb4232d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"service_region: RegionOne"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"## OpenStack Domain"},{"line_number":93,"context_line":"openstack_domain: openstack.local"},{"line_number":94,"context_line":"lxc_container_domain: \"{{ openstack_domain }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"## DHCP Domain Name"},{"line_number":97,"context_line":"dhcp_domain: openstacklocal"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_97b28ce3","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":46},"updated":"2016-06-01 09:11:01.000000000","message":"I\u0027m not sure why we\u0027re introducing a new var which refers to another var. Why not just have lxc_container_domain with a value?","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b40f2987d60840e281dda540452f8e6f65be90b1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"service_region: RegionOne"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"## OpenStack Domain"},{"line_number":93,"context_line":"openstack_domain: openstack.local"},{"line_number":94,"context_line":"lxc_container_domain: \"{{ openstack_domain }}\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"## DHCP Domain Name"},{"line_number":97,"context_line":"dhcp_domain: openstacklocal"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_20fef8ad","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":46},"in_reply_to":"9abb7d3a_97b28ce3","updated":"2016-06-01 09:58:48.000000000","message":"Now I see that https://review.openstack.org/323504 is related to this and it makes more sense.","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"}],"releasenotes/notes/RFC1034-5_hostname_upgrade-677da788600edbca.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c38b84230d412bbd6f98313a6643442e1cb4232d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - A new global variable has been created named"},{"line_number":4,"context_line":"    ``openstack_domain``. This variable has a default"},{"line_number":5,"context_line":"    value of \"openstack.local\" and the variables"},{"line_number":6,"context_line":"    ``lxc_container_domain``, and ``dhcp_domain`` have"},{"line_number":7,"context_line":"    been set to use the new global option."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_b798706b","line":7,"range":{"start_line":6,"start_character":28,"end_line":7,"end_character":42},"updated":"2016-06-01 09:11:01.000000000","message":"This is no longer true, and should not be true anyway as per my comments in a previous patch set.","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"}],"scripts/upgrade-utilities/playbooks/old-hostname-compatibility.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"43baef39238a6120c2ce8bf4fb27e7bd948a13c2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        - result2 | skipped"},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    rfc_1034_1035_name: \"{{ inventory_hostname | replace(\u0027_\u0027, \u0027-\u0027) }}\""},{"line_number":54,"context_line":"    domain_name: \"{{ openstack_domain|default(\u0027openstack.local\u0027) }}\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"- name: Set hostnames alias for RabbitMQ lookup compatibility"},{"line_number":57,"context_line":"  hosts: rabbitmq_all"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_bac975ae","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":68},"updated":"2016-06-01 09:21:15.000000000","message":"We\u0027re once again creating another var \u0027domain_name\u0027 instead of just using \u0027lxc_container_domain\u0027 from group_vars. Is this intentional? If openstack_domain is meant to be more universal (for hosts and containers) then I see the point of having that extra var in group_vars, but then why not simply use that here instead of instantiating yet another copy of it?","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b40f2987d60840e281dda540452f8e6f65be90b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        - result2 | skipped"},{"line_number":52,"context_line":"  vars:"},{"line_number":53,"context_line":"    rfc_1034_1035_name: \"{{ inventory_hostname | replace(\u0027_\u0027, \u0027-\u0027) }}\""},{"line_number":54,"context_line":"    domain_name: \"{{ openstack_domain|default(\u0027openstack.local\u0027) }}\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"- name: Set hostnames alias for RabbitMQ lookup compatibility"},{"line_number":57,"context_line":"  hosts: rabbitmq_all"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9abb7d3a_e0e51009","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":68},"in_reply_to":"9abb7d3a_bac975ae","updated":"2016-06-01 09:58:48.000000000","message":"With the context of https://review.openstack.org/323504 I now understand the use of \u0027openstack_domain\u0027 as a var. I still don\u0027t really get why we\u0027re instantiating yet another var here?","commit_id":"a797494deebebd2cf654fe0fdc928450d2aba2f6"}]}