)]}'
{"playbooks/inventory/dynamic_inventory.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2c4245a35285e228452900c701e9ff1c9419d840","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    :param config: ``dict``  User defined information"},{"line_number":687,"context_line":"    \"\"\""},{"line_number":688,"context_line":"    for key, value in container_skel.iteritems():"},{"line_number":689,"context_line":"        if \u0027contains\u0027 in value and \u0027belongs_to\u0027 in value:"},{"line_number":690,"context_line":"            for assignment in value[\u0027contains\u0027]:"},{"line_number":691,"context_line":"                for container_type in value[\u0027belongs_to\u0027]:"},{"line_number":692,"context_line":"                    _add_container_hosts("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_5027cab5","line":689,"updated":"2016-07-11 20:02:51.000000000","message":"Should this handle the case of None value as well since we are here? With YAML input, a variety of formats for \"no thanks\" makes sense to me.","commit_id":"1b15cc87d9f2bcf7afb601d68088282e8474ad3a"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"114c11d1a2e4f09588bdf6846e1f1730e1c3581e","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    :param config: ``dict``  User defined information"},{"line_number":687,"context_line":"    \"\"\""},{"line_number":688,"context_line":"    for key, value in container_skel.iteritems():"},{"line_number":689,"context_line":"        if \u0027contains\u0027 in value and \u0027belongs_to\u0027 in value:"},{"line_number":690,"context_line":"            for assignment in value[\u0027contains\u0027]:"},{"line_number":691,"context_line":"                for container_type in value[\u0027belongs_to\u0027]:"},{"line_number":692,"context_line":"                    _add_container_hosts("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c7494133","line":689,"in_reply_to":"1aa78d24_5027cab5","updated":"2016-07-11 20:30:47.000000000","message":"I\u0027d have to check, but that makes sense to me. At the very least a test case should be added around that. It may well behave that way now.","commit_id":"1b15cc87d9f2bcf7afb601d68088282e8474ad3a"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"2c4245a35285e228452900c701e9ff1c9419d840","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                        inventory,"},{"line_number":698,"context_line":"                        value.get(\u0027properties\u0027)"},{"line_number":699,"context_line":"                    )"},{"line_number":700,"context_line":"    else:"},{"line_number":701,"context_line":"        cidr_networks \u003d config.get(\u0027cidr_networks\u0027)"},{"line_number":702,"context_line":"        provider_queues \u003d {}"},{"line_number":703,"context_line":"        for net_name in cidr_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d078dac6","line":700,"updated":"2016-07-11 20:02:51.000000000","message":"What about when contains without belongs_to? Is that an info / warning / error condition worth noting? Maybe a lint-level condition?\n\nWhat about belongs_to without contains? Might be worth linting that too?","commit_id":"1b15cc87d9f2bcf7afb601d68088282e8474ad3a"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"114c11d1a2e4f09588bdf6846e1f1730e1c3581e","unresolved":false,"context_lines":[{"line_number":697,"context_line":"                        inventory,"},{"line_number":698,"context_line":"                        value.get(\u0027properties\u0027)"},{"line_number":699,"context_line":"                    )"},{"line_number":700,"context_line":"    else:"},{"line_number":701,"context_line":"        cidr_networks \u003d config.get(\u0027cidr_networks\u0027)"},{"line_number":702,"context_line":"        provider_queues \u003d {}"},{"line_number":703,"context_line":"        for net_name in cidr_networks:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a73eb588","line":700,"in_reply_to":"1aa78d24_d078dac6","updated":"2016-07-11 20:30:47.000000000","message":"Good points here - I\u0027ll need to review existing configurations to see what we currently have. It could probably be changed to use an \u0027or\u0027 at the very least.","commit_id":"1b15cc87d9f2bcf7afb601d68088282e8474ad3a"}]}