)]}'
{"playbooks/inventory/group_vars/repo_all.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1037d2fe351630502c541f702999b2b032feee77","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The folder on the repo container\u0027s host which will hold"},{"line_number":39,"context_line":"# the git clones via the container-host bind-mount"},{"line_number":40,"context_line":"repo_build_git_bind_mount: \"/openstack/{{ inventory_hostname }}{{ repo_build_git_dir | replace(repo_service_home_folder, \u0027\u0027) }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# The appropriate user:group names for the repo_build_git_dir"},{"line_number":43,"context_line":"# folder/file attributes."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_be2429af","line":40,"range":{"start_line":40,"start_character":63,"end_line":40,"end_character":128},"updated":"2016-08-22 11:48:53.000000000","message":"There could be some variable simplification to avoid the filter replace, but that\u0027s fine. It\u0027s just harder to read.\n\nGiving an example in comment to show how it looks like would be good:\n#repo_build_git_bind_mount: \"/openstack/container1/repo/openstackgit\"","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1cadaf3574e80abebcb0f66e529ab2d1b0141b48","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# The folder on the repo container\u0027s host which will hold"},{"line_number":39,"context_line":"# the git clones via the container-host bind-mount"},{"line_number":40,"context_line":"repo_build_git_bind_mount: \"/openstack/{{ inventory_hostname }}{{ repo_build_git_dir | replace(repo_service_home_folder, \u0027\u0027) }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# The appropriate user:group names for the repo_build_git_dir"},{"line_number":43,"context_line":"# folder/file attributes."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_84eda027","line":40,"range":{"start_line":40,"start_character":63,"end_line":40,"end_character":128},"in_reply_to":"1ac06dbe_be2429af","updated":"2016-08-22 12:11:00.000000000","message":"Yeah, I didn\u0027t want to create another var which someone may try to override. I opted instead to just use the standard vars.","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"}],"playbooks/repo-build.yml":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"5f964f333b2af6b991928f9b39bf8c8318ff8ee5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      local_action: shell"},{"line_number":61,"context_line":"        ls -1A {{ repo_build_git_bind_mount }}"},{"line_number":62,"context_line":"      register: _local_repo_bind_mount_contents"},{"line_number":63,"context_line":"      when:"},{"line_number":64,"context_line":"        - repo_build_git_cache is defined"},{"line_number":65,"context_line":"        - _local_git_cache.stat.exists"},{"line_number":66,"context_line":"        - _local_repo_bind_mount.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3ac371cc_994d679c","line":63,"updated":"2016-08-18 19:05:19.000000000","message":"These conditionals get really hard to read and reason about at this point due to the sheer number of different variables referenced. Could they be simplified a little?\n\ne.g. remove (\"repo_build_git_cache is defined\" and \"_local_git_cache.stat.exists\") and add \"_local_repo_bind_mount is defined\" instead\n\nthe pattern could be used to trim the list of conditions for the following task(s) as well","commit_id":"c080b9613ba1088bc7206e0d242ca38d7d71f2cb"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1037d2fe351630502c541f702999b2b032feee77","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        module: stat"},{"line_number":46,"context_line":"        path: \"{{ repo_build_git_cache }}\""},{"line_number":47,"context_line":"      register: _local_git_cache"},{"line_number":48,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Check if deployment host has the repo container bind mount"},{"line_number":51,"context_line":"      local_action:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_83be3ad2","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":43},"updated":"2016-08-22 11:48:53.000000000","message":"To avoid issues with ppl running this on nodes that are resynced by lsyncd, we should probably do that on the first repo node only.\n\nwhen:\n  - repo_build_git_cache is defined\n  - inventory_hostname \u003d\u003d groups[\u0027repo_all\u0027][0]","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1cadaf3574e80abebcb0f66e529ab2d1b0141b48","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        module: stat"},{"line_number":46,"context_line":"        path: \"{{ repo_build_git_cache }}\""},{"line_number":47,"context_line":"      register: _local_git_cache"},{"line_number":48,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Check if deployment host has the repo container bind mount"},{"line_number":51,"context_line":"      local_action:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_2404ac48","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":43},"in_reply_to":"1ac06dbe_83be3ad2","updated":"2016-08-22 12:11:00.000000000","message":"In this particular task this isn\u0027t necessary.","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1037d2fe351630502c541f702999b2b032feee77","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      register: _local_git_cache"},{"line_number":48,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Check if deployment host has the repo container bind mount"},{"line_number":51,"context_line":"      local_action:"},{"line_number":52,"context_line":"        module: stat"},{"line_number":53,"context_line":"        path: \"{{ repo_build_git_bind_mount }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_63505e5e","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":70},"updated":"2016-08-22 11:48:53.000000000","message":"Check if deployment host holds first repo_container bind mount","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1cadaf3574e80abebcb0f66e529ab2d1b0141b48","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      register: _local_git_cache"},{"line_number":48,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Check if deployment host has the repo container bind mount"},{"line_number":51,"context_line":"      local_action:"},{"line_number":52,"context_line":"        module: stat"},{"line_number":53,"context_line":"        path: \"{{ repo_build_git_bind_mount }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_a4bd3c6a","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":70},"in_reply_to":"1ac06dbe_63505e5e","updated":"2016-08-22 12:11:00.000000000","message":"Good call - done.","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1037d2fe351630502c541f702999b2b032feee77","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      when:"},{"line_number":63,"context_line":"        - _local_repo_bind_mount.stat.exists"},{"line_number":64,"context_line":"        - not _local_repo_bind_mount.stat.islnk"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    - name: Remove the bind mounted git directory so we can symlink the cache folder to replace it"},{"line_number":67,"context_line":"      local_action:"},{"line_number":68,"context_line":"        module: file"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1ac06dbe_c3d5d2b9","line":65,"updated":"2016-08-22 11:48:53.000000000","message":"same condition all the way above.","commit_id":"f9eda17042a31a8b9956a3114d05a6fe90caf9f8"}]}