)]}'
{"playbooks/os-nova-install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"79fba9214c8a3402e068dde71e07b8a004f8c912","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        key: nova_{{ nova_virt_type }}_hypervisors"},{"line_number":193,"context_line":"      tags: nova-lxd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    - name: Add lxd hosts to lxd remotes"},{"line_number":196,"context_line":"      shell:"},{"line_number":197,"context_line":"        \"lxc remote add {{ hostvars[item][\u0027ansible_nodename\u0027] }} \\"},{"line_number":198,"context_line":"         https://{{ hostvars[item][\u0027ansible_\u0027 + hostvars[item][\u0027management_bridge\u0027] | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ lxd_bind_port | default(\u00278443\u0027) }} \\"},{"line_number":199,"context_line":"         --accept-certificate --password\u003d{{ lxd_trust_password }}\""},{"line_number":200,"context_line":"      with_items:"},{"line_number":201,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":202,"context_line":"      when:"},{"line_number":203,"context_line":"        - \"\u0027nova_lxc_hypervisors\u0027 in  group_names\""},{"line_number":204,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":205,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":206,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_a7c79243","line":206,"range":{"start_line":195,"start_character":0,"end_line":206,"end_character":36},"updated":"2016-08-05 21:58:10.000000000","message":"couldn\u0027t these tasks be added to [ https://review.openstack.org/#/c/346984/13/tasks/nova_compute_lxd.yml@42 ]?","commit_id":"80a0eb329afd835ab0b830e3bbec1b4fec294956"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"10166da321e31b34268778754091c4cc07a27a6d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    nova_rabbitmq_use_ssl: \"{{ rabbitmq_use_ssl }}\""},{"line_number":185,"context_line":"    pip_lock_to_internal_repo: \"{{ (pip_links | length) \u003e\u003d 1 }}\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"- name: Add lxd remotes"},{"line_number":188,"context_line":"  hosts: nova_compute"},{"line_number":189,"context_line":"  tasks:"},{"line_number":190,"context_line":"    - name: Group hypervisors by type"},{"line_number":191,"context_line":"      group_by:"},{"line_number":192,"context_line":"        key: nova_{{ nova_virt_type }}_hypervisors"},{"line_number":193,"context_line":"      tags: nova-lxd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    - name: Add lxd hosts to lxd remotes"},{"line_number":196,"context_line":"      shell:"},{"line_number":197,"context_line":"        \"lxc remote add {{ hostvars[item][\u0027ansible_nodename\u0027] }} \\"},{"line_number":198,"context_line":"         https://{{ hostvars[item][\u0027ansible_\u0027 + hostvars[item][\u0027management_bridge\u0027] | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ lxd_bind_port | default(\u00278443\u0027) }} \\"},{"line_number":199,"context_line":"         --accept-certificate --password\u003d{{ lxd_trust_password }}\""},{"line_number":200,"context_line":"      with_items:"},{"line_number":201,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":202,"context_line":"      when:"},{"line_number":203,"context_line":"        - \"\u0027nova_lxc_hypervisors\u0027 in  group_names\""},{"line_number":204,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":205,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":206,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_0cc7a564","line":206,"range":{"start_line":187,"start_character":0,"end_line":206,"end_character":36},"updated":"2016-08-05 21:23:05.000000000","message":"this is a fine set of tasks however I think it should be added to the os_nova role in an lxd subsection which is only included when those constraints are met.","commit_id":"80a0eb329afd835ab0b830e3bbec1b4fec294956"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"55b489cd623cf8d0cb9abaf401162c134b3f54b8","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    nova_rabbitmq_use_ssl: \"{{ rabbitmq_use_ssl }}\""},{"line_number":185,"context_line":"    pip_lock_to_internal_repo: \"{{ (pip_links | length) \u003e\u003d 1 }}\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"- name: Add lxd remotes"},{"line_number":188,"context_line":"  hosts: nova_compute"},{"line_number":189,"context_line":"  tasks:"},{"line_number":190,"context_line":"    - name: Group hypervisors by type"},{"line_number":191,"context_line":"      group_by:"},{"line_number":192,"context_line":"        key: nova_{{ nova_virt_type }}_hypervisors"},{"line_number":193,"context_line":"      tags: nova-lxd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    - name: Add lxd hosts to lxd remotes"},{"line_number":196,"context_line":"      shell:"},{"line_number":197,"context_line":"        \"lxc remote add {{ hostvars[item][\u0027ansible_nodename\u0027] }} \\"},{"line_number":198,"context_line":"         https://{{ hostvars[item][\u0027ansible_\u0027 + hostvars[item][\u0027management_bridge\u0027] | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ lxd_bind_port | default(\u00278443\u0027) }} \\"},{"line_number":199,"context_line":"         --accept-certificate --password\u003d{{ lxd_trust_password }}\""},{"line_number":200,"context_line":"      with_items:"},{"line_number":201,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":202,"context_line":"      when:"},{"line_number":203,"context_line":"        - \"\u0027nova_lxc_hypervisors\u0027 in  group_names\""},{"line_number":204,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":205,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":206,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_676f5ac4","line":206,"range":{"start_line":187,"start_character":0,"end_line":206,"end_character":36},"in_reply_to":"bacf61ea_0cc7a564","updated":"2016-08-05 21:44:54.000000000","message":"I would prefer to have this there, but I just don\u0027t think it\u0027s a good fit.\n\nEach server has to be alive for this to work, and it needs to be executed on each host.\n\nI feel like putting the logic here, the task is pretty straight forward and easy to maintain.  Putting the logic inside the role would still require a task called from the outside (how else do we know everything is finished?), and some sort of tag.","commit_id":"80a0eb329afd835ab0b830e3bbec1b4fec294956"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"66000edbff7045cb68527ab07cac6719b1243d3d","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        key: nova_{{ nova_virt_type }}_hypervisors"},{"line_number":193,"context_line":"      tags: nova-lxd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    - name: Add lxd hosts to lxd remotes"},{"line_number":196,"context_line":"      shell:"},{"line_number":197,"context_line":"        \"lxc remote add {{ hostvars[item][\u0027ansible_nodename\u0027] }} \\"},{"line_number":198,"context_line":"         https://{{ hostvars[item][\u0027ansible_\u0027 + hostvars[item][\u0027management_bridge\u0027] | replace(\u0027-\u0027, \u0027_\u0027)][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ lxd_bind_port | default(\u00278443\u0027) }} \\"},{"line_number":199,"context_line":"         --accept-certificate --password\u003d{{ lxd_trust_password }}\""},{"line_number":200,"context_line":"      with_items:"},{"line_number":201,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":202,"context_line":"      when:"},{"line_number":203,"context_line":"        - \"\u0027nova_lxc_hypervisors\u0027 in  group_names\""},{"line_number":204,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":205,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":206,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ac371cc_cb596200","line":206,"range":{"start_line":195,"start_character":0,"end_line":206,"end_character":36},"in_reply_to":"bacf61ea_a7c79243","updated":"2016-08-16 15:41:54.000000000","message":"No, this task is dependent upon all lxd hypervisors being initialized.","commit_id":"80a0eb329afd835ab0b830e3bbec1b4fec294956"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f36b68ce48b2b81cf79fce7b42b9a248f847f3da","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    - name: create groups"},{"line_number":192,"context_line":"      group_by:"},{"line_number":193,"context_line":"        key: nova_{{ nova_virt_type }}_hypervisors"},{"line_number":194,"context_line":"      tags: nova-lxd"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- name: Enable nova-lxd live migration"},{"line_number":197,"context_line":"  hosts: nova_lxc_hypervisors"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_0ded9e8e","line":194,"updated":"2016-08-24 19:04:31.000000000","message":"Nit - This tag isn\u0027t particularly relevant given that this has uses beyond lxd","commit_id":"cef9767be9f93230bf82a8245951ae432e4d54cc"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f36b68ce48b2b81cf79fce7b42b9a248f847f3da","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      with_items:"},{"line_number":205,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":206,"context_line":"      when:"},{"line_number":207,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":208,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":209,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_6dfed239","line":207,"updated":"2016-08-24 19:04:31.000000000","message":"No longer necessary","commit_id":"cef9767be9f93230bf82a8245951ae432e4d54cc"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"f36b68ce48b2b81cf79fce7b42b9a248f847f3da","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        \"{{ groups[\u0027nova_lxc_hypervisors\u0027] }}\""},{"line_number":206,"context_line":"      when:"},{"line_number":207,"context_line":"        - \"inventory_hostname in groups[\u0027nova_lxc_hypervisors\u0027]\""},{"line_number":208,"context_line":"        - groups[\u0027nova_lxc_hypervisors\u0027] | length \u003e 1"},{"line_number":209,"context_line":"        - item !\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1ac06dbe_6d8532ac","line":208,"updated":"2016-08-24 19:04:31.000000000","message":"No longer necessary","commit_id":"cef9767be9f93230bf82a8245951ae432e4d54cc"}]}
