)]}'
{"playbooks/repo-build.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35a064e014f3e56cf463ef9e868d888bc7cba30b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_f5e5c208","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"updated":"2016-08-01 13:11:42.000000000","message":"This forces the use of pypi and will ignore extra indexes. This is not a good idea.","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bcbfed2a84aad8a6300e174f89e5dda76529babd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_714effc1","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_3be1082e","updated":"2016-08-01 15:05:51.000000000","message":"Hmm, clearly my brain is broken today. Sorry. :/\n\nSo thinking this through properly - this forces the pip install of all python packages to come from pypi, even if the repo server actually does have the packages. I guess this is a small price to pay.\n\nI need to think through whether there may be other repercussions here.","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cd68cf9d1a2e268850658a7ad0977f39af77a368","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_e0569f04","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_47722512","updated":"2016-08-01 14:04:57.000000000","message":"Hmm, you\u0027re right that this doesn\u0027t affect the repo build. It only affects the installation of python wheels in preparation for the repo build.\n\nThe down side here is that if an internal mirror is used to install from, this will force installation from pypi instead of that internal mirror. This will create a security issue for some environments where the internal mirrors are specifically used to prevent hosts accessing the internet.\n\nThere needs to be another solution for getting the mariadb client packages onto the repo server. I\u0027m thinking that it\u0027ll be simpler to just add the tasks to make it happen instead of trying to use the role.","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"25a3acd8cf79ac8fc3dc8d9c46b75aa6015a57f7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_b2cfd654","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_714effc1","updated":"2016-08-01 15:33:28.000000000","message":"Not all python packages, just the packages installed here:\nhttps://github.com/openstack/openstack-ansible/blob/liberty/playbooks/roles/repo_build/tasks/repo_build_install.yml#L17\n\nThis is the only place in the repo_build role that uses pip_install_options. \n\nIf a deployer is choosing to use an internal repo for installing these packages, then they would *have* to override pip_install_options in a more global level(user_variables).","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"92cf369c4d5fdc756d1f0bd0310952b7f3828279","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_15816c8f","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_95e71cab","updated":"2016-08-01 15:49:24.000000000","message":"Forget it.","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2da70c321537da8ea0767cfd920167a6ef29b105","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_95e71cab","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_b2cfd654","updated":"2016-08-01 15:47:19.000000000","message":"is is thinkable to put the pip_install_options/no-index as a galera_client role variable here above instead of a playbook variable?","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"d50eebb24784f0299a64c1a86b879921e55a18ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_3be1082e","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_e0569f04","updated":"2016-08-01 14:24:09.000000000","message":"If an internal mirror was used, wouldn\u0027t they have to override pip_install_options at a more global level(user_variables) to add that internal mirror? Negating what\u0027s in place here?\n\nAdding the tasks needed to install the galera_client packages would require adding all of these tasks[1]. Additionally, it would require moving over the templates that they use.\n[1] https://github.com/openstack/openstack-ansible/blob/liberty/playbooks/roles/galera_client/tasks/galera_client_pre_install.yml#L16-L81","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"},{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"1e878b7a6ee3e3dc4ad6320c8b01970cafee9b9a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - \"repo-build\""},{"line_number":46,"context_line":"  vars:"},{"line_number":47,"context_line":"    pip_no_index: false"},{"line_number":48,"context_line":"    pip_install_options: \"--isolated\""},{"line_number":49,"context_line":"    pkg_locations:"},{"line_number":50,"context_line":"      - ../"},{"line_number":51,"context_line":"      - /etc/ansible/roles"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bacf61ea_47722512","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":37},"in_reply_to":"bacf61ea_f5e5c208","updated":"2016-08-01 13:30:22.000000000","message":"Specifying extra indices for pip packages(pip packages that need to be installed before the repo server builds the wheels) would require this variable to be overridden in user_variables, no? If it\u0027s overridden, then we don\u0027t need to worry about the --isolated causing the problem that you mentioned.","commit_id":"53f446e3d72720a5b00e275c5948504c5ab650a0"}]}
