)]}'
{"playbooks/common-tasks/os-lxc-container-setup.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#  If extra container configurations are desirable set the"},{"line_number":28,"context_line":"#  \"extra_container_config\" list to strings containing the options needed."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set default bind mounds"},{"line_number":31,"context_line":"  set_fact:"},{"line_number":32,"context_line":"    lxc_default_bind_mounts:"},{"line_number":33,"context_line":"      - bind_dir_path: \"/var/log\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_dfc64c15","line":30,"range":{"start_line":30,"start_character":29,"end_line":30,"end_character":30},"updated":"2016-08-25 14:07:01.000000000","message":"t","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"671a002f2926e7fef9a1f6202404176325c3b747","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#  If extra container configurations are desirable set the"},{"line_number":28,"context_line":"#  \"extra_container_config\" list to strings containing the options needed."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set default bind mounds"},{"line_number":31,"context_line":"  set_fact:"},{"line_number":32,"context_line":"    lxc_default_bind_mounts:"},{"line_number":33,"context_line":"      - bind_dir_path: \"/var/log\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_f5cc0463","line":30,"range":{"start_line":30,"start_character":29,"end_line":30,"end_character":30},"in_reply_to":"1ac06dbe_dfc64c15","updated":"2016-08-25 15:43:04.000000000","message":"Done","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0f6f2d00906fa4868cfcd3aac931ddf025b80dca","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    - not is_metal | bool"},{"line_number":85,"context_line":"  register: _ec"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: LXC container restart on config change"},{"line_number":88,"context_line":"  lxc_container:"},{"line_number":89,"context_line":"    name: \"{{ inventory_hostname }}\""},{"line_number":90,"context_line":"    state: restarted"},{"line_number":91,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":92,"context_line":"  register: _bm"},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - not is_metal | bool"},{"line_number":95,"context_line":"    - (_mc is defined and _mc | changed) or (_ec is defined and _ec | changed)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- name: Wait for container ssh"},{"line_number":98,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_bf65501e","line":95,"range":{"start_line":87,"start_character":0,"end_line":95,"end_character":78},"updated":"2016-08-25 14:02:44.000000000","message":"It\u0027d be better to stop/start with the logging enabled for debugging purposes as we do here: https://github.com/openstack/openstack-ansible-lxc_container_create/blob/master/handlers/main.yml","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  register: _bm"},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - not is_metal | bool"},{"line_number":95,"context_line":"    - (_mc is defined and _mc | changed) or (_ec is defined and _ec | changed)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"- name: Wait for container ssh"},{"line_number":98,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_df62cc15","line":95,"range":{"start_line":95,"start_character":7,"end_line":95,"end_character":10},"updated":"2016-08-25 14:07:01.000000000","message":"Longer, more descriptive var naming would be very much appreciated","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8f5817a124f073d5c0694f9309928fe8058ae1d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    lxc-stop --name {{ inventory_hostname }}"},{"line_number":93,"context_line":"    --logfile {{ lxc_container_log_path }}/lxc-{{ inventory_hostname }}.log"},{"line_number":94,"context_line":"    --logpriority {{ (debug | bool) | ternary(\u0027DEBUG\u0027, \u0027INFO\u0027) }}"},{"line_number":95,"context_line":"  notify:"},{"line_number":96,"context_line":"    - Start Container"},{"line_number":97,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":98,"context_line":"  when:"},{"line_number":99,"context_line":"    - not is_metal | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1ac06dbe_3abfaefd","line":96,"range":{"start_line":95,"start_character":0,"end_line":96,"end_character":21},"updated":"2016-08-25 14:09:18.000000000","message":"This needs to be removed.","commit_id":"4907062c111eefe025b2d431ac68ece744629db4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":45,"context_line":"  when:"},{"line_number":46,"context_line":"    - list_of_bind_mounts is defined"},{"line_number":47,"context_line":"    - not is_metal | bool"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: LXC bind mount directories"},{"line_number":50,"context_line":"  lxc_container:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_34ffc102","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":25},"updated":"2016-08-26 13:05:44.000000000","message":"Why not block the include on this conditional instead of repeating it on every task?","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    - \"{{ list_of_bind_mounts | default([]) }}\""},{"line_number":56,"context_line":"    - \"{{ lxc_default_bind_mounts }}\""},{"line_number":57,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":58,"context_line":"  register: _bm"},{"line_number":59,"context_line":"  when:"},{"line_number":60,"context_line":"    - list_of_bind_mounts is defined"},{"line_number":61,"context_line":"    - not is_metal | bool"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_394a5c84","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":15},"updated":"2016-08-26 13:05:44.000000000","message":"As per Travis\u0027 comments in PS17 - a more descriptive name would be better. Suggestion \u0027_bind_mount_command_result\u0027.","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  when:"},{"line_number":73,"context_line":"    - list_of_bind_mounts is defined"},{"line_number":74,"context_line":"    - not is_metal | bool"},{"line_number":75,"context_line":"  register: _mc"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Extra lxc config"},{"line_number":78,"context_line":"  lineinfile:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_19a8381f","line":75,"range":{"start_line":75,"start_character":12,"end_line":75,"end_character":15},"updated":"2016-08-26 13:05:44.000000000","message":"As per Travis\u0027 comments in PS17 - a more descriptive name would be better. Suggestion \u0027_bind_mount_config_result\u0027.","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    backup: \"true\""},{"line_number":83,"context_line":"  with_items: \"{{ extra_container_config }}\""},{"line_number":84,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":85,"context_line":"  register: _ec"},{"line_number":86,"context_line":"  when:"},{"line_number":87,"context_line":"    - extra_container_config is defined"},{"line_number":88,"context_line":"    - not is_metal | bool"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_199118f1","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":15},"updated":"2016-08-26 13:05:44.000000000","message":"As per Travis\u0027 comments in PS17 - a more descriptive name would be better. Suggestion \u0027_extra_container_config_result\u0027.","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":93,"context_line":"- name: Lxc container restart"},{"line_number":94,"context_line":"  command: \u003e"},{"line_number":95,"context_line":"    lxc-stop --name {{ inventory_hostname }}"},{"line_number":96,"context_line":"    --logfile {{ lxc_container_log_path }}/lxc-{{ inventory_hostname }}.log"},{"line_number":97,"context_line":"    --logpriority {{ (debug | bool) | ternary(\u0027DEBUG\u0027, \u0027INFO\u0027) }}"},{"line_number":98,"context_line":"  delegate_to: \"{{ physical_host }}\""},{"line_number":99,"context_line":"  register: container_stop"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_94cfadaf","line":96,"range":{"start_line":96,"start_character":17,"end_line":96,"end_character":39},"updated":"2016-08-26 13:05:44.000000000","message":"This variable is not known to the playbook.","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"}],"playbooks/galera-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e2fef4eafdc72a7b0a41514c3b033b686d6f16e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      vars:"},{"line_number":24,"context_line":"        list_of_bind_mounts:"},{"line_number":25,"context_line":"          - bind_dir_path: \"/var/log\""},{"line_number":26,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}/log\""},{"line_number":27,"context_line":"          - bind_dir_path: \"/var/lib/mysql\""},{"line_number":28,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":29,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_acaeab2b","line":26,"range":{"start_line":26,"start_character":25,"end_line":26,"end_character":64},"updated":"2016-08-04 14:04:38.000000000","message":"this should be /openstack/log/{{ inventory_hostname }}","commit_id":"5f55587903850d86a34a02c01fd65ae8059706bc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"19321cef757a733ba29551c153f3616caad631ed","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      vars:"},{"line_number":24,"context_line":"        list_of_bind_mounts:"},{"line_number":25,"context_line":"          - bind_dir_path: \"/var/log\""},{"line_number":26,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}/log\""},{"line_number":27,"context_line":"          - bind_dir_path: \"/var/lib/mysql\""},{"line_number":28,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":29,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bacf61ea_475f08e5","line":26,"range":{"start_line":26,"start_character":25,"end_line":26,"end_character":64},"in_reply_to":"bacf61ea_acaeab2b","updated":"2016-08-04 14:11:16.000000000","message":"while that\u0027s what we had before in the liberty time frame I think it\u0027d be better for us to bind to a segmented directory instead of overloading \"/openstack/{{ inventory_hostname }}\" which is already the bind path for things like \"/var/lib/mysql\".","commit_id":"5f55587903850d86a34a02c01fd65ae8059706bc"}],"playbooks/inventory/group_vars/repo_all.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"df760d50f1ab7ec1964a7da1fb76f8690db263f0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"repo_server_package_state: \"{{ package_state }}\""},{"line_number":18,"context_line":"repo_build_package_state: \"{{ package_state }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# The default bind mount to hold the repo data"},{"line_number":21,"context_line":"repo_all_lxc_container_bind_mounts:"},{"line_number":22,"context_line":"  - mount_path: \"/openstack/log/{{ inventory_hostname }}\""},{"line_number":23,"context_line":"    bind_dir_path: \"/var/log\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1ac06dbe_9da349b1","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"updated":"2016-08-25 11:30:23.000000000","message":"This comment should now move down to the second dict in the list","commit_id":"b94d0982d42b4d72ecff9aa90357e444ced022eb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4b752e920a94e6ed1fddebbb072e3197306fe99d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"repo_server_package_state: \"{{ package_state }}\""},{"line_number":18,"context_line":"repo_build_package_state: \"{{ package_state }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# The default bind mount to hold the repo data"},{"line_number":21,"context_line":"repo_all_lxc_container_bind_mounts:"},{"line_number":22,"context_line":"  - mount_path: \"/openstack/log/{{ inventory_hostname }}\""},{"line_number":23,"context_line":"    bind_dir_path: \"/var/log\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1ac06dbe_e62589ae","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":1},"in_reply_to":"1ac06dbe_9da349b1","updated":"2016-08-25 13:22:47.000000000","message":"Done","commit_id":"b94d0982d42b4d72ecff9aa90357e444ced022eb"}],"playbooks/repo-server.yml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":38,"context_line":"      vars:"},{"line_number":39,"context_line":"        repo_build_git_cache_bind_mount:"},{"line_number":40,"context_line":"          - mount_path: \"{{ repo_build_git_cache }}\""},{"line_number":41,"context_line":"            bind_dir_path: \"{{ repo_build_git_cache }}\""},{"line_number":42,"context_line":"        list_of_bind_mounts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_1f12a462","line":39,"updated":"2016-08-25 14:07:01.000000000","message":"Why is this defined twice?","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"671a002f2926e7fef9a1f6202404176325c3b747","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":38,"context_line":"      vars:"},{"line_number":39,"context_line":"        repo_build_git_cache_bind_mount:"},{"line_number":40,"context_line":"          - mount_path: \"{{ repo_build_git_cache }}\""},{"line_number":41,"context_line":"            bind_dir_path: \"{{ repo_build_git_cache }}\""},{"line_number":42,"context_line":"        list_of_bind_mounts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_35a97c7c","line":39,"in_reply_to":"1ac06dbe_1f12a462","updated":"2016-08-25 15:43:04.000000000","message":"we only want to call the common task once and the inclusion of git cache is a conditional.","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"bf1d8cbfe6135b1bbb69907ed13beef2066a64be","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":38,"context_line":"      vars:"},{"line_number":39,"context_line":"        repo_build_git_cache_bind_mount:"},{"line_number":40,"context_line":"          - mount_path: \"{{ repo_build_git_cache }}\""},{"line_number":41,"context_line":"            bind_dir_path: \"{{ repo_build_git_cache }}\""},{"line_number":42,"context_line":"        list_of_bind_mounts:"},{"line_number":43,"context_line":"          - mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":44,"context_line":"            bind_dir_path: \"/var/www\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_59a640c2","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":55},"updated":"2016-08-26 13:05:44.000000000","message":"This should be removed as per Travis\u0027 comments in PS17","commit_id":"e5392cc3dee9b151183120b920835675f5e41e23"}],"playbooks/rsyslog-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6684a756fc3899f1592bd213cbde9eff4fdc1a74","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":23,"context_line":"      vars:"},{"line_number":24,"context_line":"        list_of_bind_mounts:"},{"line_number":25,"context_line":"          - bind_dir_path: \"/var/log\""},{"line_number":26,"context_line":"            mount_path: \"/openstack/log/{{ inventory_hostname }}\""},{"line_number":27,"context_line":"          - bind_dir_path: \"{{ storage_directory }}\""},{"line_number":28,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}/log-storage\""},{"line_number":29,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":30,"context_line":"  roles:"},{"line_number":31,"context_line":"    - { role: \"rsyslog_server\", tags: [ \"rsyslog-server\" ] }"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ac06dbe_5668a7f5","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":73},"updated":"2016-08-20 15:59:43.000000000","message":"These two bind mounts interfere with each other, causing the container start to fail.","commit_id":"2446b5f90a26edebee81884580865f3a545996ec"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"16ba0b2694e48d6077eca3936ed325b5acdbdea8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  pre_tasks:"},{"line_number":22,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":23,"context_line":"      vars:"},{"line_number":24,"context_line":"        list_of_bind_mounts:"},{"line_number":25,"context_line":"          - bind_dir_path: \"{{ storage_directory }}\""},{"line_number":26,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}/log-storage\""},{"line_number":27,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: \"rsyslog_server\", tags: [ \"rsyslog-server\" ] }"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_d4793531","side":"PARENT","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":73},"updated":"2016-08-26 13:09:31.000000000","message":"This is a fairly drastic move - we\u0027re shifting the placement of all the aggregated log data on the host from  /openstack/{{ inventory_hostname }}/log-storage to /openstack/log/{{ inventory_hostname }}/log-storage.\n\nThis should be specifically release noted if that\u0027s the intent as this is a change of default which should be highlighted for upgrades.","commit_id":"ebb2404fbcbdf39d0cf852baa987e5722fde33bc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5c35c0a011e81297d35d9df7acf220910cc93ac7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  pre_tasks:"},{"line_number":22,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":23,"context_line":"      vars:"},{"line_number":24,"context_line":"        list_of_bind_mounts:"},{"line_number":25,"context_line":"          - bind_dir_path: \"{{ storage_directory }}\""},{"line_number":26,"context_line":"            mount_path: \"/openstack/{{ inventory_hostname }}/log-storage\""},{"line_number":27,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":28,"context_line":"  roles:"},{"line_number":29,"context_line":"    - { role: \"rsyslog_server\", tags: [ \"rsyslog-server\" ] }"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"fa7ab95a_267aa977","side":"PARENT","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":73},"in_reply_to":"fa7ab95a_d4793531","updated":"2016-08-30 02:57:35.000000000","message":"good catch. replacing.","commit_id":"ebb2404fbcbdf39d0cf852baa987e5722fde33bc"}],"releasenotes/notes/bindmount-logs-3c23aab5b5ed3440.yaml":[{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    machine in the \"/openstack/log/{{ inventory_hostname }}\""},{"line_number":5,"context_line":"    location. This change will ensure containers using a block"},{"line_number":6,"context_line":"    backed file system (lvm, zfs, bfrfs) do not run into issues"},{"line_number":7,"context_line":"    with full file systems due to logging. "},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - When upgrading deployers will need to ensure they have a"},{"line_number":10,"context_line":"    backup of all logging from within the contianer prior to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_1a09122d","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"updated":"2016-08-25 14:07:01.000000000","message":"nit: remove trailing space","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"671a002f2926e7fef9a1f6202404176325c3b747","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    machine in the \"/openstack/log/{{ inventory_hostname }}\""},{"line_number":5,"context_line":"    location. This change will ensure containers using a block"},{"line_number":6,"context_line":"    backed file system (lvm, zfs, bfrfs) do not run into issues"},{"line_number":7,"context_line":"    with full file systems due to logging. "},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - When upgrading deployers will need to ensure they have a"},{"line_number":10,"context_line":"    backup of all logging from within the contianer prior to"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_581eed63","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":43},"in_reply_to":"1ac06dbe_1a09122d","updated":"2016-08-25 15:43:04.000000000","message":"Done","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    with full file systems due to logging. "},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - When upgrading deployers will need to ensure they have a"},{"line_number":10,"context_line":"    backup of all logging from within the contianer prior to"},{"line_number":11,"context_line":"    running the playbooks. If the logging node is present within"},{"line_number":12,"context_line":"    the deployment all logs should already be sync\u0027d with the"},{"line_number":13,"context_line":"    logging server and no action is required. As a pre-step it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_9a1d0269","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":51},"updated":"2016-08-25 14:07:01.000000000","message":"spelling","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"671a002f2926e7fef9a1f6202404176325c3b747","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    with full file systems due to logging. "},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - When upgrading deployers will need to ensure they have a"},{"line_number":10,"context_line":"    backup of all logging from within the contianer prior to"},{"line_number":11,"context_line":"    running the playbooks. If the logging node is present within"},{"line_number":12,"context_line":"    the deployment all logs should already be sync\u0027d with the"},{"line_number":13,"context_line":"    logging server and no action is required. As a pre-step it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_3819717a","line":10,"range":{"start_line":10,"start_character":42,"end_line":10,"end_character":51},"in_reply_to":"1ac06dbe_9a1d0269","updated":"2016-08-25 15:43:04.000000000","message":"Done","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":19814,"name":"Travis Truman (automagically)","email":"travis_truman@cable.comcast.com","username":"trumant"},"change_message_id":"2e4a560b18d3c5077b4356f6dd139ff2cc052c3e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - Due to a new bind mount at \"/var/log\" all containers will be"},{"line_number":20,"context_line":"    restarted. This is a required restart. It is recommended that"},{"line_number":21,"context_line":"    deployers run the container restarts in serial to not impact"},{"line_number":22,"context_line":"    production workloads."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_5a41ca38","line":22,"updated":"2016-08-25 14:07:01.000000000","message":"Given how big the upgrade impact is, let\u0027s get a bug in LaunchPad so we don\u0027t forget to address this with upgrade automation","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"671a002f2926e7fef9a1f6202404176325c3b747","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - Due to a new bind mount at \"/var/log\" all containers will be"},{"line_number":20,"context_line":"    restarted. This is a required restart. It is recommended that"},{"line_number":21,"context_line":"    deployers run the container restarts in serial to not impact"},{"line_number":22,"context_line":"    production workloads."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1ac06dbe_7850090b","line":22,"in_reply_to":"1ac06dbe_5a41ca38","updated":"2016-08-25 15:43:04.000000000","message":"Done","commit_id":"dcf2b2ef7b5e48c7d98b60bb74b0b4102f36a781"}],"scripts/scripts-library.sh":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e6a15179dace3503c7141e94716eb5228e85ef33","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  if [[ -d \"/etc/nodepool\" ]];then"},{"line_number":120,"context_line":"    GATE_LOG_DIR\u003d\"$(dirname \"${0}\")/../logs\""},{"line_number":121,"context_line":"    mkdir -p \"${GATE_LOG_DIR}\""},{"line_number":122,"context_line":"    rsync -av --ignore-errors /var/log/ /openstack/log/ \"${GATE_LOG_DIR}\" || true"},{"line_number":123,"context_line":"    chmod -R 0777 \"${GATE_LOG_DIR}\""},{"line_number":124,"context_line":"  fi"},{"line_number":125,"context_line":"  exit ${1}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1ac06dbe_024b912c","line":122,"range":{"start_line":122,"start_character":30,"end_line":122,"end_character":39},"updated":"2016-08-25 04:15:26.000000000","message":"Perhaps the host\u0027s /var/log content should go into its own folder? Perhaps /var/log/\u003chost name\u003e ?","commit_id":"8762442c1cb3b54b06bc7b684bfb4afa55c207be"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8fbae2ba9055e42b98dcf38d743b3b1d2f4de18","unresolved":false,"context_lines":[{"line_number":119,"context_line":"  if [[ -d \"/etc/nodepool\" ]];then"},{"line_number":120,"context_line":"    GATE_LOG_DIR\u003d\"$(dirname \"${0}\")/../logs\""},{"line_number":121,"context_line":"    mkdir -p \"${GATE_LOG_DIR}\""},{"line_number":122,"context_line":"    rsync -av --ignore-errors /var/log/ /openstack/log/ \"${GATE_LOG_DIR}\" || true"},{"line_number":123,"context_line":"    chmod -R 0777 \"${GATE_LOG_DIR}\""},{"line_number":124,"context_line":"  fi"},{"line_number":125,"context_line":"  exit ${1}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"1ac06dbe_4503d3b8","line":122,"range":{"start_line":122,"start_character":30,"end_line":122,"end_character":39},"in_reply_to":"1ac06dbe_024b912c","updated":"2016-08-25 04:37:24.000000000","message":"Done","commit_id":"8762442c1cb3b54b06bc7b684bfb4afa55c207be"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e6a15179dace3503c7141e94716eb5228e85ef33","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  else"},{"line_number":115,"context_line":"    info_block \"Status: Failure\""},{"line_number":116,"context_line":"  fi"},{"line_number":117,"context_line":"  # If this is a gate node from OpenStack-Infra Store all logs into the"},{"line_number":118,"context_line":"  #  execution directory after gate run."},{"line_number":119,"context_line":"  if [[ -d \"/etc/nodepool\" ]];then"},{"line_number":120,"context_line":"    GATE_LOG_DIR\u003d\"$(dirname \"${0}\")/../logs\""},{"line_number":121,"context_line":"    mkdir -p \"${GATE_LOG_DIR}\""},{"line_number":122,"context_line":"    rsync -av --ignore-errors /var/log/ /openstack/log/ \"${GATE_LOG_DIR}\" || true"},{"line_number":123,"context_line":"    chmod -R 0777 \"${GATE_LOG_DIR}\""},{"line_number":124,"context_line":"  fi"},{"line_number":125,"context_line":"  exit ${1}"},{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"1ac06dbe_a2f71df4","line":124,"range":{"start_line":117,"start_character":0,"end_line":124,"end_character":4},"updated":"2016-08-25 04:15:26.000000000","message":"It would seem that this actually should go into the gate_job_exit_tasks function?","commit_id":"8762442c1cb3b54b06bc7b684bfb4afa55c207be"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8fbae2ba9055e42b98dcf38d743b3b1d2f4de18","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  else"},{"line_number":115,"context_line":"    info_block \"Status: Failure\""},{"line_number":116,"context_line":"  fi"},{"line_number":117,"context_line":"  # If this is a gate node from OpenStack-Infra Store all logs into the"},{"line_number":118,"context_line":"  #  execution directory after gate run."},{"line_number":119,"context_line":"  if [[ -d \"/etc/nodepool\" ]];then"},{"line_number":120,"context_line":"    GATE_LOG_DIR\u003d\"$(dirname \"${0}\")/../logs\""},{"line_number":121,"context_line":"    mkdir -p \"${GATE_LOG_DIR}\""},{"line_number":122,"context_line":"    rsync -av --ignore-errors /var/log/ /openstack/log/ \"${GATE_LOG_DIR}\" || true"},{"line_number":123,"context_line":"    chmod -R 0777 \"${GATE_LOG_DIR}\""},{"line_number":124,"context_line":"  fi"},{"line_number":125,"context_line":"  exit ${1}"},{"line_number":126,"context_line":"}"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"1ac06dbe_852b0b33","line":124,"range":{"start_line":117,"start_character":0,"end_line":124,"end_character":4},"in_reply_to":"1ac06dbe_a2f71df4","updated":"2016-08-25 04:37:24.000000000","message":"Done","commit_id":"8762442c1cb3b54b06bc7b684bfb4afa55c207be"}]}