)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c5d3d518d5907ff9d1d48105514ef88ab077d6f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     FrankZhang \u003czxuuzx@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 19:15:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issue that only empty tasks array without shorten it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. Previous case only zero out tasks array but no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_32e32435","line":7,"updated":"2016-08-10 14:57:45.000000000","message":"Something like \u0027Print remaining tasks on failed upgrade\u0027 might be better","commit_id":"485c8668773297599354120b05c84ef3dbec14f0"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c5d3d518d5907ff9d1d48105514ef88ab077d6f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issue that only empty tasks array without shorten it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. Previous case only zero out tasks array but no"},{"line_number":11,"context_line":"removing empty entries which potentially cause playbook name"},{"line_number":12,"context_line":"misplaced in task list and failed in execution."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_92d2d05a","line":9,"updated":"2016-08-10 14:57:45.000000000","message":"stating the issue then what you did to solve would be better in the messge.\n\nsomething like this format is better imo.\n\u0027run-upgrade.sh originally printed out x, we change it to print out y for z reason\u0027","commit_id":"485c8668773297599354120b05c84ef3dbec14f0"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a49d50a3383837322ae3acbf08a5f782508a713c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issue that only empty tasks array without shorten it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. Previous case only zero out tasks array but no"},{"line_number":11,"context_line":"removing empty entries which potentially cause playbook name"},{"line_number":12,"context_line":"misplaced in task list and failed in execution."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_9232cb5d","line":10,"updated":"2016-08-10 16:19:33.000000000","message":"\u0027but no\u0027? should that be \u0027but not\u0027?","commit_id":"6268529b3aa411e0b9e79b88369437c92fb9bb8c"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a49d50a3383837322ae3acbf08a5f782508a713c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. Previous case only zero out tasks array but no"},{"line_number":11,"context_line":"removing empty entries which potentially cause playbook name"},{"line_number":12,"context_line":"misplaced in task list and failed in execution."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e33c43d55696bb91cb40ff590e167546f5f6d18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_f2334760","line":11,"updated":"2016-08-10 16:19:33.000000000","message":"should \u0027playbook name\u0027 be \u0027the playbook name to be\u0027","commit_id":"6268529b3aa411e0b9e79b88369437c92fb9bb8c"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a49d50a3383837322ae3acbf08a5f782508a713c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. Previous case only zero out tasks array but no"},{"line_number":11,"context_line":"removing empty entries which potentially cause playbook name"},{"line_number":12,"context_line":"misplaced in task list and failed in execution."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e33c43d55696bb91cb40ff590e167546f5f6d18"},{"line_number":15,"context_line":"Closes-Bug:1582272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_d238c33f","line":12,"updated":"2016-08-10 16:19:33.000000000","message":"should this be \u0027misplaced in task the task list and fail when executed\u0027?","commit_id":"6268529b3aa411e0b9e79b88369437c92fb9bb8c"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"8045caf05a17f296994513e884d143d65e31f909","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     FrankZhang \u003czxuuzx@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-10 16:30:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issue that only empty tasks array without shorten it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. The script will list the remaining and incompleted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_e858788c","line":7,"updated":"2016-08-10 16:57:52.000000000","message":"this line still needs work, while the tense of the title line is good saying \u0027fix\u0027 isn\u0027t helpful as every commit is a \u0027fix\u0027 for something.\n\nThat being said, it\u0027s not clear why this is actually fixing (from just the title), it seems like a verb is missing.","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"8045caf05a17f296994513e884d143d65e31f909","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issue that only empty tasks array without shorten it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. The script will list the remaining and incompleted"},{"line_number":11,"context_line":"tasks from the task array when failures happpened. Previous case"},{"line_number":12,"context_line":"only zero out tasks array but no removing empty entries which"},{"line_number":13,"context_line":"potentially causes playbook name mis-displayed in re-run list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_c85db47a","line":10,"updated":"2016-08-10 16:57:52.000000000","message":"place where it failed","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"8045caf05a17f296994513e884d143d65e31f909","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. The script will list the remaining and incompleted"},{"line_number":11,"context_line":"tasks from the task array when failures happpened. Previous case"},{"line_number":12,"context_line":"only zero out tasks array but no removing empty entries which"},{"line_number":13,"context_line":"potentially causes playbook name mis-displayed in re-run list."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_28573059","line":11,"updated":"2016-08-10 16:57:52.000000000","message":"when failures happen (not happened).\n\n\u0027In the previous case\u0027 instead of \u0027previous case\u0027","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"8045caf05a17f296994513e884d143d65e31f909","unresolved":false,"context_lines":[{"line_number":9,"context_line":"run-upgrade.sh should be designated to re-run and start from the"},{"line_number":10,"context_line":"place was failed. The script will list the remaining and incompleted"},{"line_number":11,"context_line":"tasks from the task array when failures happpened. Previous case"},{"line_number":12,"context_line":"only zero out tasks array but no removing empty entries which"},{"line_number":13,"context_line":"potentially causes playbook name mis-displayed in re-run list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e33c43d55696bb91cb40ff590e167546f5f6d18"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_0854ec50","line":12,"updated":"2016-08-10 16:57:52.000000000","message":"I don\u0027t know what this line means.","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"8045caf05a17f296994513e884d143d65e31f909","unresolved":false,"context_lines":[{"line_number":10,"context_line":"place was failed. The script will list the remaining and incompleted"},{"line_number":11,"context_line":"tasks from the task array when failures happpened. Previous case"},{"line_number":12,"context_line":"only zero out tasks array but no removing empty entries which"},{"line_number":13,"context_line":"potentially causes playbook name mis-displayed in re-run list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e33c43d55696bb91cb40ff590e167546f5f6d18"},{"line_number":16,"context_line":"Closes-Bug:1582272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_684da8c3","line":13,"updated":"2016-08-10 16:57:52.000000000","message":"playbook name to be mis-displayed","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"242c5c4dcda66efb1e367203039c72a8eae997dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"tasks from the task array when failures happpened. Previous case"},{"line_number":12,"context_line":"only zero out tasks array but no removing empty entries which"},{"line_number":13,"context_line":"potentially causes playbook name mis-displayed in re-run list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2e33c43d55696bb91cb40ff590e167546f5f6d18"},{"line_number":16,"context_line":"Closes-Bug:1582272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_41a6bf53","line":14,"updated":"2016-08-10 18:12:40.000000000","message":"previous behavior is to print the entire run list.  This prints tasks that have successfuly completed, which is not the desired behavior.\n\nThe new behavior prints the failed task and all remaining tasks (as desired).","commit_id":"563329fe4fb8ddfbf230e7e9f8fbbf72f4af848e"}],"scripts/run-upgrade.sh":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"51d07bb8114b90d9755fe360ac3875198997405b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      echo \"Re-run the run-upgrade.sh script, or\""},{"line_number":71,"context_line":"      echo \"execute the remaining tasks manually:\""},{"line_number":72,"context_line":"      # run the tasks in order"},{"line_number":73,"context_line":"      # NOTE(Frank Zhang): We use seq below because `RUN_TASKS\u003d(\"${RUN_TASKS[@]/$run_item}\") zeroes out the item but does not shorten the array. Since we know where we failed, we can just start printing playbooks from that position until we hit the end of the array."},{"line_number":74,"context_line":"      for item in $(seq $1 $((${#RUN_TASKS[@]} - 1))); do"},{"line_number":75,"context_line":"        if [ -n \"${RUN_TASKS[$item]}\" ]; then"},{"line_number":76,"context_line":"          echo \"openstack-ansible ${RUN_TASKS[$item]}\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9ad45d7e_43e9221a","line":73,"updated":"2016-08-08 18:37:54.000000000","message":"This line is way too long.  Please break the comment up into more lines.","commit_id":"c6f9c4316c7c43f979bd9ad0c950798a113a6af4"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c5d3d518d5907ff9d1d48105514ef88ab077d6f3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      echo \"Re-run the run-upgrade.sh script, or\""},{"line_number":71,"context_line":"      echo \"execute the remaining tasks manually:\""},{"line_number":72,"context_line":"      # run the tasks in order"},{"line_number":73,"context_line":"      # NOTE(Frank Zhang): We use seq below because"},{"line_number":74,"context_line":"      # `RUN_TASKS\u003d(\"${RUN_TASKS[@]/$run_item}\") zeroes out the item "},{"line_number":75,"context_line":"      # but does not shorten the array. Since we know where we failed, "},{"line_number":76,"context_line":"      # we can just start printing playbooks from that position "}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ad45d7e_72d75c4b","line":73,"updated":"2016-08-10 14:57:45.000000000","message":"Not sure your name is needed","commit_id":"485c8668773297599354120b05c84ef3dbec14f0"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"c5d3d518d5907ff9d1d48105514ef88ab077d6f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      # `RUN_TASKS\u003d(\"${RUN_TASKS[@]/$run_item}\") zeroes out the item "},{"line_number":75,"context_line":"      # but does not shorten the array. Since we know where we failed, "},{"line_number":76,"context_line":"      # we can just start printing playbooks from that position "},{"line_number":77,"context_line":"      # until we hit the end of the array."},{"line_number":78,"context_line":"      for item in $(seq $1 $((${#RUN_TASKS[@]} - 1))); do"},{"line_number":79,"context_line":"        if [ -n \"${RUN_TASKS[$item]}\" ]; then"},{"line_number":80,"context_line":"          echo \"openstack-ansible ${RUN_TASKS[$item]}\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9ad45d7e_d2c8c8aa","line":77,"updated":"2016-08-10 14:57:45.000000000","message":"Say what you are doing and maybe why, not why it\u0027s changing, why it\u0027s changing goes in the commit message.","commit_id":"485c8668773297599354120b05c84ef3dbec14f0"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a49d50a3383837322ae3acbf08a5f782508a713c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      echo \"Re-run the run-upgrade.sh script, or\""},{"line_number":71,"context_line":"      echo \"execute the remaining tasks manually:\""},{"line_number":72,"context_line":"      # NOTE: "},{"line_number":73,"context_line":"      # List rest part of task array which are incompleted."},{"line_number":74,"context_line":"      # Using seq to genertate a sequence which starts from the spot"},{"line_number":75,"context_line":"      # where previous exception or failured happened. "},{"line_number":76,"context_line":"      # run the tasks in order"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9ad45d7e_3242ffae","line":73,"updated":"2016-08-10 16:19:33.000000000","message":"should be \u0027list the remaining, incomplete tasks from the tasks array\u0027?","commit_id":"6268529b3aa411e0b9e79b88369437c92fb9bb8c"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a49d50a3383837322ae3acbf08a5f782508a713c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      # NOTE: "},{"line_number":73,"context_line":"      # List rest part of task array which are incompleted."},{"line_number":74,"context_line":"      # Using seq to genertate a sequence which starts from the spot"},{"line_number":75,"context_line":"      # where previous exception or failured happened. "},{"line_number":76,"context_line":"      # run the tasks in order"},{"line_number":77,"context_line":"      for item in $(seq $1 $((${#RUN_TASKS[@]} - 1))); do"},{"line_number":78,"context_line":"        if [ -n \"${RUN_TASKS[$item]}\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"9ad45d7e_123ffb24","line":75,"updated":"2016-08-10 16:19:33.000000000","message":"s/failured/failures","commit_id":"6268529b3aa411e0b9e79b88369437c92fb9bb8c"}]}