)]}'
{"playbooks/inventory/group_vars/all.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a9e43f71ba56973b1651acf5b97d554515c42fd3","unresolved":false,"context_lines":[{"line_number":386,"context_line":"# TODO: (andymccr) ceilometer with swift does not support SSL rabbitmq connections, so we are hard coding the port and use_ssl var"},{"line_number":387,"context_line":"swift_rabbitmq_telemetry_port: \"5672\""},{"line_number":388,"context_line":"swift_rabbitmq_use_ssl: False"},{"line_number":389,"context_line":"swift_rabbitmq_telemetry_password: \"{{ swift_rabbitmq_telemetry_password }}\""},{"line_number":390,"context_line":"swift_rabbitmq_telemetry_host_group: \"{{ rabbitmq_host_group }}\""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"# If there are any Ceilometer and Swift hosts in the environment, then enable its usage"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa7ab95a_753140ec","line":389,"range":{"start_line":389,"start_character":0,"end_line":389,"end_character":76},"updated":"2016-08-31 15:33:25.000000000","message":"With the secret, this is not required.","commit_id":"cecb03b8cf9ca19828d583e71b18a2c18a27acc7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a9e43f71ba56973b1651acf5b97d554515c42fd3","unresolved":false,"context_lines":[{"line_number":390,"context_line":"swift_rabbitmq_telemetry_host_group: \"{{ rabbitmq_host_group }}\""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"# If there are any Ceilometer and Swift hosts in the environment, then enable its usage"},{"line_number":393,"context_line":"swift_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027swift_proxy\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027swift_proxy\u0027] | length \u003e 0) }}\""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"## OpenStack Openrc"},{"line_number":396,"context_line":"openrc_os_auth_url: \"{{ keystone_service_internalurl }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa7ab95a_b5782891","line":393,"range":{"start_line":393,"start_character":0,"end_line":393,"end_character":195},"updated":"2016-08-31 15:33:25.000000000","message":"This is also in swift_all, so it needs to be removed there as part of this patch. This is needed here because I think that ceilometer needs this value to know that it must read stuff from the telemetry queue.","commit_id":"cecb03b8cf9ca19828d583e71b18a2c18a27acc7"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"49829adcfbae891ec0222d6eafedac1b793ffbed","unresolved":false,"context_lines":[{"line_number":389,"context_line":"swift_rabbitmq_telemetry_host_group: \"{{ rabbitmq_host_group }}\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"# If there are any Ceilometer and Swift hosts in the environment, then enable its usage"},{"line_number":392,"context_line":"swift_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027swift_proxy\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027swift_proxy\u0027] | length \u003e 0) }}\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"## OpenStack Openrc"},{"line_number":395,"context_line":"openrc_os_auth_url: \"{{ keystone_service_internalurl }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fa7ab95a_870c9a95","line":392,"range":{"start_line":392,"start_character":30,"end_line":392,"end_character":106},"updated":"2016-09-01 13:04:51.000000000","message":"Well I\u0027m not sure that\u0027s needed or useful, but I understand the re-use of the pattern.","commit_id":"6bd8f3c17b1eba37f42a397c292a265ea33b02a6"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e3e30fbc84f1be8bd925a13924adf3a5ab5c8429","unresolved":false,"context_lines":[{"line_number":389,"context_line":"swift_rabbitmq_telemetry_host_group: \"{{ rabbitmq_host_group }}\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"# If there are any Ceilometer and Swift hosts in the environment, then enable its usage"},{"line_number":392,"context_line":"swift_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027swift_proxy\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027swift_proxy\u0027] | length \u003e 0) }}\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"## OpenStack Openrc"},{"line_number":395,"context_line":"openrc_os_auth_url: \"{{ keystone_service_internalurl }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fa7ab95a_cadb09ec","line":392,"range":{"start_line":392,"start_character":30,"end_line":392,"end_character":106},"in_reply_to":"fa7ab95a_870c9a95","updated":"2016-09-01 13:18:17.000000000","message":"It may be redundant, but it\u0027s explicit protection against the possibility that the group may not exist. It is also the existing pattern, so I\u0027d welcome a patch to change this for all of them - but I\u0027d prefer not to see the pattern change for this patch.","commit_id":"6bd8f3c17b1eba37f42a397c292a265ea33b02a6"}],"playbooks/os-swift-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a9e43f71ba56973b1651acf5b97d554515c42fd3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"     when:"},{"line_number":109,"context_line":"       - swift_ceilometer_enabled | bool"},{"line_number":110,"context_line":"       - inventory_hostname \u003d\u003d groups[\u0027swift_all\u0027][0]"},{"line_number":111,"context_line":"       - groups[swift_rabbitmq_telemetry_host_group] is defined"},{"line_number":112,"context_line":"       - groups[swift_rabbitmq_telemetry_host_group] | length \u003e 0"},{"line_number":113,"context_line":"  roles:"},{"line_number":114,"context_line":"    - role: \"os_swift\""},{"line_number":115,"context_line":"      swift_venv_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa7ab95a_15dd5470","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":65},"updated":"2016-08-31 15:33:25.000000000","message":"Are these two required, seeing as the same test is done in the first condition?","commit_id":"cecb03b8cf9ca19828d583e71b18a2c18a27acc7"}]}
