)]}'
{"scripts/bootstrap-ansible.sh":[{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"4a602a240e88cd87362d1939b373cdb0a008f846","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Install the base packages"},{"line_number":52,"context_line":"case ${DISTRO_ID} in"},{"line_number":53,"context_line":"    centos|rhel)"},{"line_number":54,"context_line":"        yum check-update"},{"line_number":55,"context_line":"        yum -y install git python2 curl autoconf gcc-c++ \\"},{"line_number":56,"context_line":"          python2-devel gcc libffi-devel nc openssl-devel python-requests \\"},{"line_number":57,"context_line":"          python-pyasn1 pyOpenSSL python-ndg_httpsclient \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_e5fd533b","side":"PARENT","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":24},"updated":"2016-09-15 14:48:02.000000000","message":"I\u0027m not sure this should be removed.  Just because it exits 1 doesn\u0027t mean the entire script will.","commit_id":"4205048c440aaaf6731b53161fe5e8a97b8b3b69"},{"author":{"_account_id":20038,"name":"Michael Gugino","email":"michael.gugino@walmart.com","username":"michaelgugino"},"change_message_id":"4a602a240e88cd87362d1939b373cdb0a008f846","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          python-pyasn1 pyOpenSSL python-ndg_httpsclient \\"},{"line_number":57,"context_line":"          python-netaddr python-prettytable python-crypto PyYAML \\"},{"line_number":58,"context_line":"          python-virtualenv"},{"line_number":59,"context_line":"          ALWAYS_COPY\u003d\"\""},{"line_number":60,"context_line":"        ;;"},{"line_number":61,"context_line":"    ubuntu)"},{"line_number":62,"context_line":"        apt-get update"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_a58a6bbd","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":24},"updated":"2016-09-15 14:48:02.000000000","message":"You can just leave ALWAYS_COPY undefined for centos/rhel.","commit_id":"8ed350f427345447052ae81322c400feb24760dc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67adfc477639d1219a6831275b47f230a239a777","unresolved":false,"context_lines":[{"line_number":64,"context_line":"          libssl-dev libffi-dev netcat python-requests python-openssl python-pyasn1 \\"},{"line_number":65,"context_line":"          python-netaddr python-prettytable python-crypto python-yaml \\"},{"line_number":66,"context_line":"          python-virtualenv"},{"line_number":67,"context_line":"          ALWAYS_COPY\u003d\"--always-copy\""},{"line_number":68,"context_line":"        ;;"},{"line_number":69,"context_line":"esac"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a8ec9b2_27435114","line":67,"range":{"start_line":67,"start_character":10,"end_line":67,"end_character":21},"updated":"2016-09-19 04:18:20.000000000","message":"with `set -u` defined at the top of the script I think this will need to be set as a default empty string or in the \"centos\" case too.","commit_id":"9d591bae580328f3ed495e74b7904d2cc888f95c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c1022f4d57461905acf2d4cd5647e2305f0fecb4","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Create a Virtualenv for the Ansible runtime"},{"line_number":91,"context_line":"PYTHON_EXEC_PATH\u003d\"$(which python2 || which python)\""},{"line_number":92,"context_line":"virtualenv --clear ${ALWAYS_COPY} --system-site-packages --python\u003d\"${PYTHON_EXEC_PATH}\" /opt/ansible-runtime"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# Install ansible"},{"line_number":95,"context_line":"PIP_OPTS+\u003d\" --upgrade\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7a8ec9b2_1bf774f6","line":92,"range":{"start_line":92,"start_character":19,"end_line":92,"end_character":33},"updated":"2016-09-19 14:35:04.000000000","message":"Perhaps rather set a variable at the top of the script called VIRTUALENV_OPTIONS with the default value of \u0027--always-copy\u0027, then for CentOS change the value to \u0027\u0027. Or perhaps add that value for Ubuntu? Or ensure that there\u0027s a default of nothing here.","commit_id":"643d46952b95efd3fc5a440eee53c9509ad001fc"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"12b8d267a40d8c20f8ac58f02b7d385adad29e54","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    centos|rhel)"},{"line_number":56,"context_line":"        pip list"},{"line_number":57,"context_line":"        yum --disablerepo\u003depel -y install git python2 curl autoconf gcc-c++ \\"},{"line_number":58,"context_line":"          python2-devel gcc libffi-devel nc openssl-devel python-requests \\"},{"line_number":59,"context_line":"          python-pyasn1 pyOpenSSL python-ndg_httpsclient \\"},{"line_number":60,"context_line":"          python-netaddr python-prettytable python-crypto PyYAML \\"},{"line_number":61,"context_line":"          python-virtualenv"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a8bc5a2_9441873c","line":58,"range":{"start_line":58,"start_character":58,"end_line":58,"end_character":73},"updated":"2016-09-22 12:53:10.000000000","message":"It looks like we need to remove this.","commit_id":"a0904dc15d8b592fdae5b5f438c550dcc3a53644"},{"author":{"_account_id":13095,"name":"Marc Gariépy","email":"gariepy.marc@gmail.com","username":"mgariepy"},"change_message_id":"354a871a682208c27353de135899ca679c350733","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    centos|rhel)"},{"line_number":56,"context_line":"        pip list"},{"line_number":57,"context_line":"        yum --disablerepo\u003depel -y install git python2 curl autoconf gcc-c++ \\"},{"line_number":58,"context_line":"          python2-devel gcc libffi-devel nc openssl-devel python-requests \\"},{"line_number":59,"context_line":"          python-pyasn1 pyOpenSSL python-ndg_httpsclient \\"},{"line_number":60,"context_line":"          python-netaddr python-prettytable python-crypto PyYAML \\"},{"line_number":61,"context_line":"          python-virtualenv"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a8bc5a2_94afc7e2","line":58,"range":{"start_line":58,"start_character":58,"end_line":58,"end_character":73},"in_reply_to":"5a8bc5a2_9441873c","updated":"2016-09-22 12:55:38.000000000","message":"Done","commit_id":"a0904dc15d8b592fdae5b5f438c550dcc3a53644"}]}
