)]}'
{"scripts/upgrade-utilities/playbooks/nova-flavor-migration.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c58e2e68ead798c113388565d0346010dce09840","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      command: nova-manage db migrate_flavor_data --force"},{"line_number":27,"context_line":"      when:"},{"line_number":28,"context_line":"        - nova_manage_version.rc \u003d\u003d 0"},{"line_number":29,"context_line":"        - nova_manage_version.stderr.find(\u00272015.1.\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_3e9997c4","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":58},"updated":"2016-09-19 08:59:25.000000000","message":"Right now it\u0027ll just skip this task if you\u0027re upgrading from a version of nova prior to this. Is this the sort of thing we want? Should we fail out of this task if you aren\u0027t at this version?","commit_id":"a5fba2c28e9351262d0f475deb3cfb09e2845101"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"3e246617ad814e9e09c9c18334344a95c4cf4086","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      command: nova-manage db migrate_flavor_data --force"},{"line_number":27,"context_line":"      when:"},{"line_number":28,"context_line":"        - nova_manage_version.rc \u003d\u003d 0"},{"line_number":29,"context_line":"        - nova_manage_version.stderr.find(\u00272015.1.\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_6ce455ab","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":58},"in_reply_to":"7a8ec9b2_3e9997c4","updated":"2016-09-19 09:36:56.000000000","message":"My thinking was let it go for idempotence if someone is rerunning upgrade playbooks after already upgrading to liberty, since the command will fail out there, but that\u0027s a really good point. \nValidating juno was easy enough because of the rpc file names but there hasn\u0027t seemed to be much work done since to make sure deployers are starting off at the expected release.","commit_id":"a5fba2c28e9351262d0f475deb3cfb09e2845101"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44edbdc493abe849b9e1d65370e64bc5eef60e37","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      command: nova-manage db migrate_flavor_data --force"},{"line_number":27,"context_line":"      when:"},{"line_number":28,"context_line":"        - nova_manage_version.rc \u003d\u003d 0"},{"line_number":29,"context_line":"        - nova_manage_version.stderr.find(\u00272015.1.\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_fbcf2827","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":58},"in_reply_to":"7a8ec9b2_6ce455ab","updated":"2016-09-19 14:40:47.000000000","message":"Yeah, I\u0027d like to actually have run-upgrade to facilitate both minor and major upgrades to keep the process consistent... so version detection is going to become a thing we need to figure out.\n\nFor this patch - is there any harm in this DB migration running more than once? If so then the guard isn\u0027t necessary. If it is harmful then we\u0027ll have to drop some sort of local fact or marker file for idempotence.","commit_id":"a5fba2c28e9351262d0f475deb3cfb09e2845101"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"0540c8ea967e49eea3c7683d0f31ee61686a4cb7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      command: nova-manage db migrate_flavor_data --force"},{"line_number":27,"context_line":"      when:"},{"line_number":28,"context_line":"        - nova_manage_version.rc \u003d\u003d 0"},{"line_number":29,"context_line":"        - nova_manage_version.stderr.find(\u00272015.1.\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a8bc5a2_2abafae1","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":58},"in_reply_to":"7a8ec9b2_fbcf2827","updated":"2016-09-22 16:35:32.000000000","message":"It\u0027s safe to re-run, it\u0027s just that the subcommand won\u0027t be available outside of nova kilo deployment. I\u0027ve added a fail to make that more obvious.","commit_id":"a5fba2c28e9351262d0f475deb3cfb09e2845101"}]}