)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6209609e74875ac2e9f24250a126c14ddbde8cea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Donovan Francesco (drifterza) \u003cdonovan.francesco@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-21 12:24:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This patch is to add the Trove role to the repository."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic71703960e2259edd25faa3e992c7fa9c6d28674"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_5196c63e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":54},"updated":"2016-09-21 10:28:05.000000000","message":"Suggestion:\n\nAdd integrated Trove deployment","commit_id":"b8cd340d116270a8e9e17b1b7208f930dc29fbe8"}],"playbooks/defaults/repo_packages/openstack_services.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4068988995b61e07e01e00bffc2b7b36c3b0612d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"magnum_git_dest: \"/opt/magnum_{{ magnum_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":183,"context_line":"magnum_git_project_group: magnum_all"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"## Rally service"},{"line_number":186,"context_line":"rally_git_repo: https://git.openstack.org/openstack/rally"},{"line_number":187,"context_line":"rally_git_install_branch: 8ff0f2ee8c92f748e99138b24124a5c008918555 # HEAD of \"master\" as of 16.09.2016"},{"line_number":188,"context_line":"rally_git_dest: \"/opt/rally_{{ rally_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":189,"context_line":"rally_git_project_group: utility_all"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"## Trove service"},{"line_number":192,"context_line":"trove_git_repo: https://git.openstack.org/openstack/trove"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_ab5752c8","line":189,"range":{"start_line":185,"start_character":0,"end_line":189,"end_character":36},"updated":"2016-10-03 10:11:18.000000000","message":"Is rally necessary?","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"}],"playbooks/inventory/group_vars/all.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"f72037880fedc23fb669df0eb8ab18fa51a3f2cd","unresolved":false,"context_lines":[{"line_number":395,"context_line":"# If there are any Ceilometer and Swift hosts in the environment, then enable its usage"},{"line_number":396,"context_line":"swift_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027swift_proxy\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027swift_proxy\u0027] | length \u003e 0) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"## Trove"},{"line_number":399,"context_line":"cinder_service_port: 8776"},{"line_number":400,"context_line":"swift_proxy_port: 8080"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5a8bc5a2_2095bbe3","line":398,"updated":"2016-09-22 17:28:32.000000000","message":"I think these should go under their respective services and not the service that uses them.  That would be more inline with the existing pattern.  So cinder_xxx under #Cinder, swift_xxx under # Swift.","commit_id":"9a5831501acac86e43f4b5aa2dd65b26333da18f"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"e2b9a97b4e7ecd6fbc0b3266c2bafa22a50eadc3","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"## Cinder"},{"line_number":133,"context_line":"cinder_service_region: \"{{ service_region }}\""},{"line_number":134,"context_line":"# If there are Swift hosts in the environment, then enable cinder backups to it"},{"line_number":135,"context_line":"cinder_service_backup_program_enabled: \"{{ groups[\u0027swift_all\u0027] is defined and groups[\u0027swift_all\u0027] | length \u003e 0 }}\""},{"line_number":136,"context_line":"# cinder_backend_rbd_inuse: True if current host has an rbd backend"},{"line_number":137,"context_line":"cinder_backend_rbd_inuse: \u0027{{ (cinder_backends|default(\"\")|to_json).find(\"cinder.volume.drivers.rbd.RBDDriver\") !\u003d -1 }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_fe58d458","line":134,"updated":"2016-09-22 18:01:50.000000000","message":"I would have put the cinder_service_port here below cinder_service_region, rather than under the Cinder RPC fields.","commit_id":"595e3a660f341268e5fa715e138b43f5f1a415cc"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4068988995b61e07e01e00bffc2b7b36c3b0612d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"sahara_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027sahara_all\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027sahara_all\u0027] | length \u003e 0) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"## Swift"},{"line_number":399,"context_line":"swift_proxy_port: 8080"},{"line_number":400,"context_line":"swift_system_user_name: swift"},{"line_number":401,"context_line":"swift_system_shell: /bin/bash"},{"line_number":402,"context_line":"swift_system_comment: swift system user"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_4bfeceae","line":399,"updated":"2016-10-03 10:11:18.000000000","message":"Should we get this out of the way?","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"9c6561a5ca9e3058e3f91d454099c722fd260c75","unresolved":false,"context_lines":[{"line_number":396,"context_line":"sahara_ceilometer_enabled: \"{{ (groups[\u0027ceilometer_all\u0027] is defined) and (groups[\u0027sahara_all\u0027] is defined) and (groups[\u0027ceilometer_all\u0027] | length \u003e 0) and (groups[\u0027sahara_all\u0027] | length \u003e 0) }}\""},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"## Swift"},{"line_number":399,"context_line":"swift_proxy_port: 8080"},{"line_number":400,"context_line":"swift_system_user_name: swift"},{"line_number":401,"context_line":"swift_system_shell: /bin/bash"},{"line_number":402,"context_line":"swift_system_comment: swift system user"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_ae8120fd","line":399,"in_reply_to":"3a98d1f4_4bfeceae","updated":"2016-10-03 10:12:48.000000000","message":"Ok, my bad I didn\u0027t know it was needed.","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"}],"playbooks/os-trove-install.yml":[{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"d37774160ab3b1de6f104952a0ecce9d0be3b31d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      vars:"},{"line_number":35,"context_line":"        user: \"{{ trove_rabbitmq_userid }}\""},{"line_number":36,"context_line":"        password: \"{{ trove_rabbitmq_password }}\""},{"line_number":37,"context_line":"        vhost: \"{{ trove_rabbitmq_vhost }}\""},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - inventory_hostname \u003d\u003d groups[\u0027trove_all\u0027][0]"},{"line_number":40,"context_line":"        - groups[\u0027rabbitmq_all\u0027] | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_9bb3eb4c","line":37,"updated":"2016-09-21 18:01:22.000000000","message":"I think you need to add the following line after vhost:\n\n_rabbitmq_host_group: \"{{ trove_rabbitmq_host_group }}\"","commit_id":"32bb54779c4629d2d04c9376c908efcf1165e54e"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"d37774160ab3b1de6f104952a0ecce9d0be3b31d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        user: \"{{ trove_rabbitmq_userid }}\""},{"line_number":36,"context_line":"        password: \"{{ trove_rabbitmq_password }}\""},{"line_number":37,"context_line":"        vhost: \"{{ trove_rabbitmq_vhost }}\""},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - inventory_hostname \u003d\u003d groups[\u0027trove_all\u0027][0]"},{"line_number":40,"context_line":"        - groups[\u0027rabbitmq_all\u0027] | length \u003e 0"},{"line_number":41,"context_line":"    - include: common-tasks/mysql-db-user.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_fb222f53","line":38,"updated":"2016-09-21 18:01:22.000000000","message":"For the when: I had these lines when I did my prototyping of running trove AIO.\n\n      when:\n        - inventory_hostname \u003d\u003d groups[\u0027trove_all\u0027][0]\n        - groups[trove_rabbitmq_host_group] | length \u003e 0\n\nI\u0027m not positive it\u0027s correct but it seemed to follow pattern of other roles.","commit_id":"32bb54779c4629d2d04c9376c908efcf1165e54e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4068988995b61e07e01e00bffc2b7b36c3b0612d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Install trove server"},{"line_number":20,"context_line":"  hosts: trove_all"},{"line_number":21,"context_line":"  max_fail_percentage: 20"},{"line_number":22,"context_line":"  user: root"},{"line_number":23,"context_line":"  pre_tasks:"},{"line_number":24,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_4b9a4e6f","line":21,"updated":"2016-10-03 10:11:18.000000000","message":"Could we have a gather_facts like the other playbooks?","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4068988995b61e07e01e00bffc2b7b36c3b0612d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  max_fail_percentage: 20"},{"line_number":22,"context_line":"  user: root"},{"line_number":23,"context_line":"  pre_tasks:"},{"line_number":24,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":25,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":26,"context_line":"      vars:"},{"line_number":27,"context_line":"        log_dirs:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_ab8112fd","line":24,"updated":"2016-10-03 10:11:18.000000000","message":"Could we sort this with the usual order? It\u0027s easier to review that way.","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4068988995b61e07e01e00bffc2b7b36c3b0612d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        password: \"{{ trove_galera_password }}\""},{"line_number":46,"context_line":"        login_host: \"{{ trove_galera_address }}\""},{"line_number":47,"context_line":"        db_name: \"{{ trove_galera_database }}\""},{"line_number":48,"context_line":"      when: inventory_hostname \u003d\u003d groups[\u0027trove_all\u0027][0]"},{"line_number":49,"context_line":"  roles:"},{"line_number":50,"context_line":"    - role: \"os_trove\""},{"line_number":51,"context_line":"      trove_venv_tag: \"{{ openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a98d1f4_6be0eacd","line":48,"updated":"2016-10-03 10:11:18.000000000","message":"Should we add telemetry? Or is it planned for a future commit?","commit_id":"48e9c2bc044a022036b6ca1b5bc3bb07ae17ab0a"}]}