)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c65c7a5f0ff7cb5e2730553939d36b6a9700bc0b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  to a single restart. This reduces the chance of failure during"},{"line_number":15,"context_line":"  a deployment."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"TODO:"},{"line_number":18,"context_line":"- Implement a role-based base container for copy-on-write"},{"line_number":19,"context_line":"  implementations to reduce disk usage, cut deployment time"},{"line_number":20,"context_line":"  and provide the ability to harvest role-based container"},{"line_number":21,"context_line":"  software artifacts."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I5a4c066f5aefab4f76cd89d177df1be65c46a51e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_821cec14","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":21},"updated":"2016-10-17 22:29:27.000000000","message":"After some thought and additional testing this is clearly a whole different ball game. I\u0027ll do an entirely different patch set for this.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"}],"playbooks/repo-server.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2646998354432d12cfcd2e3e8191d11438ae838a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup repo containers"},{"line_number":17,"context_line":"  hosts: repo_all"},{"line_number":18,"context_line":"  gather_facts: no"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Check if the git cache exists on deployment host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_b75e9410","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":18},"updated":"2016-10-17 21:39:37.000000000","message":"container creation requires host machine facts. we might want to define one more play to gather facts from the physical hosts prior to running this.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9368ba642d34d7c90bb0d0e622b3554d41cab54e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup repo containers"},{"line_number":17,"context_line":"  hosts: repo_all"},{"line_number":18,"context_line":"  gather_facts: no"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Check if the git cache exists on deployment host"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_42457415","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":18},"in_reply_to":"fa6399be_b75e9410","updated":"2016-10-17 22:28:46.000000000","message":"OK, maybe - we have already gathered facts against the host when executing prior plays but I guess we need to cater for situations where this playbook is run out of sequence and not through setup-hosts.yml.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2646998354432d12cfcd2e3e8191d11438ae838a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      register: _local_git_cache"},{"line_number":26,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Set bind mounts (with git cache)"},{"line_number":29,"context_line":"      set_fact:"},{"line_number":30,"context_line":"        repo_lxc_container_bind_mounts:"},{"line_number":31,"context_line":"          - host_directory: \"/openstack/{{ inventory_hostname }}\""},{"line_number":32,"context_line":"            container_directory: \"/var/www\""},{"line_number":33,"context_line":"          - host_directory: \"{{ repo_build_git_cache }}\""},{"line_number":34,"context_line":"            container_directory: \"{{ repo_build_git_cache }}\""},{"line_number":35,"context_line":"      when:"},{"line_number":36,"context_line":"        - repo_build_git_cache is defined"},{"line_number":37,"context_line":"        - _local_git_cache.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_17566006","line":34,"range":{"start_line":28,"start_character":4,"end_line":34,"end_character":61},"updated":"2016-10-17 21:39:37.000000000","message":"I don\u0027t believe there\u0027s any reason to set a fact here. \nif we\u0027re calling the role directly all of this can been moved into role variables.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9368ba642d34d7c90bb0d0e622b3554d41cab54e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      register: _local_git_cache"},{"line_number":26,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Set bind mounts (with git cache)"},{"line_number":29,"context_line":"      set_fact:"},{"line_number":30,"context_line":"        repo_lxc_container_bind_mounts:"},{"line_number":31,"context_line":"          - host_directory: \"/openstack/{{ inventory_hostname }}\""},{"line_number":32,"context_line":"            container_directory: \"/var/www\""},{"line_number":33,"context_line":"          - host_directory: \"{{ repo_build_git_cache }}\""},{"line_number":34,"context_line":"            container_directory: \"{{ repo_build_git_cache }}\""},{"line_number":35,"context_line":"      when:"},{"line_number":36,"context_line":"        - repo_build_git_cache is defined"},{"line_number":37,"context_line":"        - _local_git_cache.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_22c960ad","line":34,"range":{"start_line":28,"start_character":4,"end_line":34,"end_character":61},"in_reply_to":"fa6399be_17566006","updated":"2016-10-17 22:28:46.000000000","message":"This is done to override the group_vars, as a set_fact overrides inventory vars. This is a special case to handle the git cache bind mount.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"75e7cf12adb393a99ab7c4b8b4d5ea249166ca4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup repo containers"},{"line_number":17,"context_line":"  hosts: repo_all"},{"line_number":18,"context_line":"  gather_facts: no"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Check if the git cache exists on deployment host"},{"line_number":22,"context_line":"      local_action:"},{"line_number":23,"context_line":"        module: stat"},{"line_number":24,"context_line":"        path: \"{{ repo_build_git_cache }}\""},{"line_number":25,"context_line":"      register: _local_git_cache"},{"line_number":26,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Set bind mounts (with git cache)"},{"line_number":29,"context_line":"      set_fact:"},{"line_number":30,"context_line":"        repo_lxc_container_bind_mounts:"},{"line_number":31,"context_line":"          - host_directory: \"/openstack/{{ inventory_hostname }}\""},{"line_number":32,"context_line":"            container_directory: \"/var/www\""},{"line_number":33,"context_line":"          - host_directory: \"{{ repo_build_git_cache }}\""},{"line_number":34,"context_line":"            container_directory: \"{{ repo_build_git_cache }}\""},{"line_number":35,"context_line":"      when:"},{"line_number":36,"context_line":"        - repo_build_git_cache is defined"},{"line_number":37,"context_line":"        - _local_git_cache.stat.exists"},{"line_number":38,"context_line":"  roles:"},{"line_number":39,"context_line":"    - role: \"lxc_container_create\""},{"line_number":40,"context_line":"      lxc_container_bind_mounts: \"{{ repo_lxc_container_bind_mounts }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Setup repo servers"},{"line_number":43,"context_line":"  hosts: repo_all"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_177bc07c","line":40,"range":{"start_line":16,"start_character":0,"end_line":40,"end_character":71},"updated":"2016-10-17 21:41:04.000000000","message":"Could all of this be moved into a service specific playbook. Something like \"repo-server-containers.yml\" and then included here? While it\u0027s functionally the same it provides better lines of separation.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9368ba642d34d7c90bb0d0e622b3554d41cab54e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Setup repo containers"},{"line_number":17,"context_line":"  hosts: repo_all"},{"line_number":18,"context_line":"  gather_facts: no"},{"line_number":19,"context_line":"  become: yes"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    - name: Check if the git cache exists on deployment host"},{"line_number":22,"context_line":"      local_action:"},{"line_number":23,"context_line":"        module: stat"},{"line_number":24,"context_line":"        path: \"{{ repo_build_git_cache }}\""},{"line_number":25,"context_line":"      register: _local_git_cache"},{"line_number":26,"context_line":"      when: repo_build_git_cache is defined"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    - name: Set bind mounts (with git cache)"},{"line_number":29,"context_line":"      set_fact:"},{"line_number":30,"context_line":"        repo_lxc_container_bind_mounts:"},{"line_number":31,"context_line":"          - host_directory: \"/openstack/{{ inventory_hostname }}\""},{"line_number":32,"context_line":"            container_directory: \"/var/www\""},{"line_number":33,"context_line":"          - host_directory: \"{{ repo_build_git_cache }}\""},{"line_number":34,"context_line":"            container_directory: \"{{ repo_build_git_cache }}\""},{"line_number":35,"context_line":"      when:"},{"line_number":36,"context_line":"        - repo_build_git_cache is defined"},{"line_number":37,"context_line":"        - _local_git_cache.stat.exists"},{"line_number":38,"context_line":"  roles:"},{"line_number":39,"context_line":"    - role: \"lxc_container_create\""},{"line_number":40,"context_line":"      lxc_container_bind_mounts: \"{{ repo_lxc_container_bind_mounts }}\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Setup repo servers"},{"line_number":43,"context_line":"  hosts: repo_all"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_82f5cccc","line":40,"range":{"start_line":16,"start_character":0,"end_line":40,"end_character":71},"in_reply_to":"fa6399be_177bc07c","updated":"2016-10-17 22:28:46.000000000","message":"I don\u0027t see how this would be done without doubling up the code lines. It seems a senseless double-up.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2646998354432d12cfcd2e3e8191d11438ae838a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  max_fail_percentage: 20"},{"line_number":46,"context_line":"  become: yes"},{"line_number":47,"context_line":"  roles:"},{"line_number":48,"context_line":"    - role: \"lxc_container_create\""},{"line_number":49,"context_line":"      lxc_container_bind_mounts: \"{{ repo_lxc_container_bind_mounts }}\""},{"line_number":50,"context_line":"    - role: \"repo_server\""},{"line_number":51,"context_line":"    - role: \"rsyslog_client\""},{"line_number":52,"context_line":"      rsyslog_client_log_rotate_file: repo_nginx_log_rotate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_5767f8e9","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":71},"updated":"2016-10-17 21:39:37.000000000","message":"This is a duplicate likely not needed.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"44ebb9d9915027c52e65dd8df9297f4ce1f545ff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  max_fail_percentage: 20"},{"line_number":46,"context_line":"  become: yes"},{"line_number":47,"context_line":"  roles:"},{"line_number":48,"context_line":"    - role: \"lxc_container_create\""},{"line_number":49,"context_line":"      lxc_container_bind_mounts: \"{{ repo_lxc_container_bind_mounts }}\""},{"line_number":50,"context_line":"    - role: \"repo_server\""},{"line_number":51,"context_line":"    - role: \"rsyslog_client\""},{"line_number":52,"context_line":"      rsyslog_client_log_rotate_file: repo_nginx_log_rotate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_5740d835","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":71},"updated":"2016-10-17 21:36:53.000000000","message":"mistaken inclusion - will be removed","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2646998354432d12cfcd2e3e8191d11438ae838a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  become: yes"},{"line_number":47,"context_line":"  roles:"},{"line_number":48,"context_line":"    - role: \"lxc_container_create\""},{"line_number":49,"context_line":"      lxc_container_bind_mounts: \"{{ repo_lxc_container_bind_mounts }}\""},{"line_number":50,"context_line":"    - role: \"repo_server\""},{"line_number":51,"context_line":"    - role: \"rsyslog_client\""},{"line_number":52,"context_line":"      rsyslog_client_log_rotate_file: repo_nginx_log_rotate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_b747744a","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":67},"updated":"2016-10-17 21:39:37.000000000","message":"this should be moved up into the container create play.","commit_id":"a0128ed467a480a14cbedc362b413541da0e97fd"}]}