)]}'
{"lib/filesystem.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"054b54658a79e5b65d7762af80772ab3f64a9c4e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            \u0027/etc\u0027, \u0027openstack_deploy\u0027"},{"line_number":27,"context_line":"        ),"},{"line_number":28,"context_line":"    ]"},{"line_number":29,"context_line":"    if include_cwd:"},{"line_number":30,"context_line":"        cwd_path \u003d os.path.join(os.getcwd())"},{"line_number":31,"context_line":"        search_paths.append(cwd_path)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_a4a4f207","line":29,"updated":"2016-11-02 20:53:52.000000000","message":"As far as I know, the cwd usage has been deprecated, and could be removed. The only options are /etc/openstack_deploy or the provided --config directory (called preferred_path here).","commit_id":"1e760246ef3a459df5c28898bcafd7089249a722"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"6fd611c962b58c5d035b39d816bf9902a08fe21d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        search_paths.insert(0, os.path.expanduser(preferred_path))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    if suffix:"},{"line_number":37,"context_line":"        search_paths \u003d [os.path.join(p, suffix) for p in search_paths]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    return search_paths"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_145f3776","line":37,"updated":"2016-11-04 17:16:09.000000000","message":"Is there a case in which suffix wouldn\u0027t be the filename? If not, I think I\u0027d prefer this to be renamed to filename to be a little more clear.\n\nI thought it might be a directory, but os.path.isfile only checks if someting is a regular file. To verify this, I tried os.path.isfile(os.getcwd()), which returns False.","commit_id":"1e760246ef3a459df5c28898bcafd7089249a722"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"847b7dc7591d4ccb605e34c1032f29624f239109","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        search_paths.insert(0, os.path.expanduser(preferred_path))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    if suffix:"},{"line_number":37,"context_line":"        search_paths \u003d [os.path.join(p, suffix) for p in search_paths]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    return search_paths"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_a7365fe5","line":37,"in_reply_to":"ba5da102_145f3776","updated":"2016-11-04 17:26:30.000000000","message":"In a following patch we will use _get_search_paths() to _find_dir() in the course of locating the env.d/ and conf.d/ directories (allowing overrides of the fixed /etc/openstack_deploy dir with a preferred_path) which serves to implement the load_user_configuration and load_environment methods. there is no use of os.path.isfile in _get_search_paths so this method is still agnostic.","commit_id":"1e760246ef3a459df5c28898bcafd7089249a722"},{"author":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"change_message_id":"79a146eea9f955656b40793f3bff702a571cef16","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    for file_candidate in search_paths:"},{"line_number":55,"context_line":"        if os.path.isfile(file_candidate):"},{"line_number":56,"context_line":"            return file_candidate"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        if pass_exception is False:"},{"line_number":59,"context_line":"            raise SystemExit(\u0027No file found at: %s\u0027 % search_paths)"},{"line_number":60,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_a689efcc","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":9},"updated":"2016-11-08 06:11:06.000000000","message":"Do we need the for...else here? we don\u0027t have the break within the for loop.","commit_id":"a2810958492979d5a341ecd969e06aa0f83c9607"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"54c5a8f5a34b686080dc23884c0c26868be4d6d9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    for file_candidate in search_paths:"},{"line_number":55,"context_line":"        if os.path.isfile(file_candidate):"},{"line_number":56,"context_line":"            return file_candidate"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        if pass_exception is False:"},{"line_number":59,"context_line":"            raise SystemExit(\u0027No file found at: %s\u0027 % search_paths)"},{"line_number":60,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_befd583c","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":9},"in_reply_to":"9a629dbe_a689efcc","updated":"2016-11-08 15:33:31.000000000","message":"Good catch - I haven\u0027t tested and I don\u0027t think we have any automated tests around it, but my hunch is that the else block is never hit.","commit_id":"a2810958492979d5a341ecd969e06aa0f83c9607"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"ad509789dc0a83dc6b7f0250d9528826b5ad02c9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    The file lookup will be done in the following directories:"},{"line_number":43,"context_line":"      ``preferred_path`` [Optional]"},{"line_number":44,"context_line":"      /etc/openstack_deploy/"},{"line_number":45,"context_line":"      $(pwd)/openstack_deploy/"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    :param filename: ``str``  Name of the file to find"},{"line_number":48,"context_line":"    :param preferred_path: ``str`` Additional directory to look in FIRST"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_b8bad121","line":45,"updated":"2016-11-16 02:26:29.000000000","message":"This is missing from search_paths, don\u0027t mind if it\u0027s added in followup patch though","commit_id":"3358b01dd4fd9847137af48454bbd053ad429642"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a2c68b63d95836e4e8a7c88311b8a96be544ee8f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    The file lookup will be done in the following directories:"},{"line_number":43,"context_line":"      ``preferred_path`` [Optional]"},{"line_number":44,"context_line":"      /etc/openstack_deploy/"},{"line_number":45,"context_line":"      $(pwd)/openstack_deploy/"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    :param filename: ``str``  Name of the file to find"},{"line_number":48,"context_line":"    :param preferred_path: ``str`` Additional directory to look in FIRST"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_9808b52f","line":45,"in_reply_to":"7a77a97e_b8bad121","updated":"2016-11-16 02:46:54.000000000","message":"oops, forgot to remove that from the docstring. will note it for the next change to this file.","commit_id":"3358b01dd4fd9847137af48454bbd053ad429642"}]}
