)]}'
{"lib/generate.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"a2302892446a3dcc90f367bf968bc623c2c8aa3f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import netaddr"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":"import tarfile"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_68edeb24","line":23,"updated":"2016-11-14 16:34:31.000000000","message":"Why was this added? I can\u0027t see it anywhere.","commit_id":"30268430be0486250a342e90546c539f87c91bc6"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"f46edd3f752743c010e35a6ff49af9d9861858a9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import netaddr"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":"import tarfile"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_bd4cc077","line":23,"in_reply_to":"7a77a97e_8b2c1dad","updated":"2016-11-14 21:55:44.000000000","message":"Correct, rebase error.","commit_id":"30268430be0486250a342e90546c539f87c91bc6"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"fba905252ff3ed48656a6481625d078acd9d8c51","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import netaddr"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":"import tarfile"},{"line_number":24,"context_line":"import uuid"},{"line_number":25,"context_line":"import warnings"},{"line_number":26,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_8b2c1dad","line":23,"in_reply_to":"9a629dbe_68edeb24","updated":"2016-11-14 21:44:09.000000000","message":"looks like a rebase error to me, it was removed in the now-parent commit, but prior to rebase it was present.","commit_id":"30268430be0486250a342e90546c539f87c91bc6"}],"lib/ip.py":[{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"a2302892446a3dcc90f367bf968bc623c2c8aa3f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    except AttributeError:"},{"line_number":22,"context_line":"        return None"},{"line_number":23,"context_line":"    except Queue.Empty:"},{"line_number":24,"context_line":"        raise SystemExit("},{"line_number":25,"context_line":"            \u0027Cannot retrieve requested amount of IP addresses. Increase the %s\u0027"},{"line_number":26,"context_line":"            \u0027 range in your openstack_user_config.yml.\u0027 % name"},{"line_number":27,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_8dd091cb","line":24,"updated":"2016-11-14 16:34:31.000000000","message":"This is probably an inappropriate exception for a library. Although it might be more reasonable to address this in another patch.","commit_id":"30268430be0486250a342e90546c539f87c91bc6"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"fba905252ff3ed48656a6481625d078acd9d8c51","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    except AttributeError:"},{"line_number":22,"context_line":"        return None"},{"line_number":23,"context_line":"    except Queue.Empty:"},{"line_number":24,"context_line":"        raise SystemExit("},{"line_number":25,"context_line":"            \u0027Cannot retrieve requested amount of IP addresses. Increase the %s\u0027"},{"line_number":26,"context_line":"            \u0027 range in your openstack_user_config.yml.\u0027 % name"},{"line_number":27,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_8b55fd1e","line":24,"in_reply_to":"9a629dbe_8dd091cb","updated":"2016-11-14 21:44:09.000000000","message":"I agree that it needs to be revised but would prefer to focus on the move with minimal modification and follow with this and other cleanups to keep the deltas easier to review.","commit_id":"30268430be0486250a342e90546c539f87c91bc6"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"1a7048a2383fce4506f02f4df57f0577ca4d67cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"def get_ip_address(name, ip_q):"},{"line_number":13,"context_line":"    \"\"\"Return an IP address from our IP Address queue.\"\"\""},{"line_number":14,"context_line":"    try:"},{"line_number":15,"context_line":"        ip_addr \u003d ip_q.get(timeout\u003d1)"},{"line_number":16,"context_line":"        while ip_addr in USED_IPS:"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_bb1b4172","line":13,"updated":"2016-11-17 20:36:26.000000000","message":"could use proper doc in following patch","commit_id":"35691fef01f0a16b76a080d4442b462abb52de04"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"1a7048a2383fce4506f02f4df57f0577ca4d67cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def load_ip_q(cidr, ip_q):"},{"line_number":31,"context_line":"    \"\"\"Load the IP queue with all IP address from a given cidr."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    :param cidr: ``str``  IP address with cidr notation"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    _all_ips \u003d [str(i) for i in list(netaddr.IPNetwork(cidr))]"},{"line_number":36,"context_line":"    base_exclude \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_fb005903","line":33,"updated":"2016-11-17 20:36:26.000000000","message":"missing the ip_q param, to add in following patch","commit_id":"35691fef01f0a16b76a080d4442b462abb52de04"}]}
