)]}'
{"lib/filesystem.py":[{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"22255135f2267232c29d71e7ffc450742dde0ece","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def load_inventory(preferred_path\u003dNone, default_inv\u003dNone):"},{"line_number":117,"context_line":"    \"\"\"Create an inventory dictionary from the given source file or a default"},{"line_number":118,"context_line":"        inventory. If an inventory is found then a backup tarball is created"},{"line_number":119,"context_line":"        as well."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_25ba47c1","line":117,"updated":"2016-11-04 18:36:50.000000000","message":"This docstring may cause warnings with pep8 for not having a blank line after the first line.","commit_id":"436fbab4ac2734b0f7bfc53a41ed1bd9402c3343"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"22255135f2267232c29d71e7ffc450742dde0ece","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        make_backup(preferred_path, file_loaded)"},{"line_number":132,"context_line":"    else:"},{"line_number":133,"context_line":"        logger.debug(\"No existing inventory, created fresh skeleton.\")"},{"line_number":134,"context_line":"        inventory \u003d copy.deepcopy(default_inv)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    return inventory"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_a5c65747","line":134,"updated":"2016-11-04 18:36:50.000000000","message":"I like this usage, as it allows other default specifications, or, at the very least, separation of concerns.","commit_id":"436fbab4ac2734b0f7bfc53a41ed1bd9402c3343"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"49d9b2d396701d6305136c235a9c70f39d1ff142","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def get_backup_name(basename):"},{"line_number":86,"context_line":"    utctime \u003d datetime.datetime.utcnow()"},{"line_number":87,"context_line":"    utctime \u003d utctime.strftime(\"%Y%m%d_%H%M%S\")"},{"line_number":88,"context_line":"    return \u0027%s-%s.json\u0027 % (basename, utctime)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def load_from_json(filename, preferred_path\u003dNone, pass_exception\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_59d53bb7","line":88,"updated":"2016-11-08 14:39:59.000000000","message":"Should we use new style format?","commit_id":"d98e882669a2e31f7809e04f62ce510424c0a635"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"f42173ecca20b945d6f5376697a291608c877ed8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def get_backup_name(basename):"},{"line_number":86,"context_line":"    utctime \u003d datetime.datetime.utcnow()"},{"line_number":87,"context_line":"    utctime \u003d utctime.strftime(\"%Y%m%d_%H%M%S\")"},{"line_number":88,"context_line":"    return \u0027%s-%s.json\u0027 % (basename, utctime)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def load_from_json(filename, preferred_path\u003dNone, pass_exception\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_fc9b5870","line":88,"in_reply_to":"9a629dbe_59d53bb7","updated":"2016-11-08 15:57:58.000000000","message":"+1 for doing this, though I think it should be a follow on review addressing just that usage throughout.","commit_id":"d98e882669a2e31f7809e04f62ce510424c0a635"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"84e6e109a7afb80973c8e76cf7cf91e664d783f6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def make_backup(config_path, inventory_file_path):"},{"line_number":74,"context_line":"    # Create a backup of all previous inventory files as a tar archive"},{"line_number":75,"context_line":"    inventory_backup_file \u003d os.path.join("},{"line_number":76,"context_line":"        config_path,"},{"line_number":77,"context_line":"        \u0027backup_openstack_inventory.tar\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_4f07f517","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":70},"updated":"2016-11-17 02:30:19.000000000","message":"while this makes sense here it\u0027d be nice to see it as a py doc string.","commit_id":"b7354adacb642bb476a0c7006572cbc0a2e52873"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"025bf338adb770ed1aa8cb739742b45c75e425f2","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def make_backup(config_path, inventory_file_path):"},{"line_number":74,"context_line":"    # Create a backup of all previous inventory files as a tar archive"},{"line_number":75,"context_line":"    inventory_backup_file \u003d os.path.join("},{"line_number":76,"context_line":"        config_path,"},{"line_number":77,"context_line":"        \u0027backup_openstack_inventory.tar\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_394107aa","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":70},"in_reply_to":"7a77a97e_4f07f517","updated":"2016-11-17 16:21:07.000000000","message":"agreed, I need to do a pass to fix up docs anyway. some funcs don\u0027t have docstring and some need to be updated.","commit_id":"b7354adacb642bb476a0c7006572cbc0a2e52873"}]}