)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"810a592eb3bbc0fcd439dfa41bc13e2595cf7d7a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of a Ceph cluster for use with OSA."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The integration should be considered experimental at this point,"},{"line_number":14,"context_line":"however an integrated functional testing scenario named \"aio_ceph\""},{"line_number":15,"context_line":"is added which fully exercises the ceph-ansible deployment and"},{"line_number":16,"context_line":"configures OSA to use the deployed Ceph cluster. Once this is added"},{"line_number":17,"context_line":"to the OSA gate tests for the integrated build, that should help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7a3c09a3_647231af","line":14,"updated":"2017-01-16 18:27:49.000000000","message":"s/aio_ceph/ceph/","commit_id":"934e396c81317dd05db2f65847b955f2a6849c46"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"5da57b73fb0df48403fdd29fe3d04c76e47cae7f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"of a Ceph cluster for use with OSA."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The integration should be considered experimental at this point,"},{"line_number":14,"context_line":"however an integrated functional testing scenario named \"aio_ceph\""},{"line_number":15,"context_line":"is added which fully exercises the ceph-ansible deployment and"},{"line_number":16,"context_line":"configures OSA to use the deployed Ceph cluster. Once this is added"},{"line_number":17,"context_line":"to the OSA gate tests for the integrated build, that should help"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"7a3c09a3_725670cf","line":14,"in_reply_to":"7a3c09a3_647231af","updated":"2017-01-16 20:25:32.000000000","message":"Done thanks!","commit_id":"934e396c81317dd05db2f65847b955f2a6849c46"}],"deploy-guide/source/app-ceph.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Appendix G: ceph-ansible Integration"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_071c2511","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":24},"updated":"2017-01-16 12:55:44.000000000","message":"Ceph-Ansible","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Appendix G: ceph-ansible Integration"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_47d46d1f","line":2,"range":{"start_line":2,"start_character":25,"end_line":2,"end_character":36},"updated":"2017-01-16 12:55:44.000000000","message":"lowercase","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Appendix G: ceph-ansible Integration"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"},{"line_number":6,"context_line":"\u003chttps://ceph.com\u003e`_ clusters using roles maintained by the `ceph-ansible`_"},{"line_number":7,"context_line":"project. Deployers can enable the ceph-ansible playbook by adding hosts to the"},{"line_number":8,"context_line":"`ceph-mon_hosts` and `ceph-osd_hosts` groups in ``openstack_user_config.yml``,"},{"line_number":9,"context_line":"and then configuring `ceph-ansible specific vars"},{"line_number":10,"context_line":"\u003chttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample\u003e`_"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_27aa0171","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":8},"updated":"2017-01-16 12:55:44.000000000","message":"This is passive voice - we need to flip this and make it clearer.\n\n\"OpenStack-Ansible allows`Ceph storage \u003chttps://ceph.com\u003e`_ cluster integration using the roles maintained by the `ceph-ansible`_ project\u003e.\"","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"},{"line_number":6,"context_line":"\u003chttps://ceph.com\u003e`_ clusters using roles maintained by the `ceph-ansible`_"},{"line_number":7,"context_line":"project. Deployers can enable the ceph-ansible playbook by adding hosts to the"},{"line_number":8,"context_line":"`ceph-mon_hosts` and `ceph-osd_hosts` groups in ``openstack_user_config.yml``,"},{"line_number":9,"context_line":"and then configuring `ceph-ansible specific vars"},{"line_number":10,"context_line":"\u003chttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample\u003e`_"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_e791d953","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":18},"updated":"2017-01-16 12:55:44.000000000","message":"You can enable *","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"},{"line_number":6,"context_line":"\u003chttps://ceph.com\u003e`_ clusters using roles maintained by the `ceph-ansible`_"},{"line_number":7,"context_line":"project. Deployers can enable the ceph-ansible playbook by adding hosts to the"},{"line_number":8,"context_line":"`ceph-mon_hosts` and `ceph-osd_hosts` groups in ``openstack_user_config.yml``,"},{"line_number":9,"context_line":"and then configuring `ceph-ansible specific vars"},{"line_number":10,"context_line":"\u003chttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample\u003e`_"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_4789cd25","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":46},"updated":"2017-01-16 12:55:44.000000000","message":"``ceph-ansible``","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"},{"line_number":6,"context_line":"\u003chttps://ceph.com\u003e`_ clusters using roles maintained by the `ceph-ansible`_"},{"line_number":7,"context_line":"project. Deployers can enable the ceph-ansible playbook by adding hosts to the"},{"line_number":8,"context_line":"`ceph-mon_hosts` and `ceph-osd_hosts` groups in ``openstack_user_config.yml``,"},{"line_number":9,"context_line":"and then configuring `ceph-ansible specific vars"},{"line_number":10,"context_line":"\u003chttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample\u003e`_"},{"line_number":11,"context_line":"in the OpenStack-Ansible ``user_variables.yml`` file."}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_a786f110","line":8,"range":{"start_line":8,"start_character":21,"end_line":8,"end_character":37},"updated":"2017-01-16 12:55:44.000000000","message":"ditto","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"bf0e08696e8095d97523f1751b79a88e4e7ad4c9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Integration is included with OpenStack-Ansible for deploying `Ceph storage"},{"line_number":6,"context_line":"\u003chttps://ceph.com\u003e`_ clusters using roles maintained by the `ceph-ansible`_"},{"line_number":7,"context_line":"project. Deployers can enable the ceph-ansible playbook by adding hosts to the"},{"line_number":8,"context_line":"`ceph-mon_hosts` and `ceph-osd_hosts` groups in ``openstack_user_config.yml``,"},{"line_number":9,"context_line":"and then configuring `ceph-ansible specific vars"},{"line_number":10,"context_line":"\u003chttps://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample\u003e`_"},{"line_number":11,"context_line":"in the OpenStack-Ansible ``user_variables.yml`` file."}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_8783b503","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":16},"updated":"2017-01-16 12:55:44.000000000","message":"double back ticks","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"}],"playbooks/ceph-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba646a59dbd8b92d5c8151a7fcf6de659065619a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        - \"system-crontab-coordination\""},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":32,"context_line":"    mon_group_name: ceph-mon"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Gather ceph-mon facts"},{"line_number":35,"context_line":"  hosts: \"{{ mon_group_name }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_32ad1a89","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":28},"updated":"2017-01-10 09:19:41.000000000","message":"This has been added to the group_vars - why re-specify them here?","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c3daf46317caa6e2e2c8cf99f4b75941952f282b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        - \"system-crontab-coordination\""},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":32,"context_line":"    mon_group_name: ceph-mon"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Gather ceph-mon facts"},{"line_number":35,"context_line":"  hosts: \"{{ mon_group_name }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_74ce602e","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":28},"in_reply_to":"ba5201f7_32ad1a89","updated":"2017-01-11 15:39:30.000000000","message":"Done","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba646a59dbd8b92d5c8151a7fcf6de659065619a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      action: setup"},{"line_number":41,"context_line":"      tags:"},{"line_number":42,"context_line":"        - ceph-osd"},{"line_number":43,"context_line":"        - ceph-mon-facts"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    mon_group_name: ceph-mon"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_12cbb673","line":43,"updated":"2017-01-10 09:19:41.000000000","message":"We should probably add the skip_ansible_lint tag here too in order to prevent future lint failures due to the external role.","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c3daf46317caa6e2e2c8cf99f4b75941952f282b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      action: setup"},{"line_number":41,"context_line":"      tags:"},{"line_number":42,"context_line":"        - ceph-osd"},{"line_number":43,"context_line":"        - ceph-mon-facts"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    mon_group_name: ceph-mon"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_b45fe83f","line":43,"in_reply_to":"ba5201f7_12cbb673","updated":"2017-01-11 15:39:30.000000000","message":"I\u0027m confused-- it seems to be passing lint currently and there is no role being run here, only the setup module.","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6bb854b2a5dd272c4f5a9016c1835a2cbd6cd2d7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      action: setup"},{"line_number":41,"context_line":"      tags:"},{"line_number":42,"context_line":"        - ceph-osd"},{"line_number":43,"context_line":"        - ceph-mon-facts"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    mon_group_name: ceph-mon"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_4f9b8918","line":43,"in_reply_to":"ba5201f7_b45fe83f","updated":"2017-01-11 15:54:48.000000000","message":"LOL, never mind. Clearly that was a pre-coffee review or something.","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba646a59dbd8b92d5c8151a7fcf6de659065619a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      tags:"},{"line_number":42,"context_line":"        - ceph-osd"},{"line_number":43,"context_line":"        - ceph-mon-facts"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    mon_group_name: ceph-mon"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Install ceph osds"},{"line_number":48,"context_line":"  hosts: \"{{ osd_group_name }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_b2982a6c","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":28},"updated":"2017-01-10 09:19:41.000000000","message":"This has been added to the group_vars - why re-specify them here?","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c3daf46317caa6e2e2c8cf99f4b75941952f282b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      tags:"},{"line_number":42,"context_line":"        - ceph-osd"},{"line_number":43,"context_line":"        - ceph-mon-facts"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    mon_group_name: ceph-mon"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Install ceph osds"},{"line_number":48,"context_line":"  hosts: \"{{ osd_group_name }}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_34bdb868","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":28},"in_reply_to":"ba5201f7_b2982a6c","updated":"2017-01-11 15:39:30.000000000","message":"Done","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba646a59dbd8b92d5c8151a7fcf6de659065619a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        - ceph"},{"line_number":55,"context_line":"        - ceph-osd"},{"line_number":56,"context_line":"        - skip_ansible_lint"},{"line_number":57,"context_line":"  vars:"},{"line_number":58,"context_line":"    osd_group_name: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_12a01690","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"updated":"2017-01-10 09:19:41.000000000","message":"This has been added to the group_vars - why re-specify them here?","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c3daf46317caa6e2e2c8cf99f4b75941952f282b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        - ceph"},{"line_number":55,"context_line":"        - ceph-osd"},{"line_number":56,"context_line":"        - skip_ansible_lint"},{"line_number":57,"context_line":"  vars:"},{"line_number":58,"context_line":"    osd_group_name: ceph-osd"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_74b3c09a","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":28},"in_reply_to":"ba5201f7_12a01690","updated":"2017-01-11 15:39:30.000000000","message":"Done","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"486c800d4a8d70a1b91792f27bd53802f7a811e5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  hosts: ceph-mon"},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - ceph"},{"line_number":22,"context_line":"    - ceph-mon"},{"line_number":23,"context_line":"  roles:"},{"line_number":24,"context_line":"    - role: \"ceph-mon\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_20acce9f","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":10},"updated":"2017-01-14 17:38:46.000000000","message":"I\u0027d like to see this tag on all ceph playbooks related playbooks. This will allow someone running multiple playbooks the ability to execute only tagged tasks with no assumption of a play or task being tagged.","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"486c800d4a8d70a1b91792f27bd53802f7a811e5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  hosts: ceph-mon"},{"line_number":18,"context_line":"  max_fail_percentage: 20"},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  tags:"},{"line_number":21,"context_line":"    - ceph"},{"line_number":22,"context_line":"    - ceph-mon"},{"line_number":23,"context_line":"  roles:"},{"line_number":24,"context_line":"    - role: \"ceph-mon\""},{"line_number":25,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_00a512b4","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":14},"updated":"2017-01-14 17:38:46.000000000","message":"total nit, but I\u0027d like the tags to be at the bottom of the play which is +/- for aesthetics and to keep things inline with our other playbooks.","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"}],"playbooks/inventory/group_vars/all.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"c192f52dee5f84a1a911d91cf394828bf9301759","unresolved":false,"context_lines":[{"line_number":465,"context_line":"# tries to create /var/log/ceph as a directory and fails if the log link already"},{"line_number":466,"context_line":"# exists. we handle the log dir creation so this is not something we need"},{"line_number":467,"context_line":"# ceph-common to prepare for us."},{"line_number":468,"context_line":"rbd_client_directories: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5a3905b3_0b93825c","line":468,"updated":"2017-01-19 21:43:54.000000000","message":"Hi Logan, can you refresh my memory -- are we able to override these vars with overrides in /etc/openstack_deploy?","commit_id":"06ede41645550b1260f0c457aeca7ab7feffe918"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"2632fd14e767c393e1c595240be38746411b0cd9","unresolved":false,"context_lines":[{"line_number":465,"context_line":"# tries to create /var/log/ceph as a directory and fails if the log link already"},{"line_number":466,"context_line":"# exists. we handle the log dir creation so this is not something we need"},{"line_number":467,"context_line":"# ceph-common to prepare for us."},{"line_number":468,"context_line":"rbd_client_directories: false"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5a3905b3_c8eed78a","line":468,"in_reply_to":"5a3905b3_0b93825c","updated":"2017-01-20 01:14:34.000000000","message":"Yes absolutely.","commit_id":"06ede41645550b1260f0c457aeca7ab7feffe918"}],"tests/bootstrap-aio.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"98a0bed924135c2b4665c3c4e33438868e54a8b0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - role: \"pip_install\""},{"line_number":23,"context_line":"    - role: \"bootstrap-host\""},{"line_number":24,"context_line":"      openstack_confd_entries: \"{{ confd_overrides[scenario] }}\""},{"line_number":25,"context_line":"      bootstrap_host_scenario: \"{{ scenario }}\""},{"line_number":26,"context_line":"      confd_overrides:"},{"line_number":27,"context_line":"        aio:"},{"line_number":28,"context_line":"          - name: aodh.yml.aio"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_feb16d90","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":47},"updated":"2017-01-16 11:02:35.000000000","message":"This is unnecessary. See https://review.openstack.org/#/c/409407/16/tests/roles/bootstrap-host/tasks/main.yml","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4635920fa615a963d592e320c3303534b04e8616","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          - name: nova.yml.aio"},{"line_number":39,"context_line":"          - name: swift.yml.aio"},{"line_number":40,"context_line":"        aio_ceph:"},{"line_number":41,"context_line":"          - name: ceph.yml.aio"},{"line_number":42,"context_line":"          - name: cinder.yml.aio"},{"line_number":43,"context_line":"          - name: glance.yml.aio"},{"line_number":44,"context_line":"          - name: heat.yml.aio"},{"line_number":45,"context_line":"          - name: horizon.yml.aio"},{"line_number":46,"context_line":"          - name: keystone.yml.aio"},{"line_number":47,"context_line":"          - name: neutron.yml.aio"},{"line_number":48,"context_line":"          - name: nova.yml.aio"},{"line_number":49,"context_line":"  vars:"},{"line_number":50,"context_line":"    scenario: \"{{ lookup(\u0027env\u0027,\u0027SCENARIO\u0027) | default(\u0027aio\u0027, true) }}\""},{"line_number":51,"context_line":"    sshd:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a3c09a3_d53559da","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":30},"updated":"2017-01-16 17:00:13.000000000","message":"Please put these in alphabetical order.","commit_id":"428aab9a6c8f0a0269d3355e7a9aab931a7001d2"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"cccc716e776910e55336a827af206be2023cc6f3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          - name: nova.yml.aio"},{"line_number":39,"context_line":"          - name: swift.yml.aio"},{"line_number":40,"context_line":"        aio_ceph:"},{"line_number":41,"context_line":"          - name: ceph.yml.aio"},{"line_number":42,"context_line":"          - name: cinder.yml.aio"},{"line_number":43,"context_line":"          - name: glance.yml.aio"},{"line_number":44,"context_line":"          - name: heat.yml.aio"},{"line_number":45,"context_line":"          - name: horizon.yml.aio"},{"line_number":46,"context_line":"          - name: keystone.yml.aio"},{"line_number":47,"context_line":"          - name: neutron.yml.aio"},{"line_number":48,"context_line":"          - name: nova.yml.aio"},{"line_number":49,"context_line":"  vars:"},{"line_number":50,"context_line":"    scenario: \"{{ lookup(\u0027env\u0027,\u0027SCENARIO\u0027) | default(\u0027aio\u0027, true) }}\""},{"line_number":51,"context_line":"    sshd:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a3c09a3_3378758f","line":48,"range":{"start_line":41,"start_character":0,"end_line":48,"end_character":30},"in_reply_to":"7a3c09a3_d53559da","updated":"2017-01-16 17:37:29.000000000","message":"I think they are already :)","commit_id":"428aab9a6c8f0a0269d3355e7a9aab931a7001d2"}],"tests/roles/bootstrap-host/defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"98a0bed924135c2b4665c3c4e33438868e54a8b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Scenario used to bootstrap the host"},{"line_number":17,"context_line":"bootstrap_host_scenario: aio"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Boolean option to implement OpenStack-Ansible configuration for an AIO"},{"line_number":20,"context_line":"# Switch to no for a multi-node configuration"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_3e95b5dd","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":28},"updated":"2017-01-16 11:02:35.000000000","message":"This is unnecessary. See https://review.openstack.org/#/c/409407/16/tests/roles/bootstrap-host/tasks/main.yml","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"7043c77b1419d941b01d921d62a28b067363523d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Scenario used to bootstrap the host"},{"line_number":17,"context_line":"bootstrap_host_scenario: aio"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Boolean option to implement OpenStack-Ansible configuration for an AIO"},{"line_number":20,"context_line":"# Switch to no for a multi-node configuration"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_4d2ac37f","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":28},"in_reply_to":"7a3c09a3_3e95b5dd","updated":"2017-01-16 16:17:08.000000000","message":"https://review.openstack.org/#/c/409407/16/tests/roles/bootstrap-host/tasks/prepare_aio_config.yml\n\nI think you were right the first time when you asked to have scenario defaulted in the role here https://review.openstack.org/#/c/409407/14/tests/roles/bootstrap-host/tasks/main.yml@89","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b79752088d309455f054cf763a7ec07fe9507994","unresolved":false,"context_lines":[{"line_number":48,"context_line":"bootstrap_host_loopback_nova_size: 1024"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Boolean option to deploy the OSD loopback disks and cluster UUID for Ceph"},{"line_number":51,"context_line":"bootstrap_host_ceph: \"{{ bootstrap_host_scenario \u003d\u003d \u0027aio_ceph\u0027 | bool }}\""},{"line_number":52,"context_line":"# Size of the Ceph OSD loopbacks"},{"line_number":53,"context_line":"bootstrap_host_loopback_ceph_size: 1024"},{"line_number":54,"context_line":"# Ceph OSDs to create on the AIO host"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a3c09a3_22bd8168","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":72},"updated":"2017-01-16 16:56:23.000000000","message":"This needs to be the following to ensure the correct precedence:\n\n  {{ (bootstrap_host_scenario \u003d\u003d \u0027aio_ceph\u0027) | bool }}","commit_id":"428aab9a6c8f0a0269d3355e7a9aab931a7001d2"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"cccc716e776910e55336a827af206be2023cc6f3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"bootstrap_host_loopback_nova_size: 1024"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# Boolean option to deploy the OSD loopback disks and cluster UUID for Ceph"},{"line_number":51,"context_line":"bootstrap_host_ceph: \"{{ bootstrap_host_scenario \u003d\u003d \u0027aio_ceph\u0027 | bool }}\""},{"line_number":52,"context_line":"# Size of the Ceph OSD loopbacks"},{"line_number":53,"context_line":"bootstrap_host_loopback_ceph_size: 1024"},{"line_number":54,"context_line":"# Ceph OSDs to create on the AIO host"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a3c09a3_93b04945","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":72},"in_reply_to":"7a3c09a3_22bd8168","updated":"2017-01-16 17:37:29.000000000","message":"Done","commit_id":"428aab9a6c8f0a0269d3355e7a9aab931a7001d2"}],"tests/roles/bootstrap-host/tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba646a59dbd8b92d5c8151a7fcf6de659065619a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# Prepare the Ceph cluster UUID and loopback disks"},{"line_number":87,"context_line":"- include: prepare_ceph.yml"},{"line_number":88,"context_line":"  when:"},{"line_number":89,"context_line":"    - \"{{ scenario \u003d\u003d \u0027aio_ceph\u0027 }}\""},{"line_number":90,"context_line":"  tags:"},{"line_number":91,"context_line":"    - prepare-ceph"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_1251f662","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":18},"updated":"2017-01-10 09:19:41.000000000","message":"This is an undefined var in the role and is currently only set in the playbook. We should add a role default.","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"c3daf46317caa6e2e2c8cf99f4b75941952f282b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# Prepare the Ceph cluster UUID and loopback disks"},{"line_number":87,"context_line":"- include: prepare_ceph.yml"},{"line_number":88,"context_line":"  when:"},{"line_number":89,"context_line":"    - \"{{ scenario \u003d\u003d \u0027aio_ceph\u0027 }}\""},{"line_number":90,"context_line":"  tags:"},{"line_number":91,"context_line":"    - prepare-ceph"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba5201f7_34321811","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":18},"in_reply_to":"ba5201f7_1251f662","updated":"2017-01-11 15:39:30.000000000","message":"Done","commit_id":"706798710b66e33814df5d45c603ccd2e92b5af3"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"98a0bed924135c2b4665c3c4e33438868e54a8b0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  tags:"},{"line_number":84,"context_line":"    - prepare-loopback-swift"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Prepare the Ceph cluster UUID and loopback disks"},{"line_number":87,"context_line":"- include: prepare_ceph.yml"},{"line_number":88,"context_line":"  when:"},{"line_number":89,"context_line":"    - \"{{ bootstrap_host_scenario \u003d\u003d \u0027aio_ceph\u0027 }}\""},{"line_number":90,"context_line":"  tags:"},{"line_number":91,"context_line":"    - prepare-ceph"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Prepare the network interfaces"},{"line_number":94,"context_line":"- include: prepare_networking.yml"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a3c09a3_dea3d14d","line":91,"range":{"start_line":86,"start_character":0,"end_line":91,"end_character":18},"updated":"2017-01-16 11:02:35.000000000","message":"I\u0027d prefer to see this implemented through a var called \u0027bootstrap_host_loopback_ceph\u0027 similar to the swift var. It can default to false, and based on the scenario this should be given to the host bootstrap as an extra var.","commit_id":"37ac1a5b0459aac3a7d20400ffdf77742fb1567b"}],"tests/roles/bootstrap-host/tasks/prepare_ceph.yml":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"ee0dfe68e2fb6016f7f2c9fe7aee4ace97408a5a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  with_items: \"{{ ceph_osd_images }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Create ceph cluster uuid"},{"line_number":50,"context_line":"  command: python -c \u0027import uuid; print(str(uuid.uuid4()))\u0027"},{"line_number":51,"context_line":"  register: cluster_uuid"},{"line_number":52,"context_line":"  become: false"},{"line_number":53,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a3c09a3_4d80f5c0","line":50,"updated":"2017-01-16 21:19:13.000000000","message":"Hi Logan, it\u0027s been a while since I looked at this, but I know ceph-common handles UUID generation also via the generate_fsid var (which defaults to true).  Do you want to make sure leaving that enabled and generating a UUID independently doesn\u0027t cause any issues?\n\nSide note, in rpc-openstack we add an empty fsid_uuid to user_secrets.yml, and then set fsid\u003dfsid_uuid in user_variables.txt.  That saves having to shell out and generate a UUID.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3c7ef8078c6815f556587e97da4b098c4eb88e0e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  with_items: \"{{ ceph_osd_images }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Create ceph cluster uuid"},{"line_number":50,"context_line":"  command: python -c \u0027import uuid; print(str(uuid.uuid4()))\u0027"},{"line_number":51,"context_line":"  register: cluster_uuid"},{"line_number":52,"context_line":"  become: false"},{"line_number":53,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a3c09a3_fdb393e7","line":50,"in_reply_to":"7a3c09a3_4d80f5c0","updated":"2017-01-18 19:28:22.000000000","message":"Yep-- the trick is getting that fsid into OSA\u0027s ceph_client role. We have to populate the fsid into a var for ceph_client, and when you have a new-cluster situation the fsid file that ceph-ansible creates does not exist yet. So doing a file lookup in ansible will fail because it cannot load the file. \n\nI always end up with a race condition doing that. So in connecting ceph-ansible and OSA I\u0027ve found the cleanest way to bootstrap the new cluster is to generate your fsid beforehand and populate it into the vars so we don\u0027t have to be concerned about race conditions with fsid generation.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"ee0dfe68e2fb6016f7f2c9fe7aee4ace97408a5a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      devices: {{ ceph_create_loopback.results | map(attribute\u003d\u0027stdout\u0027) | list | to_yaml | trim }}"},{"line_number":62,"context_line":"      # The OSA ceph_client role does not support loading IPs from an inventory group,"},{"line_number":63,"context_line":"      # so we have to feed it a list of IPs"},{"line_number":64,"context_line":"      ceph_mons: \"{% raw %}[ {% for host in groups[mon_group_name] %}\u0027{{ hostvars[host][\u0027ansible_host\u0027] }}\u0027{% if not loop.last %},{% endif %}{% endfor %} ]{% endraw %}\""},{"line_number":65,"context_line":"    dest: /etc/openstack_deploy/user_ceph_aio.yml"},{"line_number":66,"context_line":"    force: no"},{"line_number":67,"context_line":"  become: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a3c09a3_2d65691d","line":64,"updated":"2017-01-16 21:19:13.000000000","message":"Could some (if not all) of those overrides be added to user_variables.ceph.yml.j2?\n\nIs it because this work is still experimental that we\u0027re not exposing any of this stuff as defaults for a non-AIO deployment?","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3c7ef8078c6815f556587e97da4b098c4eb88e0e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      devices: {{ ceph_create_loopback.results | map(attribute\u003d\u0027stdout\u0027) | list | to_yaml | trim }}"},{"line_number":62,"context_line":"      # The OSA ceph_client role does not support loading IPs from an inventory group,"},{"line_number":63,"context_line":"      # so we have to feed it a list of IPs"},{"line_number":64,"context_line":"      ceph_mons: \"{% raw %}[ {% for host in groups[mon_group_name] %}\u0027{{ hostvars[host][\u0027ansible_host\u0027] }}\u0027{% if not loop.last %},{% endif %}{% endfor %} ]{% endraw %}\""},{"line_number":65,"context_line":"    dest: /etc/openstack_deploy/user_ceph_aio.yml"},{"line_number":66,"context_line":"    force: no"},{"line_number":67,"context_line":"  become: false"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7a3c09a3_9d10cfad","line":64,"in_reply_to":"7a3c09a3_2d65691d","updated":"2017-01-18 19:28:22.000000000","message":"The ceph_mons, fsid, and cinder_backends can be moved to user_variables.ceph.yml.j2 once https://bugs.launchpad.net/openstack-ansible/+bug/1649381 is fixed. The devices/fsid cannot since they are generated in the preceding tasks of this file.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"}],"tests/roles/bootstrap-host/templates/user_variables.ceph.yml.j2":[{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"ee0dfe68e2fb6016f7f2c9fe7aee4ace97408a5a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    rbd_store_chunk_size: 8"},{"line_number":19,"context_line":"    volume_backend_name: rbddriver"},{"line_number":20,"context_line":"    rbd_user: cinder"},{"line_number":21,"context_line":"    rbd_secret_uuid: \"{{ cluster_uuid.stdout }}\""},{"line_number":22,"context_line":"    report_discard_supported: true"},{"line_number":23,"context_line":"glance_ceph_client: glance"},{"line_number":24,"context_line":"glance_default_store: rbd"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a3c09a3_b84d1940","line":21,"updated":"2017-01-16 21:19:13.000000000","message":"I\u0027m not sure it technically matters, but we\u0027ve always pointed this at cinder_ceph_client_uuid.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3c7ef8078c6815f556587e97da4b098c4eb88e0e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    rbd_store_chunk_size: 8"},{"line_number":19,"context_line":"    volume_backend_name: rbddriver"},{"line_number":20,"context_line":"    rbd_user: cinder"},{"line_number":21,"context_line":"    rbd_secret_uuid: \"{{ cluster_uuid.stdout }}\""},{"line_number":22,"context_line":"    report_discard_supported: true"},{"line_number":23,"context_line":"glance_ceph_client: glance"},{"line_number":24,"context_line":"glance_default_store: rbd"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a3c09a3_2895d787","line":21,"in_reply_to":"7a3c09a3_b84d1940","updated":"2017-01-18 19:28:22.000000000","message":"cinder_ceph_client_uuid has to be populated from somewhere.. so in the gate what we\u0027re doing is generating a uuid to ceph_cluster_uuid, then the ceph_cluster_uuid var is used to populate the cinder_backend dict, the ceph-ansible \"fsid\" var, etc so we have a consistent fsid set across OSA and ceph-ansible.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"ee0dfe68e2fb6016f7f2c9fe7aee4ace97408a5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"glance_default_store: rbd"},{"line_number":25,"context_line":"glance_rbd_store_pool: images"},{"line_number":26,"context_line":"nova_libvirt_images_rbd_pool: vms"},{"line_number":27,"context_line":"nova_ceph_client_uuid: \"{{ cluster_uuid.stdout }}\""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a3c09a3_d8dca575","line":27,"updated":"2017-01-16 21:19:13.000000000","message":"nova_ceph_client_uuid already defaults to cinder_ceph_client_uuid, which is defaulted in user_secrets.txt.  This should be unnecessary.","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"3c7ef8078c6815f556587e97da4b098c4eb88e0e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"glance_default_store: rbd"},{"line_number":25,"context_line":"glance_rbd_store_pool: images"},{"line_number":26,"context_line":"nova_libvirt_images_rbd_pool: vms"},{"line_number":27,"context_line":"nova_ceph_client_uuid: \"{{ cluster_uuid.stdout }}\""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"7a3c09a3_9dba8f70","line":27,"in_reply_to":"7a3c09a3_d8dca575","updated":"2017-01-18 19:28:22.000000000","message":"Done","commit_id":"db074f387438722a3916fc092ef59e599d5c994e"}]}
