)]}'
{"id":"openstack%2Fopenstack-ansible~411513","triplet_id":"openstack%2Fopenstack-ansible~master~I1e17e3ca4227f1da3fc7aa8accda4e93fa90d245","project":"openstack/openstack-ansible","branch":"master","hashtags":[],"change_id":"I1e17e3ca4227f1da3fc7aa8accda4e93fa90d245","subject":"Call load_environment before mocking it","status":"MERGED","created":"2016-12-15 21:55:45.000000000","updated":"2016-12-22 00:34:42.000000000","submitted":"2016-12-22 00:34:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad6c453cd2546d9648c2d7af71539cd464594cf8","_number":411513,"virtual_id_number":411513,"owner":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},{"value":2,"date":"2016-12-22 00:34:42.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"recommended":{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},"all":[{"value":1,"date":"2016-12-16 08:37:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-21 23:33:02.000000000","_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":2,"date":"2016-12-21 12:30:03.000000000","_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":1,"date":"2016-12-21 07:30:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"all":[{"value":0,"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-21 23:33:02.000000000","_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"value":0,"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-16 08:37:27.000000000","updated_by":{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},"reviewer":{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},"state":"REVIEWER"},{"updated":"2016-12-21 07:30:14.000000000","updated_by":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"reviewer":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"state":"REVIEWER"},{"updated":"2016-12-21 12:30:03.000000000","updated_by":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"reviewer":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"state":"REVIEWER"},{"updated":"2016-12-21 23:33:02.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2016-12-22 00:34:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"57c371749a1560e4a1b9afb2ca3d0e16d4859b11","author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"date":"2016-12-15 21:55:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"04ee4abbd4022581392a1c1d966f41e6e53630eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-15 23:22:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-ansible-docs-ubuntu-xenial http://docs-draft.openstack.org/13/411513/1/check/gate-openstack-ansible-docs-ubuntu-xenial/ee4c49a//doc/build/html/ : SUCCESS in 1m 45s\n- gate-openstack-ansible-linters-ubuntu-xenial http://logs.openstack.org/13/411513/1/check/gate-openstack-ansible-linters-ubuntu-xenial/cc6067b/ : SUCCESS in 3m 54s\n- gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial http://logs.openstack.org/13/411513/1/check/gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial/69f9711/ : SUCCESS in 1h 24m 05s","accounts_in_message":[],"_revision_number":1},{"id":"3a18aaed8e53b09c8f42f1937c8f404894e03cb2","author":{"_account_id":10881,"name":"Neill Cox","email":"neill@ingenious.com.au","username":"neillc"},"date":"2016-12-16 08:37:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5c185a2fe3081fc14f666f9c0fad670c87db14d4","author":{"_account_id":16479,"name":"weezer su","email":"weezer.su@rackspace.com","username":"weezS"},"date":"2016-12-21 07:30:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4fc60465ecde88180839f644e5a0b6f015b2095c","author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"date":"2016-12-21 12:30:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"880ebd68c594ed55f6fd4dbbf906610c3da8405e","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2016-12-21 23:33:02.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5be3315888c13224a7b4a6a319eb2fd898a57220","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-21 23:33:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"60429ed548c97391e4a24ed1c6fb27b9356281d8","date":"2016-12-22 00:34:42.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"ad6c453cd2546d9648c2d7af71539cd464594cf8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-22 00:34:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-ansible-docs-ubuntu-xenial http://docs-draft.openstack.org/13/411513/1/gate/gate-openstack-ansible-docs-ubuntu-xenial/753c76c//doc/build/html/ : SUCCESS in 1m 49s\n- gate-openstack-ansible-linters-ubuntu-xenial http://logs.openstack.org/13/411513/1/gate/gate-openstack-ansible-linters-ubuntu-xenial/2156d07/ : SUCCESS in 3m 20s\n- gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial http://logs.openstack.org/13/411513/1/gate/gate-openstack-ansible-openstack-ansible-aio-ubuntu-xenial/235fd0a/ : SUCCESS in 1h 01m 25s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"71d97eb7a875139f21be9503ae4666e0a95fc1e5","revisions":{"71d97eb7a875139f21be9503ae4666e0a95fc1e5":{"kind":"REWORK","_number":1,"created":"2016-12-15 21:55:45.000000000","uploader":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"ref":"refs/changes/13/411513/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-ansible","ref":"refs/changes/13/411513/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/411513/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/411513/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-ansible refs/changes/13/411513/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-ansible refs/changes/13/411513/1"}}},"commit":{"parents":[{"commit":"a2e3d22a072a40817c9a72cdf949c79cf06c51f0","subject":"Fix role SHA\u0027s for Ocata-2 release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/a2e3d22a072a40817c9a72cdf949c79cf06c51f0"}]}],"author":{"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","date":"2016-12-15 21:52:57.000000000","tz":-300},"committer":{"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","date":"2016-12-15 21:52:57.000000000","tz":-300},"subject":"Call load_environment before mocking it","message":"Call load_environment before mocking it\n\nThe load_environment call happened after mocking, resulting in a mock\nobject being used for the duplicated IP test. Inspecting\ninventory.keys() during this test shows a length of 29, with only the\ngroups defined in the config file being present.\n\nMoving the call outside the mocked context and providing data instead\nmoves the number of keys up to 240, which includes the entries from the\nenvironment.\n\nWhile this change isn\u0027t necessarily material to the check for duplicated\nIPs, it is closer to the intent of exercising the generation system\nfully.\n\nChange-Id: I1e17e3ca4227f1da3fc7aa8accda4e93fa90d245\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/71d97eb7a875139f21be9503ae4666e0a95fc1e5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-ansible/commit/71d97eb7a875139f21be9503ae4666e0a95fc1e5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
