)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"23e948b25969616e3a917f1e392aa2983e4b4d0d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-01-18 11:04:46 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Additions to install OpenStack Octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia334ed42ed0664b10cba860d4231a6aa1588800e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_45e5b706","line":8,"updated":"2017-01-18 16:50:57.000000000","message":"would like you to add a Depends-On entry for the os_octavia role work here","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"420aead0c472b710d038ac65daff77f4daa18a96","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-01-18 11:04:46 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Additions to install OpenStack Octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ia334ed42ed0664b10cba860d4231a6aa1588800e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_55ca041c","line":8,"in_reply_to":"7a3c09a3_45e5b706","updated":"2017-01-23 16:44:51.000000000","message":"Done","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"}],"etc/network/interfaces.d/aio_interfaces.cfg":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"abe165ddd4c5ea923c22cfbb0dc0bd5590e4bb7c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    address 172.29.236.100"},{"line_number":14,"context_line":"    netmask 255.255.252.0"},{"line_number":15,"context_line":"    offload-sg off"},{"line_number":16,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":17,"context_line":"    pre-up ip link add br-mgmt-veth type veth peer name eth14 || true"},{"line_number":18,"context_line":"    # Set both ends UP"},{"line_number":19,"context_line":"    pre-up ip link set br-mgmt-veth up"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"9a30ddce_78313f0b","line":16,"updated":"2017-03-07 18:32:05.000000000","message":"Is this the network plumbing for Octavia? If so, it would be nice to get a comment in here just in case someone wonders why it\u0027s here (or has an issue with it).","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"ceb7661672371d51f80694473daced6b1b6e62d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    address 172.29.236.100"},{"line_number":14,"context_line":"    netmask 255.255.252.0"},{"line_number":15,"context_line":"    offload-sg off"},{"line_number":16,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":17,"context_line":"    pre-up ip link add br-mgmt-veth type veth peer name eth14 || true"},{"line_number":18,"context_line":"    # Set both ends UP"},{"line_number":19,"context_line":"    pre-up ip link set br-mgmt-veth up"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"9a30ddce_5eb70339","line":16,"in_reply_to":"9a30ddce_78313f0b","updated":"2017-03-07 18:56:27.000000000","message":"Done","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"}],"etc/openstack_deploy/conf.d/octavia.yml.aio":[{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"f4c02ddc3040aed77f573cc0ba45707a893b3f45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The compute host that the octavia control plane will be run on"},{"line_number":2,"context_line":"octavia_hosts:"},{"line_number":3,"context_line":"  aio1:"},{"line_number":4,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba2be162_945fc10d","line":1,"updated":"2017-02-28 18:36:57.000000000","message":"\"The compute host that the octavia control plane will be run on\". So is it a compute host? Or a controller host?","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"8f7d8d6ec405401f8890a06a47ad6eb9b038e0c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The compute host that the octavia control plane will be run on"},{"line_number":2,"context_line":"octavia_hosts:"},{"line_number":3,"context_line":"  aio1:"},{"line_number":4,"context_line":"    ip: 172.29.236.100"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ba2be162_1d20559b","line":1,"in_reply_to":"ba2be162_945fc10d","updated":"2017-02-28 19:17:12.000000000","message":"Done","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"}],"etc/openstack_deploy/openstack_user_config.yml.aio":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"abe165ddd4c5ea923c22cfbb0dc0bd5590e4bb7c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        container_bridge: \"br-mgmt\""},{"line_number":27,"context_line":"        container_type: \"veth\""},{"line_number":28,"context_line":"        container_interface: \"eth1\""},{"line_number":29,"context_line":"        host_bind_override: \"eth14\""},{"line_number":30,"context_line":"        ip_from_q: \"container\""},{"line_number":31,"context_line":"        type: \"flat\""},{"line_number":32,"context_line":"        net_name: \"mgmt\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a30ddce_9836f301","line":29,"updated":"2017-03-07 18:32:05.000000000","message":"I assume this is neeeded for Octavia\u0027s mgmt network? If so, could we get a small comment in here somewhere that explains eth14?","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"ceb7661672371d51f80694473daced6b1b6e62d0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        container_bridge: \"br-mgmt\""},{"line_number":27,"context_line":"        container_type: \"veth\""},{"line_number":28,"context_line":"        container_interface: \"eth1\""},{"line_number":29,"context_line":"        host_bind_override: \"eth14\""},{"line_number":30,"context_line":"        ip_from_q: \"container\""},{"line_number":31,"context_line":"        type: \"flat\""},{"line_number":32,"context_line":"        net_name: \"mgmt\""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a30ddce_1e1e6b0c","line":29,"in_reply_to":"9a30ddce_9836f301","updated":"2017-03-07 18:56:27.000000000","message":"Done","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  tunnel_bridge: \"br-vxlan\""},{"line_number":23,"context_line":"  management_bridge: \"br-mgmt\""},{"line_number":24,"context_line":"  provider_networks:"},{"line_number":25,"context_line":"    - network:"},{"line_number":26,"context_line":"        container_bridge: \"br-mgmt\""},{"line_number":27,"context_line":"        container_type: \"veth\""},{"line_number":28,"context_line":"        container_interface: \"eth1\""},{"line_number":29,"context_line":"        # connect container mgmt network for Octavia mgmt network to host"},{"line_number":30,"context_line":"        host_bind_override: \"eth14\""},{"line_number":31,"context_line":"        ip_from_q: \"container\""},{"line_number":32,"context_line":"        type: \"flat\""},{"line_number":33,"context_line":"        net_name: \"mgmt\""},{"line_number":34,"context_line":"        group_binds:"},{"line_number":35,"context_line":"          - all_containers"},{"line_number":36,"context_line":"          - hosts"},{"line_number":37,"context_line":"        is_container_address: true"},{"line_number":38,"context_line":"        is_ssh_address: true"},{"line_number":39,"context_line":"    - network:"},{"line_number":40,"context_line":"        container_bridge: \"br-vxlan\""},{"line_number":41,"context_line":"        container_type: \"veth\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a30ddce_1ea9e2df","line":38,"range":{"start_line":25,"start_character":0,"end_line":38,"end_character":28},"updated":"2017-03-08 15:33:54.000000000","message":"why not a new network?","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"46e62bd5eac52acbf4d9d5c2a80253b4b5812d23","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  tunnel_bridge: \"br-vxlan\""},{"line_number":23,"context_line":"  management_bridge: \"br-mgmt\""},{"line_number":24,"context_line":"  provider_networks:"},{"line_number":25,"context_line":"    - network:"},{"line_number":26,"context_line":"        container_bridge: \"br-mgmt\""},{"line_number":27,"context_line":"        container_type: \"veth\""},{"line_number":28,"context_line":"        container_interface: \"eth1\""},{"line_number":29,"context_line":"        # connect container mgmt network for Octavia mgmt network to host"},{"line_number":30,"context_line":"        host_bind_override: \"eth14\""},{"line_number":31,"context_line":"        ip_from_q: \"container\""},{"line_number":32,"context_line":"        type: \"flat\""},{"line_number":33,"context_line":"        net_name: \"mgmt\""},{"line_number":34,"context_line":"        group_binds:"},{"line_number":35,"context_line":"          - all_containers"},{"line_number":36,"context_line":"          - hosts"},{"line_number":37,"context_line":"        is_container_address: true"},{"line_number":38,"context_line":"        is_ssh_address: true"},{"line_number":39,"context_line":"    - network:"},{"line_number":40,"context_line":"        container_bridge: \"br-vxlan\""},{"line_number":41,"context_line":"        container_type: \"veth\""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9a30ddce_9ee1529d","line":38,"range":{"start_line":25,"start_character":0,"end_line":38,"end_character":28},"in_reply_to":"9a30ddce_1ea9e2df","updated":"2017-03-08 15:56:37.000000000","message":"When I asked in #openstack-ansible (see http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2017-01-20.log.html) it was suggested to use mgmt net instead of an extra network","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"}],"playbooks/defaults/repo_packages/openstack_services.yml":[{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"f4c02ddc3040aed77f573cc0ba45707a893b3f45","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"## Octavia service"},{"line_number":227,"context_line":"octavia_git_repo: https://git.openstack.org/openstack/octavia"},{"line_number":228,"context_line":"octavia_git_install_branch: 67866ea19353fd6acba7c81e840adf4b7c0885ca # HEAD of \"master\" as of `24.1.2017"},{"line_number":229,"context_line":"ocatvia_git_dest: \"/opt/octavia_{{ octavia_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":230,"context_line":"octavia_git_project_group: octavia_all"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_f4f2bd05","line":228,"updated":"2017-02-28 18:36:57.000000000","message":"I\u0027m not sure if it matters, but should this SHA be updated?","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"8f7d8d6ec405401f8890a06a47ad6eb9b038e0c4","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"## Octavia service"},{"line_number":227,"context_line":"octavia_git_repo: https://git.openstack.org/openstack/octavia"},{"line_number":228,"context_line":"octavia_git_install_branch: 67866ea19353fd6acba7c81e840adf4b7c0885ca # HEAD of \"master\" as of `24.1.2017"},{"line_number":229,"context_line":"ocatvia_git_dest: \"/opt/octavia_{{ octavia_git_install_branch | replace(\u0027/\u0027, \u0027_\u0027) }}\""},{"line_number":230,"context_line":"octavia_git_project_group: octavia_all"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_dd731db3","line":228,"in_reply_to":"ba2be162_f4f2bd05","updated":"2017-02-28 19:17:12.000000000","message":"Done - Though I wonder how this is updated.","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"}],"playbooks/inventory/env.d/octavia.yml":[{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"f4c02ddc3040aed77f573cc0ba45707a893b3f45","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"},{"line_number":38,"context_line":"      - octavia-housekeeping"},{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_546f0992","line":39,"updated":"2017-02-28 18:36:57.000000000","message":"Would there be any reason one of these services should scale independently from the others? If so, then I recommend putting that service in it\u0027s own container.","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"8f7d8d6ec405401f8890a06a47ad6eb9b038e0c4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"},{"line_number":38,"context_line":"      - octavia-housekeeping"},{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba2be162_3d81994b","line":39,"in_reply_to":"ba2be162_546f0992","updated":"2017-02-28 19:17:12.000000000","message":"In theory they could be independent form each other but so far we always paired them. So I would like to keep them together until we learn something  from future deploymemts which makes that not the best choice.","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"physical_skel:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_1ef722f6","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":31},"updated":"2017-03-08 15:33:54.000000000","message":"probably not what you want.","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_bfef99e7","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2017-03-10 12:33:22.000000000","message":"boilerplate needs to be updated for 2017","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2014, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_11f5f955","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"9a30ddce_bfef99e7","updated":"2017-03-10 13:49:13.000000000","message":"Done","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - octavia_containers"},{"line_number":35,"context_line":"    contains:"},{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"},{"line_number":38,"context_line":"      - octavia-housekeeping"},{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_5f385d3d","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":30},"updated":"2017-03-10 12:33:22.000000000","message":"Question: Do we see any reason to split these up into multiple containers? Do we expect the api, workers, housekeepers and health-managers to always scale together?","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - octavia_containers"},{"line_number":35,"context_line":"    contains:"},{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"},{"line_number":38,"context_line":"      - octavia-housekeeping"},{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_04f059fd","line":39,"range":{"start_line":36,"start_character":0,"end_line":39,"end_character":30},"in_reply_to":"9a30ddce_5f385d3d","updated":"2017-03-10 13:49:13.000000000","message":"I would like to scale them together for now. So far we don\u0027t have much data in the Octavia community to suggest otherwise. If this changes I will definitely revisit.","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"physical_skel:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_5f293d36","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":31},"updated":"2017-03-10 12:33:22.000000000","message":"this should not be here.","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      - octavia-health-manager"},{"line_number":40,"context_line":"    properties:"},{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":"      container_release: trusty"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"physical_skel:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_a4e5cd38","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":31},"in_reply_to":"9a30ddce_5f293d36","updated":"2017-03-10 13:49:13.000000000","message":"Done","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"036da427a2648bb07d2e65c1710d4dc22b5b859f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"container_skel:"},{"line_number":32,"context_line":"  octavia_server_container:"},{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - octavia_containers"},{"line_number":35,"context_line":"    contains:"},{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_7d37c8fe","line":34,"updated":"2017-03-12 03:14:38.000000000","message":"Don\u0027t fully understand why, but this needs to be renamed to avoid adding additional hosts to the octavia_all group.\n\n\u0027octavia-infra_containers\u0027 or \u0027lbaas_containers\u0027 would fit pattern of other services.","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"05a1150c3a55ade897153c8571999e96de94cc91","unresolved":false,"context_lines":[{"line_number":31,"context_line":"container_skel:"},{"line_number":32,"context_line":"  octavia_server_container:"},{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - octavia_containers"},{"line_number":35,"context_line":"    contains:"},{"line_number":36,"context_line":"      - octavia-api"},{"line_number":37,"context_line":"      - octavia-worker"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_1f8b1c69","line":34,"in_reply_to":"9a30ddce_7d37c8fe","updated":"2017-03-13 01:20:15.000000000","message":"Done","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"036da427a2648bb07d2e65c1710d4dc22b5b859f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"physical_skel:"},{"line_number":44,"context_line":"  octavia_containers:"},{"line_number":45,"context_line":"    belongs_to:"},{"line_number":46,"context_line":"      - all_containers"},{"line_number":47,"context_line":"  octavia_hosts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_9d3abce5","line":44,"updated":"2017-03-12 03:14:38.000000000","message":"here too","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"05a1150c3a55ade897153c8571999e96de94cc91","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      service_name: octavia"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"physical_skel:"},{"line_number":44,"context_line":"  octavia_containers:"},{"line_number":45,"context_line":"    belongs_to:"},{"line_number":46,"context_line":"      - all_containers"},{"line_number":47,"context_line":"  octavia_hosts:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_3fec6029","line":44,"in_reply_to":"9a30ddce_9d3abce5","updated":"2017-03-13 01:20:15.000000000","message":"Done","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"}],"playbooks/inventory/group_vars/all.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":393,"context_line":"nova_barbican_enabled: \"{{ (groups[\u0027barbican_all\u0027] is defined) and (groups[\u0027barbican_all\u0027] | length \u003e 0) }}\""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"## Octavia"},{"line_number":396,"context_line":"#glance_service_port: 9292"},{"line_number":397,"context_line":"#glance_service_proto: http"},{"line_number":398,"context_line":"#glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":399,"context_line":"#glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""},{"line_number":400,"context_line":"#glance_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(glance_service_proto) }}\""},{"line_number":401,"context_line":"#glance_service_publicuri: \"{{ glance_service_publicuri_proto }}://{{ external_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":402,"context_line":"#glance_service_publicurl: \"{{ glance_service_publicuri }}\""},{"line_number":403,"context_line":"#glance_service_internaluri: \"{{ glance_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":404,"context_line":"#glance_service_internalurl: \"{{ glance_service_internaluri }}\""},{"line_number":405,"context_line":"#glance_service_adminuri: \"{{ glance_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":406,"context_line":"#glance_service_adminurl: \"{{ glance_service_adminuri }}\""},{"line_number":407,"context_line":"#glance_api_servers: \"{{ glance_service_internaluri }}\""},{"line_number":408,"context_line":"octavia_service_user_name: octavia"},{"line_number":409,"context_line":"octavia_service_url: \"http://{{ internal_lb_vip_address }}:9876\""},{"line_number":410,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_bed0d654","line":407,"range":{"start_line":396,"start_character":0,"end_line":407,"end_character":55},"updated":"2017-03-08 15:33:54.000000000","message":"you can remove these comments.","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"46e62bd5eac52acbf4d9d5c2a80253b4b5812d23","unresolved":false,"context_lines":[{"line_number":393,"context_line":"nova_barbican_enabled: \"{{ (groups[\u0027barbican_all\u0027] is defined) and (groups[\u0027barbican_all\u0027] | length \u003e 0) }}\""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"## Octavia"},{"line_number":396,"context_line":"#glance_service_port: 9292"},{"line_number":397,"context_line":"#glance_service_proto: http"},{"line_number":398,"context_line":"#glance_service_publicuri_proto: \"{{ openstack_service_publicuri_proto | default(glance_service_proto) }}\""},{"line_number":399,"context_line":"#glance_service_adminuri_proto: \"{{ openstack_service_adminuri_proto | default(glance_service_proto) }}\""},{"line_number":400,"context_line":"#glance_service_internaluri_proto: \"{{ openstack_service_internaluri_proto | default(glance_service_proto) }}\""},{"line_number":401,"context_line":"#glance_service_publicuri: \"{{ glance_service_publicuri_proto }}://{{ external_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":402,"context_line":"#glance_service_publicurl: \"{{ glance_service_publicuri }}\""},{"line_number":403,"context_line":"#glance_service_internaluri: \"{{ glance_service_internaluri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":404,"context_line":"#glance_service_internalurl: \"{{ glance_service_internaluri }}\""},{"line_number":405,"context_line":"#glance_service_adminuri: \"{{ glance_service_adminuri_proto }}://{{ internal_lb_vip_address }}:{{ glance_service_port }}\""},{"line_number":406,"context_line":"#glance_service_adminurl: \"{{ glance_service_adminuri }}\""},{"line_number":407,"context_line":"#glance_api_servers: \"{{ glance_service_internaluri }}\""},{"line_number":408,"context_line":"octavia_service_user_name: octavia"},{"line_number":409,"context_line":"octavia_service_url: \"http://{{ internal_lb_vip_address }}:9876\""},{"line_number":410,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_19ebbcb1","line":407,"range":{"start_line":396,"start_character":0,"end_line":407,"end_character":55},"in_reply_to":"9a30ddce_bed0d654","updated":"2017-03-08 15:56:37.000000000","message":"Done","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":406,"context_line":"#glance_service_adminurl: \"{{ glance_service_adminuri }}\""},{"line_number":407,"context_line":"#glance_api_servers: \"{{ glance_service_internaluri }}\""},{"line_number":408,"context_line":"octavia_service_user_name: octavia"},{"line_number":409,"context_line":"octavia_service_url: \"http://{{ internal_lb_vip_address }}:9876\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# RPC"},{"line_number":412,"context_line":"octavia_rabbitmq_userid: octavia"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_7e565ed3","line":409,"range":{"start_line":409,"start_character":22,"end_line":409,"end_character":26},"updated":"2017-03-08 15:33:54.000000000","message":"Can we make the proto and port dependent on a var?\n\nCould the internal_lb_vip_address be replaced with something similar to the other services?","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"46e62bd5eac52acbf4d9d5c2a80253b4b5812d23","unresolved":false,"context_lines":[{"line_number":406,"context_line":"#glance_service_adminurl: \"{{ glance_service_adminuri }}\""},{"line_number":407,"context_line":"#glance_api_servers: \"{{ glance_service_internaluri }}\""},{"line_number":408,"context_line":"octavia_service_user_name: octavia"},{"line_number":409,"context_line":"octavia_service_url: \"http://{{ internal_lb_vip_address }}:9876\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"# RPC"},{"line_number":412,"context_line":"octavia_rabbitmq_userid: octavia"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_39d24001","line":409,"range":{"start_line":409,"start_character":22,"end_line":409,"end_character":26},"in_reply_to":"9a30ddce_7e565ed3","updated":"2017-03-08 15:56:37.000000000","message":"Done","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"}],"playbooks/inventory/group_vars/neutron_all.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"neutron_venv_tag: \"{{ venv_tag }}\""},{"line_number":28,"context_line":"neutron_venv_download_url: \"{{ venv_base_download_url }}/neutron-{{ openstack_release }}-{{ ansible_architecture | lower }}.tgz\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"neutron_lbaas_octavia: \"{{ (groups[\u0027octavia_all\u0027] is defined) and (groups[\u0027octavia_all\u0027] | length \u003e 0) }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a30ddce_dea4aaba","line":30,"updated":"2017-03-08 15:33:54.000000000","message":"While I love the pattern, I don\u0027t think it\u0027s a great idea to reference the an external group of the group targeted by the group var.\n\nlet\u0027s keep it until I figure out something better ;)","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"}],"playbooks/inventory/group_vars/octavia_all.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_5fb77df4","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2017-03-10 12:33:22.000000000","message":"boilerplate needs to be updated for 2017","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2016, Rackspace US, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_04d7794b","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"9a30ddce_5fb77df4","updated":"2017-03-10 13:49:13.000000000","message":"Done","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"}],"playbooks/os-octavia-install.yml":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"23e948b25969616e3a917f1e392aa2983e4b4d0d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  pre_tasks:"},{"line_number":22,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":23,"context_line":"      static: no"},{"line_number":24,"context_line":"#      vars:"},{"line_number":25,"context_line":"#        list_of_bind_mounts:"},{"line_number":26,"context_line":"#          - bind_dir_path: \"/var/lib/glance/images\""},{"line_number":27,"context_line":"#            mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":28,"context_line":"#      when:"},{"line_number":29,"context_line":"#        - glance_default_store \u003d\u003d \"file\""},{"line_number":30,"context_line":"#        - (glance_nfs_client is not defined) or (glance_nfs_client | length \u003d\u003d 0)"},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":"      static: no"},{"line_number":33,"context_line":"#      when: (glance_default_store !\u003d \"file\") or (glance_nfs_client is defined)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a3c09a3_e556a3cc","line":30,"range":{"start_line":22,"start_character":0,"end_line":30,"end_character":82},"updated":"2017-01-18 16:50:57.000000000","message":"duplicated by the include below, so cut this","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"420aead0c472b710d038ac65daff77f4daa18a96","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  pre_tasks:"},{"line_number":22,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":23,"context_line":"      static: no"},{"line_number":24,"context_line":"#      vars:"},{"line_number":25,"context_line":"#        list_of_bind_mounts:"},{"line_number":26,"context_line":"#          - bind_dir_path: \"/var/lib/glance/images\""},{"line_number":27,"context_line":"#            mount_path: \"/openstack/{{ inventory_hostname }}\""},{"line_number":28,"context_line":"#      when:"},{"line_number":29,"context_line":"#        - glance_default_store \u003d\u003d \"file\""},{"line_number":30,"context_line":"#        - (glance_nfs_client is not defined) or (glance_nfs_client | length \u003d\u003d 0)"},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":"      static: no"},{"line_number":33,"context_line":"#      when: (glance_default_store !\u003d \"file\") or (glance_nfs_client is defined)"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a3905b3_35ed78b7","line":30,"range":{"start_line":22,"start_character":0,"end_line":30,"end_character":82},"in_reply_to":"7a3c09a3_e556a3cc","updated":"2017-01-23 16:44:51.000000000","message":"Done","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"23e948b25969616e3a917f1e392aa2983e4b4d0d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#        - (glance_nfs_client is not defined) or (glance_nfs_client | length \u003d\u003d 0)"},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":"      static: no"},{"line_number":33,"context_line":"#      when: (glance_default_store !\u003d \"file\") or (glance_nfs_client is defined)"},{"line_number":34,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"},{"line_number":35,"context_line":"      static: no"},{"line_number":36,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a3c09a3_65bd5301","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":79},"updated":"2017-01-18 16:50:57.000000000","message":"we know you won\u0027t need this conditional, so cut this","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"420aead0c472b710d038ac65daff77f4daa18a96","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#        - (glance_nfs_client is not defined) or (glance_nfs_client | length \u003d\u003d 0)"},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":"      static: no"},{"line_number":33,"context_line":"#      when: (glance_default_store !\u003d \"file\") or (glance_nfs_client is defined)"},{"line_number":34,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"},{"line_number":35,"context_line":"      static: no"},{"line_number":36,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a3905b3_552e84fb","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":79},"in_reply_to":"7a3c09a3_65bd5301","updated":"2017-01-23 16:44:51.000000000","message":"Done","commit_id":"a571ea8ffdfd65692de7c0745f70a07b05e83f7d"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"abe165ddd4c5ea923c22cfbb0dc0bd5590e4bb7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      vars:"},{"line_number":36,"context_line":"        log_dirs:"},{"line_number":37,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-octavia\""},{"line_number":38,"context_line":"            dest: \"/var/log/ocatvia\""},{"line_number":39,"context_line":"    - include: common-tasks/mysql-db-user.yml"},{"line_number":40,"context_line":"      static: no"},{"line_number":41,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a30ddce_b83bb7ea","line":38,"updated":"2017-03-07 18:32:05.000000000","message":"s/ocatvia/octavia/","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"ceb7661672371d51f80694473daced6b1b6e62d0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      vars:"},{"line_number":36,"context_line":"        log_dirs:"},{"line_number":37,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-octavia\""},{"line_number":38,"context_line":"            dest: \"/var/log/ocatvia\""},{"line_number":39,"context_line":"    - include: common-tasks/mysql-db-user.yml"},{"line_number":40,"context_line":"      static: no"},{"line_number":41,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a30ddce_5ec62368","line":38,"in_reply_to":"9a30ddce_b83bb7ea","updated":"2017-03-07 18:56:27.000000000","message":"Done","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"}],"playbooks/vars/configs/haproxy_config.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      haproxy_balance_type: http"},{"line_number":274,"context_line":"      haproxy_backend_options:"},{"line_number":275,"context_line":"        - \"httpchk GET /\""},{"line_number":276,"context_line":"      haproxy_whitelist_networks: # Octavia is internal only pre Pike"},{"line_number":277,"context_line":"        - 192.168.0.0/16"},{"line_number":278,"context_line":"        - 172.16.0.0/12"},{"line_number":279,"context_line":"        - 10.0.0.0/8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_3fae4981","line":276,"range":{"start_line":276,"start_character":34,"end_line":276,"end_character":69},"updated":"2017-03-10 12:33:22.000000000","message":"this is being added into the development cycle for Pike, I think this comment could be removed.","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      haproxy_balance_type: http"},{"line_number":274,"context_line":"      haproxy_backend_options:"},{"line_number":275,"context_line":"        - \"httpchk GET /\""},{"line_number":276,"context_line":"      haproxy_whitelist_networks: # Octavia is internal only pre Pike"},{"line_number":277,"context_line":"        - 192.168.0.0/16"},{"line_number":278,"context_line":"        - 172.16.0.0/12"},{"line_number":279,"context_line":"        - 10.0.0.0/8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a30ddce_8471a978","line":276,"range":{"start_line":276,"start_character":34,"end_line":276,"end_character":69},"in_reply_to":"9a30ddce_3fae4981","updated":"2017-03-10 13:49:13.000000000","message":"Done","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"1882f20c35c6fd2b408042958d30591a977d130b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      haproxy_balance_type: http"},{"line_number":274,"context_line":"      haproxy_backend_options:"},{"line_number":275,"context_line":"        - \"httpchk GET /\""},{"line_number":276,"context_line":"      haproxy_whitelist_networks: "},{"line_number":277,"context_line":"        - 192.168.0.0/16"},{"line_number":278,"context_line":"        - 172.16.0.0/12"},{"line_number":279,"context_line":"        - 10.0.0.0/8"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_45ef941d","line":276,"range":{"start_line":276,"start_character":33,"end_line":276,"end_character":34},"updated":"2017-03-11 22:04:57.000000000","message":"nit: extra whitespace","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"05a1150c3a55ade897153c8571999e96de94cc91","unresolved":false,"context_lines":[{"line_number":273,"context_line":"      haproxy_balance_type: http"},{"line_number":274,"context_line":"      haproxy_backend_options:"},{"line_number":275,"context_line":"        - \"httpchk GET /\""},{"line_number":276,"context_line":"      haproxy_whitelist_networks: "},{"line_number":277,"context_line":"        - 192.168.0.0/16"},{"line_number":278,"context_line":"        - 172.16.0.0/12"},{"line_number":279,"context_line":"        - 10.0.0.0/8"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9a30ddce_9ff54cee","line":276,"range":{"start_line":276,"start_character":33,"end_line":276,"end_character":34},"in_reply_to":"9a30ddce_45ef941d","updated":"2017-03-13 01:20:15.000000000","message":"Done","commit_id":"e13174b7c829a110108236b0d3d871c588331b9a"}],"scripts/bootstrap-aio.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"15bae15f09c4e4a5777bdda1bdcfddd2c7b258d5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9a30ddce_7ef3be9e","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":45},"updated":"2017-03-08 15:33:54.000000000","message":"why do you want to introduce this feature?","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"46e62bd5eac52acbf4d9d5c2a80253b4b5812d23","unresolved":false,"context_lines":[{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"9a30ddce_396ec02f","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":45},"in_reply_to":"9a30ddce_7ef3be9e","updated":"2017-03-08 15:56:37.000000000","message":"I found it useful to enable ansible\u0027s debug options during bootstrap (-vvv)","commit_id":"5704592ff76eaaa196b6cb3d4bbaf12c6c3330ac"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82d3c4a0ee82a9c08f18c6b1314cc7018abd8166","unresolved":false,"context_lines":[{"line_number":24,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"},{"line_number":34,"context_line":"                     -e \"${BOOTSTRAP_OPTS}\" $@"},{"line_number":35,"context_line":"  fi"},{"line_number":36,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a30ddce_1fe425df","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":4},"updated":"2017-03-10 12:33:22.000000000","message":"Why is this being done?","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"2c15ecda031e4bb5ce96e152da169a285fa05149","unresolved":false,"context_lines":[{"line_number":24,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"},{"line_number":34,"context_line":"                     -e \"${BOOTSTRAP_OPTS}\" $@"},{"line_number":35,"context_line":"  fi"},{"line_number":36,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a30ddce_d3bd2169","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":4},"in_reply_to":"9a30ddce_13e5f9da","updated":"2017-03-10 15:46:21.000000000","message":"Reverted to the original","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"7443a44cde250b96196736208b6dd2aa2753e036","unresolved":false,"context_lines":[{"line_number":24,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"},{"line_number":34,"context_line":"                     -e \"${BOOTSTRAP_OPTS}\" $@"},{"line_number":35,"context_line":"  fi"},{"line_number":36,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a30ddce_a4014db1","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":4},"in_reply_to":"9a30ddce_1fe425df","updated":"2017-03-10 13:49:13.000000000","message":"I found it useful to pass the debug flags to sensible during bootstrap for debugging.","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6ca6deec47176b0e90f84bedcdd9c38f0c1866ee","unresolved":false,"context_lines":[{"line_number":24,"context_line":"## Main ----------------------------------------------------------------------"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Run AIO bootstrap playbook"},{"line_number":27,"context_line":"pushd tests"},{"line_number":28,"context_line":"  if [ -z \"${BOOTSTRAP_OPTS}\" ]; then"},{"line_number":29,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":30,"context_line":"                     -i test-inventory.ini $@"},{"line_number":31,"context_line":"  else"},{"line_number":32,"context_line":"    ansible-playbook bootstrap-aio.yml \\"},{"line_number":33,"context_line":"                     -i test-inventory.ini \\"},{"line_number":34,"context_line":"                     -e \"${BOOTSTRAP_OPTS}\" $@"},{"line_number":35,"context_line":"  fi"},{"line_number":36,"context_line":"popd"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9a30ddce_13e5f9da","line":36,"range":{"start_line":27,"start_character":0,"end_line":36,"end_character":4},"in_reply_to":"9a30ddce_a4014db1","updated":"2017-03-10 15:40:41.000000000","message":"this should probably come in as another review if we think it\u0027s a good thing to have.","commit_id":"8add3d31ccf571361033d2214c1b248bef45af1e"}],"tests/roles/bootstrap-host/templates/osa_interfaces.cfg.j2":[{"author":{"_account_id":11268,"name":"Miguel Alex Cantu (alextricity25)","email":"miguel.can2@gmail.com","username":"elextro"},"change_message_id":"f4c02ddc3040aed77f573cc0ba45707a893b3f45","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    pre-up ip link set eth14 up"},{"line_number":20,"context_line":"    # Delete veth pair on DOWN"},{"line_number":21,"context_line":"    post-down ip link del br-mgmt-veth || true"},{"line_number":22,"context_line":"    bridge_ports br-mgmt-veth {% if bootstrap_host_bridge_mgmt_ports|string() !\u003d \"none\" %}{{ bootstrap_host_bridge_mgmt_ports }} {% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"auto br-vxlan"},{"line_number":25,"context_line":"iface br-vxlan inet static"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ba2be162_145f5173","line":22,"updated":"2017-02-28 18:36:57.000000000","message":"Instead of using the |string() filter here, you can write:\n\"{% if bootstrap_host_bridge_mgmt_ports is defined %}\"","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"dee5fe6ecb790037f5d835332d8ebe3d654e1d26","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    pre-up ip link set eth14 up"},{"line_number":20,"context_line":"    # Delete veth pair on DOWN"},{"line_number":21,"context_line":"    post-down ip link del br-mgmt-veth || true"},{"line_number":22,"context_line":"    bridge_ports br-mgmt-veth {% if bootstrap_host_bridge_mgmt_ports|string() !\u003d \"none\" %}{{ bootstrap_host_bridge_mgmt_ports }} {% endif %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"auto br-vxlan"},{"line_number":25,"context_line":"iface br-vxlan inet static"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ba2be162_3d2b5932","line":22,"in_reply_to":"ba2be162_145f5173","updated":"2017-02-28 19:22:48.000000000","message":"Done","commit_id":"f678ce53b4795764cadf0622c0263b4cf085b438"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"abe165ddd4c5ea923c22cfbb0dc0bd5590e4bb7c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    address 172.29.236.100"},{"line_number":13,"context_line":"    netmask 255.255.252.0"},{"line_number":14,"context_line":"    offload-sg off"},{"line_number":15,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":16,"context_line":"    pre-up ip link add br-mgmt-veth type veth peer name eth14 || true"},{"line_number":17,"context_line":"    # Set both ends UP"},{"line_number":18,"context_line":"    pre-up ip link set br-mgmt-veth up"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9a30ddce_d8406b59","line":15,"updated":"2017-03-07 18:32:05.000000000","message":"An Octavia comment in here would be helpful. These files don\u0027t change often. ;)","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"ceb7661672371d51f80694473daced6b1b6e62d0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    address 172.29.236.100"},{"line_number":13,"context_line":"    netmask 255.255.252.0"},{"line_number":14,"context_line":"    offload-sg off"},{"line_number":15,"context_line":"    # Create veth pair, don\u0027t bomb if already exists"},{"line_number":16,"context_line":"    pre-up ip link add br-mgmt-veth type veth peer name eth14 || true"},{"line_number":17,"context_line":"    # Set both ends UP"},{"line_number":18,"context_line":"    pre-up ip link set br-mgmt-veth up"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"9a30ddce_9ee25bd4","line":15,"in_reply_to":"9a30ddce_d8406b59","updated":"2017-03-07 18:56:27.000000000","message":"Done","commit_id":"85d34f16cccbbbab9da246e862c17d1515dc4eb9"}]}
