)]}'
{"lib/manage.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"017bce2e0cf22fbda7dd3fd6c904e710af63f2c9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        epilog\u003d\u0027Inventory Generator Licensed \"Apache 2.0\"\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027-f\u0027,"},{"line_number":38,"context_line":"        \u0027--file\u0027,"},{"line_number":39,"context_line":"        help\u003d\u0027Inventory file.\u0027,"},{"line_number":40,"context_line":"        required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_788b7fc3","side":"PARENT","line":37,"updated":"2017-02-14 19:15:17.000000000","message":"this change is backward incompatible. Should be deprecated properly, or just retained. Both require plumbing load_inventory to optionally accept a filename. I don\u0027t like that this feels like scope creep, but stripping an existing parameter is breaking.","commit_id":"ed5acb36c8ee33dc816f0661b35e1ce6dc1c5f2e"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"4f76663ec3db843558516397415193048653668c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        epilog\u003d\u0027Inventory Generator Licensed \"Apache 2.0\"\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027-f\u0027,"},{"line_number":38,"context_line":"        \u0027--file\u0027,"},{"line_number":39,"context_line":"        help\u003d\u0027Inventory file.\u0027,"},{"line_number":40,"context_line":"        required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_d88e9d26","side":"PARENT","line":37,"in_reply_to":"fa31d9ce_788b7fc3","updated":"2017-02-17 15:18:34.000000000","message":"I\u0027d agree - removing a user-facing parameter should throw a deprecation warning. Keeping it and using it may not be consistent with the rest of the code base, but I\u0027d personally prefer maintaining expectations first, then code consistency.","commit_id":"ed5acb36c8ee33dc816f0661b35e1ce6dc1c5f2e"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"bb30a132155a13e75a9a7358e89963350a2b519b","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def remove_ip_addresses(inventory, filepath\u003dNone):"},{"line_number":278,"context_line":"    \"\"\"Removes container IP address information from the inventory dictionary"},{"line_number":279,"context_line":"    And writes the changes into the inventory file in filepath"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    All container_networks information for containers will be deleted."},{"line_number":282,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b8f09792","line":279,"updated":"2017-02-14 18:59:16.000000000","message":"This will need a space above it to make H405 happy","commit_id":"18392c33695bbcd94cbbab93d8ae3d0796738dee"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"bb30a132155a13e75a9a7358e89963350a2b519b","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"def remove_inventory_item(remove_item, inventory, filepath\u003dNone):"},{"line_number":303,"context_line":"    \"\"\"Removes inventory item from the inventory dictionary"},{"line_number":304,"context_line":"    And writes tje changes into the inventory file in filepath"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    All container_networks information for containers will be deleted."},{"line_number":307,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_1832835f","line":304,"updated":"2017-02-14 18:59:16.000000000","message":"This will need a space above it to make H405","commit_id":"18392c33695bbcd94cbbab93d8ae3d0796738dee"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"017bce2e0cf22fbda7dd3fd6c904e710af63f2c9","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"def remove_inventory_item(remove_item, inventory, filepath\u003dNone):"},{"line_number":303,"context_line":"    \"\"\"Removes inventory item from the inventory dictionary"},{"line_number":304,"context_line":"    And writes tje changes into the inventory file in filepath"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    All container_networks information for containers will be deleted."},{"line_number":307,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_9853d36a","line":304,"range":{"start_line":304,"start_character":15,"end_line":304,"end_character":18},"updated":"2017-02-14 19:15:17.000000000","message":"typo","commit_id":"18392c33695bbcd94cbbab93d8ae3d0796738dee"}],"tests/test_manage.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"017bce2e0cf22fbda7dd3fd6c904e710af63f2c9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import unittest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"MANAGE_DIR \u003d path.join(os.getcwd(), \u0027lib\u0027)"},{"line_number":22,"context_line":"TARGET_DIR \u003d path.join(os.getcwd(), \u0027tests\u0027, \u0027inventory\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"sys.path.append(MANAGE_DIR)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_93ae54e4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":10},"updated":"2017-02-14 19:15:17.000000000","message":"TARGET_PATH would be more accurate, lets tests act as documented examples","commit_id":"18392c33695bbcd94cbbab93d8ae3d0796738dee"}]}