)]}'
{"scripts/run-upgrade.sh":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"84f5a765672fd3cf832ae2b63790dfbfa1eb06ec","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    This script will perform a ${SOURCE_SERIES^} to ${TARGET_SERIES^} upgrade."},{"line_number":127,"context_line":"    Once you start the upgrade there\u0027s no going back."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Note that the upgrade targets impacting the data"},{"line_number":130,"context_line":"    plane as little as possible, but assumes that the"},{"line_number":131,"context_line":"    control plane can experience some down time."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a1ced50_5110ff4e","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":25},"updated":"2017-03-16 23:23:07.000000000","message":"What type of upgrade will be attempted? Is the same process for all of the services? if not it might be good add few lines about it\n\nBased on upgrade assertion tags:\n\n* supports-upgrade\n* supports-accessible-upgrade\n* assert:supports-rolling-upgrade\n* assert:supports-zero-downtime-upgrade\n* assert:supports-zero-impact-upgrade","commit_id":"9f07028832c97b6e3ca39873343d4e1ed4a8779d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ad587fcfcf683b6e65d96b5fb900b9d987541fb4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    This script will perform a ${SOURCE_SERIES^} to ${TARGET_SERIES^} upgrade."},{"line_number":127,"context_line":"    Once you start the upgrade there\u0027s no going back."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Note that the upgrade targets impacting the data"},{"line_number":130,"context_line":"    plane as little as possible, but assumes that the"},{"line_number":131,"context_line":"    control plane can experience some down time."},{"line_number":132,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a1ced50_d77e95ad","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":25},"in_reply_to":"1a1ced50_5110ff4e","updated":"2017-03-17 09:23:16.000000000","message":"We will always attempt the best that the service can provide. This kind of detail does not belong in the script IMO, but instead in the documentation.","commit_id":"9f07028832c97b6e3ca39873343d4e1ed4a8779d"}],"scripts/upgrade-utilities/playbooks/deploy-config-changes.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"1c3c0b032abdb2878019100f1e8a9b2489b1af5f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      - name: Update OpenStack variable names"},{"line_number":56,"context_line":"        command: \"{{ upgrade_scripts }}/migrate_openstack_vars.py {{ item }} {{ (item | basename)[:-4] }}\""},{"line_number":57,"context_line":"        args:"},{"line_number":58,"context_line":"            creates: \"/etc/openstack_deploy.NEWTON/VARS_MIGRATED_{{ (item | basename)[:-4] }}\""},{"line_number":59,"context_line":"        with_fileglob:"},{"line_number":60,"context_line":"          - \"/etc/openstack_deploy/user_*.yml\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a30ddce_16e35d34","line":58,"range":{"start_line":58,"start_character":44,"end_line":58,"end_character":50},"updated":"2017-03-09 15:39:39.000000000","message":"Shouldn\u0027t we fix this at the same time, like you did above?","commit_id":"0e02cb0f473518962355185e80e14525d4bacb56"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7f55d31cae992906aa02e2c38086e8b211f8d775","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      - name: Update OpenStack variable names"},{"line_number":56,"context_line":"        command: \"{{ upgrade_scripts }}/migrate_openstack_vars.py {{ item }} {{ (item | basename)[:-4] }}\""},{"line_number":57,"context_line":"        args:"},{"line_number":58,"context_line":"            creates: \"/etc/openstack_deploy.NEWTON/VARS_MIGRATED_{{ (item | basename)[:-4] }}\""},{"line_number":59,"context_line":"        with_fileglob:"},{"line_number":60,"context_line":"          - \"/etc/openstack_deploy/user_*.yml\""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a30ddce_367b01f7","line":58,"range":{"start_line":58,"start_character":44,"end_line":58,"end_character":50},"in_reply_to":"9a30ddce_16e35d34","updated":"2017-03-09 15:45:24.000000000","message":"Yes, that got missed in this patch. A follow on patch is coming: https://review.openstack.org/443645 - once that merges I\u0027ll backport on top of this.","commit_id":"0e02cb0f473518962355185e80e14525d4bacb56"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4b220342802e85e92a4c7606a28ea31cbf97ce80","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":23,"context_line":"      repo_root_dir: \"{{ playbook_dir }}/../../../\""},{"line_number":24,"context_line":"      source_series: \"mitaka\""},{"line_number":25,"context_line":"  tasks:"},{"line_number":26,"context_line":"      - name: Create an old copy of openstack_deploy"},{"line_number":27,"context_line":"        copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a30ddce_08b875c7","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":28},"updated":"2017-03-10 10:16:57.000000000","message":"Sorry to be a pain again, but this seems already defined in ENV vars.\nI\u0027d use a lookup instead of redefining it.\n\nAlso I think we used to have target not source series, which breaks stuff. To be verified though, I\u0027m not sure :p","commit_id":"9f07028832c97b6e3ca39873343d4e1ed4a8779d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"9bbe0ba9819853ce479b11f0f4352ecfccb558fe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"      upgrade_scripts: \"{{ playbook_dir }}/../scripts\""},{"line_number":23,"context_line":"      repo_root_dir: \"{{ playbook_dir }}/../../../\""},{"line_number":24,"context_line":"      source_series: \"mitaka\""},{"line_number":25,"context_line":"  tasks:"},{"line_number":26,"context_line":"      - name: Create an old copy of openstack_deploy"},{"line_number":27,"context_line":"        copy:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a30ddce_1ae6c0e7","line":24,"range":{"start_line":24,"start_character":22,"end_line":24,"end_character":28},"in_reply_to":"9a30ddce_08b875c7","updated":"2017-03-13 10:38:46.000000000","message":"It\u0027s a backup of config prior to the migration, so it makes sense to me that this is retained as the source, not the target version.\n\nThe env var will only be set if the run-upgrade script is used. I expect that this whole thing will either be dumped or refactored soon.","commit_id":"9f07028832c97b6e3ca39873343d4e1ed4a8779d"}]}
