)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3718a169c0e05ad05aba1b2cfeeb1774c47ec273","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   of cinder are the same across all nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://docs.openstack.org/developer/cinder/upgrade.html#minimal-downtime-upgrade-procedure"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I0bdb51ce0d8b3b9a145d29ef6808e1fe595924e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_6be48ee0","line":23,"updated":"2017-06-04 09:25:42.000000000","message":"Related-To: Ia9df064ff145bec862e2a2cc0fd180a9188c5238\nRelated-To: I38ab4345f06ba6c9ef45cfe8e3ef48f2328b2333\nDepends-On: I9aacda78f92355374af3f4ab24d2d9a9b47491ed","commit_id":"c770bb586b95958ea04d1bb1664faa7f7415a636"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fcb89d35d324dc1d80dc4731f50e6e8c0d4013b1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   of cinder are the same across all nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://docs.openstack.org/developer/cinder/upgrade.html#minimal-downtime-upgrade-procedure"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I0bdb51ce0d8b3b9a145d29ef6808e1fe595924e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_cbeddab7","line":23,"in_reply_to":"df140735_6be48ee0","updated":"2017-06-04 09:35:08.000000000","message":"Depends-On: Id80dfc8f75f2efdb35b19c4e6bb899475623d824","commit_id":"c770bb586b95958ea04d1bb1664faa7f7415a636"}],"group_vars/cinder_all.yml":[{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"72bc139fdee88b1b7a3f3945622bdf05f7046616","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Toggle whether the service is deployed in a container or not"},{"line_number":17,"context_line":"is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# The MySQL details for the cinder service"},{"line_number":20,"context_line":"cinder_galera_user: cinder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_09df99d6","line":17,"updated":"2017-06-01 18:02:11.000000000","message":"Does moving this to group_vars still allow flexibility for each cinder service/host?","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6739cd60f240120544f89d0cf07c34577e72ef92","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Toggle whether the service is deployed in a container or not"},{"line_number":17,"context_line":"is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# The MySQL details for the cinder service"},{"line_number":20,"context_line":"cinder_galera_user: cinder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_92d3d2d5","line":17,"in_reply_to":"df140735_09df99d6","updated":"2017-06-01 19:53:14.000000000","message":"It\u0027s my understanding that the group_vars are put on top of the inventory script vars, so it should. It should even more especially because playbook vars are higher precedence.","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"}],"group_vars/cinder_api.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# This variable contains the values of the local fact set for the cinder"},{"line_number":18,"context_line":"# venv tag for all hosts in the \u0027cinder_all\u0027 host group."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"cinder_all_software_versions: \"{{ ((groups[\u0027cinder_all\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_local\u0027, \u0027openstack_ansible\u0027, \u0027cinder\u0027, \u0027venv_tag\u0027])) | list) }}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# This variable outputs a boolean value which is True when"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_eec9b525","line":20,"updated":"2017-06-05 15:29:26.000000000","message":"That will be pretty slow with a lot of hosts.\nIt\u0027s pretty rare when I say that I want to transfer a group var to a task, but I think this time it\u0027s worth it.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3b11773de9e9a603c1efa7507210c0372080ad81","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# This variable contains the values of the local fact set for the cinder"},{"line_number":18,"context_line":"# venv tag for all hosts in the \u0027cinder_all\u0027 host group."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"cinder_all_software_versions: \"{{ ((groups[\u0027cinder_all\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_local\u0027, \u0027openstack_ansible\u0027, \u0027cinder\u0027, \u0027venv_tag\u0027])) | list) }}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# This variable outputs a boolean value which is True when"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_50126063","line":20,"in_reply_to":"df140735_d01f90b4","updated":"2017-06-06 13:33:04.000000000","message":"If it\u0027s possible to avoid map extract of the whole hostvars, that would be great.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92bd97f4e5dfd4a43496f890871e93e0f70e78ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# This variable contains the values of the local fact set for the cinder"},{"line_number":18,"context_line":"# venv tag for all hosts in the \u0027cinder_all\u0027 host group."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"cinder_all_software_versions: \"{{ ((groups[\u0027cinder_all\u0027] | map(\u0027extract\u0027, hostvars, [\u0027ansible_local\u0027, \u0027openstack_ansible\u0027, \u0027cinder\u0027, \u0027venv_tag\u0027])) | list) }}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# This variable outputs a boolean value which is True when"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_d01f90b4","line":20,"in_reply_to":"df140735_eec9b525","updated":"2017-06-06 13:24:45.000000000","message":"How would that be any different? I guess it could be a run_once task and set a fact on localhost - that way it would not have to execute for all hosts.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"}],"playbooks/common-tasks/restart-service.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0ad4505c7182bde96df6fdcf1df91ee6bbe0924f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7f231b9d_3643a96e","updated":"2017-06-15 18:52:13.000000000","message":"very nice!","commit_id":"eaa182e382538f3e509fd86ef9f829bf8ce9f872"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"15a613e181967b9846d25918e44047b6da682d2e","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Execute service action"},{"line_number":33,"context_line":"  service:"},{"line_number":34,"context_line":"    name: \"{{ service_file | regex_replace(\u0027.service\u0027, \u0027\u0027) }}\""},{"line_number":35,"context_line":"    state: \"{{ service_action }}\""},{"line_number":36,"context_line":"  with_items: \"{{ _enabled_services.stdout_lines }}\""},{"line_number":37,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7f231b9d_ac5a937f","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":58},"updated":"2017-06-19 03:05:11.000000000","message":"Does the ansible module require you strip .service? I think systemd accepts either \u0027serviceunit\u0027 (and assumes .service) or \u0027serviceunit.service\u0027 explicit. Not sure about the module but it seems possibly unnecessary","commit_id":"eaa182e382538f3e509fd86ef9f829bf8ce9f872"}],"playbooks/os-cinder-install.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9c169d4be5251a9bc68339bce880193067fda4c0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  max_fail_percentage: 20"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    cinder_serial:"},{"line_number":25,"context_line":"      - 1"},{"line_number":26,"context_line":"      - 100%"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_8cce17b2","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"updated":"2017-06-01 18:23:56.000000000","message":"why is this a var? could it not be just in the serial line?","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"8e66b0c384e5c37be7da458168daf172ca64d29e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  max_fail_percentage: 20"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    cinder_serial:"},{"line_number":25,"context_line":"      - 1"},{"line_number":26,"context_line":"      - 100%"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_c0f83d7c","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"df140735_8396e24b","updated":"2017-06-02 09:46:29.000000000","message":"Sure, I can do that. I\u0027m thinking that perhaps each group should have its own var so that the serialization can be individually controlled without using --limit. Thoughts?","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6739cd60f240120544f89d0cf07c34577e72ef92","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  max_fail_percentage: 20"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    cinder_serial:"},{"line_number":25,"context_line":"      - 1"},{"line_number":26,"context_line":"      - 100%"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_f2968ef0","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"df140735_8cce17b2","updated":"2017-06-01 19:53:14.000000000","message":"It\u0027s a var to allow the use -f extra-vars to override this behaviour should it need to be. It\u0027s following the keystone play pattern.\n\nIdeally it should actually just be \u0027serial: 1\u0027 to give the least effect when upgrading, but that makes new deployments take forever. That\u0027s why I did the PoC in https://review.openstack.org/469605 to try and make things more adaptive.","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"fe9e664c23b269bcf6def42b68ea805dbe2a9f5e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  max_fail_percentage: 20"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    cinder_serial:"},{"line_number":25,"context_line":"      - 1"},{"line_number":26,"context_line":"      - 100%"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_19d22701","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"df140735_c0f83d7c","updated":"2017-06-02 15:49:06.000000000","message":"My initial reaction is that its maybe a little var overkill to do separate ones, Im not sure if that adds much value beyond being able to control it per-service. If you really wanted to implement that as an operator you could run with\n\ncinder_serial: \u003e-\n  {% if \u0027cinder_api\u0027 in group_names %}[ 1 ]{% endif -%}\n  {% if \u0027cinder_scheduler\u0027 in group_names %}[ 1, \u0027100%\u0027 ]{% endif -%}\n\nits not that pretty, but i\u0027m not sure the var clutter is worth it to satisfy what may be a super edge-case.","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"85156baca926efe7fb3b2b18f4ae96e15691633f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  max_fail_percentage: 20"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    cinder_serial:"},{"line_number":25,"context_line":"      - 1"},{"line_number":26,"context_line":"      - 100%"},{"line_number":27,"context_line":"  tags:"},{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_8396e24b","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":12},"in_reply_to":"df140735_f2968ef0","updated":"2017-06-01 21:37:31.000000000","message":"\"{{ cinder_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\" would still allow a var to override","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9c169d4be5251a9bc68339bce880193067fda4c0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":34,"context_line":"      vars:"},{"line_number":35,"context_line":"        log_dirs:"},{"line_number":36,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-cinder\""},{"line_number":37,"context_line":"            dest: \"/var/log/cinder\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"},{"line_number":42,"context_line":"      static: no"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_6cfaa3bd","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":51},"updated":"2017-06-01 18:23:56.000000000","message":"seems like we could do all of the pre-tasks here in one play targetting cinder_all, and cut these out from the folling plays.","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6739cd60f240120544f89d0cf07c34577e72ef92","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - cinder"},{"line_number":29,"context_line":"  pre_tasks:"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":34,"context_line":"      vars:"},{"line_number":35,"context_line":"        log_dirs:"},{"line_number":36,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-cinder\""},{"line_number":37,"context_line":"            dest: \"/var/log/cinder\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"},{"line_number":42,"context_line":"      static: no"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_f2bfae5e","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":51},"in_reply_to":"df140735_6cfaa3bd","updated":"2017-06-01 19:53:14.000000000","message":"We could, but then we\u0027d have double-down-time if there happened to be a container config change and a service config change. If you count the lxc-containers-create playbook in as well there\u0027s the potential for triple-down-time.","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9c169d4be5251a9bc68339bce880193067fda4c0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      tags:"},{"line_number":206,"context_line":"        - crontab"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"- name: Install cinder scheduler services"},{"line_number":209,"context_line":"  hosts: cinder_backup"},{"line_number":210,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":211,"context_line":"  serial: \"{{ cinder_serial }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_2cbdcb01","line":208,"range":{"start_line":208,"start_character":23,"end_line":208,"end_character":32},"updated":"2017-06-01 18:23:56.000000000","message":"typo","commit_id":"f1bd17cd37b75e086c1707a7cd5539417d1f4ced"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"268e7715bdb57aff03d1546ccd87b94682c9d925","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - cinder"},{"line_number":24,"context_line":"  tasks:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":27,"context_line":"      vars:"},{"line_number":28,"context_line":"        haproxy_state: disabled"},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":31,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":36,"context_line":"      vars:"},{"line_number":37,"context_line":"        haproxy_state: enabled"},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":40,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":43,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_05f19f01","line":40,"range":{"start_line":26,"start_character":0,"end_line":40,"end_character":45},"updated":"2017-06-02 13:06:34.000000000","message":"The down side with this approach is that every time this playbook runs it will disable, then enable the API service - even when there are no changes to be made to the lxc config.\n\nA possible option here could be to implement some sort of dynamic local facts which tell us whether there\u0027s a change to be made, then to only do this if a change is going to happen. However, that seems like re-implementing a bunch of what Ansible does. :/\n\nAny ideas for this - or is this a small price to pay?","commit_id":"487238baf0ae3a2050e73b5ad6adb7a9447d223d"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"e1a92884baebe7e3f2530a287a70319f06528741","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - cinder"},{"line_number":24,"context_line":"  tasks:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":27,"context_line":"      vars:"},{"line_number":28,"context_line":"        haproxy_state: disabled"},{"line_number":29,"context_line":"      when:"},{"line_number":30,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":31,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":36,"context_line":"      vars:"},{"line_number":37,"context_line":"        haproxy_state: enabled"},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":40,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":43,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_79c2435b","line":40,"range":{"start_line":26,"start_character":0,"end_line":40,"end_character":45},"in_reply_to":"df140735_05f19f01","updated":"2017-06-02 15:49:13.000000000","message":"yep imo this is a reasonable expectation to set for now. if work MAY be performed on the container, place the possibly affected endpoints in maintenance and drain the traffic. maybe we can get smarter about orchestrating it into a \"when work is performed, maintenance mode\" instead of a \"if work may be performed, maintenance mode\" later on but this is a good starting point.","commit_id":"487238baf0ae3a2050e73b5ad6adb7a9447d223d"},{"author":{"_account_id":14805,"name":"Jimmy McCrory","email":"jimmy.mccrory@gmail.com","username":"jimmy-mccrory"},"change_message_id":"20538aaa0434103d7b9ec70eff059060889703be","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  post_tasks:"},{"line_number":108,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":109,"context_line":"      vars:"},{"line_number":110,"context_line":"        haproxy_state: disabled"},{"line_number":111,"context_line":"      when: \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_ee4b2228","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":31},"updated":"2017-06-02 18:04:25.000000000","message":"enabled","commit_id":"22195d73af374be960a0a547db46b5a68dd53064"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"a59caf38cabb722b42f914ac28e98b0eb6ee17d5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  post_tasks:"},{"line_number":108,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":109,"context_line":"      vars:"},{"line_number":110,"context_line":"        haproxy_state: disabled"},{"line_number":111,"context_line":"      when: \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df140735_ee77a2d3","line":110,"range":{"start_line":110,"start_character":23,"end_line":110,"end_character":31},"in_reply_to":"df140735_ee4b2228","updated":"2017-06-02 18:20:04.000000000","message":"Thanks - good catch!","commit_id":"22195d73af374be960a0a547db46b5a68dd53064"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Configure containers"},{"line_number":17,"context_line":"  hosts: cinder_all"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  serial: \"{{ cinder_all_serial | default(\u00271\u0027) }}\""},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_0e8ce9d4","line":18,"range":{"start_line":18,"start_character":20,"end_line":18,"end_character":32},"updated":"2017-06-05 15:29:26.000000000","message":"nit: While we are touching the rest of the deploy, it\u0027s maybe a good time to replace this with osa_gather_facts or ansible_gather_facts :D","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  serial: \"{{ cinder_all_serial | default(\u00271\u0027) }}\""},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - cinder"},{"line_number":24,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_d9d7dd4a","line":21,"updated":"2017-06-05 15:29:26.000000000","message":"What\u0027s the purpose of this (not what it does, but why we should do it, and what do you expect to be in deployment_environment_variables)? Could you add a comment there?","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3b11773de9e9a603c1efa7507210c0372080ad81","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  serial: \"{{ cinder_all_serial | default(\u00271\u0027) }}\""},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - cinder"},{"line_number":24,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_8401d907","line":21,"in_reply_to":"df140735_d0c79063","updated":"2017-06-06 13:33:04.000000000","message":"fair enough.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92bd97f4e5dfd4a43496f890871e93e0f70e78ef","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  serial: \"{{ cinder_all_serial | default(\u00271\u0027) }}\""},{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - cinder"},{"line_number":24,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_d0c79063","line":21,"in_reply_to":"df140735_d9d7dd4a","updated":"2017-06-06 13:24:45.000000000","message":"I think the patch that put this var in explains it all quite well. I really don\u0027t see the point of adding a comment everywhere it\u0027s used - that seems a little excessive don\u0027t you think?\n\nhttps://github.com/openstack/openstack-ansible/commit/77ac88197c223968e845e57706b81af24d6aa443","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":36,"context_line":"      vars:"},{"line_number":37,"context_line":"        haproxy_state: enabled"},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":40,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":43,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_793e91c1","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":45},"updated":"2017-06-05 15:29:26.000000000","message":"Why this? L108 seems good enough. If not, it deserves a comment.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92bd97f4e5dfd4a43496f890871e93e0f70e78ef","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":36,"context_line":"      vars:"},{"line_number":37,"context_line":"        haproxy_state: enabled"},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":40,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":43,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_f07a9421","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":45},"in_reply_to":"df140735_793e91c1","updated":"2017-06-06 13:24:45.000000000","message":"If the container configuration is changing, then the container will stop and restart. We take it out of the LB to cater for that to ensure that new requests go elsewhere during this period.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3b11773de9e9a603c1efa7507210c0372080ad81","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    - include: common-tasks/haproxy-endpoint-manage.yml"},{"line_number":36,"context_line":"      vars:"},{"line_number":37,"context_line":"        haproxy_state: enabled"},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - \"\u0027cinder_api\u0027 in group_names\""},{"line_number":40,"context_line":"        - \"groups[\u0027cinder_api\u0027] | length \u003e 1\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":43,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_a415fd3e","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":45},"in_reply_to":"df140735_f07a9421","updated":"2017-06-06 13:33:04.000000000","message":"please include a comment/name for the include expressing it.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Install cinder API services"},{"line_number":92,"context_line":"  hosts: cinder_api"},{"line_number":93,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":94,"context_line":"  serial: \"{{ cinder_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":95,"context_line":"  max_fail_percentage: 20"},{"line_number":96,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_d9a0fdf6","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":32},"updated":"2017-06-05 15:29:26.000000000","message":"please use a non-reserved name, like osa_gather_facts or ansible_gather_facts. Or maybe use gather_facts: False, and have L18 with gather_facts: True.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"3b11773de9e9a603c1efa7507210c0372080ad81","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Install cinder API services"},{"line_number":92,"context_line":"  hosts: cinder_api"},{"line_number":93,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":94,"context_line":"  serial: \"{{ cinder_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":95,"context_line":"  max_fail_percentage: 20"},{"line_number":96,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_4420619b","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":32},"in_reply_to":"df140735_b0709c41","updated":"2017-06-06 13:33:04.000000000","message":"Agreed.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92bd97f4e5dfd4a43496f890871e93e0f70e78ef","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Install cinder API services"},{"line_number":92,"context_line":"  hosts: cinder_api"},{"line_number":93,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":94,"context_line":"  serial: \"{{ cinder_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":95,"context_line":"  max_fail_percentage: 20"},{"line_number":96,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_b0709c41","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":32},"in_reply_to":"df140735_d9a0fdf6","updated":"2017-06-06 13:24:45.000000000","message":"That\u0027s out of scope for this patch. I can (or you can) work up another patch that deals specifically with that issue.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":91,"context_line":"- name: Install cinder API services"},{"line_number":92,"context_line":"  hosts: cinder_api"},{"line_number":93,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":94,"context_line":"  serial: \"{{ cinder_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":95,"context_line":"  max_fail_percentage: 20"},{"line_number":96,"context_line":"  user: root"},{"line_number":97,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_391a5916","line":94,"updated":"2017-06-05 15:29:26.000000000","message":"should we add any_error_fatal for the first batch?","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"92bd97f4e5dfd4a43496f890871e93e0f70e78ef","unresolved":false,"context_lines":[{"line_number":91,"context_line":"- name: Install cinder API services"},{"line_number":92,"context_line":"  hosts: cinder_api"},{"line_number":93,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":94,"context_line":"  serial: \"{{ cinder_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":95,"context_line":"  max_fail_percentage: 20"},{"line_number":96,"context_line":"  user: root"},{"line_number":97,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_b0ec1cbb","line":94,"in_reply_to":"df140735_391a5916","updated":"2017-06-06 13:24:45.000000000","message":"Possibly. I did that in an earlier patch set.","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"- name: Install cinder scheduler services"},{"line_number":116,"context_line":"  hosts: cinder_scheduler"},{"line_number":117,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":118,"context_line":"  serial: \"{{ cinder_scheduler_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":119,"context_line":"  max_fail_percentage: 20"},{"line_number":120,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_79769172","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":32},"updated":"2017-06-05 15:29:26.000000000","message":"same remark","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  hosts: cinder_scheduler"},{"line_number":117,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":118,"context_line":"  serial: \"{{ cinder_scheduler_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":119,"context_line":"  max_fail_percentage: 20"},{"line_number":120,"context_line":"  user: root"},{"line_number":121,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":122,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_f90741c9","line":119,"range":{"start_line":119,"start_character":2,"end_line":119,"end_character":21},"updated":"2017-06-05 15:29:26.000000000","message":"Should we add any_error_fatal for the first batch of the serial?","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"- name: Install cinder volume services"},{"line_number":130,"context_line":"  hosts: cinder_volume"},{"line_number":131,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":132,"context_line":"  serial: \"{{ cinder_volume_serial | default(\u00271\u0027) }}\""},{"line_number":133,"context_line":"  max_fail_percentage: 20"},{"line_number":134,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_39eff9e9","line":131,"updated":"2017-06-05 15:29:26.000000000","message":"see comment above","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"549477230e990d5ada99b5b0b3c7426d3aad4845","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  hosts: cinder_volume"},{"line_number":131,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":132,"context_line":"  serial: \"{{ cinder_volume_serial | default(\u00271\u0027) }}\""},{"line_number":133,"context_line":"  max_fail_percentage: 20"},{"line_number":134,"context_line":"  user: root"},{"line_number":135,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":136,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df140735_79e9f1e3","line":133,"updated":"2017-06-05 15:29:26.000000000","message":"should we add any_error_fatal for the first batch?","commit_id":"2e1b53d5ae7b2d3b02ebac4ebe91e7aeaf5e2c5e"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"379668f7829264642ae30a2abcc94a584d4d90c9","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    - name: Execute cinder service restart"},{"line_number":231,"context_line":"      include_role:"},{"line_number":232,"context_line":"        name: os_cinder"},{"line_number":233,"context_line":"        tasks_from: cinder_restart"},{"line_number":234,"context_line":"      when:"},{"line_number":235,"context_line":"        - \"cinder_all_software_updated | bool\""},{"line_number":236,"context_line":"        - \"ansible_local[\u0027openstack_ansible\u0027][\u0027cinder\u0027][\u0027need_service_restart\u0027] | bool\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df140735_392019f7","line":233,"range":{"start_line":233,"start_character":8,"end_line":233,"end_character":34},"updated":"2017-06-05 15:35:53.000000000","message":"this seems fragile. Any change to cinder role impacting cinder_restart could be causing issues.","commit_id":"6d7471c031f6638270e3775f484c3164b40e501d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6d3089ae551a2a870dcecb34ce45c1f098abfa67","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    - name: Execute cinder service restart"},{"line_number":231,"context_line":"      include_role:"},{"line_number":232,"context_line":"        name: os_cinder"},{"line_number":233,"context_line":"        tasks_from: cinder_restart"},{"line_number":234,"context_line":"      when:"},{"line_number":235,"context_line":"        - \"cinder_all_software_updated | bool\""},{"line_number":236,"context_line":"        - \"ansible_local[\u0027openstack_ansible\u0027][\u0027cinder\u0027][\u0027need_service_restart\u0027] | bool\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df140735_30eb6c78","line":233,"range":{"start_line":233,"start_character":8,"end_line":233,"end_character":34},"in_reply_to":"df140735_392019f7","updated":"2017-06-06 13:27:53.000000000","message":"I think the same could be said for anything done in the role. Do you have an alternative suggestion?\n\nThe down side (to me) to using this is that the role meta deps have to execute, which is slow. The up side is that the same notifiers any time the service restarts.\n\nThe only other way of doing this that I can think of is a task which lists all the cinder related systemd unit files, then restarts them.","commit_id":"6d7471c031f6638270e3775f484c3164b40e501d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"379668f7829264642ae30a2abcc94a584d4d90c9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        name: os_cinder"},{"line_number":233,"context_line":"        tasks_from: cinder_restart"},{"line_number":234,"context_line":"      when:"},{"line_number":235,"context_line":"        - \"cinder_all_software_updated | bool\""},{"line_number":236,"context_line":"        - \"ansible_local[\u0027openstack_ansible\u0027][\u0027cinder\u0027][\u0027need_service_restart\u0027] | bool\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df140735_5953cd6b","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":87},"updated":"2017-06-05 15:35:53.000000000","message":"This on top of L231 seems to be black magic. Maybe it\u0027s clean, but that deserves explanation for a deployer, more than what\u0027s written as task/playbook name.","commit_id":"6d7471c031f6638270e3775f484c3164b40e501d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6d3089ae551a2a870dcecb34ce45c1f098abfa67","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        name: os_cinder"},{"line_number":233,"context_line":"        tasks_from: cinder_restart"},{"line_number":234,"context_line":"      when:"},{"line_number":235,"context_line":"        - \"cinder_all_software_updated | bool\""},{"line_number":236,"context_line":"        - \"ansible_local[\u0027openstack_ansible\u0027][\u0027cinder\u0027][\u0027need_service_restart\u0027] | bool\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df140735_f085f4ad","line":236,"range":{"start_line":235,"start_character":0,"end_line":236,"end_character":87},"in_reply_to":"df140735_5953cd6b","updated":"2017-06-06 13:27:53.000000000","message":"Like what, a comment above it that informs them where to find the variable?","commit_id":"6d7471c031f6638270e3775f484c3164b40e501d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"379668f7829264642ae30a2abcc94a584d4d90c9","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    - cinder"},{"line_number":249,"context_line":"  tasks:"},{"line_number":250,"context_line":"    - name: Execute cinder service restart"},{"line_number":251,"context_line":"      include_role:"},{"line_number":252,"context_line":"        name: os_cinder"},{"line_number":253,"context_line":"        tasks_from: cinder_restart"},{"line_number":254,"context_line":"      when:"},{"line_number":255,"context_line":"        - \"cinder_all_software_updated | bool\""},{"line_number":256,"context_line":"        - \"ansible_local[\u0027openstack_ansible\u0027][\u0027cinder\u0027][\u0027need_service_restart\u0027] | bool\""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df140735_39e379a6","line":256,"range":{"start_line":251,"start_character":0,"end_line":256,"end_character":87},"updated":"2017-06-05 15:35:53.000000000","message":"same remarks here.","commit_id":"6d7471c031f6638270e3775f484c3164b40e501d"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"e1e6e17a8df1cdb96970b67b0138a6ee0276684e","unresolved":false,"context_lines":[{"line_number":205,"context_line":"- name: Install cinder backup services"},{"line_number":206,"context_line":"  hosts: cinder_backup"},{"line_number":207,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":208,"context_line":"  serial: \"{{ cinder_serial | default(\u00271\u0027) }}\""},{"line_number":209,"context_line":"  max_fail_percentage: 20"},{"line_number":210,"context_line":"  user: root"},{"line_number":211,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf091321_cdcb3851","line":208,"range":{"start_line":208,"start_character":38,"end_line":208,"end_character":41},"updated":"2017-06-09 06:08:16.000000000","message":"any reason we\u0027re defaulting cinder_serial to 1 here instead of 1, 100% like the other cinder services?\n\ni\u0027ve got to say I\u0027m not a big fan of defaulting the var inline like this. it gives us too much opportunity to overload the defaulting of cinder_serial either intentionally or by accident which will become very confusing when someone potentially tries to configure it. in this file i see cinder_serial defaulted to \u00271\u0027 and also [1, \u0027100%\u0027 ] in different places, same var.","commit_id":"060b1d589e58c20983c65fb579db3472779c914d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1c79a52569ba25bba45d51bcbe9a9f8f549dcab1","unresolved":false,"context_lines":[{"line_number":205,"context_line":"- name: Install cinder backup services"},{"line_number":206,"context_line":"  hosts: cinder_backup"},{"line_number":207,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":208,"context_line":"  serial: \"{{ cinder_serial | default(\u00271\u0027) }}\""},{"line_number":209,"context_line":"  max_fail_percentage: 20"},{"line_number":210,"context_line":"  user: root"},{"line_number":211,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f0e0f27_ab69418c","line":208,"range":{"start_line":208,"start_character":38,"end_line":208,"end_character":41},"in_reply_to":"bf091321_cdcb3851","updated":"2017-06-09 09:30:31.000000000","message":"Agreed on the var overloading problems. It\u0027s not very friendly, but as you suggested in an earlier patch set an override could be made with some jinja for it. The alternative is that each server has a var to override the particular behaviour.\n\nThe reason that some are serialised using 1,100% and others using 1 is because their profiles are different. The API/scheduler services can take on each other\u0027s work, versus cinder-volume and cinder-backup which don\u0027t - they manage the volume/backup that\u0027s assigned to them. I thought it best then to rather not take a bunch of them down at once. My feeling is that for minor upgrades, major upgrades or simple config changes the best is to ensure that only one of them is down at any one time.","commit_id":"060b1d589e58c20983c65fb579db3472779c914d"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"e1e6e17a8df1cdb96970b67b0138a6ee0276684e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":228,"context_line":"  tags:"},{"line_number":229,"context_line":"    - cinder"},{"line_number":230,"context_line":"    - testjp"},{"line_number":231,"context_line":"  tasks:"},{"line_number":232,"context_line":"    - name: refresh local facts"},{"line_number":233,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf091321_adc80455","line":230,"range":{"start_line":230,"start_character":0,"end_line":230,"end_character":12},"updated":"2017-06-09 06:08:16.000000000","message":"snip","commit_id":"060b1d589e58c20983c65fb579db3472779c914d"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"b2e4e10137783a9cede804c02a0df58d38bedd44","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        option: need_online_data_migrations"},{"line_number":224,"context_line":"        value: False"},{"line_number":225,"context_line":"      when:"},{"line_number":226,"context_line":"        - data_migrations | succeeded"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7f231b9d_e34a837e","line":226,"updated":"2017-06-12 19:32:54.000000000","message":"If this is called from within `setup-openstack.yml`, will this variable be shared? Curious if the scope might overlap when it comes to doing DB migrations on multiple services.","commit_id":"4d29170dd5952a1bbe9f8773010184b58cf2d389"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"37e4899305ad66a57e118cb06e5577fefbf5b767","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        option: need_online_data_migrations"},{"line_number":224,"context_line":"        value: False"},{"line_number":225,"context_line":"      when:"},{"line_number":226,"context_line":"        - data_migrations | succeeded"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7f231b9d_4fadca2f","line":226,"in_reply_to":"7f231b9d_e34a837e","updated":"2017-06-13 08:50:03.000000000","message":"As the register is immediately before it, any previously existing var by the same name will be overwritten, regardless of whether the task is skipped or not. The same goes for any other registered var after it.","commit_id":"4d29170dd5952a1bbe9f8773010184b58cf2d389"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"15a613e181967b9846d25918e44047b6da682d2e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare MQ/DB services"},{"line_number":17,"context_line":"  hosts: cinder_all[0]"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7f231b9d_2c4e83c0","line":17,"updated":"2017-06-19 03:05:11.000000000","message":"Same query as the keystone review, I wonder if this is better done as ansible_play_hosts[0]","commit_id":"eaa182e382538f3e509fd86ef9f829bf8ce9f872"}]}
