)]}'
{"playbooks/common-playbooks/glance.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8a53d91360f6b703f2bdce88488b0c21e2bc634","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - include: ../common-tasks/os-lxc-container-setup.yml"},{"line_number":45,"context_line":"      static: no"},{"line_number":46,"context_line":"      when: (glance_default_store !\u003d \"file\") or (glance_nfs_client is defined)"},{"line_number":47,"context_line":"    - include: ../common-tasks/rabbitmq-vhost-user.yml"},{"line_number":48,"context_line":"      static: no"},{"line_number":49,"context_line":"      vars:"},{"line_number":50,"context_line":"        user: \"{{ glance_rabbitmq_userid }}\""},{"line_number":51,"context_line":"        password: \"{{ glance_rabbitmq_password }}\""},{"line_number":52,"context_line":"        vhost: \"{{ glance_rabbitmq_vhost }}\""},{"line_number":53,"context_line":"        _rabbitmq_host_group: \"{{ glance_rabbitmq_host_group }}\""},{"line_number":54,"context_line":"      when:"},{"line_number":55,"context_line":"        - inventory_hostname \u003d\u003d groups[\u0027glance_all\u0027][0]"},{"line_number":56,"context_line":"        - groups[glance_rabbitmq_host_group] | length \u003e 0"},{"line_number":57,"context_line":"    - include: ../common-tasks/os-log-dir-setup.yml"},{"line_number":58,"context_line":"      vars:"},{"line_number":59,"context_line":"        log_dirs:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_b4187575","line":56,"range":{"start_line":47,"start_character":0,"end_line":56,"end_character":57},"updated":"2017-06-29 10:27:33.000000000","message":"This is in playbooks/os-glance-install.yml - why is it also here?","commit_id":"e20f32fe79de9240ac023e70293b1ae08c61602e"}],"playbooks/os-glance-install.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8a53d91360f6b703f2bdce88488b0c21e2bc634","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Prepare MQ/DB services"},{"line_number":17,"context_line":"  hosts: glance_all[0]"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  user: root"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_9475799b","line":17,"updated":"2017-06-29 10:27:33.000000000","message":"For better serialisation with limits this should run against all, but run_once on each task.","commit_id":"e20f32fe79de9240ac023e70293b1ae08c61602e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8a53d91360f6b703f2bdce88488b0c21e2bc634","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      when:"},{"line_number":34,"context_line":"        - inventory_hostname \u003d\u003d groups[\u0027glance_all\u0027][0]"},{"line_number":35,"context_line":"        - groups[glance_rabbitmq_host_group] | length \u003e 0"},{"line_number":36,"context_line":"    - name: Configure rabbitmq vhost/user (telemetry)"},{"line_number":37,"context_line":"      include: common-tasks/rabbitmq-vhost-user.yml"},{"line_number":38,"context_line":"      static: no"},{"line_number":39,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_7451bd0e","line":36,"updated":"2017-06-29 10:27:33.000000000","message":"Please add a line feed between each task to help make it easier to read. Add 3 line feeds between plays.","commit_id":"e20f32fe79de9240ac023e70293b1ae08c61602e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8a53d91360f6b703f2bdce88488b0c21e2bc634","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        login_host: \"{{ glance_galera_address }}\""},{"line_number":57,"context_line":"        db_name: \"{{ glance_galera_database }}\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Install glance API services"},{"line_number":60,"context_line":"  include: common-playbooks/glance.yml"},{"line_number":61,"context_line":"  vars:"},{"line_number":62,"context_line":"    glance_hosts: \"glance_api\""},{"line_number":63,"context_line":"    glance_serial: \"{{ glance_api_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# These facts are set against the deployment host to ensure that"},{"line_number":66,"context_line":"# they are fast to access. This is done in preference to setting"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_14128959","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":69},"updated":"2017-06-29 10:27:33.000000000","message":"What about the glance_registry group? Does it exist? Is there some other host group that needs the role executed against it?\n\nAlso, common-playbooks/glance.yml does not use \u0027glance_hosts\u0027 or \u0027glance_Serial\u0027.\n\nIf there is only one host group to do things against, then there is no need to split the playbook out. If there are two groups (one per service) then we need to act against them both. We need to cater for the possibility that each glance service may be in different containers, or the same. That\u0027s why the cinder deployment process executes the way it does.","commit_id":"e20f32fe79de9240ac023e70293b1ae08c61602e"}]}
