)]}'
{"playbooks/common-playbooks/swift.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e83f607bc02d6639e08422fb31ecac904e2e3f95","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    - swift"},{"line_number":24,"context_line":"  pre_tasks:"},{"line_number":25,"context_line":"    - name: Configure package proxy cache"},{"line_number":26,"context_line":"      include: ../common-tasks/package-cache-proxy.yml"},{"line_number":27,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1f1a1f67_38e91ce5","line":24,"updated":"2017-07-19 13:18:29.000000000","message":"There should be a pre-task and post task for removing the swift proxy from the LB. See the other plays for examples.","commit_id":"09642cd4232a018f900b6a437a9888380d5094c4"}],"playbooks/os-swift-install.yml":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"08b8ad72b523a4b989be414c18daa310a38d01bd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  hosts: swift_obj:swift_remote"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  serial: 1"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  pre_tasks:"},{"line_number":23,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_f2df8f37","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":11},"updated":"2017-07-17 16:48:28.000000000","message":"Does this mean we\u0027ll run on each storage host individually?\nIs there a way we can do bigger batches rather than 1 by 1? I\u0027m concerned this would take a long time if there is a large swift cluster.\n\nCould we do like a [1,100%] thing where it will do 1 by itself and then all the others?\n\nAnd similarly with the proxy hosts.","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93f06a745f9e978025ec36a0a7945e96f87606af","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  hosts: swift_obj:swift_remote"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  serial: 1"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  pre_tasks:"},{"line_number":23,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_0db42ef1","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":11},"in_reply_to":"1f1a1f67_9205fb16","updated":"2017-07-17 17:15:16.000000000","message":"I would suggest \u002720%\u0027 like we do for nova compute, so it ends up being 5 batches so that we don\u0027t take too many storage nodes offline at once.\n\nFor the proxy I\u0027d suggest [\u00271\u0027,\u0027100%\u0027]","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"208cdddbd8ff69800f631cf4917dd4f5c950a5f8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  hosts: swift_obj:swift_remote"},{"line_number":18,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  max_fail_percentage: 20"},{"line_number":20,"context_line":"  serial: 1"},{"line_number":21,"context_line":"  user: root"},{"line_number":22,"context_line":"  pre_tasks:"},{"line_number":23,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_9205fb16","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":11},"in_reply_to":"1f1a1f67_f2df8f37","updated":"2017-07-17 17:02:52.000000000","message":"Good call - I mostly held off to be sure that we weren\u0027t taking too much out of the cluster. If that\u0027s safe from a swift standpoint we can try it.","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93f06a745f9e978025ec36a0a7945e96f87606af","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      swift_do_setup: True"},{"line_number":52,"context_line":"      swift_do_sync: False"},{"line_number":53,"context_line":"  vars:"},{"line_number":54,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":55,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":56,"context_line":"  tags:"},{"line_number":57,"context_line":"    - swift"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_cd96364d","line":54,"updated":"2017-07-17 17:15:16.000000000","message":"is_metal doesn\u0027t need to be set here any more as it\u0027s in the all group_vars.","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93f06a745f9e978025ec36a0a7945e96f87606af","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  tags:"},{"line_number":57,"context_line":"    - swift"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Installation and setup of Swift proxy nodes"},{"line_number":60,"context_line":"  hosts: swift_proxy"},{"line_number":61,"context_line":"  gather_facts: \"{{ gather_facts | default(True) }}\""},{"line_number":62,"context_line":"  max_fail_percentage: 20"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_6dc4c25f","line":59,"updated":"2017-07-17 17:15:16.000000000","message":"There\u0027s quite a bit of duplication here - I\u0027d suggest using the same common-playbook structure used for the other services.","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"93f06a745f9e978025ec36a0a7945e96f87606af","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      swift_do_setup: False"},{"line_number":110,"context_line":"      swift_do_sync: True"},{"line_number":111,"context_line":"  vars:"},{"line_number":112,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":113,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":114,"context_line":"  tags:"},{"line_number":115,"context_line":"    - swift"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_2da80a8b","line":112,"updated":"2017-07-17 17:15:16.000000000","message":"is_metal doesn\u0027t need to be set here any more as it\u0027s in the all group_vars.","commit_id":"d75bf068b9b12bbec8b72c10b3b9f0318aa52336"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e83f607bc02d6639e08422fb31ecac904e2e3f95","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  user: root"},{"line_number":21,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":22,"context_line":"  tasks:"},{"line_number":23,"context_line":"    - include: common-tasks/os-lxc-container-setup.yml"},{"line_number":24,"context_line":"      vars:"},{"line_number":25,"context_line":"        extra_container_config_no_restart:"},{"line_number":26,"context_line":"          - \"lxc.start.order\u003d79\""},{"line_number":27,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":28,"context_line":"      vars:"},{"line_number":29,"context_line":"        log_dirs:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1f1a1f67_18f660d8","line":26,"range":{"start_line":23,"start_character":0,"end_line":26,"end_character":32},"updated":"2017-07-19 13:18:29.000000000","message":"This should be moved into the common play as it pertains to the container config.","commit_id":"09642cd4232a018f900b6a437a9888380d5094c4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e83f607bc02d6639e08422fb31ecac904e2e3f95","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      vars:"},{"line_number":25,"context_line":"        extra_container_config_no_restart:"},{"line_number":26,"context_line":"          - \"lxc.start.order\u003d79\""},{"line_number":27,"context_line":"    - include: common-tasks/os-log-dir-setup.yml"},{"line_number":28,"context_line":"      vars:"},{"line_number":29,"context_line":"        log_dirs:"},{"line_number":30,"context_line":"          - src: \"/openstack/log/{{ inventory_hostname }}-swift\""},{"line_number":31,"context_line":"            dest: \"/var/log/swift\""},{"line_number":32,"context_line":"            owner: \"syslog\""},{"line_number":33,"context_line":"            group: \"syslog\""},{"line_number":34,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # If we\u0027re using ceilometer then swift needs a rabbitmq/vhost \u0026 usera"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1f1a1f67_b8d52c1e","line":33,"range":{"start_line":27,"start_character":0,"end_line":33,"end_character":27},"updated":"2017-07-19 13:18:29.000000000","message":"This should be moved to the common play as it pertains to host config.","commit_id":"09642cd4232a018f900b6a437a9888380d5094c4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e83f607bc02d6639e08422fb31ecac904e2e3f95","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            dest: \"/var/log/swift\""},{"line_number":32,"context_line":"            owner: \"syslog\""},{"line_number":33,"context_line":"            group: \"syslog\""},{"line_number":34,"context_line":"    - include: common-tasks/package-cache-proxy.yml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # If we\u0027re using ceilometer then swift needs a rabbitmq/vhost \u0026 usera"},{"line_number":37,"context_line":"    - include: common-tasks/rabbitmq-vhost-user.yml"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1f1a1f67_f86ba481","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":51},"updated":"2017-07-19 13:18:29.000000000","message":"This is now duplicated. It should be removed from here.","commit_id":"09642cd4232a018f900b6a437a9888380d5094c4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"28c537a9c2a84aaf8f20be949deacedd213dc0d3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  include: common-playbooks/swift.yml"},{"line_number":39,"context_line":"  vars:"},{"line_number":40,"context_line":"    swift_hosts: \"swift_obj:swift_remote\""},{"line_number":41,"context_line":"    swift_serial: \"{{ swift_obj_serial | default([\u00271\u0027, \u002720%\u0027]) }}\""},{"line_number":42,"context_line":"    swift_setup: True"},{"line_number":43,"context_line":"    swift_sync: False"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f1a1f67_419aa061","line":41,"updated":"2017-07-19 16:51:53.000000000","message":"I don\u0027t understand why 1,20% is being used here? Can you explain the rationale please?","commit_id":"cf5cecb47c547ca2dad16bc63eb3c9dfc06e0c28"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fe6c26f736704207ca67cd88fe4ba1a44f160b37","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  include: common-playbooks/swift.yml"},{"line_number":39,"context_line":"  vars:"},{"line_number":40,"context_line":"    swift_hosts: \"swift_obj:swift_remote\""},{"line_number":41,"context_line":"    swift_serial: \"{{ swift_obj_serial | default([\u00271\u0027, \u002720%\u0027]) }}\""},{"line_number":42,"context_line":"    swift_setup: True"},{"line_number":43,"context_line":"    swift_sync: False"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f1a1f67_5044a473","line":41,"in_reply_to":"1f1a1f67_35859a07","updated":"2017-07-19 19:26:01.000000000","message":"I feel like this goal would best be achieved by doing just 20%. I\u0027m not sure I understand the point of doing the 1 first?","commit_id":"cf5cecb47c547ca2dad16bc63eb3c9dfc06e0c28"},{"author":{"_account_id":12892,"name":"Nolan Brubaker","email":"nolan.brubaker@rackspace.com","username":"nrb"},"change_message_id":"ec81f1614aec34c528aa9d09f6c751183f0e2b52","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  include: common-playbooks/swift.yml"},{"line_number":39,"context_line":"  vars:"},{"line_number":40,"context_line":"    swift_hosts: \"swift_obj:swift_remote\""},{"line_number":41,"context_line":"    swift_serial: \"{{ swift_obj_serial | default([\u00271\u0027, \u002720%\u0027]) }}\""},{"line_number":42,"context_line":"    swift_setup: True"},{"line_number":43,"context_line":"    swift_sync: False"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f1a1f67_35859a07","line":41,"in_reply_to":"1f1a1f67_419aa061","updated":"2017-07-19 18:38:49.000000000","message":"This is to ensure that we don\u0027t overload a single node by taking down 100% of the rest of the cluster.","commit_id":"cf5cecb47c547ca2dad16bc63eb3c9dfc06e0c28"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"28c537a9c2a84aaf8f20be949deacedd213dc0d3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  vars:"},{"line_number":48,"context_line":"    swift_hosts: \"swift_proxy\""},{"line_number":49,"context_line":"    swift_serial: \"{{ swift_proxy_serial | default([\u00271\u0027, \u0027100%\u0027]) }}\""},{"line_number":50,"context_line":"    swift_setup: True"},{"line_number":51,"context_line":"    swift_sync: False"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Refresh local facts after all software changes are made"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f1a1f67_e1aacc6e","line":50,"updated":"2017-07-19 16:51:53.000000000","message":"As the software is being changed here, the services will restart - but there is no removal from the LB so it will cause an API outage. As mentioned in the previous PS, please add the LB disable/enable process.","commit_id":"cf5cecb47c547ca2dad16bc63eb3c9dfc06e0c28"}]}