)]}'
{"group_vars/cinder_volume.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7da9621955ea70042ffb2a1be470adf87497fad7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# cinder_backend_rbd_inuse: True if current host has an rbd backend"},{"line_number":17,"context_line":"# this is defined identically downstream in the os_cinder role, but redefined"},{"line_number":18,"context_line":"# here so it can be consumed by the nova group vars"},{"line_number":19,"context_line":"cinder_backend_rbd_inuse: \u0027{{ (cinder_backends|default(\"\")|to_json).find(\"cinder.volume.drivers.rbd.RBDDriver\") !\u003d -1 }}\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"lxc_container_config_list:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_db5e4b11","line":18,"updated":"2017-07-13 16:42:55.000000000","message":"Hmm, the nova vars can\u0027t get them here because this is scoped to the cinder_volume group. It\u0027s only working in the AIO because the host happens to be a member of both groups.","commit_id":"0640dbbba8661639fa36b2a8172e5208fa7c6f92"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"7e9f102c57ef9446640368f95b7c7adf038cdb77","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# cinder_backend_rbd_inuse: True if current host has an rbd backend"},{"line_number":17,"context_line":"# this is defined identically downstream in the os_cinder role, but redefined"},{"line_number":18,"context_line":"# here so it can be consumed by the nova group vars"},{"line_number":19,"context_line":"cinder_backend_rbd_inuse: \u0027{{ (cinder_backends|default(\"\")|to_json).find(\"cinder.volume.drivers.rbd.RBDDriver\") !\u003d -1 }}\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"lxc_container_config_list:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_9b31f3a5","line":18,"in_reply_to":"1f1a1f67_db5e4b11","updated":"2017-07-13 16:50:05.000000000","message":"The nova var referenced here is nova_cinder_rbd_inuse, which looks at the cinder_volume group\u0027s hostvars, which are scoped correctly here.","commit_id":"0640dbbba8661639fa36b2a8172e5208fa7c6f92"}],"group_vars/nova_all.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7da9621955ea70042ffb2a1be470adf87497fad7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  {%     set _var \u003d True %}"},{"line_number":56,"context_line":"  {%   endif %}"},{"line_number":57,"context_line":"  {% endfor %}"},{"line_number":58,"context_line":"  {{ _var }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_9b9e93b6","line":58,"updated":"2017-07-13 16:42:55.000000000","message":"This is a fairly expensive action. If this is done as a set_fact in the play, with run_once and localhost delegation, it will be less expensive and usable across all hosts.","commit_id":"0640dbbba8661639fa36b2a8172e5208fa7c6f92"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"7e9f102c57ef9446640368f95b7c7adf038cdb77","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  {%     set _var \u003d True %}"},{"line_number":56,"context_line":"  {%   endif %}"},{"line_number":57,"context_line":"  {% endfor %}"},{"line_number":58,"context_line":"  {{ _var }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_5b2b5b2f","line":58,"in_reply_to":"1f1a1f67_9b9e93b6","updated":"2017-07-13 16:50:05.000000000","message":"will do","commit_id":"0640dbbba8661639fa36b2a8172e5208fa7c6f92"}],"playbooks/common-playbooks/nova.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2b59edeecf0e357c33f622543155b89b04111025","unresolved":false,"context_lines":[{"line_number":140,"context_line":"      nova_spicehtml5_git_repo: \"{{ openstack_repo_git_url }}/spice-html5\""},{"line_number":141,"context_line":"      nova_spicehtml5_git_install_branch: \"{{ spicehtml5_git_install_branch }}\""},{"line_number":142,"context_line":"      nova_management_address: \"{{ management_address }}\""},{"line_number":143,"context_line":"      nova_cinder_rbd_inuse: \"{{ hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] }}\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    - role: \"openstack_openrc\""},{"line_number":146,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_e54f0bbb","line":143,"updated":"2017-07-14 10:59:18.000000000","message":"I think if you don\u0027t set this var, it would still work, because you set fact nova_cinder_rbd_inuse which lasts the playbook\u0027s timespan.","commit_id":"be1419dbdf86d9f04c1ce5f8820e524f6e1a6af4"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"9e07df2f7217548853b8358e6b3cb5e70e439bd1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"      nova_spicehtml5_git_repo: \"{{ openstack_repo_git_url }}/spice-html5\""},{"line_number":141,"context_line":"      nova_spicehtml5_git_install_branch: \"{{ spicehtml5_git_install_branch }}\""},{"line_number":142,"context_line":"      nova_management_address: \"{{ management_address }}\""},{"line_number":143,"context_line":"      nova_cinder_rbd_inuse: \"{{ hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] }}\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    - role: \"openstack_openrc\""},{"line_number":146,"context_line":"      tags:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f1a1f67_a006a185","line":143,"in_reply_to":"1f1a1f67_e54f0bbb","updated":"2017-07-14 11:38:09.000000000","message":"It is being set on localhost. So you\u0027re right, it would work, but only in the gate.\n\nFor the reason behind setting the fact on localhost instead of group_vars, see the great suggestion by Jesse earlier in the review which led to this method.","commit_id":"be1419dbdf86d9f04c1ce5f8820e524f6e1a6af4"}]}