)]}'
{"playbooks/common-playbooks/nova.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5f810ae4487dd0104591d091063de95e1cd0e0d6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":44,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":45,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":46,"context_line":"      tags:"},{"line_number":47,"context_line":"        - always"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_85d61727","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":73},"updated":"2017-07-14 10:42:28.000000000","message":"I think this can just be the following and it might give a performance improvement, although it\u0027s likely very marginal:\n\n- \"nova_cinder_rbd_inuse is not defined\"","commit_id":"1aeed9b531c3ffa75743c6da88d846d4777b7ddf"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"8acabaca4fa3ffb9c3e817cb1523bd26edf53aad","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":44,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":45,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":46,"context_line":"      tags:"},{"line_number":47,"context_line":"        - always"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_c043ddae","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":73},"in_reply_to":"1f1a1f67_659f7b03","updated":"2017-07-14 11:37:46.000000000","message":"What does that mean? One of the cases (the one highlighted) is to not set this fact more than once. Is there a case I\u0027m missing?","commit_id":"1aeed9b531c3ffa75743c6da88d846d4777b7ddf"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"39d67b337967bbac0d8ba83982dbe33f139092b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":44,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":45,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":46,"context_line":"      tags:"},{"line_number":47,"context_line":"        - always"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_659f7b03","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":73},"in_reply_to":"1f1a1f67_85d61727","updated":"2017-07-14 11:00:54.000000000","message":"I agree but maybe the conditional shouldn\u0027t appear at all, and we should do the right thing here, for all the cases.","commit_id":"1aeed9b531c3ffa75743c6da88d846d4777b7ddf"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b14f6a3fe9b925e02d3a74fb21988fd9caff8a70","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      when:"},{"line_number":43,"context_line":"        - \"\u0027nova_compute\u0027 in group_names\""},{"line_number":44,"context_line":"        - \"inventory_hostname \u003d\u003d ((groups[\u0027nova_compute\u0027] | intersect(ansible_play_hosts)) | list)[0]\""},{"line_number":45,"context_line":"        - \"hostvars[\u0027localhost\u0027][\u0027nova_cinder_rbd_inuse\u0027] is not defined\""},{"line_number":46,"context_line":"      tags:"},{"line_number":47,"context_line":"        - always"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_9bbe7463","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":73},"in_reply_to":"1f1a1f67_c043ddae","updated":"2017-07-14 12:26:21.000000000","message":"My bad.","commit_id":"1aeed9b531c3ffa75743c6da88d846d4777b7ddf"}]}