)]}'
{"playbooks/lxc-containers-create.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"35c324cba78cfb68b033357d7c4e91023ef8f981","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  max_fail_percentage: 20"},{"line_number":24,"context_line":"  user: root"},{"line_number":25,"context_line":"  roles:"},{"line_number":26,"context_line":"    - role: \"lxc_container_create\""},{"line_number":27,"context_line":"  post_tasks:"},{"line_number":28,"context_line":"    - name: Wait for container connectivity"},{"line_number":29,"context_line":"      wait_for_connection:"},{"line_number":30,"context_line":"        connect_timeout: \"{{ lxc_container_wait_params.connect_timeout | default(omit) }}\""},{"line_number":31,"context_line":"        delay: \"{{ lxc_container_wait_params.delay | default(omit) }}\""},{"line_number":32,"context_line":"        sleep: \"{{ lxc_container_wait_params.sleep | default(omit) }}\""},{"line_number":33,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":36,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_04c3968a","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":74},"updated":"2017-07-19 17:10:24.000000000","message":"Suggestion:\n\n  tasks:\n    - include_role:\n        name: \"lxc_container_create\"\n\n    - name: Wait for container connectivity\n      wait_for_connection:\n        connect_timeout: \"{{ lxc_container_wait_params.connect_timeout | default(omit) }}\"\n        delay: \"{{ lxc_container_wait_params.delay | default(omit) }}\"\n        sleep: \"{{ lxc_container_wait_params.sleep | default(omit) }}\"\n        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\"\n\n    - include_role:\n        name: \"pip_install\"","commit_id":"0d6807e6ac6f87c94fa85002fb3f1ed223e00b6a"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"f868aff04360cf7127349a45d9436da2e86edf77","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        connect_timeout: \"{{ lxc_container_wait_params.connect_timeout | default(omit) }}\""},{"line_number":31,"context_line":"        delay: \"{{ lxc_container_wait_params.delay | default(omit) }}\""},{"line_number":32,"context_line":"        sleep: \"{{ lxc_container_wait_params.sleep | default(omit) }}\""},{"line_number":33,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    is_metal: \"{{ properties.is_metal|default(false) }}\""},{"line_number":36,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f1a1f67_10fbccc0","line":33,"updated":"2017-07-19 19:02:46.000000000","message":"That\u0027s definitely cleaner. I\u0027ll get it worked up.","commit_id":"0d6807e6ac6f87c94fa85002fb3f1ed223e00b6a"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"8927402e7193e450f54c724163473754e8d3673a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    - name: Apply pip_install role"},{"line_number":39,"context_line":"      include_role:"},{"line_number":40,"context_line":"        name: \"pip_install\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_908c7c36","line":39,"updated":"2017-07-19 19:09:37.000000000","message":"Confused why you used include_role here instead of making another play below this one targeting the same hosts and leaving the existing play as-is. Wouldn\u0027t a 2nd play be more standard practice for this?","commit_id":"003ad8c80f029f0299d0c22f25b4179db07fdcb7"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"5209a36ae21329c4a76e377558d2440d70977449","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    - name: Apply pip_install role"},{"line_number":39,"context_line":"      include_role:"},{"line_number":40,"context_line":"        name: \"pip_install\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_bb1ab9c2","line":39,"updated":"2017-07-19 19:47:06.000000000","message":"Fixing now.","commit_id":"003ad8c80f029f0299d0c22f25b4179db07fdcb7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"03bc8c03f710db75327e39f6e7ede56a6250e5a6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    - name: Apply pip_install role"},{"line_number":39,"context_line":"      include_role:"},{"line_number":40,"context_line":"        name: \"pip_install\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_b0009803","line":39,"in_reply_to":"1f1a1f67_908c7c36","updated":"2017-07-19 19:28:45.000000000","message":"Fair point, I guess. However I think the general idea here is to try and setup the hosts in one place, and the containers in another - then remove the pip_install in all the roles.\n\nI would suggest adding the pip-install tag to the task and moving the lxc-container-create tag to the container-create related tasks.","commit_id":"003ad8c80f029f0299d0c22f25b4179db07fdcb7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f17846f383056366dacf0aecb46e55373b466a98","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        timeout: \"{{ lxc_container_wait_params.timeout | default(omit) }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    - name: Apply pip_install role"},{"line_number":39,"context_line":"      include_role:"},{"line_number":40,"context_line":"        name: \"pip_install\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f1a1f67_3bd229d2","line":39,"in_reply_to":"1f1a1f67_bb1ab9c2","updated":"2017-07-19 19:48:00.000000000","message":"Looks like you\u0027ll need to do a setup task to gather facts before running pip_install.","commit_id":"003ad8c80f029f0299d0c22f25b4179db07fdcb7"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d2d132f473dc10390a15188f977873df41ee3a35","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Gather facts"},{"line_number":43,"context_line":"      setup:"},{"line_number":44,"context_line":"        gather_subset: \"all\""},{"line_number":45,"context_line":"      tags:"},{"line_number":46,"context_line":"        - pip-install"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f1a1f67_96011408","line":44,"updated":"2017-07-19 19:56:32.000000000","message":"The following is more than enough, and a little faster:\n\ngather_subset: \u0027network,hardware,virtual\u0027","commit_id":"4c017bddeda6f2e4b475b1f7c2e79fb818f516eb"}]}