)]}'
{"playbooks/inventory/env.d/heat.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67c8b20cafdbd06bb540bfb3f9698e49ada12976","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"container_skel:"},{"line_number":32,"context_line":"  heat_apis_container:"},{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - orchestration_containers"},{"line_number":35,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_d715eee6","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":21},"updated":"2017-10-05 12:36:27.000000000","message":"Should this be renamed \u0027heat_api_container\u0027 to conform to the cinder container group name?","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"35a6b37b6d3b9da9ac2269d9d2edaa7980418555","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"container_skel:"},{"line_number":32,"context_line":"  heat_apis_container:"},{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - orchestration_containers"},{"line_number":35,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f4e5783_0708f229","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":21},"in_reply_to":"7f515b1d_d715eee6","updated":"2017-10-11 19:07:51.000000000","message":"Done","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"389ac618b6b04361a1c98564f2be66c8c93091b9","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"container_skel:"},{"line_number":32,"context_line":"  heat_apis_container:"},{"line_number":33,"context_line":"    belongs_to:"},{"line_number":34,"context_line":"      - orchestration_containers"},{"line_number":35,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f4e5783_813bc9cf","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":21},"in_reply_to":"7f515b1d_d715eee6","updated":"2017-10-11 04:17:47.000000000","message":"It very well could however I don\u0027t find it particularly necessary.","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"}],"playbooks/inventory/env.d/ironic.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67c8b20cafdbd06bb540bfb3f9698e49ada12976","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    belongs_to:"},{"line_number":49,"context_line":"      - ironic-compute_containers"},{"line_number":50,"context_line":"    contains:"},{"line_number":51,"context_line":"      - ironic_compute"},{"line_number":52,"context_line":"      - nova_compute"},{"line_number":53,"context_line":"      - nova_scheduler"},{"line_number":54,"context_line":"      - neutron_linuxbridge_agent"},{"line_number":55,"context_line":"      - neutron_openvswitch_agent"},{"line_number":56,"context_line":"    properties:"},{"line_number":57,"context_line":"      is_metal: false"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_97be56d2","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":33},"updated":"2017-10-05 12:36:27.000000000","message":"I\u0027m guessing that these stay in their own container as a security measure? Perhaps we should add comments here to reflect that so that we understand when revisiting this in the future again.","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"389ac618b6b04361a1c98564f2be66c8c93091b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    belongs_to:"},{"line_number":49,"context_line":"      - ironic-compute_containers"},{"line_number":50,"context_line":"    contains:"},{"line_number":51,"context_line":"      - ironic_compute"},{"line_number":52,"context_line":"      - nova_compute"},{"line_number":53,"context_line":"      - nova_scheduler"},{"line_number":54,"context_line":"      - neutron_linuxbridge_agent"},{"line_number":55,"context_line":"      - neutron_openvswitch_agent"},{"line_number":56,"context_line":"    properties:"},{"line_number":57,"context_line":"      is_metal: false"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f4e5783_61668df0","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":33},"in_reply_to":"7f515b1d_97be56d2","updated":"2017-10-11 04:17:47.000000000","message":"This are here for compute compatibility. Ironic compute runs within a container as its nothing more than a scheduler and broker to communicate with other ironic services. We could however collapse this within the Ironic server and update our documentation to that effect if we think it best?","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"}],"playbooks/inventory/env.d/nova.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"67c8b20cafdbd06bb540bfb3f9698e49ada12976","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_skel:"},{"line_number":41,"context_line":"  nova_api_os_compute_container:"},{"line_number":42,"context_line":"    belongs_to:"},{"line_number":43,"context_line":"      - compute-infra_containers"},{"line_number":44,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f515b1d_b7a032a7","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":31},"updated":"2017-10-05 12:36:27.000000000","message":"Should this be renamed \u0027nova_api_container\u0027 to conform to the cinder container group name?","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"35a6b37b6d3b9da9ac2269d9d2edaa7980418555","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_skel:"},{"line_number":41,"context_line":"  nova_api_os_compute_container:"},{"line_number":42,"context_line":"    belongs_to:"},{"line_number":43,"context_line":"      - compute-infra_containers"},{"line_number":44,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f4e5783_8714e24f","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":31},"in_reply_to":"7f515b1d_b7a032a7","updated":"2017-10-11 19:07:51.000000000","message":"Done","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"389ac618b6b04361a1c98564f2be66c8c93091b9","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_skel:"},{"line_number":41,"context_line":"  nova_api_os_compute_container:"},{"line_number":42,"context_line":"    belongs_to:"},{"line_number":43,"context_line":"      - compute-infra_containers"},{"line_number":44,"context_line":"      - os-infra_containers"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f4e5783_a1f7e5f5","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":31},"in_reply_to":"7f515b1d_b7a032a7","updated":"2017-10-11 04:17:47.000000000","message":"It very well could however I don\u0027t find it particularly necessary.","commit_id":"a90403205aa0a28a9a104f97d358b0b459c428b0"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"a8719c4a9893580fcbbea101f7cebc764f4be9be","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      - os-infra_containers"},{"line_number":45,"context_line":"    contains:"},{"line_number":46,"context_line":"      - nova_api_metadata"},{"line_number":47,"context_line":"      - nova_api_os_compute"},{"line_number":48,"context_line":"      - nova_api_placement"},{"line_number":49,"context_line":"      - nova_conductor"},{"line_number":50,"context_line":"      - nova_scheduler"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_02222001","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":27},"updated":"2017-10-11 19:45:49.000000000","message":"Could this change to nova_api_compute for consistency sake w/ the container naming change","commit_id":"11d0aafefa1c2d55f553ad2eee378c1dd311e601"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1d00a0f8fcdad183d6a2b01ea5ba841ebac12b56","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      - os-infra_containers"},{"line_number":45,"context_line":"    contains:"},{"line_number":46,"context_line":"      - nova_api_metadata"},{"line_number":47,"context_line":"      - nova_api_os_compute"},{"line_number":48,"context_line":"      - nova_api_placement"},{"line_number":49,"context_line":"      - nova_conductor"},{"line_number":50,"context_line":"      - nova_scheduler"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f4e5783_70bcf0db","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":27},"in_reply_to":"5f4e5783_02222001","updated":"2017-10-12 08:53:00.000000000","message":"That group name is based on the service name, so it\u0027s consistent in the right way here. If this were to change, it would require several changes in the os_nova role, one of which would be: https://github.com/openstack/openstack-ansible-os_nova/blob/823a80bd444ae0607519d42c15e969802459c78e/defaults/main.yml#L438\n\nI think this is best left as-is.","commit_id":"11d0aafefa1c2d55f553ad2eee378c1dd311e601"}],"tests/test_inventory.py":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1d00a0f8fcdad183d6a2b01ea5ba841ebac12b56","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        \u0027heat_api\u0027,"},{"line_number":216,"context_line":"        \u0027heat_api_cfn\u0027,"},{"line_number":217,"context_line":"        \u0027heat_api_cloudwatch\u0027,"},{"line_number":218,"context_line":"        \u0027heat_apis_container\u0027,"},{"line_number":219,"context_line":"        \u0027heat_engine\u0027,"},{"line_number":220,"context_line":"        \u0027horizon\u0027,"},{"line_number":221,"context_line":"        \u0027horizon_all\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4e5783_d0ca846c","line":218,"range":{"start_line":218,"start_character":9,"end_line":218,"end_character":28},"updated":"2017-10-12 08:53:00.000000000","message":"needs change to heat_api_container","commit_id":"11d0aafefa1c2d55f553ad2eee378c1dd311e601"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1d00a0f8fcdad183d6a2b01ea5ba841ebac12b56","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        \u0027nova_all\u0027,"},{"line_number":326,"context_line":"        \u0027nova_api_metadata\u0027,"},{"line_number":327,"context_line":"        \u0027nova_api_os_compute\u0027,"},{"line_number":328,"context_line":"        \u0027nova_api_os_compute_container\u0027,"},{"line_number":329,"context_line":"        \u0027nova_api_placement\u0027,"},{"line_number":330,"context_line":"        \u0027nova_compute\u0027,"},{"line_number":331,"context_line":"        \u0027nova_compute_container\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f4e5783_d08f242c","line":328,"range":{"start_line":328,"start_character":9,"end_line":328,"end_character":38},"updated":"2017-10-12 08:53:00.000000000","message":"needs to change to nova_api_container","commit_id":"11d0aafefa1c2d55f553ad2eee378c1dd311e601"}]}