)]}'
{"ansible-role-requirements.yml":[{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"5ffc368fe0b4bfd0a76372b92a9bd24e2a335517","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  scm: git"},{"line_number":71,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_cinder"},{"line_number":72,"context_line":"  version: b3f53ea50e35e7c8821329ca926ae5413621eb3f"},{"line_number":73,"context_line":"- name: os_designate"},{"line_number":74,"context_line":"  scm: git"},{"line_number":75,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_designate"},{"line_number":76,"context_line":"  version: 56cf5e273fe6241482e840fc75c9d5e9adc228ee"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_0d1c2bbf","line":73,"updated":"2017-10-25 07:39:38.000000000","message":"Is including this change in this patch intentional? (Also applies to the other non-Ceph-role related changes.)","commit_id":"9ade47f72f618b64dd4401572d6fb503f7c24864"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"b4acbc24ab11385d8c56d64403b53746a7dbdf33","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  scm: git"},{"line_number":71,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_cinder"},{"line_number":72,"context_line":"  version: b3f53ea50e35e7c8821329ca926ae5413621eb3f"},{"line_number":73,"context_line":"- name: os_designate"},{"line_number":74,"context_line":"  scm: git"},{"line_number":75,"context_line":"  src: https://git.openstack.org/openstack/openstack-ansible-os_designate"},{"line_number":76,"context_line":"  version: 56cf5e273fe6241482e840fc75c9d5e9adc228ee"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_c7bdc7d8","line":73,"in_reply_to":"3f4b6375_0d1c2bbf","updated":"2017-10-25 13:17:09.000000000","message":"There is no actual change in the roles or SHAs, just alpha sorting the openstack roles list.","commit_id":"9ade47f72f618b64dd4401572d6fb503f7c24864"}],"tests/roles/bootstrap-host/templates/user_variables_ceph.yml.j2":[{"author":{"_account_id":2463,"name":"Florian Haas","email":"florian.haas@cleura.com","username":"fghaas"},"change_message_id":"5ffc368fe0b4bfd0a76372b92a9bd24e2a335517","unresolved":false,"context_lines":[{"line_number":18,"context_line":"monitor_interface: eth1 # Management network in the AIO"},{"line_number":19,"context_line":"public_network: \"{{ (mgmt_range ~ \u0027.0/\u0027 ~ netmask) | ipaddr(\u0027net\u0027) }}\""},{"line_number":20,"context_line":"journal_size: 100"},{"line_number":21,"context_line":"osd_scenario: collocated"},{"line_number":22,"context_line":"pool_default_pg_num: 32"},{"line_number":23,"context_line":"openstack_config: true # Ceph ansible automatically creates pools \u0026 keys"},{"line_number":24,"context_line":"cinder_ceph_client: cinder"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f4b6375_cdf61364","line":21,"updated":"2017-10-25 07:39:38.000000000","message":"What do we want to do about osd_objectstore? Set that to filestore to maintain compatibility with what ceph-ansible would deploy previously, or set it to bluestore to be in line with the new upstream default? Or leave it unset and document it?","commit_id":"9ade47f72f618b64dd4401572d6fb503f7c24864"},{"author":{"_account_id":17799,"name":"Logan V","email":"logan2211@gmail.com","username":"Logan2211"},"change_message_id":"b4acbc24ab11385d8c56d64403b53746a7dbdf33","unresolved":false,"context_lines":[{"line_number":18,"context_line":"monitor_interface: eth1 # Management network in the AIO"},{"line_number":19,"context_line":"public_network: \"{{ (mgmt_range ~ \u0027.0/\u0027 ~ netmask) | ipaddr(\u0027net\u0027) }}\""},{"line_number":20,"context_line":"journal_size: 100"},{"line_number":21,"context_line":"osd_scenario: collocated"},{"line_number":22,"context_line":"pool_default_pg_num: 32"},{"line_number":23,"context_line":"openstack_config: true # Ceph ansible automatically creates pools \u0026 keys"},{"line_number":24,"context_line":"cinder_ceph_client: cinder"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3f4b6375_67d3b3d6","line":21,"in_reply_to":"3f4b6375_cdf61364","updated":"2017-10-25 13:17:09.000000000","message":"First note that the \"bootstrap-host\" role is only used in AIO and CI builds, so these vars are only deployed in those scenarios.\n\nThe vars here are only defined only as needed to provide a single node ceph cluster as needed in the AIO scenario. We don\u0027t define most of the ceph-ansible vars in the OSA tree because ceph-ansible can handle its own ceph-related defaults, and operators can override both OSA and ceph-ansible vars using group vars, or /etc/openstack_deploy/user_*.yml vars files as they would with any OSA vars customizations.\n\nI see that ceph-ansible has osd_objectstore defaulted to filestore even in v3 https://github.com/ceph/ceph-ansible/blob/stable-3.0/roles/ceph-defaults/defaults/main.yml#L325 so that\u0027s interesting -- I guess they use a conservative default since stable-3.0 is still supporting Jewel, but they could easily have a conditional there to default it to bluestore for Luminous and up. Maybe that would be a good patch to apply upstream?","commit_id":"9ade47f72f618b64dd4401572d6fb503f7c24864"}]}