)]}'
{"zuul.d/jobs.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ab054c79e17dd1b5c0ac222dc61635a8df976f59","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    name: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":42,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":43,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":44,"context_line":"- job:"},{"line_number":45,"context_line":"    name: openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":46,"context_line":"    parent: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":47,"context_line":"    vars:"},{"line_number":48,"context_line":"      action: deploy"},{"line_number":49,"context_line":"      scenario: ceph"},{"line_number":50,"context_line":"- job:"},{"line_number":51,"context_line":"    name: openstack-ansible-deploy-octavia-ubuntu-xenial"},{"line_number":52,"context_line":"    parent: openstack-ansible-deploy-aio-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f4b6375_9ae68f44","line":49,"range":{"start_line":44,"start_character":0,"end_line":49,"end_character":20},"updated":"2017-10-19 15:10:44.000000000","message":"Suggestion:\n\nInstead of repeating all these vars all the time, define each scenario - then each distro.\n\neg:\n\n- job:\n    name: openstack-ansible-deploy-ceph\n    parent: openstack-ansible-deploy-aio\n    vars:\n      action: deploy\n      scenario: ceph\n\n- job:\n    name: openstack-ansible-deploy-ceph\n    parent: openstack-ansible-deploy-ceph-ubuntu-xenial\n    nodeset: ubuntu-xenial","commit_id":"a285757ca65340ba8acceb89d3fbe22a6e777476"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c5c653688db1f3a90b2125af502485d55350b038","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    name: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":42,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":43,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":44,"context_line":"    branches:"},{"line_number":45,"context_line":"      - master"},{"line_number":46,"context_line":"      - stable/pike"},{"line_number":47,"context_line":"      - stable/ocata"},{"line_number":48,"context_line":"- job:"},{"line_number":49,"context_line":"    name: openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":50,"context_line":"    parent: openstack-ansible-deploy-aio-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_7a5193d8","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":20},"updated":"2017-10-19 15:12:30.000000000","message":"It\u0027s better to propose job definitions to each branch than to maintain these lists from here forward. It\u0027s easier to read and maintain if it\u0027s done in the branches.","commit_id":"40802b7d085bed849b216ce1d95e0d5a76f2d12d"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"2b6d14f4447d8c02531bdc04cedb6c4a1660f896","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    name: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":42,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":43,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":44,"context_line":"    branches:"},{"line_number":45,"context_line":"      - master"},{"line_number":46,"context_line":"      - stable/pike"},{"line_number":47,"context_line":"      - stable/ocata"},{"line_number":48,"context_line":"- job:"},{"line_number":49,"context_line":"    name: openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":50,"context_line":"    parent: openstack-ansible-deploy-aio-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_5abc97db","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":20},"in_reply_to":"3f4b6375_7a5193d8","updated":"2017-10-19 15:16:24.000000000","message":"I agree, but that\u0027s not how I understood how periodics work:\n\"So if you add a periodic job to a project it will run on all of that project’s branches. If you only want it to run on a subset of branches, just use branch matchers in the project-pipeline in the regular way.\"\n\nSource: https://docs.openstack.org/infra/manual/zuulv3.html#periodic-jobs","commit_id":"40802b7d085bed849b216ce1d95e0d5a76f2d12d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c5c653688db1f3a90b2125af502485d55350b038","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      - master"},{"line_number":46,"context_line":"      - stable/pike"},{"line_number":47,"context_line":"      - stable/ocata"},{"line_number":48,"context_line":"- job:"},{"line_number":49,"context_line":"    name: openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":50,"context_line":"    parent: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":51,"context_line":"    vars:"},{"line_number":52,"context_line":"      action: deploy"},{"line_number":53,"context_line":"      scenario: ceph"},{"line_number":54,"context_line":"    branches:"},{"line_number":55,"context_line":"      - master"},{"line_number":56,"context_line":"      - stable/pike"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_da73e77f","line":53,"range":{"start_line":48,"start_character":0,"end_line":53,"end_character":20},"updated":"2017-10-19 15:12:30.000000000","message":"See PS2 for a suggestion to simplify this.","commit_id":"40802b7d085bed849b216ce1d95e0d5a76f2d12d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"369c327508dd4b8d9c30c9d0f526dfc678d9fcf6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      Uses the gate-check-commit.sh script, running a default"},{"line_number":22,"context_line":"      aio deploy."},{"line_number":23,"context_line":"    run: zuul.d/playbooks/run"},{"line_number":24,"context_line":"    #post-run: tests/legacy_jobs/openstack-ansible-openstack-ansible-aio/post"},{"line_number":25,"context_line":"    timeout: 7200"},{"line_number":26,"context_line":"    irrelevant-files:"},{"line_number":27,"context_line":"      - ^\\.git.*"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f4b6375_284ef56e","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":77},"updated":"2017-10-23 10:53:40.000000000","message":"nit: We shouldn\u0027t include lines that have no purpose. If this does have a purpose, it should be commented to explain the purpose.","commit_id":"14a26c00678b84e54d71972c7563d7ab15d694b4"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"369c327508dd4b8d9c30c9d0f526dfc678d9fcf6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"      - master"},{"line_number":135,"context_line":"      - stable/pike"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"# opensuse"},{"line_number":138,"context_line":"- job:"},{"line_number":139,"context_line":"    name: openstack-ansible-deploy-aio-opensuse-423"},{"line_number":140,"context_line":"    parent: openstack-ansible-deploy-aio"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f4b6375_e8cc5dbd","line":137,"updated":"2017-10-23 10:53:40.000000000","message":"We should probably also add an upgrade for opensuse from pike to master for the aio scenario.","commit_id":"14a26c00678b84e54d71972c7563d7ab15d694b4"}],"zuul.d/project.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"473e44e2594a369e4fae5a82285d28e275335a02","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        - openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":23,"context_line":"        - openstack-ansible-deploy-ceph-centos-7"},{"line_number":24,"context_line":"        - openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":25,"context_line":"        - openstack-ansible-linters        "},{"line_number":26,"context_line":"    experimental:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - openstack-ansible-deploy-ceph-opensuse-423"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_29d7574e","line":25,"updated":"2017-10-19 18:27:12.000000000","message":"whitespace, and I prefer linters on top personally :p","commit_id":"19ed307db6f1ad70044609adec10fe11d9d4926b"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"22014d434a0020689ba56f05773d015731b7845f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        - openstack-ansible-linters"},{"line_number":33,"context_line":"        - openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":34,"context_line":"        - openstack-ansible-deploy-ceph-ubuntu-xenial"},{"line_number":35,"context_line":"    release:"},{"line_number":36,"context_line":"      jobs:"},{"line_number":37,"context_line":"        - announce-release        "},{"line_number":38,"context_line":"    periodic:"},{"line_number":39,"context_line":"      jobs:"},{"line_number":40,"context_line":"        - openstack-ansible-deploy-aio-centos-7"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3f4b6375_0178e027","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":34},"updated":"2017-10-20 10:17:05.000000000","message":"Release/docs jobs need to be done in project-config, not here as far as I recall.","commit_id":"96bdb278f592c8acfa732f42662244c72a9c5bbf"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"369c327508dd4b8d9c30c9d0f526dfc678d9fcf6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      jobs:"},{"line_number":32,"context_line":"        - openstack-ansible-linters"},{"line_number":33,"context_line":"        - openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":34,"context_line":"        - openstack-ansible-deploy-ceph-ubuntu-xenial    "},{"line_number":35,"context_line":"    periodic:"},{"line_number":36,"context_line":"      jobs:"},{"line_number":37,"context_line":"        - openstack-ansible-deploy-aio-centos-7"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f4b6375_68550dc6","line":34,"updated":"2017-10-23 10:53:40.000000000","message":"whitespace","commit_id":"14a26c00678b84e54d71972c7563d7ab15d694b4"}]}