)]}'
{"inventory/env.d/neutron.yml":[{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"aaf32c74df6bc1f5a91cbb8242742382171a35eb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    contains:"},{"line_number":76,"context_line":"      - neutron_server"},{"line_number":77,"context_line":"      - opendaylight"},{"line_number":78,"context_line":"      - quagga_server"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"physical_skel:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_31584154","line":78,"updated":"2018-01-18 08:08:55.000000000","message":"Thanks Dimitris for helping me out to provide right quagga inventory host configuration.","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":25505,"name":"Dimitrios Markou","email":"dimitrios.markou@att.com","username":"mardim"},"change_message_id":"9766a539a57f6e56ce87054b741cc18cb0ce2a59","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    contains:"},{"line_number":76,"context_line":"      - neutron_server"},{"line_number":77,"context_line":"      - opendaylight"},{"line_number":78,"context_line":"      - quagga_server"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"physical_skel:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_346caf9a","line":78,"in_reply_to":"7f96bb07_31584154","updated":"2018-01-18 08:21:50.000000000","message":"No problem! Anytime :)","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"}],"inventory/group_vars/quagga_all.yml":[{"author":{"_account_id":25505,"name":"Dimitrios Markou","email":"dimitrios.markou@att.com","username":"mardim"},"change_message_id":"1f2a10cc3adccb63168be794eccb41f239a34e64","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Find out correct quagga package url based on the"},{"line_number":20,"context_line":"# quagga install method"},{"line_number":21,"context_line":"quagga_package_url: \"{% if quagga_install_method \u003d\u003d \u0027deb_repo\u0027 %}https://wiki.opnfv.org/download/attachments/6827916/quagga-ubuntu.tar.gz{% else %}https://wiki.opnfv.org/download/attachments/6827916/quagga-4.tar.gz{% endif %}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Temporary location on which quagga packages to be"},{"line_number":24,"context_line":"# retrieved for the installation"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_f6498bb6","line":21,"range":{"start_line":21,"start_character":65,"end_line":21,"end_character":137},"updated":"2018-01-17 14:40:13.000000000","message":"I think is better to assign this to a variable","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":25505,"name":"Dimitrios Markou","email":"dimitrios.markou@att.com","username":"mardim"},"change_message_id":"1f2a10cc3adccb63168be794eccb41f239a34e64","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Find out correct quagga package url based on the"},{"line_number":20,"context_line":"# quagga install method"},{"line_number":21,"context_line":"quagga_package_url: \"{% if quagga_install_method \u003d\u003d \u0027deb_repo\u0027 %}https://wiki.opnfv.org/download/attachments/6827916/quagga-ubuntu.tar.gz{% else %}https://wiki.opnfv.org/download/attachments/6827916/quagga-4.tar.gz{% endif %}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Temporary location on which quagga packages to be"},{"line_number":24,"context_line":"# retrieved for the installation"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_76d33bd6","line":21,"range":{"start_line":21,"start_character":147,"end_line":21,"end_character":214},"updated":"2018-01-17 14:40:13.000000000","message":"ditto","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"aaf32c74df6bc1f5a91cbb8242742382171a35eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Find out correct quagga package url based on the"},{"line_number":20,"context_line":"# quagga install method"},{"line_number":21,"context_line":"quagga_package_url: \"{% if quagga_install_method \u003d\u003d \u0027deb_repo\u0027 %}https://wiki.opnfv.org/download/attachments/6827916/quagga-ubuntu.tar.gz{% else %}https://wiki.opnfv.org/download/attachments/6827916/quagga-4.tar.gz{% endif %}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Temporary location on which quagga packages to be"},{"line_number":24,"context_line":"# retrieved for the installation"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_912275b8","line":21,"range":{"start_line":21,"start_character":65,"end_line":21,"end_character":137},"in_reply_to":"7f96bb07_f6498bb6","updated":"2018-01-18 08:08:55.000000000","message":"okay, will do it in the next patch.","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":25505,"name":"Dimitrios Markou","email":"dimitrios.markou@att.com","username":"mardim"},"change_message_id":"1f2a10cc3adccb63168be794eccb41f239a34e64","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The neutron server node on which OSA configures ODL"},{"line_number":28,"context_line":"# as the BGP speaker"},{"line_number":29,"context_line":"quagga_install_host: \"{{ ((groups[\u0027neutron_server\u0027] | intersect(ansible_play_hosts)) | list)[0] }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# BGP Config Server Port at quagga side for ODL to establish"},{"line_number":32,"context_line":"# thrift connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_569cff0c","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":19},"updated":"2018-01-17 14:40:13.000000000","message":"Are you planning to install quagga in all neutron_server containers when you deploy HA topology or ?","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"aaf32c74df6bc1f5a91cbb8242742382171a35eb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The neutron server node on which OSA configures ODL"},{"line_number":28,"context_line":"# as the BGP speaker"},{"line_number":29,"context_line":"quagga_install_host: \"{{ ((groups[\u0027neutron_server\u0027] | intersect(ansible_play_hosts)) | list)[0] }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# BGP Config Server Port at quagga side for ODL to establish"},{"line_number":32,"context_line":"# thrift connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_b4075f18","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":19},"in_reply_to":"7f96bb07_569cff0c","updated":"2018-01-18 08:08:55.000000000","message":"Yes, the plan is to install quagga in all neutron_server containers, but enabling ODL as a bgp speaker on only one host. \nI think this variable name is misleading, will change it to odl-bgp-speaker-host. is that fine ?","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"},{"author":{"_account_id":25505,"name":"Dimitrios Markou","email":"dimitrios.markou@att.com","username":"mardim"},"change_message_id":"9766a539a57f6e56ce87054b741cc18cb0ce2a59","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The neutron server node on which OSA configures ODL"},{"line_number":28,"context_line":"# as the BGP speaker"},{"line_number":29,"context_line":"quagga_install_host: \"{{ ((groups[\u0027neutron_server\u0027] | intersect(ansible_play_hosts)) | list)[0] }}\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# BGP Config Server Port at quagga side for ODL to establish"},{"line_number":32,"context_line":"# thrift connection."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_f4be47d3","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":19},"in_reply_to":"7f96bb07_b4075f18","updated":"2018-01-18 08:21:50.000000000","message":"Yes I think its fine.","commit_id":"1083fc6e31d778eb1908857fa5215200aaa72826"}],"playbooks/os-setup-bgp-odl.yml":[{"author":{"_account_id":26087,"name":"thomas sounapoglou","email":"tomsou@gmail.com"},"change_message_id":"bc2d84026f998e5fac780ae8eee6e8663233ee81","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      command: \"{{ opendaylight_karaf_client }} -h {{ opendaylight_karaf_host }} \u0027bgp-connect --host {{ opendaylight_karaf_host }} --port {{ bgp_config_server_port }} add\u0027\""},{"line_number":61,"context_line":"      when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    - name: Configure Opendaylight as BGP speaker"},{"line_number":64,"context_line":"      command: \"{{ opendaylight_karaf_client }} -h {{ opendaylight_karaf_host }} \u0027odl:configure-bgp -op start-bgp-server --as-num 100 --router-id {{ odl_bgp_speaker_host }}\u0027\""},{"line_number":65,"context_line":"      when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7f96bb07_645d9a45","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":54},"updated":"2018-01-18 14:28:25.000000000","message":"Note, that for the time being bgp speaker is started and configured in the context of sdnvpn/testcase3.","commit_id":"e9089a23b7e9fb35a0cfb121159faff19ccd1613"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"12ca11ef876577478ae33334e230484bf1e4c5a6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      when: quagga_install_method \u003d\u003d \"deb_repo\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Prerequisite check for quagga"},{"line_number":48,"context_line":"      yum:"},{"line_number":49,"context_line":"        name: glib2,glib2-devel"},{"line_number":50,"context_line":"        state: present"},{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_753158a2","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":22},"updated":"2018-02-07 15:24:33.000000000","message":"what happens if we are running on openSUSE?","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"d1c86c34af1e0ab325c8f9402d83c7a6c58cd5f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      when: quagga_install_method \u003d\u003d \"deb_repo\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Prerequisite check for quagga"},{"line_number":48,"context_line":"      yum:"},{"line_number":49,"context_line":"        name: glib2,glib2-devel"},{"line_number":50,"context_line":"        state: present"},{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_d306041d","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":22},"in_reply_to":"3fa0c359_2e15ac9c","updated":"2018-02-09 13:14:36.000000000","message":"As we discussed in irc, I have removed prerequisite check since we use package module to install quagga packages which resolves dependencies automatically.","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"aa3c3722e5db5cba0b54dc1954382b36ead2d3e0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      when: quagga_install_method \u003d\u003d \"deb_repo\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Prerequisite check for quagga"},{"line_number":48,"context_line":"      yum:"},{"line_number":49,"context_line":"        name: glib2,glib2-devel"},{"line_number":50,"context_line":"        state: present"},{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_e354cf23","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":22},"in_reply_to":"3fa0c359_753158a2","updated":"2018-02-07 18:09:56.000000000","message":"Doesn\u0027t opensuse belong to rpm ansible-os-family ? With that assumption, i have added this check here. Please let me know what can go wrong here.","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5a45cb70b24c1c046d2f0dc1ea34b4f8b0e61e22","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      when: quagga_install_method \u003d\u003d \"deb_repo\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: Prerequisite check for quagga"},{"line_number":48,"context_line":"      yum:"},{"line_number":49,"context_line":"        name: glib2,glib2-devel"},{"line_number":50,"context_line":"        state: present"},{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_2e15ac9c","line":50,"range":{"start_line":48,"start_character":0,"end_line":50,"end_character":22},"in_reply_to":"3fa0c359_e354cf23","updated":"2018-02-08 08:42:45.000000000","message":"In quagga_all.yml you have this\n\nquagga_install_method: \"{{ (ansible_os_family\u003d\u003d\u0027Debian\u0027) | ternary(\u0027deb_repo\u0027, \u0027rpm_repo\u0027) }}\"\n\nso anything that\u0027s not Debian, it\u0027s rpm_repo.\n\nHere you are using \u0027yum\u0027 assuming that the only non-Debian distro that runs OSA is Centos which is not true. You shouldn\u0027t use the \u0027yum\u0027 module but use the \u0027package\u0027 one instead and merge the two tasks.","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"12ca11ef876577478ae33334e230484bf1e4c5a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_d5f86cc5","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"updated":"2018-02-07 15:24:33.000000000","message":"this feels a bit weird\n\nWhy not use the package module?\n\nhttp://docs.ansible.com/ansible/latest/package_module.html","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"5a45cb70b24c1c046d2f0dc1ea34b4f8b0e61e22","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_ee0ee48b","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"3fa0c359_863719b1","updated":"2018-02-08 08:42:45.000000000","message":"Use the package module","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":15362,"name":"fdegir","display_name":"Fatih Degirmenci","email":"fdegir@gmail.com","username":"fdegir"},"change_message_id":"ba5a206218aaf4455e2ef423c287b7a690e10d7d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_a33a9995","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"3fa0c359_899a3311","updated":"2018-02-14 18:59:16.000000000","message":"it seems ansible package module has some inconsistencies across the package managers. installing local packages works fine on centos but it doesn\u0027t on ubuntu/with apt. urls is not supported on ubuntu either as oppose to centos.\n\nThis throws the error as Peri noted: No package matching \u0027/tmp/git-core_2.15.0~rc0-1_all.deb\u0027 is available\nAttempting to install package with url fails as well: No package matching \u0027http://ftp.se.debian.org/debian/pool/main/g/git/git-core_2.15.0~rc0-1_all.deb\u0027 is available\n\n\n    - name: Install packages\n      package:\n        name: http://ftp.se.debian.org/debian/pool/main/g/git/git-core_2.15.0~rc0-1_all.deb\n        state: present\n\n\nand this works on centos.\n\n\n    - name: Install packages\n      package:\n        name: /tmp/git-1.8.3.1-12.el7_4.x86_64.rpm\n        state: present","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"70350f43c1ea6bceb934c56f25aee2b89782c4d0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_899a3311","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"3fa0c359_933ddcc5","updated":"2018-02-14 08:52:17.000000000","message":"Markos, when I tested it with package module it throws the following error.\n\nTASK [Install Quagga packages] ******************************************************************************************************************************************************************************************************************************************************************\nWednesday 14 February 2018  08:33:54 +0000 (0:00:00.272)       0:00:04.406 ****\nfailed: [controller00_neutron_server_container-e8d7ed9c] (item\u003dc-capnproto_1.0.2.75f7901.Ubuntu16.04_amd64.deb) \u003d\u003e {\"changed\": false, \"item\": \"c-capnproto_1.0.2.75f7901.Ubuntu16.04_amd64.deb\", \"msg\": \"No package matching \u0027/tmp/quagga/c-capnproto_1.0.2.75f7901.Ubuntu16.04_amd64.deb\u0027 is available\"}\nfailed: [controller00_neutron_server_container-e8d7ed9c] (item\u003dquagga_1.1.0.cd8ab40.Ubuntu16.04_amd64.deb) \u003d\u003e {\"changed\": false, \"item\": \"quagga_1.1.0.cd8ab40.Ubuntu16.04_amd64.deb\", \"msg\": \"No package matching \u0027/tmp/quagga/quagga_1.1.0.cd8ab40.Ubuntu16.04_amd64.deb\u0027 is available\"}\nfailed: [controller00_neutron_server_container-e8d7ed9c] (item\u003dthrift_1.0.0.b2a4d4a.Ubuntu16.04_amd64.deb) \u003d\u003e {\"changed\": false, \"item\": \"thrift_1.0.0.b2a4d4a.Ubuntu16.04_amd64.deb\", \"msg\": \"No package matching \u0027/tmp/quagga/thrift_1.0.0.b2a4d4a.Ubuntu16.04_amd64.deb\u0027 is available\"}\nfailed: [controller00_neutron_server_container-e8d7ed9c] (item\u003dzmq_4.1.3.56b71af.Ubuntu16.04_amd64.deb) \u003d\u003e {\"changed\": false, \"item\": \"zmq_4.1.3.56b71af.Ubuntu16.04_amd64.deb\", \"msg\": \"No package matching \u0027/tmp/quagga/zmq_4.1.3.56b71af.Ubuntu16.04_amd64.deb\u0027 is available\"}\nfailed: [controller00_neutron_server_container-e8d7ed9c] (item\u003dzrpc_0.2.0efd19f.thriftv4.Ubuntu16.04_amd64.deb) \u003d\u003e {\"changed\": false, \"item\": \"zrpc_0.2.0efd19f.thriftv4.Ubuntu16.04_amd64.deb\", \"msg\": \"No package matching \u0027/tmp/quagga/zrpc_0.2.0efd19f.thriftv4.Ubuntu16.04_amd64.deb\u0027 is available\"}\n\nI hope you already know that quagga_package_url just having tarball of quagga packages, got downloaded locally and trying to install the local packages with ansible package module. is that possible ? Doesn\u0027t package module is for installing packages from upstream ?","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"aa3c3722e5db5cba0b54dc1954382b36ead2d3e0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_863719b1","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"3fa0c359_d5f86cc5","updated":"2018-02-07 18:09:56.000000000","message":"I just borrowed this logic from apex installer which installs dependent packages followed by other packages for quagga which i couldn\u0027t it with ansible package module. Please suggest me the correct approach with using package module.","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"d1c86c34af1e0ab325c8f9402d83c7a6c58cd5f4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Install quagga rpm packages"},{"line_number":54,"context_line":"      shell: |"},{"line_number":55,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":56,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":57,"context_line":"        yum -y $packages"},{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_933ddcc5","line":57,"range":{"start_line":54,"start_character":0,"end_line":57,"end_character":24},"in_reply_to":"3fa0c359_ee0ee48b","updated":"2018-02-09 13:14:36.000000000","message":"done. But I haven\u0027t tested it yet due to ironic inspection issue. will check it once this issue is resolved.","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"12ca11ef876577478ae33334e230484bf1e4c5a6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      when: quagga_install_method \u003d\u003d \"rpm_repo\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    - name: Install quagga Debian packages"},{"line_number":61,"context_line":"      shell: |"},{"line_number":62,"context_line":"        cd {{ temp_quagga_dir }}"},{"line_number":63,"context_line":"        packages\u003d$(ls |grep -vE \u0027debuginfo|devel|contrib\u0027)"},{"line_number":64,"context_line":"        dpkg -i $packages"},{"line_number":65,"context_line":"      when: quagga_install_method \u003d\u003d \"deb_repo\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    - name: Start Zebra RPC Daemon for Quagga"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3fa0c359_f56ec894","line":64,"range":{"start_line":61,"start_character":6,"end_line":64,"end_character":25},"updated":"2018-02-07 15:24:33.000000000","message":"ditto\n\ncan\u0027t you also merge these two tasks?","commit_id":"81978749b6ff7ea177f0ff3127cce10e3275408b"}],"playbooks/roles/os_quagga/defaults/main.yml":[{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"c2cda02666196e22a608fa1c563d58260b06dd5c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"quagga_install_method: \"{{ (ansible_os_family\u003d\u003d\u0027Debian\u0027) | ternary(\u0027deb_repo\u0027, \u0027rpm_repo\u0027) }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Quagga deb packages repository location"},{"line_number":20,"context_line":"quagga_deb_repo: https://raw.githubusercontent.com/pperiyasamy/sdnvpn/master/quagga/quagga-ubuntu-updated.tar.gz"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Quagga rpm packages repository location"},{"line_number":23,"context_line":"quagga_rpm_repo: https://raw.githubusercontent.com/pperiyasamy/sdnvpn/master/quagga/quagga.tar.gz"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"3fa0c359_6fdec711","line":20,"updated":"2018-02-26 15:51:25.000000000","message":"Markos: As we discussed in IRC, now these packages can now be configured as local repository and quagga packages are just installed using quagga_package_list.\nAlso added prepare_quagga.yml to remove neutron server dependency for quagga zuul test.\n\nquagga_deb_repo and quagga_rpm_repo url will be changed to http://artifacts.opnfv.org/sdnvpn/quagga/... \nwill do it once reviews and tests are complete.","commit_id":"e4bb8874a092648a44cdc441c6ff16840955c638"}],"playbooks/roles/os_quagga/tasks/main.yml":[{"author":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"change_message_id":"0aaeddec865a0653e8d3cfad9514de381e8efe3b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    state: present"},{"line_number":56,"context_line":"  when: ansible_os_family \u003d\u003d \"Suse\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: Install Quagga packages"},{"line_number":59,"context_line":"  package:"},{"line_number":60,"context_line":"    name: \"{{ quagga_package_list }}\""},{"line_number":61,"context_line":"    state: present"},{"line_number":62,"context_line":"    update_cache: \"{{ (ansible_pkg_mgr in [\u0027apt\u0027, \u0027zypper\u0027]) | ternary(\u0027yes\u0027, omit) }}\""},{"line_number":63,"context_line":"    cache_valid_time: \"{{ (ansible_pkg_mgr \u003d\u003d \u0027apt\u0027) | ternary(cache_timeout, omit) }}\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Create Symbolic link for Quagga Zebra RPC service Init script"},{"line_number":66,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1f9dbf25_5b94e3e8","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":87},"updated":"2018-02-27 11:12:07.000000000","message":"This is not going to work for suse because the rpm packages you have in the tarball are only built for CentOS. Is it not possible to use upstream packages of quagga, thrift, zrpc, etc?","commit_id":"77dc85052bb7bb6ba03e6b847e5bae2f6d185b4f"}],"playbooks/roles/quagga/tasks/main.yml":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"e85fe158b419bdd1e3c787a79e776dea44dbed63","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_fbd0efcb","line":46,"updated":"2018-02-19 14:34:23.000000000","message":"Is it possible to get this into the system-wide init scripts directory, or better yet, convert it to a systemd unit file? This would allow us to use Ansible\u0027s service module.","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"3c2d40aa850244a3f3d6168abec066c5b1468064","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_5443dbaf","line":46,"in_reply_to":"3fa0c359_1179e591","updated":"2018-02-20 12:22:49.000000000","message":"Done","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"b93bd59d81da3f720bbf04d0ec3bd7d00de4ffd8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_1179e591","line":46,"in_reply_to":"3fa0c359_1fca5119","updated":"2018-02-20 10:59:52.000000000","message":"instead of command you can also use the \u0027file\u0027 module I believe :) it can create symlinks for you.","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"56e09ec679832363c9ea88ef43a41d7b2fd43c23","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_bfff9d65","line":46,"in_reply_to":"3fa0c359_7e883bc5","updated":"2018-02-20 10:35:11.000000000","message":"ok but i think it would work if you simply copy the zrpcd file to /etc/init.d/ and then use the \u0027service\u0027 ansible module to manage it. no? or is there a hard requirement for it to be in /opt/quagga? it seems a bit strange.","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"98baf2b7b11b4d521ec296d459d1fec576778475","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_1fca5119","line":46,"in_reply_to":"3fa0c359_bfff9d65","updated":"2018-02-20 10:42:26.000000000","message":"Yes Markos, I\u0027m changing it like below:\n\n- name: Create Symbolic link for Quagga Zebra RPC service Init script\n  shell: \"/bin/ln -s /opt/quagga/etc/init.d/zrpcd /etc/init.d/zrpcd\"\n  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host\n\n- name: Start Quagga Zebra RPC service\n  service:\n    name: zrpcd\n    state: started\n    enabled: yes\n  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"dcde3f3eecb776ffdfd4334059b7940ae2de43ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    state: present"},{"line_number":44,"context_line":"  with_items: \"{{ quagga_packages.stdout_lines }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Start Quagga Zebra RPC service"},{"line_number":47,"context_line":"  command: /opt/quagga/etc/init.d/zrpcd start"},{"line_number":48,"context_line":"  when: inventory_hostname \u003d\u003d odl_bgp_speaker_host"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_7e883bc5","line":46,"in_reply_to":"3fa0c359_fbd0efcb","updated":"2018-02-20 08:54:11.000000000","message":"This is the only option which comes with 6WIND quagga package to start the thrift rpc server. This service is optional and is required only for OpenDaylight (on one of its node if ODL runs in a cluster). This would be the reason why it\u0027s not made as init script or systemd service. Let me talk to 6WIND folks and will come back.","commit_id":"2b8692be7c3ed213c4480b8ffebf53ad73f6ce09"}],"playbooks/setup-openstack.yml":[{"author":{"_account_id":21883,"name":"Manuel Buil","email":"mbuil@suse.com","username":"mbuil"},"change_message_id":"0aaeddec865a0653e8d3cfad9514de381e8efe3b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- include: os-cinder-install.yml"},{"line_number":20,"context_line":"- include: os-nova-install.yml"},{"line_number":21,"context_line":"- include: os-neutron-install.yml"},{"line_number":22,"context_line":"- include: os-setup-bgp-odl.yml"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - neutron_plugin_type \u003d\u003d \"ml2.opendaylight\""},{"line_number":25,"context_line":"    - \"\u0027bgpvpn\u0027 in neutron_plugin_base\""},{"line_number":26,"context_line":"- include: os-heat-install.yml"},{"line_number":27,"context_line":"- include: os-horizon-install.yml"},{"line_number":28,"context_line":"- include: os-ceilometer-install.yml"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1f9dbf25_9e901998","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":39},"updated":"2018-02-27 11:12:07.000000000","message":"I still don\u0027t like this approach. The setup-openstack.yml should trigger the installation of openstack components and adding extra stuff perverts it and creates a dangerous precedent. To me, there are two options (I think 2 is better):\n1 - The call to the role should be part of the meta directory of os_neutron, as we are doing with ODL\n2 - This functionality requires ODL and does not have any meaning without ODL, so probably it should be contained inside the ODL role. ODL role would deploy ODL and when bgpvpn is selected, it will also install the required quagga packages.","commit_id":"77dc85052bb7bb6ba03e6b847e5bae2f6d185b4f"}],"tests/roles/bootstrap-host/tasks/prepare_quagga.yml":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"f5ed1cba4ed6af95f14a4e64ebfb7d3a166b2b81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3fa0c359_9fffb7aa","updated":"2018-02-27 08:27:46.000000000","message":"What is the purpose of this file since you already have playbooks/roles/os_quagga/tasks/main.yml ? The role is supposed to prepare and setup quagga so I am not sure why you need this extra playbook to duplicate the work","commit_id":"77dc85052bb7bb6ba03e6b847e5bae2f6d185b4f"},{"author":{"_account_id":26445,"name":"Periyasamy Palanisamy","email":"periyasamy.palanisamy@ericsson.com","username":"pperiyasamy"},"change_message_id":"5b2f81d198381344c7d54b957fcd0b3d5f3a4cad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3fa0c359_bfbf13a9","in_reply_to":"3fa0c359_9fffb7aa","updated":"2018-02-27 08:41:23.000000000","message":"To run the os_quagga role, we might need to have neutron server with opendaylight to decide whether to configure it as BGP server or not. Hence I have duplicated only quagga installation specific tasks in this file for early run.\n\nwe do have checks like inventory_hostname \u003d\u003d odl_bgp_speaker_host in the neutron server node specific tasks. so it is good to invoke os_quagga role from here ?","commit_id":"77dc85052bb7bb6ba03e6b847e5bae2f6d185b4f"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"da048b0792eb934a61396d34b2ac9c6df1be9f7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"3fa0c359_622812ee","in_reply_to":"3fa0c359_bfbf13a9","updated":"2018-02-27 09:34:36.000000000","message":"That sounds more reasonable and that probably means that the quagga has to be a separate role living outside the integration repo so it can be shared by other projects. It\u0027s just another role that neutron can use in the end.","commit_id":"77dc85052bb7bb6ba03e6b847e5bae2f6d185b4f"}]}