)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"7da7663d8222f2ab703071aaf6693cf1a9490144","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Carter (cloudnull) \u003ckevin@cloudnull.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-04 21:28:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add scafolding for multiple container techs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_ed93225a","line":7,"updated":"2018-01-08 15:11:24.000000000","message":"scaffolding","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"66a76c49f0f5b6a1d3278e948b14da838ebc59c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Carter (cloudnull) \u003ckevin@cloudnull.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-04 21:28:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add scafolding for multiple container techs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_4d4785bd","line":7,"in_reply_to":"9f91af0f_ed93225a","updated":"2018-01-09 21:02:09.000000000","message":"Done","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"7da7663d8222f2ab703071aaf6693cf1a9490144","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add scafolding for multiple container techs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"},{"line_number":11,"context_line":"been added allowing the deployer to set the container tech within a"},{"line_number":12,"context_line":"dpleoyment. At this point the only supported container tech is \"lxc\""},{"line_number":13,"context_line":"however in a follow on PR we intend to add systemd-nspawn."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_8d9cd66a","line":10,"updated":"2018-01-08 15:11:24.000000000","message":"technologies","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"66a76c49f0f5b6a1d3278e948b14da838ebc59c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add scafolding for multiple container techs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"},{"line_number":11,"context_line":"been added allowing the deployer to set the container tech within a"},{"line_number":12,"context_line":"dpleoyment. At this point the only supported container tech is \"lxc\""},{"line_number":13,"context_line":"however in a follow on PR we intend to add systemd-nspawn."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_0d173da6","line":10,"in_reply_to":"9f91af0f_8d9cd66a","updated":"2018-01-09 21:02:09.000000000","message":"Done","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"7da7663d8222f2ab703071aaf6693cf1a9490144","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"},{"line_number":11,"context_line":"been added allowing the deployer to set the container tech within a"},{"line_number":12,"context_line":"dpleoyment. At this point the only supported container tech is \"lxc\""},{"line_number":13,"context_line":"however in a follow on PR we intend to add systemd-nspawn."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The playbooks for lxc-containers-* have all been renamed so we have a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_ad999a79","line":12,"updated":"2018-01-08 15:11:24.000000000","message":"deployment","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"66a76c49f0f5b6a1d3278e948b14da838ebc59c9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change makes it possible for us to add future support for multiple"},{"line_number":10,"context_line":"container technolofies within a single deployment. A new variable has"},{"line_number":11,"context_line":"been added allowing the deployer to set the container tech within a"},{"line_number":12,"context_line":"dpleoyment. At this point the only supported container tech is \"lxc\""},{"line_number":13,"context_line":"however in a follow on PR we intend to add systemd-nspawn."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The playbooks for lxc-containers-* have all been renamed so we have a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_cd0cf595","line":12,"in_reply_to":"9f91af0f_ad999a79","updated":"2018-01-09 21:02:09.000000000","message":"Done","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":538,"name":"Major Hayden","email":"major@mhtx.net","username":"rackerhacker"},"change_message_id":"7da7663d8222f2ab703071aaf6693cf1a9490144","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The playbooks for lxc-containers-* have all been renamed so we have a"},{"line_number":16,"context_line":"consistent experience when sourcing and executing container type plays."},{"line_number":17,"context_line":"To ensure this change does not break exisitng deployer automation links"},{"line_number":18,"context_line":"have been created for the old playbook names. In a future release we can"},{"line_number":19,"context_line":"remove these links."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_4d8c8e35","line":17,"updated":"2018-01-08 15:11:24.000000000","message":"existing","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"66a76c49f0f5b6a1d3278e948b14da838ebc59c9","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The playbooks for lxc-containers-* have all been renamed so we have a"},{"line_number":16,"context_line":"consistent experience when sourcing and executing container type plays."},{"line_number":17,"context_line":"To ensure this change does not break exisitng deployer automation links"},{"line_number":18,"context_line":"have been created for the old playbook names. In a future release we can"},{"line_number":19,"context_line":"remove these links."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f91af0f_ed0f7985","line":17,"in_reply_to":"9f91af0f_4d8c8e35","updated":"2018-01-09 21:02:09.000000000","message":"Done","commit_id":"26e0bcf5acd8d41a68d0a52c952502b8b5e501f1"}],"playbooks/common-playbooks/cinder.yml":[{"author":{"_account_id":2799,"name":"Andy McCrae","email":"andy.mccrae@googlemail.com","username":"andrew-mccrae"},"change_message_id":"eda67d91cbb655b1bcdee00a7ed7fe6d9fd40061","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        - \"cinder_backend_lvm_inuse | bool\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    - name: Configure container (other services)"},{"line_number":59,"context_line":"      include: \"../common-tasks/os-{{ container_tech | default(\u0027lxc\u0027) }}-container-setup.yml\""},{"line_number":60,"context_line":"      static: no"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - \"\u0027cinder_volume\u0027 not in group_names\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df87a7cf_da8680dc","line":59,"range":{"start_line":59,"start_character":64,"end_line":59,"end_character":67},"updated":"2017-12-14 06:47:58.000000000","message":"Generic comment about pretty much all the includes/when clauses:\n\nYou wouldn\u0027t need to default here, since you are specifying container_tech.\n\nAlternatively, if you want to be able to not specify it - then all the \"when\" clauses with \"when: container_tech \u003d\u003d \u0027lxc\u0027 are going to have to be changed. e.g. line 92 would have to change to something like:\n\nwhen:\n  - container_tech is not defined or container_tech \u003d\u003d \u0027lxc\u0027\n\nTL;DR pick whether its a forced var that HAS to be set (and we default in some default location like group_vars or w/e) - or whether it can be left out altogether (and we explicitly default to lxc in the absence of the container_tech variable).","commit_id":"b03a153f6165c4c1b2ddc48ce944faf1a8f86b61"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"971a03483682960d8050af32cf85a042f1387fa8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        - \"cinder_backend_lvm_inuse | bool\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    - name: Configure container (other services)"},{"line_number":59,"context_line":"      include: \"../common-tasks/os-{{ container_tech | default(\u0027lxc\u0027) }}-container-setup.yml\""},{"line_number":60,"context_line":"      static: no"},{"line_number":61,"context_line":"      when:"},{"line_number":62,"context_line":"        - \"\u0027cinder_volume\u0027 not in group_names\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df87a7cf_c0968695","line":59,"range":{"start_line":59,"start_character":64,"end_line":59,"end_character":67},"in_reply_to":"df87a7cf_da8680dc","updated":"2017-12-14 14:42:36.000000000","message":"Sadly the includes are doing a playbook include which does not have access to the group_vars but the when clauses in the playbooks do. To keep all of the includes consistent I have defaulted to \"{{ container_tech | default(\u0027lxc\u0027) }}\" however I could remove that syntax and just do \"{{ container_tech }}\" in the playbooks for task includes if we think it best.","commit_id":"b03a153f6165c4c1b2ddc48ce944faf1a8f86b61"}],"playbooks/containers-deploy.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_8b4c0477","updated":"2018-01-23 09:33:05.000000000","message":"I am not sure what\u0027s the point of this playbook.\nI understand it\u0027s for user-friendliness, but isn\u0027t lxc-containers-hosts enough to be explicit we are using lxc?\n\nThe swap to nspawn, instead of being one var, would be done by replacing the default playbook path, which is more explicit, and also would need updating in the upgrade script, which is more explicit/less failure prone to me.\n\nRight now, if we follow that path, at some point people would have lxc containers and nspawn containers at the same time by just a change of var. I think respecting the same path is not a bad idea.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_1df33d75","in_reply_to":"7f96bb07_8b4c0477","updated":"2018-01-24 03:12:51.000000000","message":"I\u0027d be happy to remove this rename however as you mentioned it\u0027s for ease of understanding. The old container playbooks started with lxc- this groups all container playbooks under containers- which is sorted by tools like `ls` and from a point of presentation is easy to grok from browsers like github.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"}],"playbooks/lxc-containers-create.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"containers-lxc-create.yml"}],"source_content_type":"x-git/symlink","patch_set":10,"id":"7f96bb07_eb5d8815","line":1,"updated":"2018-01-23 09:33:05.000000000","message":"nit: I don\u0027t see why we have to rename this. It makes it less explicit that something starting with the \"backend\".","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"containers-lxc-create.yml"}],"source_content_type":"x-git/symlink","patch_set":10,"id":"7f96bb07_7d8841c5","line":1,"in_reply_to":"7f96bb07_eb5d8815","updated":"2018-01-24 03:12:51.000000000","message":"I\u0027d argue that it makes it more explicit. From the persepective of the user, the container interactions all now happen in the container- playbooks. This is following a similar pattern as the os-*, setup-* etc playbooks.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"}],"playbooks/setup-hosts.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: openstack-hosts-setup.yml"},{"line_number":17,"context_line":"- include: security-hardening.yml"},{"line_number":18,"context_line":"- include: containers-deploy.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_2bd7f051","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"updated":"2018-01-23 09:33:05.000000000","message":"Same remark as above on the explicit path.\n\nIf you change that, you should also change scripts/run-upgrades.sh","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: openstack-hosts-setup.yml"},{"line_number":17,"context_line":"- include: security-hardening.yml"},{"line_number":18,"context_line":"- include: containers-deploy.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_7d7601db","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"7f96bb07_2bd7f051","updated":"2018-01-24 03:12:51.000000000","message":"I certainly could change the reference in run-upgrades however I don\u0027t see how that\u0027s relevant here. Any upgrade would have lxc containers and the call to RUN_TASKS+\u003d(\"lxc-containers-create.yml -e \u0027lxc_container_allow_restarts\u003dfalse\u0027 --limit galera_all\") is what would would be required there.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a50ac5cc042da530a7c722dabc645bce78398825","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: openstack-hosts-setup.yml"},{"line_number":17,"context_line":"- include: security-hardening.yml"},{"line_number":18,"context_line":"- include: containers-deploy.yml"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_b1e82ab3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":32},"in_reply_to":"7f96bb07_7d7601db","updated":"2018-01-24 09:30:30.000000000","message":"Well, if you rename the playbooks in this patch, it makes sense to rename everywhere they are used.\nIf we rename lxc-hosts-setup and lxc-containers-create, we have to rename them in the upgrade script too.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"}],"scripts/gate-check-commit.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5775d2d401f6e5a2b0209415135f62d6205cb7e2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"export ANSIBLE_LOG_DIR\u003d\"/openstack/log/ansible-logging\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Set the scenario to execute based on the first CLI parameter"},{"line_number":47,"context_line":"export SCENARIO\u003d${1:-\"aio_lxc\"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Set the action base on the second CLI parameter"},{"line_number":50,"context_line":"# Actions available: [ \u0027deploy\u0027, \u0027upgrade\u0027 ]"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9f91af0f_1556cd5d","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":29},"updated":"2018-01-04 15:11:39.000000000","message":"why not keeping aio, and have another scenario for nspawn later? No risk from breaking upgrades AND consistency accross the board.","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"32ccf5286542697e7590fcf43ab218623d71521b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"export ANSIBLE_LOG_DIR\u003d\"/openstack/log/ansible-logging\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Set the scenario to execute based on the first CLI parameter"},{"line_number":47,"context_line":"export SCENARIO\u003d${1:-\"aio_lxc\"}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Set the action base on the second CLI parameter"},{"line_number":50,"context_line":"# Actions available: [ \u0027deploy\u0027, \u0027upgrade\u0027 ]"}],"source_content_type":"text/x-sh","patch_set":8,"id":"9f91af0f_99ec4ff4","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":29},"in_reply_to":"9f91af0f_1556cd5d","updated":"2018-01-04 21:33:21.000000000","message":"this is changed so we can differentiate jobs by the core tech they\u0027re using. In the future it\u0027s my hope that we can have gates for things like \"aio_lxc\", \"aio_nspawn\", \"aio_baremetal\", etc...","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"}],"tests/roles/bootstrap-host/defaults/main.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5775d2d401f6e5a2b0209415135f62d6205cb7e2","unresolved":false,"context_lines":[{"line_number":238,"context_line":"#bootstrap_host_public_address: 0.0.0.0"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# Set the container technology in service. Options are lxc."},{"line_number":241,"context_line":"bootstrap_container_tech: \"lxc\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f91af0f_f54a49aa","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":10},"updated":"2018-01-04 15:11:39.000000000","message":"can\u0027t we just use container_tech here? or parse the scenario if you really want to keep the scenario name with lxc?","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4b5924cffdafdfc706595b17ad46227b904cef16","unresolved":false,"context_lines":[{"line_number":238,"context_line":"#bootstrap_host_public_address: 0.0.0.0"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"# Set the container technology in service. Options are lxc."},{"line_number":241,"context_line":"bootstrap_container_tech: \"lxc\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f91af0f_5909e7da","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":10},"in_reply_to":"9f91af0f_f54a49aa","updated":"2018-01-04 21:29:15.000000000","message":"Done","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"}],"tests/roles/bootstrap-host/templates/user_variables.aio.yml.j2":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"5775d2d401f6e5a2b0209415135f62d6205cb7e2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"{% endif %}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Set the container tech. Options are \"lxc\""},{"line_number":209,"context_line":"container_tech: \"{{ bootstrap_container_tech }}\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f91af0f_75d4f9bd","line":209,"range":{"start_line":209,"start_character":20,"end_line":209,"end_character":30},"updated":"2018-01-04 15:11:39.000000000","message":"we can probably remove bootstrap_ to avoid an extra var.","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"4b5924cffdafdfc706595b17ad46227b904cef16","unresolved":false,"context_lines":[{"line_number":206,"context_line":"{% endif %}"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Set the container tech. Options are \"lxc\""},{"line_number":209,"context_line":"container_tech: \"{{ bootstrap_container_tech }}\""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f91af0f_390663d0","line":209,"range":{"start_line":209,"start_character":20,"end_line":209,"end_character":30},"in_reply_to":"9f91af0f_75d4f9bd","updated":"2018-01-04 21:29:15.000000000","message":"Done","commit_id":"8f8aaad4b4d76e4168777e51c3464aa7e2593925"}],"tests/vars/bootstrap-aio-vars.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"confd_overrides:"},{"line_number":17,"context_line":"  aio_lxc:"},{"line_number":18,"context_line":"    - name: cinder.yml.aio"},{"line_number":19,"context_line":"    - name: designate.yml.aio"},{"line_number":20,"context_line":"    - name: glance.yml.aio"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_cb53ece1","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"updated":"2018-01-23 09:33:05.000000000","message":"how would that work for upgrades that would have the var for the scenario set to aio? I know it doesn\u0027t go through the bootstrap again, so this will be ignored, but I am afraid of the future issues that can happen in the next cycle.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3c8b8ee119d920324646d98d808d61e81f447d88","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"confd_overrides:"},{"line_number":17,"context_line":"  aio_lxc:"},{"line_number":18,"context_line":"    - name: cinder.yml.aio"},{"line_number":19,"context_line":"    - name: designate.yml.aio"},{"line_number":20,"context_line":"    - name: glance.yml.aio"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f93b717_710d328f","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"in_reply_to":"7f96bb07_317adab9","updated":"2018-01-25 03:00:35.000000000","message":"yes this change is because it names the aio type being run. As baremetal, nspawn, etc, come into play those new system types should follow suit. As a developer / user of OSA I should be able to see what gates are running and I should be able to derive the characteristics of the jobs without having to descend into each one or know what\u0027s going on because of tribal knowledge.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a50ac5cc042da530a7c722dabc645bce78398825","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"confd_overrides:"},{"line_number":17,"context_line":"  aio_lxc:"},{"line_number":18,"context_line":"    - name: cinder.yml.aio"},{"line_number":19,"context_line":"    - name: designate.yml.aio"},{"line_number":20,"context_line":"    - name: glance.yml.aio"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_317adab9","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"in_reply_to":"7f96bb07_bd3a49e4","updated":"2018-01-24 09:30:30.000000000","message":"The upgrade job is passing a scenario named \"aio\", while the others are passing \"aio_lxc\".\n\nBecause we checkout previous branch before the bootstraping ansible, we\u0027d use \"aio\" for Pike, which knows what \"aio\" is, then we do the upgrade.\n\nin R cycle, the upgrade would still be \"aio\" but that wouldn\u0027t map to anything, because aio isn\u0027t defined here. So we\u0027d have to worry about changing that var to aio_lxc again.\n\nWhy don\u0027t we simply keep aio, it\u0027s simple and it works. If it\u0027s just because it looks good/consistent, I\u0027d say we aren\u0027t consistent already, and we should probably don\u0027t care.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"confd_overrides:"},{"line_number":17,"context_line":"  aio_lxc:"},{"line_number":18,"context_line":"    - name: cinder.yml.aio"},{"line_number":19,"context_line":"    - name: designate.yml.aio"},{"line_number":20,"context_line":"    - name: glance.yml.aio"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_bd3a49e4","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"in_reply_to":"7f96bb07_cb53ece1","updated":"2018-01-24 03:12:51.000000000","message":"This is simply the job name. We could leave the aio name in place and have it point to \"aio_lxc\" however I\u0027m not sure what effect we\u0027re worried about?","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4349a040104b6fd13f5716736fadb2a7f93ee2d8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    timeout: 10800"},{"line_number":66,"context_line":"    vars:"},{"line_number":67,"context_line":"      action: upgrade"},{"line_number":68,"context_line":"      scenario: aio_lxc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"- job:"},{"line_number":71,"context_line":"    name: openstack-ansible-upgrade-ceph-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df87a7cf_62cb1972","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":23},"updated":"2017-12-13 17:37:04.000000000","message":"this will break the upgrades:\nWe\u0027ll checkout pike with AIO_LXC set as scenario and therefore we won\u0027t know what to do.","commit_id":"97ace196e775faf5148ce85ddd495bf6e2a0c5f0"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_f97005dd","updated":"2018-01-23 09:33:05.000000000","message":"I don\u0027t think we should rename jobs. There are jobs that depend on that definition in tests repo, so I\u0027d rather be safe and keep the same name for now. We can include _nspawn later, I don\u0027t mind the non-consistency between the two, because we already aren\u0027t consistent for aio/ceph (which don\u0027t have the _lxc)","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"955b4c80a9fdc08594ce14dfcd91e6e6263ea889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_cf10b8ab","in_reply_to":"7f96bb07_bd132966","updated":"2018-01-24 03:31:21.000000000","message":"to help with the possibility of an external repo using our old job name a collection of meta jobs has been added to the bottom of this file which will allow folks to continue using the old job as needed.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a50ac5cc042da530a7c722dabc645bce78398825","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_f136b203","in_reply_to":"7f96bb07_cf10b8ab","updated":"2018-01-24 09:30:30.000000000","message":"What I mean is the change of name is unnecessary:\nIt brings more possible issues than it brings solutions, just to see something in the job name...\n\nFor the meta playbooks, I don\u0027t see the job openstack-ansible-deploy-aio-ubuntu-xenial.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"3c8b8ee119d920324646d98d808d61e81f447d88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5f93b717_b105fa7c","in_reply_to":"7f96bb07_f136b203","updated":"2018-01-25 03:00:35.000000000","message":"The job you\u0027re looking for is defined here -\n https://review.openstack.org/#/c/527749/11/zuul.d/jobs.yaml@156","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_bd132966","in_reply_to":"7f96bb07_f97005dd","updated":"2018-01-24 03:12:51.000000000","message":"What jobs or impact are we worried about? do you have links to the jobs that need to change? As for ceph, I\u0027m not touching the ceph job however I could if you want me to.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    timeout: 10800"},{"line_number":67,"context_line":"    vars:"},{"line_number":68,"context_line":"      action: upgrade"},{"line_number":69,"context_line":"      scenario: aio"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"},{"line_number":72,"context_line":"    name: openstack-ansible-upgrade-ceph-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_196cd106","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":19},"updated":"2018-01-23 09:33:05.000000000","message":"I think this is confusing to have a scenario that isn\u0027t the same as the job name, but I don\u0027t see another way to do it (except keeping the aio name or using another axis)","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    timeout: 10800"},{"line_number":67,"context_line":"    vars:"},{"line_number":68,"context_line":"      action: upgrade"},{"line_number":69,"context_line":"      scenario: aio"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- job:"},{"line_number":72,"context_line":"    name: openstack-ansible-upgrade-ceph-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f96bb07_8f0dd036","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":19},"in_reply_to":"7f96bb07_196cd106","updated":"2018-01-24 03:12:51.000000000","message":"Same as above, I fail to see how it\u0027s confusing. The old scenario was called \"aio\" the new one is called \"aio_lxc\".","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4c71f08d893225e84a894be7713c1002bd99e566","unresolved":false,"context_lines":[{"line_number":147,"context_line":"# In order to cater for the possibility that an external job was dependent on the old job name"},{"line_number":148,"context_line":"# the following job items are used to repoint work to the updated job name should the old name"},{"line_number":149,"context_line":"# be referenced. As we updated our zuul dependencies and external job runners these items should"},{"line_number":150,"context_line":"# be removed as soon as they\u0027re no longer needed."},{"line_number":151,"context_line":"- job:"},{"line_number":152,"context_line":"    name: openstack-ansible-varstest-aio-ubuntu-xenial"},{"line_number":153,"context_line":"    parent: openstack-ansible-varstest-aio_lxc-ubuntu-xenial"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f96bb07_b1158a4b","line":150,"updated":"2018-01-24 09:31:11.000000000","message":"Ok got it.","commit_id":"e4ca9c0e1d615e99d173589d693c384bac43a0a1"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b4273265cbcc213fc4b102b55f2794ebefbc9413","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      scenario: aio"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# NOTE(cloudnull): META JOB MAP"},{"line_number":147,"context_line":"# In order to cater for the possibility that an external job was dependent on the old job name"},{"line_number":148,"context_line":"# the following job items are used to repoint work to the updated job name should the old name"},{"line_number":149,"context_line":"# be referenced. As we updated our zuul dependencies and external job runners these items should"},{"line_number":150,"context_line":"# be removed as soon as they\u0027re no longer needed."},{"line_number":151,"context_line":"- job:"},{"line_number":152,"context_line":"    name: openstack-ansible-varstest-aio-ubuntu-xenial"},{"line_number":153,"context_line":"    parent: openstack-ansible-varstest-aio_lxc-ubuntu-xenial"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- job:"},{"line_number":156,"context_line":"    name: openstack-ansible-deploy-aio-ubuntu-xenial"},{"line_number":157,"context_line":"    parent: openstack-ansible-deploy-aio"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"- job:"},{"line_number":160,"context_line":"    name: openstack-ansible-upgrade-aio-ubuntu-xenial"},{"line_number":161,"context_line":"    parent: openstack-ansible-deploy-aio_lxc-ubuntu-xenial"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"- job:"},{"line_number":164,"context_line":"    name: openstack-ansible-deploy-aio-centos-7"},{"line_number":165,"context_line":"    parent: openstack-ansible-deploy-aio_lxc-centos-7"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"- job:"},{"line_number":168,"context_line":"    name: openstack-ansible-upgrade-aio-centos-7"},{"line_number":169,"context_line":"    parent: openstack-ansible-upgrade-aio_lxc-centos-7"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"- job:"},{"line_number":172,"context_line":"    name: openstack-ansible-deploy-aio-opensuse-423"},{"line_number":173,"context_line":"    parent: openstack-ansible-deploy-aio_lxc-opensuse-423"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"- job:"},{"line_number":176,"context_line":"    name: openstack-ansible-deploy-ceph-opensuse-423"},{"line_number":177,"context_line":"    parent: openstack-ansible-deploy-aio_lxc-opensuse-423"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"- job:"},{"line_number":180,"context_line":"    name: openstack-ansible-upgrade-aio-opensuse-423"},{"line_number":181,"context_line":"    parent: openstack-ansible-deploy-aio_lxc-opensuse-423"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f93b717_bcf18a03","line":181,"range":{"start_line":146,"start_character":0,"end_line":181,"end_character":57},"updated":"2018-02-01 16:57:27.000000000","message":"I don\u0027t think this is a good idea, for the sake of consistency.","commit_id":"d5860004652368b1f31aa8599a98545879c0174c"}],"zuul.d/project.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"f2fbcbca577c74223c75b94f2fc172924b0c6f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_19137168","updated":"2018-01-23 09:33:05.000000000","message":"Same remark about external jobs breakages.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"810cb46449371f51f3627c3362a3f6c0a7a94cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7f96bb07_0f50e009","in_reply_to":"7f96bb07_19137168","updated":"2018-01-24 03:12:51.000000000","message":"I fail to see how the changes in this file would break our external job names. These are the jobs that we run in check and gate for only in this repo.","commit_id":"df7c427e70b0ba98b368bed9e28c84b01dc1e30c"}]}