)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b35d0e0b212508dc24903798401f4df33f88317a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a return code check to the osa wrapper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to our use of block/rescue pattern in some of the playbooks/roles"},{"line_number":10,"context_line":"the after run report will show something \"failed\" even when the run"},{"line_number":11,"context_line":"succeeds. This creates a poor user experience when looking at the"},{"line_number":12,"context_line":"playbook runs, especially as a new user. This change adds a simple"},{"line_number":13,"context_line":"return code check when the openstack-ansible wrapper is used and reports"},{"line_number":14,"context_line":"if the run succeeds or is a failure based on the RC. This should help"},{"line_number":15,"context_line":"users understand when something actually fails, at a glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_0b31e5ec","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":39},"updated":"2018-01-03 16:54:09.000000000","message":"I am ok with the code itself, but I don\u0027t think this is a good reason to introduce the change.\n\nWe\u0027ve got to have reliable input, in all cases. We removed the tasks that fails by default due to poor design and ansible behavior. Now, the failing tasks are failing for a good reason, and it should be shown, and not hidden. People should see the issue.\n\nBut I agree, having a single line summary is maybe improving the user experience.","commit_id":"52f7d72f457ec76ad0544141165f8f97f00866f3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0e65779cb82103c3b7685cefa99c431459f54943","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a return code check to the osa wrapper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to our use of block/rescue pattern in some of the playbooks/roles"},{"line_number":10,"context_line":"the after run report will show something \"failed\" even when the run"},{"line_number":11,"context_line":"succeeds. This creates a poor user experience when looking at the"},{"line_number":12,"context_line":"playbook runs, especially as a new user. This change adds a simple"},{"line_number":13,"context_line":"return code check when the openstack-ansible wrapper is used and reports"},{"line_number":14,"context_line":"if the run succeeds or is a failure based on the RC. This should help"},{"line_number":15,"context_line":"users understand when something actually fails, at a glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_4b9e0d55","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":39},"in_reply_to":"9f91af0f_0b31e5ec","updated":"2018-01-03 17:10:34.000000000","message":"We still use the block rescue in quite a few places which which reports a failure in playbook run information at the end. If color is enabled, this will return \"red\" saying something failed when in fact it didn\u0027t.","commit_id":"52f7d72f457ec76ad0544141165f8f97f00866f3"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"a036fefdc457e2c84055ef59f7d5d14595a2a967","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a return code check to the osa wrapper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to our use of block/rescue pattern in some of the playbooks/roles"},{"line_number":10,"context_line":"the after run report will show something \"failed\" even when the run"},{"line_number":11,"context_line":"succeeds. This creates a poor user experience when looking at the"},{"line_number":12,"context_line":"playbook runs, especially as a new user. This change adds a simple"},{"line_number":13,"context_line":"return code check when the openstack-ansible wrapper is used and reports"},{"line_number":14,"context_line":"if the run succeeds or is a failure based on the RC. This should help"},{"line_number":15,"context_line":"users understand when something actually fails, at a glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_8bead5a9","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":39},"in_reply_to":"9f91af0f_4b9e0d55","updated":"2018-01-03 17:13:05.000000000","message":"Yeah, but we should keep the thing red, it should show there is a failure somewhere, but we somewhat managed to make it work.","commit_id":"52f7d72f457ec76ad0544141165f8f97f00866f3"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"f23e96973e0a442d875e9563daf2d56f388c1ed5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a return code check to the osa wrapper"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to our use of block/rescue pattern in some of the playbooks/roles"},{"line_number":10,"context_line":"the after run report will show something \"failed\" even when the run"},{"line_number":11,"context_line":"succeeds. This creates a poor user experience when looking at the"},{"line_number":12,"context_line":"playbook runs, especially as a new user. This change adds a simple"},{"line_number":13,"context_line":"return code check when the openstack-ansible wrapper is used and reports"},{"line_number":14,"context_line":"if the run succeeds or is a failure based on the RC. This should help"},{"line_number":15,"context_line":"users understand when something actually fails, at a glance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_a6dd9015","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":39},"in_reply_to":"9f91af0f_8bead5a9","updated":"2018-01-03 18:06:39.000000000","message":"Totally agree. we should have a way to notify the user that the failure was trapped and resolved however we\u0027re not there yet. This change is being implemented because those failures in the after action report are confusing for folks, especially new users.","commit_id":"52f7d72f457ec76ad0544141165f8f97f00866f3"}],"scripts/bootstrap-ansible.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"4db8635df40a4b85a45fca6a8df665ccb3fd7a9e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"# Execute the Ansible command."},{"line_number":267,"context_line":"if [ \"\\${RUN_CMD}\" \u003d\u003d \"openstack-ansible\" ] || [ \"\\${RUN_CMD}\" \u003d\u003d \"ansible-playbook\" ]; then"},{"line_number":268,"context_line":"  ansible-playbook \"\\${@}\" \\${VAR1}"},{"line_number":269,"context_line":"  if [[ \"\\$?\" -gt \"0\" ]]; then"},{"line_number":270,"context_line":"    info \"NOTICE: Playbook execution failure\""},{"line_number":271,"context_line":"  else"},{"line_number":272,"context_line":"    echo \"NOTICE: Playbook execution success\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f91af0f_2b6aa9b2","line":269,"range":{"start_line":269,"start_character":14,"end_line":269,"end_character":17},"updated":"2018-01-03 16:55:21.000000000","message":"maybe not equal in case ansible decides to report negative things? I haven\u0027t looked in the rc tbh, but it makes more sense to me.","commit_id":"52f7d72f457ec76ad0544141165f8f97f00866f3"}]}