)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"2814da849cb20197b5eafbd1426d4ef8b94dfd1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The rsyslog role has served us well however there\u0027s now a better way"},{"line_number":10,"context_line":"given the ability to remotely journal. This change disables the use of"},{"line_number":11,"context_line":"the `rsyslog_client` and `server` roles unless journal remote is not"},{"line_number":12,"context_line":"unavailable. In this change the `rsyslog_client` interaction has been"},{"line_number":13,"context_line":"moved into an include_tasks which is conditionally loaded when the"},{"line_number":14,"context_line":"variable `rsyslog_client_enabled` is set to true. Additionally the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f6a8fd7_d6212ca1","line":11,"updated":"2018-05-02 18:21:02.000000000","message":"Nit: remove \"not\"","commit_id":"03a7d99faddf0e158882738a2c46edba3114c09f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a5ef0b3f69f46063bd19738076b4335b84b1e9e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The rsyslog role has served us well however there\u0027s now a better way"},{"line_number":10,"context_line":"given the ability to remotely journal. This change disables the use of"},{"line_number":11,"context_line":"the `rsyslog_client` and `server` roles unless journal remote is not"},{"line_number":12,"context_line":"unavailable. In this change the `rsyslog_client` interaction has been"},{"line_number":13,"context_line":"moved into an include_tasks which is conditionally loaded when the"},{"line_number":14,"context_line":"variable `rsyslog_client_enabled` is set to true. Additionally the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f6a8fd7_d6f28c06","line":11,"in_reply_to":"9f6a8fd7_d6212ca1","updated":"2018-05-02 18:33:58.000000000","message":"Done","commit_id":"03a7d99faddf0e158882738a2c46edba3114c09f"}],"inventory/group_vars/haproxy.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"da0c77a8a24d969900e6c77a41544cd4e9c7b570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9f6a8fd7_bcf8fb7a","updated":"2018-04-20 14:56:44.000000000","message":"I think this should go into inventory/group_vars/haproxy/ ?","commit_id":"c07f4ecf07fcbbdf03e16e75952b73aeab7c89de"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9b903a1daf54d36054be47e3c3d033d1e2f401a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9f6a8fd7_c2d94af3","in_reply_to":"9f6a8fd7_bcf8fb7a","updated":"2018-04-20 16:03:41.000000000","message":"Done","commit_id":"c07f4ecf07fcbbdf03e16e75952b73aeab7c89de"}],"inventory/group_vars/octavia_all.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"da0c77a8a24d969900e6c77a41544cd4e9c7b570","unresolved":false,"context_lines":[{"line_number":30,"context_line":"octavia_venv_download_url: \"{{ venv_base_download_url }}/octavia-{{ openstack_release }}-{{ ansible_architecture | lower }}.tgz\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"rsyslog_client_log_rotate_file: octavia_log_rotate"},{"line_number":33,"context_line":"rsyslog_client_log_dir: \"/var/log/ocgtavia\""},{"line_number":34,"context_line":"rsyslog_client_config_name: \" 100-octavia-rsyslog-client.conf\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f6a8fd7_3c806bc0","line":33,"range":{"start_line":33,"start_character":34,"end_line":33,"end_character":42},"updated":"2018-04-20 14:56:44.000000000","message":"Spelling error?\n\nThis was fixed in https://review.openstack.org/555631","commit_id":"c07f4ecf07fcbbdf03e16e75952b73aeab7c89de"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9b903a1daf54d36054be47e3c3d033d1e2f401a0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"octavia_venv_download_url: \"{{ venv_base_download_url }}/octavia-{{ openstack_release }}-{{ ansible_architecture | lower }}.tgz\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"rsyslog_client_log_rotate_file: octavia_log_rotate"},{"line_number":33,"context_line":"rsyslog_client_log_dir: \"/var/log/ocgtavia\""},{"line_number":34,"context_line":"rsyslog_client_config_name: \" 100-octavia-rsyslog-client.conf\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f6a8fd7_c202aa3d","line":33,"range":{"start_line":33,"start_character":34,"end_line":33,"end_character":42},"in_reply_to":"9f6a8fd7_3c806bc0","updated":"2018-04-20 16:03:41.000000000","message":"Done","commit_id":"c07f4ecf07fcbbdf03e16e75952b73aeab7c89de"}],"playbooks/ceph-rgw-install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b57dfc81e4f112fcf3d65c5d51b05bb7b0163be4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"      when:"},{"line_number":180,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":181,"context_line":"      tags:"},{"line_number":182,"context_line":"        - rsyslog"},{"line_number":183,"context_line":"        - \"ceph-rsyslog-client\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_65d9db81","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":17},"updated":"2018-05-04 08:08:37.000000000","message":"do you want to remove rsyslog now that the tag is added into the common task?","commit_id":"4633ba8338b1d406ef772cf8e675ff85e42ab1d0"}],"playbooks/common-playbooks/cinder.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b8d3b40bbc8f6a54add01a9cae9b8401b1b1810a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        - crontab"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  post_tasks:"},{"line_number":108,"context_line":"    - include_tasks: \"common-tasks/rsyslog-client.yml\""},{"line_number":109,"context_line":"      when:"},{"line_number":110,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f6a8fd7_1ad623c7","line":108,"range":{"start_line":108,"start_character":22,"end_line":108,"end_character":34},"updated":"2018-04-17 15:55:01.000000000","message":"This should be:\n\n../common-tasks","commit_id":"c84d55398cdc2644dc089c6f4eedd610210643ae"}],"playbooks/common-playbooks/glance.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b8d3b40bbc8f6a54add01a9cae9b8401b1b1810a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        - crontab"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  post_tasks:"},{"line_number":75,"context_line":"    - include_tasks: \"common-tasks/rsyslog-client.yml\""},{"line_number":76,"context_line":"      when:"},{"line_number":77,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f6a8fd7_9a1eb3b8","line":75,"range":{"start_line":75,"start_character":22,"end_line":75,"end_character":34},"updated":"2018-04-17 15:55:01.000000000","message":"This should be:\n\n../common-tasks","commit_id":"c84d55398cdc2644dc089c6f4eedd610210643ae"}],"playbooks/common-playbooks/neutron.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b8d3b40bbc8f6a54add01a9cae9b8401b1b1810a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        - crontab"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  post_tasks:"},{"line_number":107,"context_line":"    - include_tasks: \"common-tasks/rsyslog-client.yml\""},{"line_number":108,"context_line":"      vars:"},{"line_number":109,"context_line":"        rsyslog_client_log_rotate_file: \"{{ rsyslog_var.log_rotate_file }}\""},{"line_number":110,"context_line":"        rsyslog_client_log_dir: \"{{ rsyslog_var.log_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f6a8fd7_fa824fc8","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":34},"updated":"2018-04-17 15:55:01.000000000","message":"This should be:\n\n../common-tasks","commit_id":"c84d55398cdc2644dc089c6f4eedd610210643ae"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b8d3b40bbc8f6a54add01a9cae9b8401b1b1810a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      when:"},{"line_number":123,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    - include_tasks: \"common-tasks/rsyslog-client.yml\""},{"line_number":126,"context_line":"      vars:"},{"line_number":127,"context_line":"        rsyslog_client_log_rotate_file: \"{{ rsyslog_var.log_rotate_file }}\""},{"line_number":128,"context_line":"        rsyslog_client_log_dir: \"{{ rsyslog_var.log_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f6a8fd7_da698b25","line":125,"range":{"start_line":125,"start_character":22,"end_line":125,"end_character":34},"updated":"2018-04-17 15:55:01.000000000","message":"This should be:\n\n../common-tasks","commit_id":"c84d55398cdc2644dc089c6f4eedd610210643ae"}],"playbooks/common-playbooks/nova.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"b8d3b40bbc8f6a54add01a9cae9b8401b1b1810a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        - crontab"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  post_tasks:"},{"line_number":156,"context_line":"    - include_tasks: \"common-tasks/rsyslog-client.yml\""},{"line_number":157,"context_line":"      when:"},{"line_number":158,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f6a8fd7_9a731316","line":156,"range":{"start_line":156,"start_character":22,"end_line":156,"end_character":34},"updated":"2018-04-17 15:55:01.000000000","message":"This should be:\n\n../common-tasks","commit_id":"c84d55398cdc2644dc089c6f4eedd610210643ae"},{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b57dfc81e4f112fcf3d65c5d51b05bb7b0163be4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        rsyslog_client_log_rotate_file: nova_log_rotate"},{"line_number":159,"context_line":"        rsyslog_client_log_dir: \"/var/log/nova\""},{"line_number":160,"context_line":"        rsyslog_client_config_name: \"99-nova-rsyslog-client.conf\""},{"line_number":161,"context_line":"      when:"},{"line_number":162,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Now that container changes are done, we can set"},{"line_number":165,"context_line":"    # the load balancer back end for this container"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_65c23b88","line":162,"range":{"start_line":161,"start_character":0,"end_line":162,"end_character":39},"updated":"2018-05-04 08:08:37.000000000","message":"add the tag, or remove it, but please decide where you put it, and stick to it :)","commit_id":"4633ba8338b1d406ef772cf8e675ff85e42ab1d0"}],"playbooks/haproxy-install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b57dfc81e4f112fcf3d65c5d51b05bb7b0163be4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        rsyslog_client_config_name: \"99-haproxy-rsyslog-client.conf\""},{"line_number":65,"context_line":"      when:"},{"line_number":66,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":67,"context_line":"      tags:"},{"line_number":68,"context_line":"        - rsyslog"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":71,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_85cbd7a3","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":17},"updated":"2018-05-04 08:08:37.000000000","message":"you can remove this","commit_id":"4633ba8338b1d406ef772cf8e675ff85e42ab1d0"}],"playbooks/memcached-install.yml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"b57dfc81e4f112fcf3d65c5d51b05bb7b0163be4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        rsyslog_client_config_name: \"99-memcached-rsyslog-client.conf\""},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - rsyslog_client_enabled | bool"},{"line_number":45,"context_line":"      tags:"},{"line_number":46,"context_line":"        - rsyslog"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  environment: \"{{ deployment_environment_variables | default({}) }}\""},{"line_number":49,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_c5d1cf59","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":17},"updated":"2018-05-04 08:08:37.000000000","message":"removing this one too.","commit_id":"4633ba8338b1d406ef772cf8e675ff85e42ab1d0"}],"playbooks/rsyslog-install.yml":[{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"2814da849cb20197b5eafbd1426d4ef8b94dfd1a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  gather_facts: \"{{ osa_gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    # The systemd-journal-remote capability has taken over this functionality. However,"},{"line_number":22,"context_line":"    # at this time there\u0027s no suitable package available for systemd-journal-remote/gateway"},{"line_number":23,"context_line":"    # When installing on SUSE 42.x. For now this playbook will omit suse when the package"},{"line_number":24,"context_line":"    # manager is \"zypper\". When a suitable package is available on SUSE this should be removed."},{"line_number":25,"context_line":"    - name: Omit ubuntu and centos from this playbook"},{"line_number":26,"context_line":"      meta: end_play"},{"line_number":27,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_169b24c9","line":24,"range":{"start_line":21,"start_character":79,"end_line":24,"end_character":95},"updated":"2018-05-02 18:21:02.000000000","message":"Not sure that this comment is germane to the code below.","commit_id":"03a7d99faddf0e158882738a2c46edba3114c09f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a5ef0b3f69f46063bd19738076b4335b84b1e9e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  gather_facts: \"{{ osa_gather_facts | default(True) }}\""},{"line_number":19,"context_line":"  user: root"},{"line_number":20,"context_line":"  pre_tasks:"},{"line_number":21,"context_line":"    # The systemd-journal-remote capability has taken over this functionality. However,"},{"line_number":22,"context_line":"    # at this time there\u0027s no suitable package available for systemd-journal-remote/gateway"},{"line_number":23,"context_line":"    # When installing on SUSE 42.x. For now this playbook will omit suse when the package"},{"line_number":24,"context_line":"    # manager is \"zypper\". When a suitable package is available on SUSE this should be removed."},{"line_number":25,"context_line":"    - name: Omit ubuntu and centos from this playbook"},{"line_number":26,"context_line":"      meta: end_play"},{"line_number":27,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f6a8fd7_56e67c46","line":24,"range":{"start_line":21,"start_character":79,"end_line":24,"end_character":95},"in_reply_to":"9f6a8fd7_169b24c9","updated":"2018-05-02 18:33:58.000000000","message":"Done","commit_id":"03a7d99faddf0e158882738a2c46edba3114c09f"}]}